37341116d3d67a3b1d5ef1104c968508640ad8ec
Files Diff
- Added: 1
- Removed: 4
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type committedTx : RecoverableTransaction to tx : CommittedTransactionRepresentation in method public visit(tx CommittedTransactionRepresentation) : boolean in class org.neo4j.kernel.impl.transaction.log.PhysicalLogicalTransactionStoreTest.FakeRecoveryVisitor | From | To | |
| Change Parameter Type transaction : RecoverableTransaction to transaction : CommittedTransactionRepresentation in method public visit(transaction CommittedTransactionRepresentation) : boolean in class org.neo4j.kernel.recovery.DefaultRecoverySPI | From | To | |
| Move Method | 2 | ||
| Move Method public visit(transaction RecoverableTransaction) : boolean from class org.neo4j.kernel.impl.transaction.state.RecoveryVisitor to public visit(transaction CommittedTransactionRepresentation) : boolean from class org.neo4j.kernel.recovery.DefaultRecoverySPI | From | To | |
| Move Method private prepareIndexUpdates(txRepresentation TransactionRepresentation) : ValidatedIndexUpdates from class org.neo4j.kernel.impl.transaction.state.RecoveryVisitor to private prepareIndexUpdates(txRepresentation TransactionRepresentation) : ValidatedIndexUpdates from class org.neo4j.kernel.recovery.DefaultRecoverySPI | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private channel : T from class org.neo4j.kernel.impl.transaction.log.PhysicalTransactionCursor.Marker to private channel : T from class org.neo4j.kernel.impl.transaction.log.PhysicalTransactionCursor | From | To | |
| Move Attribute private numberOfRecoveredTransactions : int from class org.neo4j.kernel.impl.transaction.log.LoggingLogFileMonitor to private numberOfRecoveredTransactions : int from class org.neo4j.kernel.recovery.Recovery | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.neo4j.kernel.impl.transaction.state.RecoverableTransaction moved and renamed to org.neo4j.kernel.impl.transaction.log.TransactionCursor | From | To | |
| Extract Variable | 2 | ||
| Extract Variable metadataCache : TransactionMetadataCache in method public shouldRecoverExistingData() : void from class org.neo4j.kernel.RecoveryTest | From | To | |
| Extract Variable metadataCache : TransactionMetadataCache in method public shouldSeeThatACleanDatabaseShouldNotRequireRecovery() : void from class org.neo4j.kernel.RecoveryTest | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type recoverer : Visitor<LogVersionedStoreChannel,IOException> to recoveryVisitor : Visitor<CommittedTransactionRepresentation,Exception> in method public init() : void in class org.neo4j.kernel.recovery.Recovery | From | To | |
| Change Variable Type endlessCursor : IOCursor<CommittedTransactionRepresentation> to endlessCursor : TransactionCursor in method public shouldHaveFixedTargetTransactionIdEvenIfLastTransactionIdIsMoving() : void in class org.neo4j.com.storecopy.ResponsePackerTest | From | To | |
| Extract Method | 1 | ||
| Extract Method private printFile(file File, out PrintStream) : void extracted from public dump(filenameOrDirectory String, logPrefix String, out PrintStream, timeZone TimeZone, regex String) : int in class org.neo4j.kernel.impl.util.DumpLogicalLog | From | To | |
| Rename Method | 2 | ||
| Rename Method public recoveryRequired() : void renamed to public getRecoveryVisitor() : Visitor<CommittedTransactionRepresentation,Exception> in class org.neo4j.kernel.recovery.DefaultRecoverySPI | From | To | |
| Rename Method public recoveryRequired() : void renamed to public getRecoveryVisitor() : Visitor<CommittedTransactionRepresentation,Exception> in class org.neo4j.kernel.recovery.Recovery.SPI | From | To | |
| Rename Variable | 4 | ||
| Rename Variable recoveryRequiredCalled : AtomicBoolean to recoveryRequired : AtomicBoolean in method public shouldRecoverExistingData() : void in class org.neo4j.kernel.RecoveryTest | From | To | |
| Rename Variable recoveryPosition : LogPosition to recoveryFromPosition : LogPosition in method public init() : void in class org.neo4j.kernel.recovery.Recovery | From | To | |
| Rename Variable recoverer : Visitor<LogVersionedStoreChannel,IOException> to recoveryVisitor : Visitor<CommittedTransactionRepresentation,Exception> in method public init() : void in class org.neo4j.kernel.recovery.Recovery | From | To | |
| Rename Variable recoveryRequiredCalled : AtomicBoolean to recoveryRequired : AtomicBoolean in method public shouldOpenAndRecoverExistingData() : void in class org.neo4j.kernel.impl.transaction.log.PhysicalLogicalTransactionStoreTest | From | To | |
| Inline Method | 1 | ||
| Inline Method protected filenamesOf(filenameOrDirectory String, prefix String) : String[] inlined to public dump(filenameOrDirectory String, out PrintStream, timeZone TimeZone, regex String) : void in class org.neo4j.kernel.impl.util.DumpLogicalLog | From | To | |
| Change Return Type | 6 | ||
| Change Return Type IOCursor<CommittedTransactionRepresentation> to TransactionCursor in method public getTransactions(transactionIdToStartFrom long) : TransactionCursor in class org.neo4j.kernel.impl.transaction.log.LogicalTransactionStore | From | To | |
| Change Return Type void to Visitor<CommittedTransactionRepresentation,Exception> in method public getRecoveryVisitor() : Visitor<CommittedTransactionRepresentation,Exception> in class org.neo4j.kernel.recovery.DefaultRecoverySPI | From | To | |
| Change Return Type IOCursor<CommittedTransactionRepresentation> to TransactionCursor in method public getTransactions(transactionIdToStartFrom long) : TransactionCursor in class org.neo4j.kernel.impl.transaction.log.PhysicalLogicalTransactionStore | From | To | |
| Change Return Type int to void in method public dump(filenameOrDirectory String, out PrintStream, timeZone TimeZone, regex String) : void in class org.neo4j.kernel.impl.util.DumpLogicalLog | From | To | |
| Change Return Type void to Visitor<CommittedTransactionRepresentation,Exception> in method public getRecoveryVisitor() : Visitor<CommittedTransactionRepresentation,Exception> in class org.neo4j.kernel.recovery.Recovery.SPI | From | To | |
| Change Return Type IOCursor<CommittedTransactionRepresentation> to TransactionCursor in method public getTransactions(transactionIdToStartFrom long) : TransactionCursor in class org.neo4j.kernel.impl.transaction.log.ReadOnlyTransactionStore | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute logFileRecoverer : Visitor<LogVersionedStoreChannel,IOException> to logicalTransactionStore : LogicalTransactionStore in class org.neo4j.kernel.recovery.DefaultRecoverySPI | From | To | |
| Rename Attribute lastKnownGoodPosition : long to channel : T in class org.neo4j.kernel.impl.transaction.log.PhysicalTransactionCursor | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type logFileRecoverer : Visitor<LogVersionedStoreChannel,IOException> to logicalTransactionStore : LogicalTransactionStore in class org.neo4j.kernel.recovery.DefaultRecoverySPI | From | To | |
| Change Attribute Type lastKnownGoodPosition : long to channel : T in class org.neo4j.kernel.impl.transaction.log.PhysicalTransactionCursor | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter committedTx : RecoverableTransaction to tx : CommittedTransactionRepresentation in method public visit(tx CommittedTransactionRepresentation) : boolean in class org.neo4j.kernel.impl.transaction.log.PhysicalLogicalTransactionStoreTest.FakeRecoveryVisitor | From | To |