neo4j 3d45aaa7306a730bdfef5ab25a2076f7f968e6c0

3d45aaa7306a730bdfef5ab25a2076f7f968e6c0

Files Diff

Added: 10
Removed: 5
Renamed: 0
Modified: 21

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	1
Change Parameter Type relTypeCursor : Cursor<IntSupplier> to relTypeCursor : Cursor<RelationshipTypeItem> in method package DegreeCursor(relTypeCursor Cursor<RelationshipTypeItem>) in class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor.DegreeCursor	From	To
Move Method	20
Move Method public get() : NodeItem from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to public get() : NodeItem from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Method private shortLivedReadLock() : Lock from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor to private shortLivedReadLock() : Lock from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor	From	To
Move Method public degree(direction Direction) : int from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to public degree(direction Direction) : int from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Method public properties() : Cursor<PropertyItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to public properties() : Cursor<PropertyItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Method public degrees() : Cursor<DegreeItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to public degrees() : Cursor<DegreeItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Method public label(labelId int) : Cursor<LabelItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to public label(labelId int) : Cursor<LabelItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Method public degree(direction Direction, relType int) : int from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to public degree(direction Direction, relType int) : int from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Method public isDense() : boolean from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to public isDense() : boolean from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Method private deduplicate(types int[]) : int[] from class org.neo4j.kernel.api.cursor.NodeItemHelper to private deduplicate(types int[]) : int[] from class org.neo4j.kernel.impl.api.OperationsFacade	From	To
Move Method public id() : long from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor to public id() : long from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor	From	To
Move Method protected doFetchNext(highId long) : boolean from class org.neo4j.kernel.impl.api.store.AllRecordIdIterator to protected doFetchNext(highId long) : boolean from class org.neo4j.kernel.impl.api.store.AllRelationshipIterator	From	To
Move Method public close() : void from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to public close() : void from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Method public relationships(direction Direction, relTypes int...) : Cursor<RelationshipItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to public relationships(direction Direction) : Cursor<RelationshipItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Method public isDense() : boolean from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor to public isDense() : boolean from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor	From	To
Move Method public get() : NodeItem from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor to public get() : NodeItem from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor	From	To
Move Method public labels() : Cursor<LabelItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to public labels() : Cursor<LabelItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Method private directionOf(nodeId long, relationshipId long, startNode long, endNode long) : Direction from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor to private directionOf(nodeId long, relationshipId long, startNode long, endNode long) : Direction from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor	From	To
Move Method public relationships(direction Direction) : Cursor<RelationshipItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to public relationships(direction Direction, relTypes int...) : Cursor<RelationshipItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Method public property(propertyKeyId int) : Cursor<PropertyItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to public property(propertyKeyId int) : Cursor<PropertyItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Method public id() : long from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to public id() : long from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Change Return Type	2
Change Return Type void to boolean in method private updateRelationshipsCountsFromDegrees(type int, label int, outgoing long, incoming long) : boolean in class org.neo4j.kernel.api.txstate.TransactionCountingStateVisitor	From	To
Change Return Type Cursor<IntSupplier> to Cursor<RelationshipTypeItem> in method public relationshipTypes() : Cursor<RelationshipTypeItem> in class org.neo4j.storageengine.api.NodeItem	From	To
Move Attribute	10
Move Attribute protected state : TransactionState from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to private state : TransactionState from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Attribute protected relationshipStore : RelationshipStore from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor to private relationshipStore : RelationshipStore from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor	From	To
Move Attribute protected relationshipGroupStore : RecordStore<RelationshipGroupRecord> from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor to private relationshipGroupStore : RecordStore<RelationshipGroupRecord> from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor	From	To
Move Attribute private currentId : long from class org.neo4j.kernel.impl.api.store.AllRecordIdIterator to private currentId : long from class org.neo4j.kernel.impl.api.store.AllRelationshipIterator	From	To
Move Attribute protected id : long from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to private id : long from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Attribute protected nodeRecord : NodeRecord from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor to private nodeRecord : NodeRecord from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor	From	To
Move Attribute protected nodeState : NodeState from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to private nodeState : NodeState from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Attribute private lockService : LockService from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor to private lockService : LockService from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor	From	To
Move Attribute protected nodeIsAddedInThisTx : boolean from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to private nodeIsAddedInThisTx : boolean from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move Attribute protected cursor : Cursor<NodeItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor to private cursor : Cursor<NodeItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Move And Rename Class	1
Move And Rename Class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor.DegreeItemIterator moved and renamed to org.neo4j.kernel.impl.api.store.DegreeItemCursor	From	To
Move Class	2
Move Class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor.DegreeCursor moved to org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor.DegreeCursor	From	To
Move Class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor.DegreeItemDenseCursor moved to org.neo4j.kernel.impl.api.store.DegreeItemDenseCursor	From	To
Rename Attribute	1
Rename Attribute group : RelationshipGroupRecord to relationshipGroupRecord : RelationshipGroupRecord in class org.neo4j.kernel.impl.api.store.DegreeItemDenseCursor	From	To
Change Variable Type	1
Change Variable Type relTypesCursor : Cursor<IntSupplier> to relTypesCursor : Cursor<RelationshipTypeItem> in method private relTypes(cursor StoreSingleNodeCursor) : Set<TestRelType> in class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursorTest	From	To
Change Attribute Type	1
Change Attribute Type relTypeCursor : Cursor<IntSupplier> to relTypeCursor : Cursor<RelationshipTypeItem> in class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor.DegreeCursor	From	To
Extract Method	2
Extract Method public mapForAll(function Function<T,E>, consumer Consumer<E>) : void extracted from public forAll(consumer Consumer<T>) : void in class org.neo4j.cursor.RawCursor	From	To
Extract Method private lockAllNodes(state KernelStatement) : void extracted from package lockAllNodesAndConsumeRelationships(nodeId long, state KernelStatement) : void in class org.neo4j.kernel.impl.api.TwoPhaseNodeForRelationshipLocking	From	To
Inline Variable	2
Inline Variable cursor : Cursor<NodeItem> in method private nodeCursor(statement StorageStatement, nodeId long) : Cursor<NodeItem> from class org.neo4j.kernel.api.txstate.TransactionCountingStateVisitor	From	To
Inline Variable exists : boolean in method public next() : boolean from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Extract And Move Method	2
Extract And Move Method package returnRelationships(ops EntityReadOperations, state KernelStatement, nodeId long, skipFirst boolean, relIds RelationshipData...) : void extracted from public detachDeleteNodeExclusivelyLockNodes() : void in class org.neo4j.kernel.impl.api.LockingStatementOperationsTest & moved to class org.neo4j.kernel.impl.api.TwoPhaseNodeForRelationshipLockingTest	From	To
Extract And Move Method package returnRelationships(ops EntityReadOperations, state KernelStatement, nodeId long, skipFirst boolean, relIds RelationshipData...) : void extracted from public detachDeleteNodeWithoutRelationshipsExclusivelyLockNode() : void in class org.neo4j.kernel.impl.api.LockingStatementOperationsTest & moved to class org.neo4j.kernel.impl.api.TwoPhaseNodeForRelationshipLockingTest	From	To

3d45aaa7306a730bdfef5ab25a2076f7f968e6c0

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: