neo4j 3daae343d00687d7c98a7b093067b77c05fa74d0

3daae343d00687d7c98a7b093067b77c05fa74d0

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 72

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method private migrateAndValidateSettings(settings Map<String,String>, warnOnUnknownSettings boolean) : Map<String,String> renamed to private migrateAndValidateAndUpdateSettings(settings Map<String,String>, warnOnUnknownSettings boolean) : void in class org.neo4j.kernel.configuration.Config	From	To
Change Parameter Type	3
Change Parameter Type rawConfig : Map<String,String> to config : Config in method private validateBoltConnector(config Config) : void in class org.neo4j.causalclustering.core.CausalClusterConfigurationValidator	From	To
Change Parameter Type provider : Function<String,String> to config : Config in method private validateInitialHosts(config Config) : void in class org.neo4j.configuration.HaConfigurationValidator	From	To
Change Parameter Type rawConfig : Map<String,String> to config : Config in method private validateLoadBalancing(config Config, log Log) : void in class org.neo4j.causalclustering.core.CausalClusterConfigurationValidator	From	To
Rename Variable	2
Rename Variable validSettings : Map<String,String> to migratedSettings : Map<String,String> in method private migrateAndValidateAndUpdateSettings(settings Map<String,String>, warnOnUnknownSettings boolean) : void in class org.neo4j.kernel.configuration.Config	From	To
Rename Variable first : Config to config : Config in method public shouldWarnAndDiscardUnknownOptionsInReservedNamespaceAndPassOnBufferedLogInWithMethods() : void in class org.neo4j.kernel.configuration.ConfigTest	From	To
Inline Method	1
Inline Method private readConfigFile() : Map<String,String> inlined to private Config(configFile File, initialSettings Map<String,String>, overriddenDefaults Map<String,String>, additionalValidators Collection<ConfigurationValidator>, settingsClasses List<LoadableConfig>) in class org.neo4j.kernel.configuration.Config	From	To
Change Return Type	6
Change Return Type Config to void in method public augmentDefaults(additionalDefaults Map<String,String>) : void in class org.neo4j.kernel.configuration.Config	From	To
Change Return Type Config to void in method public augment(settings Map<String,String>) : void in class org.neo4j.kernel.configuration.Config	From	To
Change Return Type Config to void in method public augment(config Config) : void in class org.neo4j.kernel.configuration.Config	From	To
Change Return Type List<String> to Set<String> in method public allConnectorIdentifiers(params Map<String,String>) : Set<String> in class org.neo4j.kernel.configuration.Config	From	To
Change Return Type Map<String,String> to void in method private migrateAndValidateAndUpdateSettings(settings Map<String,String>, warnOnUnknownSettings boolean) : void in class org.neo4j.kernel.configuration.Config	From	To
Change Return Type List<String> to Set<String> in method public allConnectorIdentifiers() : Set<String> in class org.neo4j.kernel.configuration.Config	From	To
Replace Variable With Attribute	1
Replace Variable With Attribute validSettings : Map<String,String> to params : Map<String,String> in method private Config(configFile File, initialSettings Map<String,String>, overriddenDefaults Map<String,String>, additionalValidators Collection<ConfigurationValidator>, settingsClasses List<LoadableConfig>) in class org.neo4j.kernel.configuration.Config	From	To
Extract Variable	1
Extract Variable anotherConfig : Config in method public augmentAnotherConfig() : void from class org.neo4j.kernel.configuration.ConfigTest	From	To
Change Variable Type	1
Change Variable Type field : Pair<Field,ConfigurationMigrator> to field : ConfigurationMigrator in method package AnnotationBasedConfigurationMigrator(settingsClasses Iterable<LoadableConfig>) in class org.neo4j.kernel.configuration.AnnotationBasedConfigurationMigrator	From	To
Extract Method	4
Extract Method private configWith(databaseName String, dataDirectory String) : Config extracted from public shouldNotCopyOverAndExistingDatabase() : void in class org.neo4j.restore.RestoreDatabaseCommandTest	From	To
Extract Method private configWith(databaseName String, dataDirectory String) : Config extracted from public shouldAllowForcedCopyOverAnExistingDatabase() : void in class org.neo4j.restore.RestoreDatabaseCommandTest	From	To
Extract Method private configWith(databaseName String, dataDirectory String) : Config extracted from public shouldThrowExceptionIfBackupDirectoryDoesNotExist() : void in class org.neo4j.restore.RestoreDatabaseCommandTest	From	To
Extract Method private configWith(databaseName String, dataDirectory String) : Config extracted from public forceShouldRespectStoreLock() : void in class org.neo4j.restore.RestoreDatabaseCommandTest	From	To
Extract And Move Method	6
Extract And Move Method public augment(setting String, value String) : void extracted from protected publishEditionInfo(sysInfo UsageData, databaseInfo DatabaseInfo, config Config) : void in class org.neo4j.kernel.impl.factory.EditionModule & moved to class org.neo4j.kernel.configuration.Config	From	To
Extract And Move Method public validate(config Config, log Log) : Map<String,String> extracted from private migrateAndValidateSettings(settings Map<String,String>, warnOnUnknownSettings boolean) : Map<String,String> in class org.neo4j.kernel.configuration.Config & moved to class org.neo4j.kernel.configuration.ServerConfigurationValidator	From	To
Extract And Move Method public augment(setting String, value String) : void extracted from public shouldBeAbleToAugmentConfig() : void in class org.neo4j.kernel.configuration.ConfigTest & moved to class org.neo4j.kernel.configuration.Config	From	To
Extract And Move Method public augment(setting String, value String) : void extracted from public HighlyAvailableEditionModule(platformModule PlatformModule) in class org.neo4j.kernel.ha.factory.HighlyAvailableEditionModule & moved to class org.neo4j.kernel.configuration.Config	From	To
Extract And Move Method public augment(setting String, value String) : void extracted from public shouldBeAbleToRestartServer() : void in class org.neo4j.server.enterprise.jmx.ServerManagementIT & moved to class org.neo4j.kernel.configuration.Config	From	To
Extract And Move Method public augment(setting String, value String) : void extracted from protected addPropertyDirect(key String, value Object) : void in class org.neo4j.server.plugins.ConfigAdapter & moved to class org.neo4j.kernel.configuration.Config	From	To
Rename Parameter	7
Rename Parameter rawConfig : Map<String,String> to config : Config in method private validateBoltConnector(config Config) : void in class org.neo4j.causalclustering.core.CausalClusterConfigurationValidator	From	To
Rename Parameter overriddenSettings : Map<String,String> to initialSettings : Map<String,String> in method private Config(configFile File, initialSettings Map<String,String>, overriddenDefaults Map<String,String>, additionalValidators Collection<ConfigurationValidator>, settingsClasses List<LoadableConfig>) in class org.neo4j.kernel.configuration.Config	From	To
Rename Parameter key : String to setting : String in method public defaults(setting String, value String) : Config in class org.neo4j.kernel.configuration.Config	From	To
Rename Parameter provider : Function<String,String> to config : Config in method private validateInitialHosts(config Config) : void in class org.neo4j.configuration.HaConfigurationValidator	From	To
Rename Parameter changes : Map<String,String> to settings : Map<String,String> in method public augment(settings Map<String,String>) : void in class org.neo4j.kernel.configuration.Config	From	To
Rename Parameter rawConfig : Map<String,String> to config : Config in method private validateLoadBalancing(config Config, log Log) : void in class org.neo4j.causalclustering.core.CausalClusterConfigurationValidator	From	To
Rename Parameter key : String to setting : String in method public withSetting(setting String, value String) : Builder in class org.neo4j.kernel.configuration.Config.Builder	From	To

3daae343d00687d7c98a7b093067b77c05fa74d0

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: