3ec19b0d1f7c7bb7899d1cd17100d8b0c07d05b1
Files Diff
- Added: 12
- Removed: 11
- Renamed: 0
- Modified: 25
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type creds : Credentials to creds : Credential in method public withCredentials(creds Credential) : Builder in class org.neo4j.server.security.auth.User.Builder | From | To | |
| Change Parameter Type request : HttpServletRequest to path : String in method private whitelisted(path String) : boolean in class org.neo4j.server.rest.dbms.AuthorizationFilter | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private X_FORWARD_PROTO_HEADER_KEY : String from class org.neo4j.server.web.XForwardFilter to public X_FORWARD_PROTO_HEADER_KEY : String from class org.neo4j.server.web.XForwardUtil | From | To | |
| Move Attribute private log : ConsoleLogger from class org.neo4j.server.rest.dbms.UserService to private log : ConsoleLogger from class org.neo4j.server.rest.dbms.AuthorizationFilter | From | To | |
| Move Attribute private log : ConsoleLogger from class org.neo4j.server.rest.dbms.AuthenticationService to private log : ConsoleLogger from class org.neo4j.server.rest.dbms.AuthorizationFilter | From | To | |
| Move Attribute private X_FORWARD_HOST_HEADER_KEY : String from class org.neo4j.server.web.XForwardFilter to public X_FORWARD_HOST_HEADER_KEY : String from class org.neo4j.server.web.XForwardUtil | From | To | |
| Extract Class | 1 | ||
| Extract Class org.neo4j.server.web.XForwardUtil from class org.neo4j.server.web.XForwardFilter | From | To | |
| Rename Class | 2 | ||
| Rename Class org.neo4j.server.security.auth.UnauthenticatedUser renamed to org.neo4j.server.security.auth.AuthenticationResult | From | To | |
| Rename Class org.neo4j.server.security.auth.Credentials renamed to org.neo4j.server.security.auth.Credential | From | To | |
| Move Class | 2 | ||
| Move Class org.neo4j.server.web.XForwardFilter.ForwardedHost moved to org.neo4j.server.web.XForwardUtil.ForwardedHost | From | To | |
| Move Class org.neo4j.server.web.XForwardFilter.ForwardedProto moved to org.neo4j.server.web.XForwardUtil.ForwardedProto | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type that : Credentials to that : Credential in method public equals(o Object) : boolean in class org.neo4j.server.security.auth.Credential | From | To | |
| Extract Variable | 2 | ||
| Extract Variable firstError : JsonNode in method public shouldReplyNicelyToTooManyFailedAuthAttempts() : void from class org.neo4j.server.rest.security.AuthenticationDocIT | From | To | |
| Extract Variable firstError : JsonNode in method public incorrect_authentication() : void from class org.neo4j.server.rest.security.AuthenticationDocIT | From | To | |
| Rename Method | 6 | ||
| Rename Method private authURL() : String renamed to private dataURL() : String in class org.neo4j.server.rest.security.UsersDocIT | From | To | |
| Rename Method public shouldNotFindUserByTokenAfterChangingToken() : void renamed to public shouldNotFindUserAfterDelete() : void in class org.neo4j.server.security.auth.FileUserRepositoryTest | From | To | |
| Rename Method public shouldSayMalformedTokenIfMalformedToken() : void renamed to public shouldSayMalformedHeaderIfMalformedAuthorization() : void in class org.neo4j.server.rest.security.AuthenticationDocIT | From | To | |
| Rename Method public authorization_metadata() : void renamed to public missing_authorization() : void in class org.neo4j.server.rest.security.AuthenticationDocIT | From | To | |
| Rename Method private authURL() : String renamed to private dataURL() : String in class org.neo4j.server.rest.security.AuthenticationDocIT | From | To | |
| Rename Method public auth_disabled_get_metadata() : void renamed to public auth_disabled() : void in class org.neo4j.server.rest.security.AuthenticationDocIT | From | To | |
| Rename Variable | 3 | ||
| Rename Variable put : HTTP.Response to post : HTTP.Response in method public startServerWithConfiguredUser() : void in class org.neo4j.server.rest.security.AuthenticationDocIT | From | To | |
| Rename Variable token : String to password : String in method public shouldParseHappyPath() : void in class org.neo4j.server.rest.dbms.AuthorizationHeadersTest | From | To | |
| Rename Variable put : HTTP.Response to post : HTTP.Response in method public startServerWithConfiguredUser() : void in class org.neo4j.server.rest.security.UsersDocIT | From | To | |
| Inline Method | 1 | ||
| Inline Method private getString(data Map<String,Object>, key String) : String inlined to public setPassword(username String, req HttpServletRequest, payload String) : Response in class org.neo4j.server.rest.dbms.UserService | From | To | |
| Change Return Type | 2 | ||
| Change Return Type Credentials to Credential in method public credentials() : Credential in class org.neo4j.server.security.auth.User | From | To | |
| Change Return Type String to byte[] in method public salt() : byte[] in class org.neo4j.server.security.auth.Credential | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute credentials : Credentials to credential : Credential in class org.neo4j.server.security.auth.User.Builder | From | To | |
| Rename Attribute security : SecurityCentral to log : ConsoleLogger in class org.neo4j.server.rest.dbms.AuthorizationFilter | From | To | |
| Rename Attribute credentials : Credentials to credential : Credential in class org.neo4j.server.security.auth.User | From | To | |
| Rename Attribute security : SecurityCentral to authManager : AuthManager in class org.neo4j.server.AbstractNeoServer | From | To | |
| Change Attribute Type | 6 | ||
| Change Attribute Type security : SecurityCentral to log : ConsoleLogger in class org.neo4j.server.rest.dbms.AuthorizationFilter | From | To | |
| Change Attribute Type credentials : Credentials to credential : Credential in class org.neo4j.server.security.auth.User | From | To | |
| Change Attribute Type credentials : Credentials to credential : Credential in class org.neo4j.server.security.auth.User.Builder | From | To | |
| Change Attribute Type INACCESSIBLE : Credentials to INACCESSIBLE : Credential in class org.neo4j.server.security.auth.Credential | From | To | |
| Change Attribute Type salt : String to salt : byte[] in class org.neo4j.server.security.auth.Credential | From | To | |
| Change Attribute Type security : SecurityCentral to authManager : AuthManager in class org.neo4j.server.AbstractNeoServer | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter user : String to username : String in method public setPassword(username String, req HttpServletRequest, payload String) : Response in class org.neo4j.server.rest.dbms.UserService | From | To | |
| Rename Parameter request : HttpServletRequest to path : String in method private whitelisted(path String) : boolean in class org.neo4j.server.rest.dbms.AuthorizationFilter | From | To |