3ed1a77e73fa2710a056d3f582ae34df60a5bbbc
Files Diff
- Added: 5
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 4 | ||
| Pull Up Method private assertFailedSubCommand(command String, args String[], errors String...) : void from class org.neo4j.commandline.admin.security.UsersCommandIT to package assertFailedSubCommand(command String, args String[], errors String...) : void from class org.neo4j.commandline.admin.security.CommandTestBase | From | To | |
| Pull Up Method private args(args String...) : String[] from class org.neo4j.commandline.admin.security.UsersCommandIT to package args(args String...) : String[] from class org.neo4j.commandline.admin.security.CommandTestBase | From | To | |
| Pull Up Method private assertSuccessfulSubCommand(command String, args String[], messages String...) : void from class org.neo4j.commandline.admin.security.UsersCommandIT to package assertSuccessfulSubCommand(command String, args String[], messages String...) : void from class org.neo4j.commandline.admin.security.CommandTestBase | From | To | |
| Pull Up Method private makeArgs(command String, args String...) : String[] from class org.neo4j.commandline.admin.security.UsersCommandIT to private makeArgs(subCommand String, args String...) : String[] from class org.neo4j.commandline.admin.security.CommandTestBase | From | To | |
| Push Down Method | 2 | ||
| Push Down Method protected assertUserRequiresPasswordChange(username String) : void from class org.neo4j.commandline.admin.security.CommandTestBase to package assertUserRequiresPasswordChange(username String) : void from class org.neo4j.commandline.admin.security.UsersCommandTestBase | From | To | |
| Push Down Method protected assertUserDoesNotRequirePasswordChange(username String) : void from class org.neo4j.commandline.admin.security.CommandTestBase to package assertUserDoesNotRequirePasswordChange(username String) : void from class org.neo4j.commandline.admin.security.UsersCommandTestBase | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass org.neo4j.commandline.admin.security.UsersCommandTestBase from class org.neo4j.commandline.admin.security.CommandTestBase | From | To | |
| Change Return Type | 1 | ||
| Change Return Type AuthManager to EnterpriseAuthManager in method public newInstance(config Config, logProvider LogProvider, allegedSecurityLog Log, fileSystem FileSystemAbstraction, jobScheduler JobScheduler) : EnterpriseAuthManager in class org.neo4j.server.security.enterprise.auth.EnterpriseAuthManagerFactory | From | To | |
| Push Down Attribute | 3 | ||
| Push Down Attribute protected password_change_required : String from class org.neo4j.commandline.admin.security.CommandTestBase to protected password_change_required : String from class org.neo4j.commandline.admin.security.UsersCommandTestBase | From | To | |
| Push Down Attribute public ruleChain : RuleChain from class org.neo4j.commandline.admin.security.CommandTestBase to public ruleChain : RuleChain from class org.neo4j.commandline.admin.security.RolesCommandIT | From | To | |
| Push Down Attribute public ruleChain : RuleChain from class org.neo4j.commandline.admin.security.CommandTestBase to public ruleChain : RuleChain from class org.neo4j.commandline.admin.security.CreateCommandTest | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.neo4j.commandline.admin.security.UsersCommandTestBase from classes [org.neo4j.commandline.admin.security.CreateCommandTest, org.neo4j.commandline.admin.security.DeleteCommandTest, org.neo4j.commandline.admin.security.ListCommandTest, org.neo4j.commandline.admin.security.SetPasswordCommandTest, org.neo4j.commandline.admin.security.UsersCommandIT] | From | To | |
| Extract Method | 1 | ||
| Extract Method public getRoleRepository(config Config, logProvider LogProvider, fileSystem FileSystemAbstraction) : RoleRepository extracted from private createInternalRealm(config Config, logProvider LogProvider, fileSystem FileSystemAbstraction, jobScheduler JobScheduler) : InternalFlatFileRealm in class org.neo4j.server.security.enterprise.auth.EnterpriseAuthManagerFactory | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter command : String to subCommand : String in method private makeArgs(subCommand String, args String...) : String[] in class org.neo4j.commandline.admin.security.CommandTestBase | From | To |