3fda82c14c62d78175f811d149a6ffedfc63af52
Files Diff
- Added: 3
- Removed: 3
- Renamed: 0
- Modified: 30
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private updateReplicationMembers() : void from class org.neo4j.coreedge.raft.state.membership.RaftMembershipState to private updateMemberSets() : void from class org.neo4j.coreedge.raft.membership.RaftMembershipManager | From | To | |
| Move And Inline Method | 3 | ||
| Move And Inline Method public replicationMembers() : Set<CoreMember> moved from class org.neo4j.coreedge.raft.state.membership.RaftMembershipState to class org.neo4j.coreedge.raft.membership.RaftMembershipManager & inlined to public replicationMembers() : Set<CoreMember> | From | To | |
| Move And Inline Method public registerListener(listener Listener) : void moved from class org.neo4j.coreedge.raft.state.membership.RaftMembershipState to class org.neo4j.coreedge.raft.membership.RaftMembershipManager & inlined to public registerListener(listener Listener) : void | From | To | |
| Move And Inline Method public votingMembers() : Set<CoreMember> moved from class org.neo4j.coreedge.raft.state.membership.RaftMembershipState to class org.neo4j.coreedge.raft.membership.RaftMembershipManager & inlined to public votingMembers() : Set<CoreMember> | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type logCommands : Collection<LogCommand> to logCommands : Collection<RaftLogCommand> in method public Outcome(nextRole Role, term long, leader CoreMember, leaderCommit long, votedFor CoreMember, votesForMe Set<CoreMember>, lastLogIndexBeforeWeBecameLeader long, followerStates FollowerStates<CoreMember>, renewElectionTimeout boolean, logCommands Collection<RaftLogCommand>, outgoingMessages Collection<RaftMessages.Directed>, shipCommands Collection<ShipCommand>, commitIndex long) in class org.neo4j.coreedge.raft.outcome.Outcome | From | To | |
| Change Parameter Type item : LogCommand to item : RaftLogCommand in method protected matchesSafely(item RaftLogCommand) : boolean in class org.neo4j.coreedge.raft.roles.AppendingTest.LogCommandMatcher | From | To | |
| Change Parameter Type logCommand : LogCommand to logCommand : RaftLogCommand in method public addLogCommand(logCommand RaftLogCommand) : void in class org.neo4j.coreedge.raft.outcome.Outcome | From | To | |
| Move Method | 4 | ||
| Move Method private dataMatchesEventually(server CoreServer, targetDBs Collection<CoreServer>) : void from class org.neo4j.coreedge.scenarios.CoreServerReplicationIT to public dataMatchesEventually(server CoreServer, targetDBs Collection<CoreServer>) : void from class org.neo4j.coreedge.discovery.Cluster | From | To | |
| Move Method private notifyListeners() : void from class org.neo4j.coreedge.raft.state.membership.RaftMembershipState to private notifyListeners() : void from class org.neo4j.coreedge.raft.membership.RaftMembershipManager | From | To | |
| Move Method public logIndex() : long from class org.neo4j.coreedge.raft.state.RaftStateTest.FakeMembership to public logIndex() : long from class org.neo4j.coreedge.raft.state.membership.MembershipEntry | From | To | |
| Move Method public logIndex() : long from class org.neo4j.coreedge.raft.state.membership.RaftMembershipState to public logIndex() : long from class org.neo4j.coreedge.raft.state.membership.MembershipEntry | From | To | |
| Move Attribute | 5 | ||
| Move Attribute private votingMembers : Set<CoreMember> from class org.neo4j.coreedge.raft.state.membership.RaftMembershipState to private votingMembers : Set<CoreMember> from class org.neo4j.coreedge.raft.membership.RaftMembershipManager | From | To | |
| Move Attribute private listeners : Set<Listener> from class org.neo4j.coreedge.raft.state.membership.RaftMembershipState to private listeners : Set<Listener> from class org.neo4j.coreedge.raft.membership.RaftMembershipManager | From | To | |
| Move Attribute private replicationMembers : Set<CoreMember> from class org.neo4j.coreedge.raft.state.membership.RaftMembershipState to private replicationMembers : Set<CoreMember> from class org.neo4j.coreedge.raft.membership.RaftMembershipManager | From | To | |
| Move Attribute private logIndex : long from class org.neo4j.coreedge.raft.state.membership.RaftMembershipState to private logIndex : long from class org.neo4j.coreedge.raft.state.membership.MembershipEntry | From | To | |
| Move Attribute private additionalReplicationMembers : Set<CoreMember> from class org.neo4j.coreedge.raft.state.membership.RaftMembershipState to private additionalReplicationMembers : Set<CoreMember> from class org.neo4j.coreedge.raft.membership.RaftMembershipManager | From | To | |
| Extract Class | 1 | ||
| Extract Class org.neo4j.coreedge.raft.state.membership.MembershipEntry from class org.neo4j.coreedge.raft.state.membership.RaftMembershipState | From | To | |
| Rename Class | 2 | ||
| Rename Class org.neo4j.coreedge.raft.membership.RaftMembershipStateMachine renamed to org.neo4j.coreedge.raft.membership.RaftMembershipChanger | From | To | |
| Rename Class org.neo4j.coreedge.raft.outcome.LogCommand renamed to org.neo4j.coreedge.raft.outcome.RaftLogCommand | From | To | |
| Change Variable Type | 8 | ||
| Change Variable Type noLogCommands : List<LogCommand> to noLogCommands : List<RaftLogCommand> in method public build() : RaftState in class org.neo4j.coreedge.raft.state.RaftStateBuilder | From | To | |
| Change Variable Type logCommand : LogCommand to logCommand : RaftLogCommand in method public update(outcome Outcome) : void in class org.neo4j.coreedge.raft.state.explorer.ComparableRaftState | From | To | |
| Change Variable Type logCommand : LogCommand to logCommand : RaftLogCommand in method public membershipManagerShouldRevertToOldMembershipSetAfterTruncationCausesLossOfAllAppendedMembershipSets() : void in class org.neo4j.coreedge.raft.membership.RaftMembershipManagerTest | From | To | |
| Change Variable Type logCommands : List<LogCommand> to logCommands : List<RaftLogCommand> in method public membershipManagerShouldRevertToEarlierAppendedMembershipSetAfterTruncationCausesLossOfLastAppened() : void in class org.neo4j.coreedge.raft.membership.RaftMembershipManagerTest | From | To | |
| Change Variable Type logCommand : LogCommand to logCommand : RaftLogCommand in method public update(outcome Outcome) : void in class org.neo4j.coreedge.raft.state.RaftState | From | To | |
| Change Variable Type logCommands : List<LogCommand> to logCommands : List<RaftLogCommand> in method public shouldUpdateCacheState() : void in class org.neo4j.coreedge.raft.state.RaftStateTest | From | To | |
| Change Variable Type logCommand : LogCommand to logCommand : RaftLogCommand in method public membershipManagerShouldRevertToEarlierAppendedMembershipSetAfterTruncationCausesLossOfLastAppened() : void in class org.neo4j.coreedge.raft.membership.RaftMembershipManagerTest | From | To | |
| Change Variable Type logCommands : List<LogCommand> to logCommands : List<RaftLogCommand> in method public membershipManagerShouldRevertToOldMembershipSetAfterTruncationCausesLossOfAllAppendedMembershipSets() : void in class org.neo4j.coreedge.raft.membership.RaftMembershipManagerTest | From | To | |
| Rename Method | 1 | ||
| Rename Method public getApplyingIndex() : long renamed to package getLastAppliedIndex() : long in class org.neo4j.coreedge.raft.state.CoreStateMachines | From | To | |
| Rename Variable | 1 | ||
| Rename Variable logIndex : long to ordinal : long in method public unmarshal0(channel ReadableChannel) : RaftMembershipState in class org.neo4j.coreedge.raft.state.membership.RaftMembershipState.Marshal | From | To | |
| Change Return Type | 2 | ||
| Change Return Type Collection<LogCommand> to Collection<RaftLogCommand> in method private emptyLogCommands() : Collection<RaftLogCommand> in class org.neo4j.coreedge.raft.state.RaftStateTest | From | To | |
| Change Return Type Collection<LogCommand> to Collection<RaftLogCommand> in method public getLogCommands() : Collection<RaftLogCommand> in class org.neo4j.coreedge.raft.outcome.Outcome | From | To | |
| Rename Attribute | 6 | ||
| Rename Attribute membershipDriver : MembershipDriver to membershipManager : RaftMembershipManager in class org.neo4j.coreedge.raft.membership.RaftMembershipChanger | From | To | |
| Rename Attribute stateStorage : StateStorage<RaftMembershipState> to storage : StateStorage<RaftMembershipState> in class org.neo4j.coreedge.raft.membership.RaftMembershipManager | From | To | |
| Rename Attribute membershipState : RaftMembershipState to membershipManager : RaftMembershipManager in class org.neo4j.coreedge.raft.membership.RaftMembershipChanger | From | To | |
| Rename Attribute logIndex : long to ordinal : long in class org.neo4j.coreedge.raft.state.membership.RaftMembershipState | From | To | |
| Rename Attribute membershipStateMachine : RaftMembershipStateMachine to membershipChanger : RaftMembershipChanger in class org.neo4j.coreedge.raft.membership.RaftMembershipManager | From | To | |
| Rename Attribute memberMarshal : ChannelMarshal<CoreMember> to entryMarshal : MembershipEntry.Marshal in class org.neo4j.coreedge.raft.state.membership.RaftMembershipState.Marshal | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type membershipStateMachine : RaftMembershipStateMachine to membershipChanger : RaftMembershipChanger in class org.neo4j.coreedge.raft.membership.RaftMembershipManager | From | To | |
| Change Attribute Type logCommands : Collection<LogCommand> to logCommands : Collection<RaftLogCommand> in class org.neo4j.coreedge.raft.outcome.Outcome | From | To | |
| Change Attribute Type memberMarshal : ChannelMarshal<CoreMember> to entryMarshal : MembershipEntry.Marshal in class org.neo4j.coreedge.raft.state.membership.RaftMembershipState.Marshal | From | To | |
| Change Attribute Type membershipState : RaftMembershipState to membershipManager : RaftMembershipManager in class org.neo4j.coreedge.raft.membership.RaftMembershipChanger | From | To | |
| Change Attribute Type membershipDriver : MembershipDriver to membershipManager : RaftMembershipManager in class org.neo4j.coreedge.raft.membership.RaftMembershipChanger | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public startState() : RaftMembershipState extracted from public startState() : RaftMembershipState in class org.neo4j.coreedge.raft.state.membership.RaftMembershipState.Marshal & moved to class org.neo4j.coreedge.raft.state.membership.RaftMembershipState | From | To | |
| Extract And Move Method public startState() : RaftMembershipState extracted from public membershipManagerShouldRevertToEarlierAppendedMembershipSetAfterTruncationCausesLossOfLastAppened() : void in class org.neo4j.coreedge.raft.membership.RaftMembershipManagerTest & moved to class org.neo4j.coreedge.raft.state.membership.RaftMembershipState | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter stateStorage : StateStorage<RaftMembershipState> to membershipStorage : StateStorage<RaftMembershipState> in method public RaftMembershipManager(sendToMyself SendToMyself, memberSetBuilder RaftGroup.Builder<CoreMember>, raftLog ReadableRaftLog, logProvider LogProvider, expectedClusterSize int, electionTimeout long, clock Clock, catchupTimeout long, membershipStorage StateStorage<RaftMembershipState>, recoverFromIndex long) in class org.neo4j.coreedge.raft.membership.RaftMembershipManager | From | To | |
| Rename Parameter replicator : SendToMyself to sendToMyself : SendToMyself in method public RaftMembershipManager(sendToMyself SendToMyself, memberSetBuilder RaftGroup.Builder<CoreMember>, raftLog ReadableRaftLog, logProvider LogProvider, expectedClusterSize int, electionTimeout long, clock Clock, catchupTimeout long, membershipStorage StateStorage<RaftMembershipState>, recoverFromIndex long) in class org.neo4j.coreedge.raft.membership.RaftMembershipManager | From | To |