40637512c955f62c2f27c84ab115084c110ea959
Files Diff
- Added: 0
- Removed: 1
- Renamed: 0
- Modified: 6
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type dataStats : NumberArrayStats to highestSetIndex : long in method public ParallelSort(radix Radix, dataCache LongArray, highestSetIndex long, tracker IntArray, threads int, progress ProgressListener, comparator Comparator) in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.ParallelSort | From | To | |
| Change Parameter Type collisionDataCacheStats : NumberArrayStats to numberOfCollisions : int in method private detectDuplicateInputIds(radix Radix, numberOfCollisions int, sourceDescriptions List<String>, collector Collector) : void in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
| Rename Variable | 3 | ||
| Rename Variable numCollisions : int to numberOfCollisions : int in method private detectAndMarkCollisions(progress ProgressListener) : int in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
| Rename Variable temp : long to trackerIndex : long in method public run() : void in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.ParallelSort.TrackerInitializer | From | To | |
| Rename Variable x : long to eId : long in method private encode(inputId Object) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
| Inline Method | 2 | ||
| Inline Method private newLongArray(cacheFactory NumberArrayFactory, chunkSize int) : LongArray inlined to public EncodingIdMapper(cacheFactory NumberArrayFactory, encoder Encoder, radixFactory Factory<Radix>, monitor Monitor, chunkSize int, processorsForSorting int) in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to boolean in method private markAsCollision(dataIndex int) : boolean in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute max : long to highestSetIndex : long in method public run() : void in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.ParallelSort.TrackerInitializer | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable collisionDataCacheStats : NumberArrayStats to numberOfCollisions : int in method private buildCollisionInfo(ids InputIterator<Object>, numberOfCollisions int, collector Collector, progress ProgressListener) : void in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute highBucketRange : int to highRadixRange : int in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.ParallelSort.TrackerInitializer | From | To | |
| Rename Attribute lowBucketRange : int to lowRadixRange : int in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.ParallelSort.TrackerInitializer | From | To | |
| Rename Attribute dataStats : NumberArrayStats to highestSetIndex : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.ParallelSort | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type collisionDataCacheStats : NumberArrayStats to numberOfCollisions : int in method private buildCollisionInfo(ids InputIterator<Object>, numberOfCollisions int, collector Collector, progress ProgressListener) : void in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
| Extract Variable | 2 | ||
| Extract Variable numberOfCollisions : int in method public prepare(ids InputIterable<Object>, collector Collector, progress ProgressListener) : void from class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
| Extract Variable eId : long in method private markAsCollision(dataIndex int) : boolean from class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type dataStats : NumberArrayStats to highestSetIndex : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.ParallelSort | From | To | |
| Change Attribute Type random : Random to random : RandomRule in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapperTest | From | To | |
| Extract Method | 2 | ||
| Extract Method private encode(inputId Object) : long extracted from public put(inputId Object, id long, group Group) : void in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
| Extract Method private encode(inputId Object) : long extracted from private binarySearch(inputId Object, groupId int) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
| Rename Parameter | 5 | ||
| Rename Parameter highBucketRange : int to highRadixRange : int in method package TrackerInitializer(threadIndex int, rangeParams int[], lowRadixRange int, highRadixRange int, result long[]) in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.ParallelSort.TrackerInitializer | From | To | |
| Rename Parameter lowBucketRange : int to lowRadixRange : int in method package TrackerInitializer(threadIndex int, rangeParams int[], lowRadixRange int, highRadixRange int, result long[]) in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.ParallelSort.TrackerInitializer | From | To | |
| Rename Parameter dataStats : NumberArrayStats to highestSetIndex : long in method public ParallelSort(radix Radix, dataCache LongArray, highestSetIndex long, tracker IntArray, threads int, progress ProgressListener, comparator Comparator) in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.ParallelSort | From | To | |
| Rename Parameter numberOfCollisions : int to count : int in method public numberOfCollisions(count int) : void in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper.Monitor | From | To | |
| Rename Parameter collisionDataCacheStats : NumberArrayStats to numberOfCollisions : int in method private detectDuplicateInputIds(radix Radix, numberOfCollisions int, sourceDescriptions List<String>, collector Collector) : void in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To |