neo4j 432b939851fbcf0cb9ec618f77d8d1942dc7a522

432b939851fbcf0cb9ec618f77d8d1942dc7a522

Files Diff

Added: 8
Removed: 7
Renamed: 0
Modified: 63

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Inline Method	1
Move And Inline Method public refreshSearcher() : void moved from class org.neo4j.kernel.api.impl.index.LuceneLabelScanStore to class org.neo4j.kernel.api.impl.index.LuceneLabelScanWriter & inlined to public close() : void	From	To
Change Parameter Type	14
Change Parameter Type searcher : IndexSearcher to luceneIndex : LuceneIndex in method public labelsForNode(luceneIndex LuceneIndex, nodeId long) : Iterator<Long> in class org.neo4j.kernel.api.impl.index.NodeRangeDocumentLabelScanStorageStrategy	From	To
Change Parameter Type searcher : IndexSearcher to index : LuceneIndex in method package PageOfRangesIterator(format BitmapDocumentFormat, index LuceneIndex, rangesPerPage int, query Query, labels int...) in class org.neo4j.kernel.api.impl.index.PageOfRangesIterator	From	To
Change Parameter Type indexId : long to identifier : String in method public IndexFolderLayout(rootDirectory File, identifier String) in class org.neo4j.kernel.api.impl.index.storage.layout.IndexFolderLayout	From	To
Change Parameter Type storage : LabelScanStorageStrategy.StorageService to index : LuceneIndex in method public LuceneLabelScanWriter(index LuceneIndex, format BitmapDocumentFormat, heldLock Lock) in class org.neo4j.kernel.api.impl.index.LuceneLabelScanWriter	From	To
Change Parameter Type searcher : IndexSearcher to index : LuceneIndex in method public nodesWithLabel(index LuceneIndex, labelId int) : PrimitiveLongIterator in class org.neo4j.kernel.api.impl.index.NodeRangeDocumentLabelScanStorageStrategy	From	To
Change Parameter Type result : DoubleLong.Out to result : Register.DoubleLong.Out in method public sampleIndex(result Register.DoubleLong.Out) : long in class org.neo4j.kernel.impl.api.index.inmemory.HashBasedIndexSampler	From	To
Change Parameter Type searcher : IndexSearcher to luceneIndex : LuceneIndex in method public nodesWithLabel(luceneIndex LuceneIndex, labelId int) : PrimitiveLongIterator in class org.neo4j.kernel.api.impl.index.LabelScanStorageStrategy	From	To
Change Parameter Type indexId : long to identifier : String in method public PartitionedIndexStorage(directoryFactory DirectoryFactory, fileSystem FileSystemAbstraction, rootFolder File, identifier String) in class org.neo4j.kernel.api.impl.index.storage.PartitionedIndexStorage	From	To
Change Parameter Type searcher : SearcherManager to indexReader : IndexReader in method public newNodeLabelReader(indexReader IndexReader) : AllEntriesLabelScanReader in class org.neo4j.kernel.api.impl.index.LabelScanStorageStrategy	From	To
Change Parameter Type searcherManager : SearcherManager to indexReader : IndexReader in method public newNodeLabelReader(indexReader IndexReader) : AllEntriesLabelScanReader in class org.neo4j.kernel.api.impl.index.NodeRangeDocumentLabelScanStorageStrategy	From	To
Change Parameter Type searcher : IndexSearcher to luceneIndex : LuceneIndex in method public labelsForNode(luceneIndex LuceneIndex, nodeId long) : Iterator<Long> in class org.neo4j.kernel.api.impl.index.LabelScanStorageStrategy	From	To
Change Parameter Type storage : StorageService to index : LuceneIndex in method public acquireWriter(index LuceneIndex, heldLock Lock) : LabelScanWriter in class org.neo4j.kernel.api.impl.index.LabelScanStorageStrategy	From	To
Change Parameter Type indexStorage : IndexStorage to luceneIndex : LuceneIndex in method public LuceneLabelScanStore(strategy LabelScanStorageStrategy, luceneIndex LuceneIndex, fullStoreStream FullStoreChangeStream, monitor Monitor) in class org.neo4j.kernel.api.impl.index.LuceneLabelScanStore	From	To
Change Parameter Type storage : StorageService to luceneIndex : LuceneIndex in method public acquireWriter(luceneIndex LuceneIndex, heldLock Lock) : LabelScanWriter in class org.neo4j.kernel.api.impl.index.NodeRangeDocumentLabelScanStorageStrategy	From	To
Move Method	1
Move Method public sampleIndex(result DoubleLong.Out) : long from class org.neo4j.kernel.impl.api.index.inmemory.HashBasedIndex to public sampleIndex(result Register.DoubleLong.Out) : long from class org.neo4j.kernel.impl.api.index.inmemory.HashBasedIndexSampler	From	To
Move Class	3
Move Class org.neo4j.kernel.api.impl.index.reader.sample.UniqueLuceneIndexSampler moved to org.neo4j.kernel.api.impl.index.sampler.UniqueLuceneIndexSampler	From	To
Move Class org.neo4j.unsafe.batchinsert.LabelScanWriter moved to org.neo4j.kernel.api.labelscan.LabelScanWriter	From	To
Move Class org.neo4j.kernel.api.impl.index.reader.sample.NonUniqueLuceneIndexSampler moved to org.neo4j.kernel.api.impl.index.sampler.NonUniqueLuceneIndexSampler	From	To
Change Variable Type	1
Change Variable Type indexStorage : IndexStorage to index : LuceneIndex in method public newInstance(context KernelContext, dependencies Dependencies) : LabelScanStoreProvider in class org.neo4j.kernel.api.impl.index.LuceneLabelScanStoreExtension	From	To
Extract Method	1
Extract Method public listFolders() : List<File> extracted from public openIndexDirectories() : Map<File,Directory> in class org.neo4j.kernel.api.impl.index.storage.PartitionedIndexStorage	From	To
Rename Method	3
Rename Method public sampleIndex(result Register.DoubleLong.Out) : long renamed to protected performSampling(result Register.DoubleLong.Out) : long in class org.neo4j.kernel.api.impl.index.sampler.NonUniqueLuceneIndexSampler	From	To
Rename Method private createIndexSampler() : LuceneIndexSampler renamed to public createSampler() : IndexSampler in class org.neo4j.kernel.api.impl.index.reader.SimpleIndexReader	From	To
Rename Method public sampleIndex(result Register.DoubleLong.Out) : long renamed to protected performSampling(result Register.DoubleLong.Out) : long in class org.neo4j.kernel.api.impl.index.sampler.UniqueLuceneIndexSampler	From	To
Rename Variable	3
Rename Variable indexStorage : IndexStorage to index : LuceneIndex in method public newInstance(context KernelContext, dependencies Dependencies) : LabelScanStoreProvider in class org.neo4j.kernel.api.impl.index.LuceneLabelScanStoreExtension	From	To
Rename Variable file : File to dir : File in method public openIndexDirectories() : Map<File,Directory> in class org.neo4j.kernel.api.impl.index.storage.PartitionedIndexStorage	From	To
Rename Variable luceneIndex : LuceneIndex to index : LuceneIndex in method public before() : void in class org.neo4j.kernel.api.impl.index.LuceneIndexIT	From	To
Inline Method	2
Inline Method private prepareRebuildOfIndex() : void inlined to public init() : void in class org.neo4j.kernel.api.impl.index.LuceneLabelScanStore	From	To
Change Return Type	3
Change Return Type IndexReader to PartitionedIndexReader in method private createPartitionedReader(partitions List<IndexPartition>) : PartitionedIndexReader in class org.neo4j.kernel.api.impl.index.LuceneIndex	From	To
Change Return Type LuceneIndexSampler to IndexSampler in method public createSampler() : IndexSampler in class org.neo4j.kernel.api.impl.index.reader.SimpleIndexReader	From	To
Change Return Type IndexReader to SimpleIndexReader in method private createSimpleReader(partitions List<IndexPartition>) : SimpleIndexReader in class org.neo4j.kernel.api.impl.index.LuceneIndex	From	To
Rename Attribute	4
Rename Attribute storage : LabelScanStorageStrategy.StorageService to index : LuceneIndex in class org.neo4j.kernel.api.impl.index.LuceneLabelScanWriter	From	To
Rename Attribute indexId : long to INDEX_IDENTIFIER : String in class org.neo4j.kernel.impl.api.constraints.ConstraintCreationIT	From	To
Rename Attribute INDEX_ID : int to INDEX_IDENTIFIER : String in class org.neo4j.kernel.api.impl.index.DeferredConstraintVerificationUniqueLuceneIndexPopulatorTest	From	To
Rename Attribute indexId : long to indexIdentifier : String in class org.neo4j.kernel.api.impl.index.storage.FailureStorageTest	From	To
Change Package	1
Change Package org.neo4j.kernel.api.impl.index.reader.sample to org.neo4j.kernel.api.impl.index.sampler	From	To
Change Attribute Type	4
Change Attribute Type INDEX_ID : int to INDEX_IDENTIFIER : String in class org.neo4j.kernel.api.impl.index.DeferredConstraintVerificationUniqueLuceneIndexPopulatorTest	From	To
Change Attribute Type indexId : long to indexIdentifier : String in class org.neo4j.kernel.api.impl.index.storage.FailureStorageTest	From	To
Change Attribute Type storage : LabelScanStorageStrategy.StorageService to index : LuceneIndex in class org.neo4j.kernel.api.impl.index.LuceneLabelScanWriter	From	To
Change Attribute Type indexId : long to INDEX_IDENTIFIER : String in class org.neo4j.kernel.impl.api.constraints.ConstraintCreationIT	From	To
Rename Parameter	14
Rename Parameter searcher : IndexSearcher to luceneIndex : LuceneIndex in method public labelsForNode(luceneIndex LuceneIndex, nodeId long) : Iterator<Long> in class org.neo4j.kernel.api.impl.index.NodeRangeDocumentLabelScanStorageStrategy	From	To
Rename Parameter searcher : IndexSearcher to luceneIndex : LuceneIndex in method public labelsForNode(luceneIndex LuceneIndex, nodeId long) : Iterator<Long> in class org.neo4j.kernel.api.impl.index.LabelScanStorageStrategy	From	To
Rename Parameter searcher : IndexSearcher to index : LuceneIndex in method public nodesWithLabel(index LuceneIndex, labelId int) : PrimitiveLongIterator in class org.neo4j.kernel.api.impl.index.NodeRangeDocumentLabelScanStorageStrategy	From	To
Rename Parameter schemaIndexRootFolder : File to rootFolder : File in method public PartitionedIndexStorage(directoryFactory DirectoryFactory, fileSystem FileSystemAbstraction, rootFolder File, identifier String) in class org.neo4j.kernel.api.impl.index.storage.PartitionedIndexStorage	From	To
Rename Parameter searcher : SearcherManager to indexReader : IndexReader in method public newNodeLabelReader(indexReader IndexReader) : AllEntriesLabelScanReader in class org.neo4j.kernel.api.impl.index.LabelScanStorageStrategy	From	To
Rename Parameter indexId : long to identifier : String in method public PartitionedIndexStorage(directoryFactory DirectoryFactory, fileSystem FileSystemAbstraction, rootFolder File, identifier String) in class org.neo4j.kernel.api.impl.index.storage.PartitionedIndexStorage	From	To
Rename Parameter storage : StorageService to luceneIndex : LuceneIndex in method public acquireWriter(luceneIndex LuceneIndex, heldLock Lock) : LabelScanWriter in class org.neo4j.kernel.api.impl.index.NodeRangeDocumentLabelScanStorageStrategy	From	To
Rename Parameter searcher : IndexSearcher to index : LuceneIndex in method package PageOfRangesIterator(format BitmapDocumentFormat, index LuceneIndex, rangesPerPage int, query Query, labels int...) in class org.neo4j.kernel.api.impl.index.PageOfRangesIterator	From	To
Rename Parameter indexId : long to identifier : String in method public IndexFolderLayout(rootDirectory File, identifier String) in class org.neo4j.kernel.api.impl.index.storage.layout.IndexFolderLayout	From	To
Rename Parameter searcherManager : SearcherManager to indexReader : IndexReader in method public newNodeLabelReader(indexReader IndexReader) : AllEntriesLabelScanReader in class org.neo4j.kernel.api.impl.index.NodeRangeDocumentLabelScanStorageStrategy	From	To
Rename Parameter storage : LabelScanStorageStrategy.StorageService to index : LuceneIndex in method public LuceneLabelScanWriter(index LuceneIndex, format BitmapDocumentFormat, heldLock Lock) in class org.neo4j.kernel.api.impl.index.LuceneLabelScanWriter	From	To
Rename Parameter searcher : IndexSearcher to luceneIndex : LuceneIndex in method public nodesWithLabel(luceneIndex LuceneIndex, labelId int) : PrimitiveLongIterator in class org.neo4j.kernel.api.impl.index.LabelScanStorageStrategy	From	To
Rename Parameter storage : StorageService to index : LuceneIndex in method public acquireWriter(index LuceneIndex, heldLock Lock) : LabelScanWriter in class org.neo4j.kernel.api.impl.index.LabelScanStorageStrategy	From	To
Rename Parameter indexStorage : IndexStorage to luceneIndex : LuceneIndex in method public LuceneLabelScanStore(strategy LabelScanStorageStrategy, luceneIndex LuceneIndex, fullStoreStream FullStoreChangeStream, monitor Monitor) in class org.neo4j.kernel.api.impl.index.LuceneLabelScanStore	From	To

432b939851fbcf0cb9ec618f77d8d1942dc7a522

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: