46b4df583cdd98b1855a2e6fe00371ab027e562a
Files Diff
- Added: 0
- Removed: 1
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method private readHighIdFromHeader(channel StoreChannel, fileName File) : ByteBuffer renamed to private readAndValidate(channel StoreChannel, fileName File) : long in class org.neo4j.kernel.impl.store.id.IdFile | From | To | |
| Rename Method private writeHeader(buffer ByteBuffer) : void renamed to private markAsCleanlyClosed() : void in class org.neo4j.kernel.impl.store.id.IdFile | From | To | |
| Rename Method private readHeader() : ByteBuffer renamed to private readAndValidateHeader() : long in class org.neo4j.kernel.impl.store.id.IdFile | From | To | |
| Inline Method | 1 | ||
| Inline Method private restoreIdsOnStartup() : void inlined to public FreeIdKeeper(channel StoreChannel, threshold int, aggressiveReuse boolean, initialPosition int) in class org.neo4j.kernel.impl.store.id.FreeIdKeeper | From | To | |
| Change Return Type | 2 | ||
| Change Return Type ByteBuffer to long in method private readAndValidate(channel StoreChannel, fileName File) : long in class org.neo4j.kernel.impl.store.id.IdFile | From | To | |
| Change Return Type ByteBuffer to long in method private readAndValidateHeader() : long in class org.neo4j.kernel.impl.store.id.IdFile | From | To | |
| Move Attribute | 1 | ||
| Move Attribute public NO_RESULT : long from class org.neo4j.kernel.impl.store.id.FreeIdKeeper to public NO_RESULT : long from class org.neo4j.kernel.impl.store.id.IdFile | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute id : long to highId : long in method public nextId() : long in class org.neo4j.kernel.impl.store.id.IdGeneratorImpl | From | To | |
| Extract Method | 19 | ||
| Extract Method private getFreeIdKeeper(channel StoreChannel, threshold int) : FreeIdKeeper extracted from public shouldStoreAndRestoreIds() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getFreeIdKeeper(channel StoreChannel, threshold int) : FreeIdKeeper extracted from public shouldNotReturnIdsPersistedDuringThisRunIfAggressiveIsFalse() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getStoreChannel() : StoreChannel extracted from public shouldReturnNoResultIfIdsAreRestoredAndExhaustedAndThereAreFreeIdsFromThisRunWithAggressiveFalse() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getStoreChannel() : StoreChannel extracted from public shouldReadBackPersistedIdsWhenAggressiveReuseIsSet() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private writeHeader(highId long) : void extracted from public close() : void in class org.neo4j.kernel.impl.store.id.IdFile | From | To | |
| Extract Method private getStoreChannel() : StoreChannel extracted from public shouldFirstReturnNonPersistedIdsAndThenPersistedOnesWhenAggressiveReuse() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getFreeIdKeeper(channel StoreChannel, threshold int) : FreeIdKeeper extracted from public shouldReturnNoResultIfIdsAreRestoredAndExhaustedAndThereAreFreeIdsFromThisRunWithAggressiveFalse() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getFreeIdKeeper(channel StoreChannel, threshold int) : FreeIdKeeper extracted from public newlyConstructedInstanceShouldReportProperDefaultValues() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getStoreChannel() : StoreChannel extracted from public shouldNotReturnNewlyReleasedIdsIfAggressiveIsFalse() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getFreeIdKeeper(channel StoreChannel, threshold int) : FreeIdKeeper extracted from public shouldNotReturnNewlyReleasedIdsIfAggressiveIsFalse() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getStoreChannel() : StoreChannel extracted from public shouldReadBackManyPersistedIdBatchesWhenAggressiveReuseIsSet() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getFreeIdKeeper(channel StoreChannel, threshold int) : FreeIdKeeper extracted from public shouldOnlyOverflowWhenThresholdIsReached() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getFreeIdKeeper(channel StoreChannel, threshold int, aggresiveReuse boolean) : FreeIdKeeper extracted from public shouldReturnIdsRestoredAndIgnoreNewlyReleasedIfAggressiveReuseIsFalse() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getFreeIdKeeper(channel StoreChannel, threshold int, aggresiveReuse boolean) : FreeIdKeeper extracted from public shouldStoreAndRestoreIds() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getStoreChannel() : StoreChannel extracted from public shouldStoreAndRestoreIds() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getFreeIdKeeper(channel StoreChannel, threshold int) : FreeIdKeeper extracted from public shouldReturnIdsRestoredAndIgnoreNewlyReleasedIfAggressiveReuseIsFalse() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getStoreChannel() : StoreChannel extracted from public shouldReturnIdsRestoredAndIgnoreNewlyReleasedIfAggressiveReuseIsFalse() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getStoreChannel() : StoreChannel extracted from public persistedIdsShouldStillBeCounted() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To | |
| Extract Method private getFreeIdKeeper(channel StoreChannel, threshold int, aggresiveReuse boolean) : FreeIdKeeper extracted from public shouldReturnNoResultIfIdsAreRestoredAndExhaustedAndThereAreFreeIdsFromThisRunWithAggressiveFalse() : void in class org.neo4j.kernel.impl.store.id.FreeIdKeeperTest | From | To |