615656da6247c9f10cd5ed8a9c169411d5df432d
Files Diff
- Added: 4
- Removed: 10
- Renamed: 0
- Modified: 37
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Inline Method | 3 | ||
| Move And Inline Method public start() : void moved from class org.neo4j.coreedge.core.state.BindingService to class org.neo4j.coreedge.catchup.storecopy.LocalDatabase & inlined to public start() : void | From | To | |
| Move And Inline Method public start() : void moved from class org.neo4j.coreedge.core.state.BindingService to class org.neo4j.coreedge.core.state.CoreState & inlined to public start() : void | From | To | |
| Move And Inline Method public start() : void moved from class org.neo4j.coreedge.core.state.BindingService to class org.neo4j.coreedge.core.state.CommandApplicationProcess & inlined to public start() : void | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass org.neo4j.coreedge.core.state.storage.SimpleFileStorage from class org.neo4j.coreedge.core.state.storage.SimpleStorage | From | To | |
| Push Down Attribute | 4 | ||
| Push Down Attribute private marshal : ChannelMarshal<T> from class org.neo4j.coreedge.core.state.storage.SimpleStorage to private marshal : ChannelMarshal<T> from class org.neo4j.coreedge.core.state.storage.SimpleFileStorage | From | To | |
| Push Down Attribute private log : Log from class org.neo4j.coreedge.core.state.storage.SimpleStorage to private log : Log from class org.neo4j.coreedge.core.state.storage.SimpleFileStorage | From | To | |
| Push Down Attribute private file : File from class org.neo4j.coreedge.core.state.storage.SimpleStorage to private file : File from class org.neo4j.coreedge.core.state.storage.SimpleFileStorage | From | To | |
| Push Down Attribute private fileSystem : FileSystemAbstraction from class org.neo4j.coreedge.core.state.storage.SimpleStorage to private fileSystem : FileSystemAbstraction from class org.neo4j.coreedge.core.state.storage.SimpleFileStorage | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private boundClusterId : ClusterId from class org.neo4j.coreedge.core.state.BindingService to private boundClusterId : ClusterId from class org.neo4j.coreedge.core.state.CoreState | From | To | |
| Move Attribute public LAST_FLUSHED_NAME : String from class org.neo4j.coreedge.ReplicationModule to public LAST_FLUSHED_NAME : String from class org.neo4j.coreedge.core.server.CoreServerModule | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type destination : Path to destination : File in method public shouldReplicateTransactionToCoreMembers() : void in class org.neo4j.coreedge.scenarios.ConvertNonCoreEdgeStoreIT | From | To | |
| Extract Method | 1 | ||
| Extract Method private publishClusterId(localClusterId ClusterId) : void extracted from private bindToCluster() : ClusterId in class org.neo4j.coreedge.core.state.BindingService | From | To | |
| Rename Method | 3 | ||
| Rename Method public shouldConsiderTopologyChanges() : void renamed to public shouldBindToClusterIdPublishedByAnotherMember() : void in class org.neo4j.coreedge.core.state.BindingServiceTest | From | To | |
| Rename Method public shouldTimeoutEventually() : void renamed to public shouldTimeoutWhenNotBootrappableAndNobodyElsePublishesClusterId() : void in class org.neo4j.coreedge.core.state.BindingServiceTest | From | To | |
| Rename Method public shouldPublishOldId() : void renamed to public shouldPublishStoredClusterIdIfPreviouslyBound() : void in class org.neo4j.coreedge.core.state.BindingServiceTest | From | To | |
| Push Down Method | 4 | ||
| Push Down Method public readState() : T from class org.neo4j.coreedge.core.state.storage.SimpleStorage to public readState() : T from class org.neo4j.coreedge.core.state.storage.SimpleFileStorage | From | To | |
| Push Down Method public SimpleStorage(fileSystem FileSystemAbstraction, directory File, name String, marshal ChannelMarshal<T>, logProvider LogProvider) from class org.neo4j.coreedge.core.state.storage.SimpleStorage to public SimpleFileStorage(fileSystem FileSystemAbstraction, directory File, name String, marshal ChannelMarshal<T>, logProvider LogProvider) from class org.neo4j.coreedge.core.state.storage.SimpleFileStorage | From | To | |
| Push Down Method public writeState(state T) : void from class org.neo4j.coreedge.core.state.storage.SimpleStorage to public writeState(state T) : void from class org.neo4j.coreedge.core.state.storage.SimpleFileStorage | From | To | |
| Push Down Method public exists() : boolean from class org.neo4j.coreedge.core.state.storage.SimpleStorage to public exists() : boolean from class org.neo4j.coreedge.core.state.storage.SimpleFileStorage | From | To | |
| Rename Variable | 9 | ||
| Rename Variable bindingService : BindingService to binder : BindingService in method public shouldPublishStoredClusterIdIfPreviouslyBound() : void in class org.neo4j.coreedge.core.state.BindingServiceTest | From | To | |
| Rename Variable commonClusterId : ClusterId to publishedClusterId : ClusterId in method public shouldBindToClusterIdPublishedByAnotherMember() : void in class org.neo4j.coreedge.core.state.BindingServiceTest | From | To | |
| Rename Variable backupPathPerCoreMachine : File to backupDir : File in method public makeSureBackupCanBePerformedFromAnyInstance() : void in class org.neo4j.coreedge.backup.BackupCoreIT | From | To | |
| Rename Variable localClusterId : ClusterId to previouslyBoundClusterId : ClusterId in method public shouldPublishStoredClusterIdIfPreviouslyBound() : void in class org.neo4j.coreedge.core.state.BindingServiceTest | From | To | |
| Rename Variable bindingService : BindingService to binder : BindingService in method public shouldBindToClusterIdPublishedByAnotherMember() : void in class org.neo4j.coreedge.core.state.BindingServiceTest | From | To | |
| Rename Variable topologyNOK : CoreTopology to unboundTopology : CoreTopology in method public shouldBindToClusterIdPublishedByAnotherMember() : void in class org.neo4j.coreedge.core.state.BindingServiceTest | From | To | |
| Rename Variable bindingService : BindingService to binder : BindingService in method public shouldTimeoutWhenNotBootrappableAndNobodyElsePublishesClusterId() : void in class org.neo4j.coreedge.core.state.BindingServiceTest | From | To | |
| Rename Variable topologyOK : CoreTopology to boundTopology : CoreTopology in method public shouldBindToClusterIdPublishedByAnotherMember() : void in class org.neo4j.coreedge.core.state.BindingServiceTest | From | To | |
| Rename Variable topology : CoreTopology to unboundTopology : CoreTopology in method public shouldTimeoutWhenNotBootrappableAndNobodyElsePublishesClusterId() : void in class org.neo4j.coreedge.core.state.BindingServiceTest | From | To | |
| Inline Method | 1 | ||
| Inline Method private notifyNeedFreshSnapshot(source MemberId) : void inlined to public handle(storeIdAwareMessage RaftMessages.StoreIdAwareMessage) : void in class org.neo4j.coreedge.core.state.CoreState | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to boolean in method public submit(abortableTask Function<Status,Runnable>) : boolean in class org.neo4j.coreedge.core.state.CoreStateApplier | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable commonClusterId : ClusterId to localClusterId : ClusterId in method private publishClusterId(localClusterId ClusterId) : void in class org.neo4j.coreedge.core.state.BindingService | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute backupPath : File to backupsDir : File in class org.neo4j.coreedge.backup.BackupCoreIT | From | To |