6df278c77abee9e82f78d8846218fe033578aa25
Files Diff
- Added: 6
- Removed: 3
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 1 | ||
| Merge Attribute [neo4jPack : Neo4jPack, connection : BoltConnection] to boltProtocol : BoltProtocol in class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstaller | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type throttleGroup : TransportThrottleGroup to stateMachineFactory : BoltStateMachineFactory in method private createBoltProtocolInstallerFactory(connectionFactory BoltConnectionFactory, stateMachineFactory BoltStateMachineFactory) : BoltProtocolPipelineInstallerFactory in class org.neo4j.bolt.BoltServer | From | To | |
| Change Parameter Type connection : BoltConnection to boltProtocol : BoltProtocol in method public DefaultBoltProtocolPipelineInstaller(boltChannel BoltChannel, boltProtocol BoltProtocol, logging LogService) in class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstaller | From | To | |
| Change Parameter Type throttleGroup : TransportThrottleGroup to stateMachineFactory : BoltStateMachineFactory in method public DefaultBoltProtocolPipelineInstallerFactory(connectionFactory BoltConnectionFactory, stateMachineFactory BoltStateMachineFactory, logService LogService) in class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstallerFactory | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private neo4jPack : Neo4jPack from class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstaller to private neo4jPack : Neo4jPack from class org.neo4j.bolt.v1.BoltProtocolV1 | From | To | |
| Move Attribute private connection : BoltConnection from class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstaller to private connection : BoltConnection from class org.neo4j.bolt.v1.BoltProtocolV1 | From | To | |
| Extract Class | 1 | ||
| Extract Class org.neo4j.bolt.v1.BoltProtocolV1 from class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstaller | From | To | |
| Rename Class | 3 | ||
| Rename Class org.neo4j.bolt.v1.runtime.BoltFactory renamed to org.neo4j.bolt.v1.runtime.BoltStateMachineFactory | From | To | |
| Rename Class org.neo4j.bolt.v1.runtime.BoltFactoryImpl renamed to org.neo4j.bolt.v1.runtime.BoltStateMachineFactoryImpl | From | To | |
| Rename Class org.neo4j.bolt.v1.runtime.BoltFactoryImplTest renamed to org.neo4j.bolt.v1.runtime.BoltStateMachineFactoryImplTest | From | To | |
| Extract Variable | 3 | ||
| Extract Variable boltProtocol : BoltProtocol in method public shouldReportCorrectVersion(version long) : void from class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstallerTest | From | To | |
| Extract Variable logging : NullLogService in method private testPermutation(unfragmented byte[], fragments ByteBuf[]) : void from class org.neo4j.bolt.v1.transport.socket.FragmentedMessageDeliveryTest | From | To | |
| Extract Variable boltProtocol : BoltProtocol in method public shouldInstallChannelHandlersInCorrectOrder() : void from class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstallerTest | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type boltFactory : BoltFactory to boltStateMachineFactory : BoltStateMachineFactory in method public start() : void in class org.neo4j.bolt.BoltServer | From | To | |
| Change Variable Type factory : BoltFactoryImpl to factory : BoltStateMachineFactoryImpl in method public shouldCreateBoltStateMachines(protocolVersion long) : void in class org.neo4j.bolt.v1.runtime.BoltStateMachineFactoryImplTest | From | To | |
| Rename Method | 3 | ||
| Rename Method private createHandlerFactory(connectionFactory BoltConnectionFactory, throttleGroup TransportThrottleGroup) : BoltProtocolPipelineInstallerFactory renamed to private createBoltProtocolInstallerFactory(connectionFactory BoltConnectionFactory, stateMachineFactory BoltStateMachineFactory) : BoltProtocolPipelineInstallerFactory in class org.neo4j.bolt.BoltServer | From | To | |
| Rename Method public newMachine(boltChannel BoltChannel, clock Clock) : BoltStateMachine renamed to private newStateMachineV1(boltChannel BoltChannel) : BoltStateMachine in class org.neo4j.bolt.v1.runtime.BoltStateMachineFactoryImpl | From | To | |
| Rename Method private testHandlerCreation(protocolVersion long) : void renamed to public shouldCreateBoltProtocolInstaller(protocolVersion long) : void in class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstallerFactoryTest | From | To | |
| Inline Method | 2 | ||
| Inline Method private newProtocolPipelineInstaller(channel BoltChannel, neo4jPack Neo4jPack) : BoltProtocolPipelineInstaller inlined to public create(protocolVersion long, channel BoltChannel) : BoltProtocolPipelineInstaller in class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstallerFactory | From | To | |
| Inline Method package newMachine(boltChannel BoltChannel, clock Clock) : BoltStateMachine inlined to package newMachine(boltChannel BoltChannel) : BoltStateMachine in class org.neo4j.bolt.v1.runtime.integration.SessionRule | From | To | |
| Rename Variable | 5 | ||
| Rename Variable protocol : DefaultBoltProtocolPipelineInstaller to installer : DefaultBoltProtocolPipelineInstaller in method public shouldInstallChannelHandlersInCorrectOrder() : void in class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstallerTest | From | To | |
| Rename Variable handlerFactory : BoltProtocolPipelineInstallerFactory to boltProtocolInstaller : BoltProtocolPipelineInstallerFactory in method public start() : void in class org.neo4j.bolt.BoltServer | From | To | |
| Rename Variable protocol : DefaultBoltProtocolPipelineInstaller to installer : DefaultBoltProtocolPipelineInstaller in method public shouldReportCorrectVersion(version long) : void in class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstallerTest | From | To | |
| Rename Variable handler : BoltProtocolPipelineInstaller to installer : BoltProtocolPipelineInstaller in method public shouldCreateBoltProtocolInstaller(protocolVersion long) : void in class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstallerFactoryTest | From | To | |
| Rename Variable boltFactory : BoltFactory to boltStateMachineFactory : BoltStateMachineFactory in method public start() : void in class org.neo4j.bolt.BoltServer | From | To | |
| Change Return Type | 2 | ||
| Change Return Type BoltFactoryImpl to BoltStateMachineFactoryImpl in method private newBoltFactory(db GraphDatabaseAPI) : BoltStateMachineFactoryImpl in class org.neo4j.bolt.v1.runtime.BoltStateMachineFactoryImplTest | From | To | |
| Change Return Type BoltFactoryImpl to BoltStateMachineFactoryImpl in method private newBoltFactory() : BoltStateMachineFactoryImpl in class org.neo4j.bolt.v1.runtime.BoltStateMachineFactoryImplTest | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute throttleGroup : TransportThrottleGroup to stateMachineFactory : BoltStateMachineFactory in class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstallerFactory | From | To | |
| Rename Attribute handlerFactory : BoltProtocolPipelineInstallerFactory to boltProtocolInstallerFactory : BoltProtocolPipelineInstallerFactory in class org.neo4j.bolt.transport.pipeline.ProtocolHandshaker | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type boltFactory : BoltFactoryImpl to boltFactory : BoltStateMachineFactoryImpl in class org.neo4j.bolt.v1.runtime.integration.SessionRule | From | To | |
| Change Attribute Type throttleGroup : TransportThrottleGroup to stateMachineFactory : BoltStateMachineFactory in class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstallerFactory | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter throttleGroup : TransportThrottleGroup to stateMachineFactory : BoltStateMachineFactory in method private createBoltProtocolInstallerFactory(connectionFactory BoltConnectionFactory, stateMachineFactory BoltStateMachineFactory) : BoltProtocolPipelineInstallerFactory in class org.neo4j.bolt.BoltServer | From | To | |
| Rename Parameter connection : BoltConnection to boltProtocol : BoltProtocol in method public DefaultBoltProtocolPipelineInstaller(boltChannel BoltChannel, boltProtocol BoltProtocol, logging LogService) in class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstaller | From | To | |
| Rename Parameter throttleGroup : TransportThrottleGroup to stateMachineFactory : BoltStateMachineFactory in method public DefaultBoltProtocolPipelineInstallerFactory(connectionFactory BoltConnectionFactory, stateMachineFactory BoltStateMachineFactory, logService LogService) in class org.neo4j.bolt.transport.DefaultBoltProtocolPipelineInstallerFactory | From | To | |
| Rename Parameter handlerFactory : BoltProtocolPipelineInstallerFactory to boltProtocolInstallerFactory : BoltProtocolPipelineInstallerFactory in method public ProtocolHandshaker(boltProtocolInstallerFactory BoltProtocolPipelineInstallerFactory, boltChannel BoltChannel, logging LogProvider, encryptionRequired boolean, encrypted boolean) in class org.neo4j.bolt.transport.pipeline.ProtocolHandshaker | From | To |