702cb71953c582a19c68e677d4802f60c22a4a2f
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 28
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private getPopulator(index int) : IndexPopulation renamed to private getPopulation(descriptor IndexDescriptor) : IndexPopulation in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Rename Method public shouldPopulateMultipleIndexPopulatorsUnderStress() : void renamed to private readConfigAndRunTest(multiThreaded boolean) : void in class schema.MultipleIndexPopulationStressIT | From | To | |
| Change Parameter Type | 6 | ||
| Change Parameter Type updaters : List<IndexUpdater> to updaters : Map<IndexDescriptor,IndexUpdater> in method package MultipleIndexUpdater(multipleIndexPopulator MultipleIndexPopulator, updaters Map<IndexDescriptor,IndexUpdater>, logProvider LogProvider) in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.MultipleIndexUpdater | From | To | |
| Change Parameter Type logProvider : LogProvider to multiPopulator : MultipleIndexPopulator in method public IndexPopulationJob(storeView IndexStoreView, multiPopulator MultipleIndexPopulator, monitor IndexingService.Monitor, schemaStateChangeCallback Runnable) in class org.neo4j.kernel.impl.api.index.IndexPopulationJob | From | To | |
| Change Parameter Type value : boolean to value : Object in method public toggle(location Class<?>, name String, value Object) : String in class org.neo4j.unsafe.impl.internal.dragons.FeatureToggles | From | To | |
| Change Parameter Type index : int to descriptor : IndexDescriptor in method protected fail(descriptor IndexDescriptor, t Throwable) : void in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Change Parameter Type samplingConfig : IndexSamplingConfig to config : Config in method public createIndexingService(config Config, scheduler JobScheduler, providerMap SchemaIndexProviderMap, storeView IndexStoreView, tokenNameLookup TokenNameLookup, indexRules Iterable<IndexRule>, logProvider LogProvider, monitor IndexingService.Monitor, schemaStateChangeCallback Runnable) : IndexingService in class org.neo4j.kernel.impl.api.index.IndexingServiceFactory | From | To | |
| Change Parameter Type index : int to descriptor : IndexDescriptor in method private getPopulation(descriptor IndexDescriptor) : IndexPopulation in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Rename Variable | 4 | ||
| Rename Variable sleep : long to checkIntervalMillis : long in method public await(condition Supplier<Boolean>, timeout long, unit TimeUnit) : void in class org.neo4j.function.Predicates | From | To | |
| Rename Variable populator : IndexPopulation to population : IndexPopulation in method private add(update NodePropertyUpdate) : void in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.NodePopulationVisitor | From | To | |
| Rename Variable i : int to descriptor : IndexDescriptor in method public process(update NodePropertyUpdate) : void in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.MultipleIndexUpdater | From | To | |
| Rename Variable populator : IndexPopulation to population : IndexPopulation in method public flipAfterPopulation() : void in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Merge Variable | 4 | ||
| Merge Variable [nodeId : long, propertyValue : Object] to update : NodePropertyUpdate in method public add(updates List<NodePropertyUpdate>) : void in class org.neo4j.kernel.impl.api.index.IndexPopulationJobTest.NodeChangingWriter | From | To | |
| Merge Variable [nodeId : long, propertyValue : Object] to update : NodePropertyUpdate in method public add(updates List<NodePropertyUpdate>) : void in class org.neo4j.kernel.impl.api.index.IndexPopulationJobTest.NodeDeletingWriter | From | To | |
| Merge Variable [nodeId : long, propertyValue : Object] to update : NodePropertyUpdate in method public add(updates List<NodePropertyUpdate>) : void in class org.neo4j.kernel.impl.api.index.IndexCRUDIT.GatheringIndexWriter | From | To | |
| Merge Variable [nodeId : long, propertyValue : Object] to update : NodePropertyUpdate in method public add(updates List<NodePropertyUpdate>) : void in class org.neo4j.kernel.impl.api.index.inmemory.InMemoryIndex.Populator | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [nodeId : long, propertyValue : Object] to updates : List<NodePropertyUpdate> in method public add(updates List<NodePropertyUpdate>) : void in class org.neo4j.kernel.api.SchemaIndexHaIT.ControlledIndexPopulator | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute populator : MultipleIndexPopulator to multiPopulator : MultipleIndexPopulator in class org.neo4j.kernel.impl.api.index.IndexPopulationJob | From | To | |
| Extract Variable | 2 | ||
| Extract Variable sampleSize : long in method private flip() : void from class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.IndexPopulation | From | To | |
| Extract Variable uniqueElements : long in method private flip() : void from class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.IndexPopulation | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type updaters : List<IndexUpdater> to updaters : Map<IndexDescriptor,IndexUpdater> in method public newPopulatingUpdater(accessor PropertyAccessor) : MultipleIndexUpdater in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Change Variable Type i : int to descriptor : IndexDescriptor in method public process(update NodePropertyUpdate) : void in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.MultipleIndexUpdater | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type updaters : List<IndexUpdater> to updaters : Map<IndexDescriptor,IndexUpdater> in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.MultipleIndexUpdater | From | To | |
| Change Attribute Type directoryFactory : DirectoryFactory.InMemoryDirectoryFactory to directoryFactory : DirectoryFactory in class org.neo4j.kernel.api.impl.schema.DeferredConstraintVerificationUniqueLuceneIndexPopulatorTest | From | To | |
| Change Attribute Type populations : List<IndexPopulation> to populations : Map<IndexDescriptor,IndexPopulation> in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Extract Method | 3 | ||
| Extract Method protected createPopulation(populator IndexPopulator, descriptor IndexDescriptor, config IndexConfiguration, providerDescriptor Descriptor, flipper FlippableIndexProxy, failedIndexProxyFactory FailedIndexProxyFactory, indexUserDescription String) : IndexPopulation extracted from public addPopulator(populator IndexPopulator, descriptor IndexDescriptor, providerDescriptor Descriptor, config IndexConfiguration, flipper FlippableIndexProxy, failedIndexProxyFactory FailedIndexProxyFactory, indexUserDescription String) : void in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Extract Method protected addApplicable(update NodePropertyUpdate) : void extracted from public add(update NodePropertyUpdate) : void in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.IndexPopulation | From | To | |
| Extract Method public await(condition Supplier<Boolean>, timeout long, checkInterval long, unit TimeUnit) : void extracted from public await(condition Supplier<Boolean>, timeout long, unit TimeUnit) : void in class org.neo4j.function.Predicates | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method protected populateFromQueue(currentlyIndexedNodeId long) : void extracted from public visit(update NodePropertyUpdate) : boolean in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.NodePopulationVisitor & moved to class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter index : int to descriptor : IndexDescriptor in method private getPopulation(descriptor IndexDescriptor) : IndexPopulation in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Rename Parameter samplingConfig : IndexSamplingConfig to config : Config in method public createIndexingService(config Config, scheduler JobScheduler, providerMap SchemaIndexProviderMap, storeView IndexStoreView, tokenNameLookup TokenNameLookup, indexRules Iterable<IndexRule>, logProvider LogProvider, monitor IndexingService.Monitor, schemaStateChangeCallback Runnable) : IndexingService in class org.neo4j.kernel.impl.api.index.IndexingServiceFactory | From | To | |
| Rename Parameter index : int to descriptor : IndexDescriptor in method protected fail(descriptor IndexDescriptor, t Throwable) : void in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Rename Parameter logProvider : LogProvider to multiPopulator : MultipleIndexPopulator in method public IndexPopulationJob(storeView IndexStoreView, multiPopulator MultipleIndexPopulator, monitor IndexingService.Monitor, schemaStateChangeCallback Runnable) in class org.neo4j.kernel.impl.api.index.IndexPopulationJob | From | To |