neo4j 71f7d07b0f8ed9a4e6f7701f6fca3d2f674b2cfa

71f7d07b0f8ed9a4e6f7701f6fca3d2f674b2cfa

Files Diff

Added: 11
Removed: 2
Renamed: 0
Modified: 38

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	9
Change Parameter Type applicationProtocolRepository : ProtocolRepository<Protocol.ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in method public HandshakeClientInitializer(applicationProtocolRepository ApplicationProtocolRepository, modifierProtocolRepository ModifierProtocolRepository, protocolInstallerRepository ProtocolInstallerRepository<ProtocolInstaller.Orientation.Client>, pipelineBuilderFactory NettyPipelineBuilderFactory, config Config, logProvider LogProvider) in class org.neo4j.causalclustering.protocol.handshake.HandshakeClientInitializer	From	To
Change Parameter Type applicationProtocolRepository : ProtocolRepository<ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in method package HandshakeServer(applicationProtocolRepository ApplicationProtocolRepository, modifierProtocolRepository ModifierProtocolRepository, channel Channel) in class org.neo4j.causalclustering.protocol.handshake.HandshakeServer	From	To
Change Parameter Type applicationProtocolRepository : ProtocolRepository<Protocol.ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in method public HandshakeServerInitializer(applicationProtocolRepository ApplicationProtocolRepository, modifierProtocolRepository ModifierProtocolRepository, protocolInstallerRepository ProtocolInstallerRepository<ProtocolInstaller.Orientation.Server>, pipelineBuilderFactory NettyPipelineBuilderFactory, logProvider LogProvider) in class org.neo4j.causalclustering.protocol.handshake.HandshakeServerInitializer	From	To
Change Parameter Type modifierProtocolRepository : ProtocolRepository<Protocol.ModifierProtocol> to modifierProtocolRepository : ModifierProtocolRepository in method public HandshakeClientInitializer(applicationProtocolRepository ApplicationProtocolRepository, modifierProtocolRepository ModifierProtocolRepository, protocolInstallerRepository ProtocolInstallerRepository<ProtocolInstaller.Orientation.Client>, pipelineBuilderFactory NettyPipelineBuilderFactory, config Config, logProvider LogProvider) in class org.neo4j.causalclustering.protocol.handshake.HandshakeClientInitializer	From	To
Change Parameter Type applicationProtocolRepository : ProtocolRepository<Protocol.ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in method public initiate(channel Channel, applicationProtocolRepository ApplicationProtocolRepository, modifierProtocolRepository ModifierProtocolRepository) : CompletableFuture<ProtocolStack> in class org.neo4j.causalclustering.protocol.handshake.HandshakeClient	From	To
Change Parameter Type version : int to version : Integer in method package select(protocolName String, version Integer) : Optional<T> in class org.neo4j.causalclustering.protocol.handshake.ProtocolRepository	From	To
Change Parameter Type modifierProtocolRepository : ProtocolRepository<Protocol.ModifierProtocol> to modifierProtocolRepository : ModifierProtocolRepository in method public HandshakeServerInitializer(applicationProtocolRepository ApplicationProtocolRepository, modifierProtocolRepository ModifierProtocolRepository, protocolInstallerRepository ProtocolInstallerRepository<ProtocolInstaller.Orientation.Server>, pipelineBuilderFactory NettyPipelineBuilderFactory, logProvider LogProvider) in class org.neo4j.causalclustering.protocol.handshake.HandshakeServerInitializer	From	To
Change Parameter Type modifierProtocolRepository : ProtocolRepository<Protocol.ModifierProtocol> to modifierProtocolRepository : ModifierProtocolRepository in method public initiate(channel Channel, applicationProtocolRepository ApplicationProtocolRepository, modifierProtocolRepository ModifierProtocolRepository) : CompletableFuture<ProtocolStack> in class org.neo4j.causalclustering.protocol.handshake.HandshakeClient	From	To
Change Parameter Type modifierProtocolRepository : ProtocolRepository<ModifierProtocol> to modifierProtocolRepository : ModifierProtocolRepository in method package HandshakeServer(applicationProtocolRepository ApplicationProtocolRepository, modifierProtocolRepository ModifierProtocolRepository, channel Channel) in class org.neo4j.causalclustering.protocol.handshake.HandshakeServer	From	To
Move Attribute	1
Move Attribute private handshakeServer : HandshakeServer from class org.neo4j.causalclustering.protocol.handshake.NettyProtocolHandshakeIT to package handshakeServer : HandshakeServer from class org.neo4j.causalclustering.protocol.handshake.NettyProtocolHandshakeIT.Server	From	To
Rename Class	2
Rename Class org.neo4j.causalclustering.protocol.handshake.ProtocolRepositoryTest renamed to org.neo4j.causalclustering.protocol.handshake.ApplicationProtocolRepositoryTest	From	To
Rename Class org.neo4j.causalclustering.protocol.handshake.ProtocolHandshakeTest renamed to org.neo4j.causalclustering.protocol.handshake.ProtocolHandshakeSadTest	From	To
Move And Rename Class	2
Move And Rename Class org.neo4j.causalclustering.protocol.handshake.ProtocolHandshakeTest.FakeClientChannel moved and renamed to org.neo4j.causalclustering.protocol.handshake.ProtocolHandshakeHappyTest.FakeServerChannel	From	To
Move And Rename Class org.neo4j.causalclustering.protocol.handshake.ProtocolHandshakeTest.FakeServerChannel moved and renamed to org.neo4j.causalclustering.protocol.handshake.ProtocolHandshakeHappyTest.FakeClientChannel	From	To
Move Class	1
Move Class org.neo4j.causalclustering.protocol.handshake.ProtocolHandshakeTest.FakeChannelWrapper moved to org.neo4j.causalclustering.protocol.handshake.ProtocolHandshakeHappyTest.FakeChannelWrapper	From	To
Change Variable Type	4
Change Variable Type selectedModifierProtocol : Optional<Protocol.ModifierProtocol> to selectedModifierProtocol : Optional<ModifierProtocol> in method public handle(modifierProtocolResponse ModifierProtocolResponse) : void in class org.neo4j.causalclustering.protocol.handshake.HandshakeClient	From	To
Change Variable Type agreedModifierProtocols : List<Protocol.ModifierProtocol> to agreedModifierProtocols : List<ModifierProtocol> in method private sendSwitchOverRequestIfReady() : void in class org.neo4j.causalclustering.protocol.handshake.HandshakeClient	From	To
Change Variable Type protocol : Optional<Protocol.ApplicationProtocol> to protocol : Optional<ApplicationProtocol> in method public handle(applicationProtocolResponse ApplicationProtocolResponse) : void in class org.neo4j.causalclustering.protocol.handshake.HandshakeClient	From	To
Change Variable Type actual : List<Protocol.ModifierProtocol> to actual : Collection<Collection<Protocol.ModifierProtocol>> in method public shouldReturnModifierProtocolsForServer() : void in class org.neo4j.causalclustering.protocol.ProtocolInstallerRepositoryTest	From	To
Extract Method	1
Extract Method private sendProtocolRequests(channel Channel, applicationProtocols SupportedProtocols<ApplicationProtocol>, supportedModifierProtocols Collection<SupportedProtocols<ModifierProtocol>>) : void extracted from public initiate(channel Channel, applicationProtocolRepository ProtocolRepository<Protocol.ApplicationProtocol>, applicationProtocolIdentifier Protocol.ApplicationProtocolIdentifier, modifierProtocolRepository ProtocolRepository<Protocol.ModifierProtocol>, modifierProtocolIdentifiers Set<Protocol.ModifierProtocolIdentifier>) : CompletableFuture<ProtocolStack> in class org.neo4j.causalclustering.protocol.handshake.HandshakeClient	From	To
Rename Method	3
Rename Method public shouldSuccessfullyHandshakeKnownProtocolOnClient() : void renamed to public shouldSuccessfullyHandshakeKnownProtocolOnClientWithCompression() : void in class org.neo4j.causalclustering.protocol.handshake.NettyProtocolHandshakeIT	From	To
Rename Method public shouldSuccessfullyHandshakeKnownProtocolOnServer() : void renamed to public shouldSuccessfullyHandshakeKnownProtocolOnServerWithCompression() : void in class org.neo4j.causalclustering.protocol.handshake.NettyProtocolHandshakeIT	From	To
Rename Method public shouldReturnProtocolOfHighestVersionRequestedAndSupported() : void renamed to public shouldReturnApplicationProtocolOfHighestVersionNumberRequestedAndSupported() : void in class org.neo4j.causalclustering.protocol.handshake.ApplicationProtocolRepositoryTest	From	To
Push Down Method	1
Push Down Method private of(identifier String, version Integer) : Optional<T> from class org.neo4j.causalclustering.protocol.handshake.ProtocolRepository to public supportedProtocolFor(protocolName String) : Optional<SupportedProtocols<Protocol.ModifierProtocol>> from class org.neo4j.causalclustering.protocol.handshake.ModifierProtocolRepository	From	To
Pull Up Method	2
Pull Up Method public apply(nettyPipelineBuilder NettyPipelineBuilder<Orientation.Server,BUILDER>) : void from class org.neo4j.causalclustering.protocol.ModifierProtocolInstaller.SnappyServer to public apply(nettyPipelineBuilder NettyPipelineBuilder<Orientation.Server,BUILDER>) : void from class org.neo4j.causalclustering.protocol.ModifierProtocolInstaller.BaseServerModifier	From	To
Pull Up Method public apply(nettyPipelineBuilder NettyPipelineBuilder<Orientation.Client,BUILDER>) : void from class org.neo4j.causalclustering.protocol.ModifierProtocolInstaller.SnappyClient to public apply(nettyPipelineBuilder NettyPipelineBuilder<Orientation.Client,BUILDER>) : void from class org.neo4j.causalclustering.protocol.ModifierProtocolInstaller.BaseClientModifier	From	To
Rename Variable	1
Rename Variable versions : Set<Integer> to selectedVersions : Set<Integer> in method public getAll(identifier Protocol.Identifier<T>, versions Collection<Integer>) : ProtocolSelection<T> in class org.neo4j.causalclustering.protocol.handshake.ProtocolRepository	From	To
Change Return Type	4
Change Return Type Optional<T> to Optional<SupportedProtocols<Protocol.ModifierProtocol>> in method public supportedProtocolFor(protocolName String) : Optional<SupportedProtocols<Protocol.ModifierProtocol>> in class org.neo4j.causalclustering.protocol.handshake.ModifierProtocolRepository	From	To
Change Return Type List<Protocol.ModifierProtocol> to Collection<Collection<Protocol.ModifierProtocol>> in method public modifiers() : Collection<Collection<Protocol.ModifierProtocol>> in class org.neo4j.causalclustering.core.consensus.RaftProtocolClientInstaller	From	To
Change Return Type List<Protocol.ModifierProtocol> to Collection<Collection<Protocol.ModifierProtocol>> in method public modifiers() : Collection<Collection<Protocol.ModifierProtocol>> in class org.neo4j.causalclustering.core.consensus.RaftProtocolServerInstaller	From	To
Change Return Type List<Protocol.ModifierProtocol> to Collection<Collection<Protocol.ModifierProtocol>> in method public modifiers() : Collection<Collection<Protocol.ModifierProtocol>> in class org.neo4j.causalclustering.protocol.ProtocolInstaller	From	To
Extract Superclass	2
Extract Superclass org.neo4j.causalclustering.protocol.ModifierProtocolInstaller.BaseServerModifier from classes [org.neo4j.causalclustering.protocol.ModifierProtocolInstaller.SnappyServer]	From	To
Extract Superclass org.neo4j.causalclustering.protocol.ModifierProtocolInstaller.BaseClientModifier from classes [org.neo4j.causalclustering.protocol.ModifierProtocolInstaller.SnappyClient]	From	To
Rename Attribute	5
Rename Attribute applicationProtocolIdentifier : Protocol.ApplicationProtocolIdentifier to supportedApplicationProtocol : SupportedProtocols<ApplicationProtocol> in class org.neo4j.causalclustering.protocol.handshake.HandshakeServer	From	To
Rename Attribute applicationProtocolRepository : ProtocolRepository<Protocol.ApplicationProtocol> to catchupApplicationProtocolRepository : ApplicationProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.ProtocolHandshakeSadTest	From	To
Rename Attribute knownApplicationProtocolVersions : ProtocolSelection<Protocol.ApplicationProtocol> to supportedApplicationProtocol : SupportedProtocols<ApplicationProtocol> in class org.neo4j.causalclustering.protocol.handshake.HandshakeClient	From	To
Rename Attribute protocolRepository : ProtocolRepository<Protocol.ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.ApplicationProtocolRepositoryTest	From	To
Rename Attribute knownModifierProtocolVersions : List<ProtocolSelection<Protocol.ModifierProtocol>> to supportedModifierProtocols : Collection<SupportedProtocols<ModifierProtocol>> in class org.neo4j.causalclustering.protocol.handshake.HandshakeClient	From	To
Change Attribute Type	26
Change Attribute Type applicationProtocol : Protocol.ApplicationProtocol to applicationProtocol : ApplicationProtocol in class org.neo4j.causalclustering.protocol.handshake.HandshakeClient	From	To
Change Attribute Type applicationProtocolIdentifier : Protocol.ApplicationProtocolIdentifier to supportedApplicationProtocol : SupportedProtocols<ApplicationProtocol> in class org.neo4j.causalclustering.protocol.handshake.HandshakeServer	From	To
Change Attribute Type knownApplicationProtocolVersions : ProtocolSelection<Protocol.ApplicationProtocol> to supportedApplicationProtocol : SupportedProtocols<ApplicationProtocol> in class org.neo4j.causalclustering.protocol.handshake.HandshakeClient	From	To
Change Attribute Type applicationProtocolRepository : ProtocolRepository<Protocol.ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeClientEnsureMagicTest	From	To
Change Attribute Type applicationProtocolRepository : ProtocolRepository<ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeServerTest	From	To
Change Attribute Type applicationProtocolRepository : ProtocolRepository<Protocol.ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeClientInitializer	From	To
Change Attribute Type protocolRepository : ProtocolRepository<Protocol.ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.ApplicationProtocolRepositoryTest	From	To
Change Attribute Type modifierProtocolRepository : ProtocolRepository<Protocol.ModifierProtocol> to modifierProtocolRepository : ModifierProtocolRepository in class org.neo4j.causalclustering.messaging.SenderServiceIT	From	To
Change Attribute Type modifierProtocolRepository : ProtocolRepository<Protocol.ModifierProtocol> to modifierProtocolRepository : ModifierProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeServerEnsureMagicTest	From	To
Change Attribute Type modifierProtocolRepository : ProtocolRepository<Protocol.ModifierProtocol> to modifierProtocolRepository : ModifierProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeServerInitializer	From	To
Change Attribute Type modifierProtocolRepository : ProtocolRepository<Protocol.ModifierProtocol> to modifierProtocolRepository : ModifierProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeClientEnsureMagicTest	From	To
Change Attribute Type modifierProtocolRepository : ProtocolRepository<ModifierProtocol> to modifierProtocolRepository : ModifierProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeServer	From	To
Change Attribute Type modifierProtocolRepository : ProtocolRepository<Protocol.ModifierProtocol> to modifierProtocolRepository : ModifierProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeClientInitializer	From	To
Change Attribute Type negotiatedModifierProtocols : Map<String,Optional<Protocol.ModifierProtocol>> to negotiatedModifierProtocols : List<Pair<String,Optional<ModifierProtocol>>> in class org.neo4j.causalclustering.protocol.handshake.HandshakeClient	From	To
Change Attribute Type applicationProtocolRepository : ProtocolRepository<ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeServer	From	To
Change Attribute Type modifierProtocolRepository : ProtocolRepository<ModifierProtocol> to modifierProtocolRepository : ModifierProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeClientTest	From	To
Change Attribute Type knownModifierProtocolVersions : List<ProtocolSelection<Protocol.ModifierProtocol>> to supportedModifierProtocols : Collection<SupportedProtocols<ModifierProtocol>> in class org.neo4j.causalclustering.protocol.handshake.HandshakeClient	From	To
Change Attribute Type modifierProtocolRepository : ProtocolRepository<Protocol.ModifierProtocol> to modifierProtocolRepository : ProtocolRepository<ModifierProtocol> in class org.neo4j.causalclustering.protocol.handshake.HandshakeClient	From	To
Change Attribute Type applicationProtocolRepository : ProtocolRepository<Protocol.ApplicationProtocol> to catchupApplicationProtocolRepository : ApplicationProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.ProtocolHandshakeSadTest	From	To
Change Attribute Type applicationProtocolRepository : ProtocolRepository<ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeClientTest	From	To
Change Attribute Type applicationProtocolRepository : ProtocolRepository<Protocol.ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeClient	From	To
Change Attribute Type applicationProtocolRepository : ProtocolRepository<Protocol.ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in class org.neo4j.causalclustering.messaging.SenderServiceIT	From	To
Change Attribute Type applicationProtocolRepository : ProtocolRepository<Protocol.ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeServerEnsureMagicTest	From	To
Change Attribute Type modifierProtocolRepository : ProtocolRepository<Protocol.ModifierProtocol> to modifierProtocolRepository : ModifierProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.ProtocolHandshakeSadTest	From	To
Change Attribute Type applicationProtocolRepository : ProtocolRepository<Protocol.ApplicationProtocol> to applicationProtocolRepository : ApplicationProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeServerInitializer	From	To
Change Attribute Type modifierProtocolRepository : ProtocolRepository<ModifierProtocol> to modifierProtocolRepository : ModifierProtocolRepository in class org.neo4j.causalclustering.protocol.handshake.HandshakeServerTest	From	To
Extract And Move Method	1
Extract And Move Method package createAndStart(platformModule PlatformModule, consensusModule ConsensusModule, identityModule IdentityModule, coreServerModule CoreServerModule, localDatabase LocalDatabase, pipelineBuilderFactory NettyPipelineBuilderFactory, messageLogger MessageLogger<MemberId>, topologyService CoreTopologyService, supportedApplicationProtocol SupportedProtocols<ApplicationProtocol>, supportedModifierProtocols Collection<SupportedProtocols<ModifierProtocol>>) : RaftServerModule extracted from public EnterpriseCoreEditionModule(platformModule PlatformModule, discoveryServiceFactory DiscoveryServiceFactory) in class org.neo4j.causalclustering.core.EnterpriseCoreEditionModule & moved to class org.neo4j.causalclustering.core.RaftServerModule	From	To
Rename Parameter	1
Rename Parameter identifier : String to protocolName : String in method public supportedProtocolFor(protocolName String) : Optional<SupportedProtocols<Protocol.ModifierProtocol>> in class org.neo4j.causalclustering.protocol.handshake.ModifierProtocolRepository	From	To

71f7d07b0f8ed9a4e6f7701f6fca3d2f674b2cfa

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: