7254f8b1fa9ee558fabac1fa883179940f82a531
Files Diff
- Added: 0
- Removed: 1
- Renamed: 0
- Modified: 92
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 17 | ||
| Change Parameter Type provider : Optional<String> to provider : String in method public indexUniqueCreate(schema SchemaDescriptor, provider String) : IndexDescriptor in class org.neo4j.locking.QueryExecutionLocksIT.DelegatingTransaction | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method public createConstraintIndex(schema SchemaDescriptor, provider String) : IndexDescriptor in class org.neo4j.kernel.impl.api.state.ConstraintIndexCreator | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method private indexBackedConstraintCreate(constraint IndexBackedConstraintDescriptor, provider String) : void in class org.neo4j.kernel.impl.newapi.Operations | From | To | |
| Change Parameter Type expectedProvider : GraphDatabaseSettings.SchemaIndex to descriptor : IndexProviderDescriptor in method package LogMessageMatcher(match LogMatcherBuilder, descriptor IndexProviderDescriptor) in class org.neo4j.kernel.impl.api.SchemaLoggingIT.LogMessageMatcher | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method public uniquePropertyConstraintCreate(descriptor SchemaDescriptor, provider String) : ConstraintDescriptor in class org.neo4j.internal.kernel.api.SchemaWrite | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method public indexCreate(descriptor SchemaDescriptor, provider String, name Optional<String>) : IndexReference in class org.neo4j.kernel.impl.newapi.Operations | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method public uniquePropertyConstraintCreate(descriptor SchemaDescriptor, provider String) : ConstraintDescriptor in class org.neo4j.kernel.impl.newapi.Operations | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method public indexUniqueCreate(schema SchemaDescriptor, provider String) : IndexDescriptor in class org.neo4j.kernel.builtinprocs.StubKernelTransaction | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method public indexUniqueCreate(schema SchemaDescriptor, provider String) : IndexDescriptor in class org.neo4j.kernel.impl.newapi.Operations | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method public nodeKeyConstraintCreate(descriptor LabelSchemaDescriptor, provider String) : ConstraintDescriptor in class org.neo4j.kernel.impl.newapi.Operations | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method public indexUniqueCreate(schema SchemaDescriptor, provider String) : IndexDescriptor in class org.neo4j.kernel.api.KernelTransaction | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method public indexUniqueCreate(schema SchemaDescriptor, provider String) : IndexDescriptor in class org.neo4j.kernel.impl.api.KernelTransactionImplementation | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method public indexCreate(descriptor SchemaDescriptor, provider String, name Optional<String>) : IndexReference in class org.neo4j.internal.kernel.api.SchemaWrite | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method public nodeKeyConstraintCreate(descriptor LabelSchemaDescriptor, provider String) : ConstraintDescriptor in class org.neo4j.internal.kernel.api.SchemaWrite | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method public indexUniqueCreate(schema SchemaDescriptor, provider String) : IndexDescriptor in class org.neo4j.kernel.enterprise.builtinprocs.StubKernelTransaction | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method public createUniquenessConstraintIndex(transaction KernelTransactionImplementation, descriptor SchemaDescriptor, provider String) : long in class org.neo4j.kernel.impl.api.state.ConstraintIndexCreator | From | To | |
| Change Parameter Type provider : Optional<String> to provider : String in method private getOrCreateUniquenessConstraintIndex(schemaRead SchemaRead, tokenRead TokenRead, schema SchemaDescriptor, provider String) : IndexReference in class org.neo4j.kernel.impl.api.state.ConstraintIndexCreator | From | To | |
| Rename Variable | 2 | ||
| Rename Variable expectedProvider : GraphDatabaseSettings.SchemaIndex to providerDescriptor : IndexProviderDescriptor in method public shouldLogUserReadableLabelAndPropertyNames() : void in class org.neo4j.kernel.impl.api.SchemaLoggingIT | From | To | |
| Rename Variable filteredAndCasted : List<T> to typeDependencies : Iterable<? extends T> in method public resolveDependency(type Class<T>, selector SelectionStrategy) : T in class org.neo4j.kernel.extension.AbstractKernelExtensions | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Collection<KernelExtensionFactory> to Collection<Object[]> in method public parameters() : Collection<Object[]> in class org.neo4j.index.recovery.UniqueIndexRecoveryTest | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute package INDEX_PROVIDER : IndexProviderDescriptor in class org.neo4j.kernel.impl.api.index.IndexPopulationMissConcurrentUpdateIT.ControlledSchemaIndexProvider | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute expectedProvider : GraphDatabaseSettings.SchemaIndex to descriptor : IndexProviderDescriptor in class org.neo4j.kernel.impl.api.SchemaLoggingIT.LogMessageMatcher | From | To | |
| Extract Variable | 5 | ||
| Extract Variable logProvider : NullLogProvider in method public setUp() : void from class org.neo4j.kernel.impl.transaction.state.OnlineIndexUpdatesTest | From | To | |
| Extract Variable logProvider : NullLogProvider in method private get(fs FileSystemAbstraction, pageCache PageCache, indexProvider IndexProvider, databaseHealth DatabaseHealth, databaseLayout DatabaseLayout, transactionApplierTransformer Function<BatchTransactionApplierFacade,BatchTransactionApplierFacade>, monitors Monitors) : RecordStorageEngine from class org.neo4j.test.rule.RecordStorageEngineRule | From | To | |
| Extract Variable resolver : DependencyResolver in method private addIndex(database GraphDatabaseService) : void from class org.neo4j.consistency.HalfCreatedConstraintIT | From | To | |
| Extract Variable configuration : Map<String,String> in method private newBatchInserterWithIndexProvider(provider KernelExtensionFactory<?>, providerDescriptor IndexProviderDescriptor) : BatchInserter from class org.neo4j.unsafe.batchinsert.internal.BatchInsertTest | From | To | |
| Extract Variable descriptor : IndexProviderDescriptor in method package shouldThrowOnLookupOnUnknownProvider() : void from class org.neo4j.kernel.impl.transaction.state.DefaultIndexProviderMapTest | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type expectedProvider : GraphDatabaseSettings.SchemaIndex to providerDescriptor : IndexProviderDescriptor in method public shouldLogUserReadableLabelAndPropertyNames() : void in class org.neo4j.kernel.impl.api.SchemaLoggingIT | From | To | |
| Change Variable Type filteredAndCasted : List<T> to typeDependencies : Iterable<? extends T> in method public resolveDependency(type Class<T>, selector SelectionStrategy) : T in class org.neo4j.kernel.extension.AbstractKernelExtensions | From | To | |
| Extract Method | 5 | ||
| Extract Method private createDefaultProviderMap(dependencies Dependencies, descriptor IndexProviderDescriptor) : DefaultIndexProviderMap extracted from public shouldThrowOnLookupOnUnknownProvider() : void in class org.neo4j.kernel.impl.transaction.state.DefaultIndexProviderMapTest | From | To | |
| Extract Method private getConfigWithProvider() : Map<String,String> extracted from package createBatchIndexFromAnyIndexStoreProvider() : void in class org.neo4j.index.impl.lucene.explicit.LuceneBatchInserterIndexProviderNewImplTest | From | To | |
| Extract Method private getConfig() : Map<String,String> extracted from public shouldStartBatchInserterWithRealIndexProvider() : void in class org.neo4j.unsafe.batchinsert.BatchInsertersIT | From | To | |
| Extract Method public resolveTypeDependencies(type Class<T>) : Iterable<? extends T> extracted from public resolveDependency(type Class<T>, selector SelectionStrategy) : T in class org.neo4j.kernel.extension.AbstractKernelExtensions | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type rule : ImpermanentDatabaseRule to rule : DatabaseRule in class org.neo4j.graphdb.SchemaIndexWaitingAcceptanceTest | From | To | |
| Change Attribute Type expectedProvider : GraphDatabaseSettings.SchemaIndex to descriptor : IndexProviderDescriptor in class org.neo4j.kernel.impl.api.SchemaLoggingIT.LogMessageMatcher | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter expectedProvider : GraphDatabaseSettings.SchemaIndex to descriptor : IndexProviderDescriptor in method package LogMessageMatcher(match LogMatcherBuilder, descriptor IndexProviderDescriptor) in class org.neo4j.kernel.impl.api.SchemaLoggingIT.LogMessageMatcher | From | To | |
| Rename Parameter reltionshipId : long to relationshipId : long in method private gatherUpdatesFor(relationshipId long, relationshipCommand RelationshipCommand, propertyCommands List<PropertyCommand>) : void in class org.neo4j.kernel.impl.transaction.state.OnlineIndexUpdates | From | To |