73a8d486bbedec5ce9d9c82eb14a1643a0f12708
Files Diff
- Added: 6
- Removed: 0
- Renamed: 0
- Modified: 33
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public allocate(type int, direction Direction, relId long, incrementCount boolean) : long renamed to private visitGroup(nodeId long, relGroupIndex long, visitor GroupVisitor) : long in class org.neo4j.unsafe.impl.batchimport.cache.NodeRelationshipCache.RelGroupCache | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method private getOrCreateId(key Object) : int from class org.neo4j.unsafe.impl.batchimport.store.BatchingTokenRepository.BatchingPropertyKeyTokenRepository to public getOrCreateId(key Object) : int from class org.neo4j.unsafe.impl.batchimport.store.BatchingTokenRepository | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type relationships : InputIterable<InputRelationship> to relationships : InputIterator<InputRelationship> in method public RelationshipStage(topic String, config Configuration, writeMonitor IoMonitor, relationships InputIterator<InputRelationship>, idMapper IdMapper, neoStore BatchingNeoStores, cache NodeRelationshipCache, specificIds boolean, storeUpdateMonitor EntityStoreUpdaterStep.Monitor, firstRelationshipId long) in class org.neo4j.unsafe.impl.batchimport.RelationshipStage | From | To | |
| Rename Variable | 1 | ||
| Rename Variable previousId : long to loop : long in method private visitGroup(nodeId long, relGroupIndex long, visitor GroupVisitor) : long in class org.neo4j.unsafe.impl.batchimport.cache.NodeRelationshipCache.RelGroupCache | From | To | |
| Inline Method | 1 | ||
| Inline Method private putRelField(array ByteArray, relGroupIndex long, direction Direction, relId long, increment boolean) : long inlined to private visitGroup(nodeId long, relGroupIndex long, visitor GroupVisitor) : long in class org.neo4j.unsafe.impl.batchimport.cache.NodeRelationshipCache.RelGroupCache | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute private CHUNK_SIZE : int in class org.neo4j.unsafe.impl.batchimport.cache.NodeRelationshipCache | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute type : int to relationshipType : int in method public visit(nodeId long, next long, out long, in long, loop long) : long in class org.neo4j.unsafe.impl.batchimport.NodeFirstRelationshipProcessor | From | To | |
| Extract Variable | 6 | ||
| Extract Variable changed : boolean in method public process(record RelationshipRecord) : boolean from class org.neo4j.unsafe.impl.batchimport.RelationshipLinkbackProcessor | From | To | |
| Extract Variable index : long in method private visitGroup(nodeId long, relGroupIndex long, visitor GroupVisitor) : long from class org.neo4j.unsafe.impl.batchimport.cache.NodeRelationshipCache.RelGroupCache | From | To | |
| Extract Variable type : String in method protected fetchNextOrNull() : InputRelationship from class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporterTest.relationships.iterator | From | To | |
| Extract Variable type : String in method public iterator() : InputIterator<InputRelationship> from class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporterTest.relationships | From | To | |
| Extract Variable dense : boolean in method public getAndPutRelationship(nodeId long, direction Direction, firstRelId long, incrementCount boolean) : long from class org.neo4j.unsafe.impl.batchimport.cache.NodeRelationshipCache | From | To | |
| Extract Variable type : String in method private relationships(randomSeed long, count long, idGenerator InputIdGenerator, groups IdGroupDistribution) : InputIterable<InputRelationship> from class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporterTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type random : Random to random : RandomRule in class org.neo4j.unsafe.impl.batchimport.cache.NodeRelationshipCacheTest | From | To | |
| Extract Method | 1 | ||
| Extract Method private incrementCount(array ByteArray, index long, offset int) : int extracted from public incrementCount(nodeId long) : int in class org.neo4j.unsafe.impl.batchimport.cache.NodeRelationshipCache | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter labels : String[] to names : String[] in method public getOrCreateIds(names String[]) : long[] in class org.neo4j.unsafe.impl.batchimport.store.BatchingTokenRepository | From | To | |
| Rename Parameter nodeId : long to index : long in method private incrementCount(array ByteArray, index long, offset int) : int in class org.neo4j.unsafe.impl.batchimport.cache.NodeRelationshipCache | From | To |