neo4j 771060df56a018be8790c9b1e8549e4792bee3b4

771060df56a018be8790c9b1e8549e4792bee3b4

Files Diff

Added: 15
Removed: 0
Renamed: 0
Modified: 37

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method public missingInitialMembers() : void renamed to public missingInitialMembersDNS() : void in class org.neo4j.causalclustering.core.CausalClusterConfigurationValidatorTest	From	To
Change Parameter Type	9
Change Parameter Type initialMembers : List<AdvertisedSocketAddress> to initialMembers : Collection<String> in method private logConnectionInfo(initialMembers Collection<String>) : void in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService	From	To
Change Parameter Type hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public coreTopologyService(config Config, myself MemberId, jobScheduler JobScheduler, logProvider LogProvider, userLogProvider LogProvider, remoteMembersResolver RemoteMembersResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy, monitors Monitors) : CoreTopologyService in class org.neo4j.causalclustering.discovery.HazelcastDiscoveryServiceFactory	From	To
Change Parameter Type hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public readReplicaTopologyService(config Config, logProvider LogProvider, jobScheduler JobScheduler, myself MemberId, remoteMembersResolver RemoteMembersResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy) : TopologyService in class org.neo4j.causalclustering.discovery.DiscoveryServiceFactory	From	To
Change Parameter Type hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public coreTopologyService(config Config, myself MemberId, jobScheduler JobScheduler, logProvider LogProvider, userLogProvider LogProvider, remoteMembersResolver RemoteMembersResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy, monitors Monitors) : CoreTopologyService in class org.neo4j.causalclustering.discovery.SharedDiscoveryServiceFactory	From	To
Change Parameter Type hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public coreTopologyService(config Config, myself MemberId, jobScheduler JobScheduler, logProvider LogProvider, userLogProvider LogProvider, remoteMembersResolver RemoteMembersResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy, monitors Monitors) : CoreTopologyService in class org.neo4j.causalclustering.discovery.DiscoveryServiceFactory	From	To
Change Parameter Type hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public HazelcastClientConnector(config Config, logProvider LogProvider, remoteMembersResolver RemoteMembersResolver) in class org.neo4j.causalclustering.discovery.HazelcastClientConnector	From	To
Change Parameter Type hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public readReplicaTopologyService(config Config, logProvider LogProvider, jobScheduler JobScheduler, myself MemberId, remoteMembersResolver RemoteMembersResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy) : TopologyService in class org.neo4j.causalclustering.discovery.SharedDiscoveryServiceFactory	From	To
Change Parameter Type hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public HazelcastCoreTopologyService(config Config, myself MemberId, jobScheduler JobScheduler, logProvider LogProvider, userLogProvider LogProvider, remoteMembersResolver RemoteMembersResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy, monitors Monitors) in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService	From	To
Change Parameter Type hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public readReplicaTopologyService(config Config, logProvider LogProvider, jobScheduler JobScheduler, myself MemberId, remoteMembersResolver RemoteMembersResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy) : TopologyService in class org.neo4j.causalclustering.discovery.HazelcastDiscoveryServiceFactory	From	To
Move Method	2
Move Method private testRetryStrategy(numRetries int) : MultiRetryStrategy<AdvertisedSocketAddress,Collection<AdvertisedSocketAddress>> from class org.neo4j.causalclustering.discovery.SrvHostnameResolverTest to public testRetryStrategy(numRetries int) : MultiRetryStrategy<AdvertisedSocketAddress,Collection<AdvertisedSocketAddress>> from class org.neo4j.causalclustering.discovery.MultiRetryStrategyTest	From	To
Move Method private testRetryStrategy(numRetries int) : MultiRetryStrategy<AdvertisedSocketAddress,Collection<AdvertisedSocketAddress>> from class org.neo4j.causalclustering.discovery.DnsHostnameResolverTest to public testRetryStrategy(numRetries int) : MultiRetryStrategy<AdvertisedSocketAddress,Collection<AdvertisedSocketAddress>> from class org.neo4j.causalclustering.discovery.MultiRetryStrategyTest	From	To
Rename Variable	3
Rename Variable hostnameResolver : HostnameResolver to initialDiscoveryMemberResolver : InitialDiscoveryMembersResolver in method public shouldBeAbleToStartAndStopWithoutSuccessfulJoin() : void in class org.neo4j.causalclustering.scenarios.BaseCoreTopologyServiceIT	From	To
Rename Variable hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public ClusteringModule(discoveryServiceFactory DiscoveryServiceFactory, myself MemberId, platformModule PlatformModule, clusterStateDirectory File, databaseLayout DatabaseLayout) in class org.neo4j.causalclustering.core.state.ClusteringModule	From	To
Rename Variable hostnameResolver : HostnameResolver to remoteMemberResolver : InitialDiscoveryMembersResolver in method private createDiscoveryJob(member MemberId, discoveryServiceFactory DiscoveryServiceFactory, expectedTargetSet Set<MemberId>) : Callable<Void> in class org.neo4j.causalclustering.scenarios.SharedDiscoveryServiceIT	From	To
Change Return Type	1
Change Return Type HostnameResolver to RemoteMembersResolver in method public chooseResolver(config Config, logService LogService) : RemoteMembersResolver in class org.neo4j.causalclustering.discovery.ResolutionResolverFactory	From	To
Move Attribute	4
Move Attribute private hostnameResolver : HostnameResolver from class org.neo4j.causalclustering.discovery.HazelcastClientConnector to private hostnameResolver : HostnameResolver from class org.neo4j.causalclustering.discovery.InitialDiscoveryMembersResolver	From	To
Move Attribute private hostnameResolver : HostnameResolver from class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService to private hostnameResolver : HostnameResolver from class org.neo4j.causalclustering.discovery.InitialDiscoveryMembersResolver	From	To
Move Attribute private hostnameResolver : HostnameResolver from class org.neo4j.causalclustering.discovery.HazelcastClientConnector to private hostnameResolver : HostnameResolver from class org.neo4j.causalclustering.discovery.InitialDiscoveryMembersResolverTest	From	To
Move Attribute private hostnameResolver : HostnameResolver from class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService to private hostnameResolver : HostnameResolver from class org.neo4j.causalclustering.discovery.InitialDiscoveryMembersResolverTest	From	To
Merge Parameter	1
Merge Parameter [logProvider : LogProvider, userLogProvider : LogProvider] to logService : LogService in method public chooseResolver(config Config, logService LogService) : RemoteMembersResolver in class org.neo4j.causalclustering.discovery.ResolutionResolverFactory	From	To
Rename Attribute	2
Rename Attribute hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService	From	To
Rename Attribute hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in class org.neo4j.causalclustering.discovery.HazelcastClientConnector	From	To
Extract Variable	1
Extract Variable config : Config in method private createDiscoveryJob(member MemberId, discoveryServiceFactory DiscoveryServiceFactory, expectedTargetSet Set<MemberId>) : Callable<Void> from class org.neo4j.causalclustering.scenarios.SharedDiscoveryServiceIT	From	To
Change Variable Type	5
Change Variable Type discoveryType : CausalClusteringSettings.DiscoveryType to discoveryType : DiscoveryType in method public chooseResolver(config Config, logService LogService) : RemoteMembersResolver in class org.neo4j.causalclustering.discovery.ResolutionResolverFactory	From	To
Change Variable Type hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public ClusteringModule(discoveryServiceFactory DiscoveryServiceFactory, myself MemberId, platformModule PlatformModule, clusterStateDirectory File, databaseLayout DatabaseLayout) in class org.neo4j.causalclustering.core.state.ClusteringModule	From	To
Change Variable Type hostnameResolver : HostnameResolver to hostnameResolver : RemoteMembersResolver in method public EnterpriseReadReplicaEditionModule(platformModule PlatformModule, discoveryServiceFactory DiscoveryServiceFactory, myself MemberId) in class org.neo4j.causalclustering.readreplica.EnterpriseReadReplicaEditionModule	From	To
Change Variable Type hostnameResolver : HostnameResolver to initialDiscoveryMemberResolver : InitialDiscoveryMembersResolver in method public shouldBeAbleToStartAndStopWithoutSuccessfulJoin() : void in class org.neo4j.causalclustering.scenarios.BaseCoreTopologyServiceIT	From	To
Change Variable Type hostnameResolver : HostnameResolver to remoteMemberResolver : InitialDiscoveryMembersResolver in method private createDiscoveryJob(member MemberId, discoveryServiceFactory DiscoveryServiceFactory, expectedTargetSet Set<MemberId>) : Callable<Void> in class org.neo4j.causalclustering.scenarios.SharedDiscoveryServiceIT	From	To
Change Attribute Type	2
Change Attribute Type hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in class org.neo4j.causalclustering.discovery.HazelcastClientConnector	From	To
Change Attribute Type hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService	From	To
Rename Parameter	8
Rename Parameter hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public coreTopologyService(config Config, myself MemberId, jobScheduler JobScheduler, logProvider LogProvider, userLogProvider LogProvider, remoteMembersResolver RemoteMembersResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy, monitors Monitors) : CoreTopologyService in class org.neo4j.causalclustering.discovery.DiscoveryServiceFactory	From	To
Rename Parameter hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public HazelcastClientConnector(config Config, logProvider LogProvider, remoteMembersResolver RemoteMembersResolver) in class org.neo4j.causalclustering.discovery.HazelcastClientConnector	From	To
Rename Parameter hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public readReplicaTopologyService(config Config, logProvider LogProvider, jobScheduler JobScheduler, myself MemberId, remoteMembersResolver RemoteMembersResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy) : TopologyService in class org.neo4j.causalclustering.discovery.SharedDiscoveryServiceFactory	From	To
Rename Parameter hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public HazelcastCoreTopologyService(config Config, myself MemberId, jobScheduler JobScheduler, logProvider LogProvider, userLogProvider LogProvider, remoteMembersResolver RemoteMembersResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy, monitors Monitors) in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService	From	To
Rename Parameter hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public readReplicaTopologyService(config Config, logProvider LogProvider, jobScheduler JobScheduler, myself MemberId, remoteMembersResolver RemoteMembersResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy) : TopologyService in class org.neo4j.causalclustering.discovery.HazelcastDiscoveryServiceFactory	From	To
Rename Parameter hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public readReplicaTopologyService(config Config, logProvider LogProvider, jobScheduler JobScheduler, myself MemberId, remoteMembersResolver RemoteMembersResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy) : TopologyService in class org.neo4j.causalclustering.discovery.DiscoveryServiceFactory	From	To
Rename Parameter hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public coreTopologyService(config Config, myself MemberId, jobScheduler JobScheduler, logProvider LogProvider, userLogProvider LogProvider, remoteMembersResolver RemoteMembersResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy, monitors Monitors) : CoreTopologyService in class org.neo4j.causalclustering.discovery.SharedDiscoveryServiceFactory	From	To
Rename Parameter hostnameResolver : HostnameResolver to remoteMembersResolver : RemoteMembersResolver in method public coreTopologyService(config Config, myself MemberId, jobScheduler JobScheduler, logProvider LogProvider, userLogProvider LogProvider, remoteMembersResolver RemoteMembersResolver, topologyServiceRetryStrategy TopologyServiceRetryStrategy, monitors Monitors) : CoreTopologyService in class org.neo4j.causalclustering.discovery.HazelcastDiscoveryServiceFactory	From	To

771060df56a018be8790c9b1e8549e4792bee3b4

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: