7a2e62fa86a4e06da6b7ed7ad45e94fd9ce73d76
Files Diff
- Added: 5
- Removed: 3
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private listFiles(from AdvertisedSocketAddress, expectedStoreId StoreId, storeFileStreams StoreFileStreams) : PrepareStoreCopyResponse renamed to private prepareStoreCopy(from AdvertisedSocketAddress, expectedStoreId StoreId, storeFileStream StoreFileStreamProvider) : PrepareStoreCopyResponse in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClient | From | To | |
| Rename Method public getFilesystem() : Map<String,StringBuffer> renamed to public fileStreams() : Map<String,StringBuffer> in class org.neo4j.causalclustering.catchup.storecopy.InMemoryStoreStreamProvider | From | To | |
| Change Parameter Type | 5 | ||
| Change Parameter Type storeFileStreams : InMemoryFileSystemStream to storeStreamProvider : InMemoryStoreStreamProvider in method private clientFileContents(storeStreamProvider InMemoryStoreStreamProvider, filename String) : String in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClientIT | From | To | |
| Change Parameter Type storeFileStreams : StoreFileStreams to storeFileStream : StoreFileStreamProvider in method private copyFilesIndividually(prepareStoreCopyResponse PrepareStoreCopyResponse, expectedStoreId StoreId, addressProvider CatchupAddressProvider, storeFileStream StoreFileStreamProvider, terminationConditions Supplier<TerminationCondition>) : void in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClient | From | To | |
| Change Parameter Type storeFileStreams : StoreFileStreams to storeFileStream : StoreFileStreamProvider in method private prepareStoreCopy(from AdvertisedSocketAddress, expectedStoreId StoreId, storeFileStream StoreFileStreamProvider) : PrepareStoreCopyResponse in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClient | From | To | |
| Change Parameter Type storeFileStreams : StoreFileStreams to storeFileStream : StoreFileStreamProvider in method private copyIndexSnapshotIndividually(prepareStoreCopyResponse PrepareStoreCopyResponse, expectedStoreId StoreId, addressProvider CatchupAddressProvider, storeFileStream StoreFileStreamProvider, terminationConditions Supplier<TerminationCondition>) : void in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClient | From | To | |
| Change Parameter Type storeFileStreams : StoreFileStreams to storeFileStreamProvider : StoreFileStreamProvider in method package copyStoreFiles(catchupAddressProvider CatchupAddressProvider, expectedStoreId StoreId, storeFileStreamProvider StoreFileStreamProvider, requestWiseTerminationCondition Supplier<TerminationCondition>) : long in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClient | From | To | |
| Rename Variable | 1 | ||
| Rename Variable tempBuffer : ByteBuffer to writerProvider : StreamToDiskProvider in method public shouldLetPageCacheHandleRecordStoresAndNativeLabelScanStoreFiles() : void in class org.neo4j.causalclustering.catchup.storecopy.StreamToDiskTest | From | To | |
| Change Return Type | 1 | ||
| Change Return Type StoreFileStreams to StoreFileStream in method public getStoreFileStreams() : StoreFileStream in class org.neo4j.causalclustering.catchup.storecopy.StoreFileReceiver | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private storeDir : File from class org.neo4j.causalclustering.catchup.storecopy.StreamToDisk to private storeDir : File from class org.neo4j.causalclustering.catchup.storecopy.StreamToDiskProvider | From | To | |
| Move Attribute private fileCopyMonitor : FileCopyMonitor from class org.neo4j.causalclustering.catchup.storecopy.StreamToDisk to private fileCopyMonitor : FileCopyMonitor from class org.neo4j.causalclustering.catchup.storecopy.StreamToDiskProvider | From | To | |
| Move Attribute private fs : FileSystemAbstraction from class org.neo4j.causalclustering.catchup.storecopy.StreamToDisk to private fs : FileSystemAbstraction from class org.neo4j.causalclustering.catchup.storecopy.StreamToDiskProvider | From | To | |
| Move Attribute private pageCache : PageCache from class org.neo4j.causalclustering.catchup.storecopy.StreamToDisk to private pageCache : PageCache from class org.neo4j.causalclustering.catchup.storecopy.StreamToDiskProvider | From | To | |
| Extract Class | 1 | ||
| Extract Class org.neo4j.causalclustering.catchup.storecopy.StreamToDiskProvider from class org.neo4j.causalclustering.catchup.storecopy.StreamToDisk | From | To | |
| Rename Class | 2 | ||
| Rename Class org.neo4j.causalclustering.catchup.storecopy.InMemoryFileSystemStream renamed to org.neo4j.causalclustering.catchup.storecopy.InMemoryStoreStreamProvider | From | To | |
| Rename Class org.neo4j.causalclustering.catchup.storecopy.StoreFileStreams renamed to org.neo4j.causalclustering.catchup.storecopy.StoreFileStream | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute expectedStoreFileStreams : StoreFileStreams to expectedStoreFileStream : StoreFileStreamProvider in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClientTest | From | To | |
| Rename Attribute streamToDisk : StreamToDisk to streamToDiskProvider : StreamToDiskProvider in class org.neo4j.causalclustering.catchup.storecopy.SimpleCatchupClient | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type storeFileStream : InMemoryFileSystemStream to storeFileStream : InMemoryStoreStreamProvider in method public canPerformCatchup() : void in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClientIT | From | To | |
| Change Variable Type tempBuffer : ByteBuffer to writerProvider : StreamToDiskProvider in method public shouldLetPageCacheHandleRecordStoresAndNativeLabelScanStoreFiles() : void in class org.neo4j.causalclustering.catchup.storecopy.StreamToDiskTest | From | To | |
| Change Variable Type clientStoreFileStream : InMemoryFileSystemStream to clientStoreFileStream : InMemoryStoreStreamProvider in method public failedFileCopyShouldRetry() : void in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClientIT | From | To | |
| Change Variable Type storeFileStream : InMemoryFileSystemStream to storeFileStream : InMemoryStoreStreamProvider in method public reconnectingWorks() : void in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClientIT | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type expectedStoreFileStreams : StoreFileStreams to expectedStoreFileStream : StoreFileStreamProvider in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClientTest | From | To | |
| Change Attribute Type streamToDisk : StreamToDisk to streamToDiskProvider : StreamToDiskProvider in class org.neo4j.causalclustering.catchup.storecopy.SimpleCatchupClient | From | To | |
| Rename Parameter | 5 | ||
| Rename Parameter storeFileStreams : StoreFileStreams to storeFileStream : StoreFileStreamProvider in method private copyFilesIndividually(prepareStoreCopyResponse PrepareStoreCopyResponse, expectedStoreId StoreId, addressProvider CatchupAddressProvider, storeFileStream StoreFileStreamProvider, terminationConditions Supplier<TerminationCondition>) : void in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClient | From | To | |
| Rename Parameter storeFileStreams : StoreFileStreams to storeFileStream : StoreFileStreamProvider in method private prepareStoreCopy(from AdvertisedSocketAddress, expectedStoreId StoreId, storeFileStream StoreFileStreamProvider) : PrepareStoreCopyResponse in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClient | From | To | |
| Rename Parameter storeFileStreams : StoreFileStreams to storeFileStream : StoreFileStreamProvider in method private copyIndexSnapshotIndividually(prepareStoreCopyResponse PrepareStoreCopyResponse, expectedStoreId StoreId, addressProvider CatchupAddressProvider, storeFileStream StoreFileStreamProvider, terminationConditions Supplier<TerminationCondition>) : void in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClient | From | To | |
| Rename Parameter storeFileStreams : StoreFileStreams to storeFileStreamProvider : StoreFileStreamProvider in method package copyStoreFiles(catchupAddressProvider CatchupAddressProvider, expectedStoreId StoreId, storeFileStreamProvider StoreFileStreamProvider, requestWiseTerminationCondition Supplier<TerminationCondition>) : long in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClient | From | To | |
| Rename Parameter storeFileStreams : InMemoryFileSystemStream to storeStreamProvider : InMemoryStoreStreamProvider in method private clientFileContents(storeStreamProvider InMemoryStoreStreamProvider, filename String) : String in class org.neo4j.causalclustering.catchup.storecopy.StoreCopyClientIT | From | To |