7acf3b3a8cb421ab6d9d7da57060d13cdb370f8f
Files Diff
- Added: 9
- Removed: 4
- Renamed: 0
- Modified: 39
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type store : RecordStore<RelationshipGroupRecord> to idGenerator : IdSequence in method public RelationshipGroupGetter(idGenerator IdSequence) in class org.neo4j.kernel.impl.transaction.state.RelationshipGroupGetter | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute private dataSize : int from class org.neo4j.unsafe.impl.batchimport.RelativeIdRecordAllocator to private dataSize : int from class org.neo4j.kernel.impl.store.StandardDynamicRecordAllocator | From | To | |
| Move Attribute | 5 | ||
| Move Attribute private relationshipDeleter : RelationshipDeleter from class org.neo4j.kernel.impl.storageengine.impl.recordstorage.RecordStorageEngine to private relationshipDeleter : RelationshipDeleter from class org.neo4j.kernel.impl.storageengine.impl.recordstorage.RecordStorageCommandCreationContext | From | To | |
| Move Attribute private propertyCreator : PropertyCreator from class org.neo4j.kernel.impl.storageengine.impl.recordstorage.RecordStorageEngine to private propertyCreator : PropertyCreator from class org.neo4j.kernel.impl.storageengine.impl.recordstorage.RecordStorageCommandCreationContext | From | To | |
| Move Attribute private relationshipCreator : RelationshipCreator from class org.neo4j.kernel.impl.storageengine.impl.recordstorage.RecordStorageEngine to private relationshipCreator : RelationshipCreator from class org.neo4j.kernel.impl.storageengine.impl.recordstorage.RecordStorageCommandCreationContext | From | To | |
| Move Attribute private loaders : Loaders from class org.neo4j.kernel.impl.storageengine.impl.recordstorage.RecordStorageEngine to private loaders : Loaders from class org.neo4j.kernel.impl.storageengine.impl.recordstorage.RecordStorageCommandCreationContext | From | To | |
| Move Attribute private propertyDeleter : PropertyDeleter from class org.neo4j.kernel.impl.storageengine.impl.recordstorage.RecordStorageEngine to private propertyDeleter : PropertyDeleter from class org.neo4j.kernel.impl.storageengine.impl.recordstorage.RecordStorageCommandCreationContext | From | To | |
| Extract Class | 1 | ||
| Extract Class org.neo4j.kernel.impl.storageengine.impl.recordstorage.RecordStorageCommandCreationContext from class org.neo4j.kernel.impl.storageengine.impl.recordstorage.RecordStorageEngine | From | To | |
| Move Class | 2 | ||
| Move Class org.neo4j.kernel.impl.api.store.StoreStatementTest moved to org.neo4j.kernel.impl.storageengine.impl.recordstorage.StoreStatementTest | From | To | |
| Move Class org.neo4j.kernel.impl.api.store.StoreStatement moved to org.neo4j.kernel.impl.storageengine.impl.recordstorage.StoreStatement | From | To | |
| Extract Method | 5 | ||
| Extract Method private currentRangeOffset() : int extracted from private nextRangeCandidate() : long in class org.neo4j.kernel.impl.store.id.IdRangeIterator | From | To | |
| Extract Method private idSequence() : BatchingIdSequence extracted from public peek() : long in class org.neo4j.unsafe.impl.batchimport.RelativeIdRecordAllocator | From | To | |
| Extract Method private askForNextRangeFromMaster() : void extracted from public nextId() : long in class org.neo4j.kernel.ha.id.HaIdGeneratorFactory.SlaveIdGenerator | From | To | |
| Extract Method public allocateRecord(id long) : DynamicRecord extracted from public nextRecord() : DynamicRecord in class org.neo4j.kernel.impl.store.StandardDynamicRecordAllocator | From | To | |
| Extract Method private acquireNextIdBatch() : void extracted from public nextId() : long in class org.neo4j.causalclustering.core.state.machines.id.ReplicatedIdGenerator | From | To | |
| Rename Method | 1 | ||
| Rename Method public next() : long renamed to public nextId() : long in class org.neo4j.kernel.impl.store.id.IdRangeIterator | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method public getRecordDataSize() : int from class org.neo4j.unsafe.impl.batchimport.RelativeIdRecordAllocator to public getRecordDataSize() : int from class org.neo4j.kernel.impl.store.StandardDynamicRecordAllocator | From | To | |
| Pull Up Method public nextRecord() : DynamicRecord from class org.neo4j.unsafe.impl.batchimport.RelativeIdRecordAllocator to public nextRecord() : DynamicRecord from class org.neo4j.kernel.impl.store.StandardDynamicRecordAllocator | From | To | |
| Change Return Type | 2 | ||
| Change Return Type long to void in method private storeLocally(allocation IdAllocation) : void in class org.neo4j.kernel.ha.id.HaIdGeneratorFactory.SlaveIdGenerator | From | To | |
| Change Return Type long to void in method private storeLocally(allocation IdAllocation) : void in class org.neo4j.causalclustering.core.state.machines.id.ReplicatedIdGenerator | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.neo4j.kernel.impl.store.StandardDynamicRecordAllocator from classes [org.neo4j.unsafe.impl.batchimport.RelativeIdRecordAllocator] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute store : RecordStore<RelationshipGroupRecord> to idGenerator : IdSequence in class org.neo4j.kernel.impl.transaction.state.RelationshipGroupGetter | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type store : RecordStore<RelationshipGroupRecord> to idGenerator : IdSequence in class org.neo4j.kernel.impl.transaction.state.RelationshipGroupGetter | From | To | |
| Extract And Move Method | 7 | ||
| Extract And Move Method public iterator() : IdRangeIterator extracted from public shouldNotHaveAnyGaps() : void in class org.neo4j.kernel.impl.store.id.IdRangeIteratorTest & moved to class org.neo4j.kernel.impl.store.id.IdRange | From | To | |
| Extract And Move Method public iterator() : IdRangeIterator extracted from private storeLocally(allocation IdAllocation) : long in class org.neo4j.kernel.ha.id.HaIdGeneratorFactory.SlaveIdGenerator & moved to class org.neo4j.kernel.impl.store.id.IdRange | From | To | |
| Extract And Move Method public iterator() : IdRangeIterator extracted from private idRange(size int, idSource IdSequence) : IdRangeIterator in class org.neo4j.unsafe.impl.batchimport.PropertyEncoderStep & moved to class org.neo4j.kernel.impl.store.id.IdRange | From | To | |
| Extract And Move Method public iterator() : IdRangeIterator extracted from public shouldReturnValueRepresentingNullIfWeExhaustIdRange() : void in class org.neo4j.kernel.impl.store.id.IdRangeIteratorTest & moved to class org.neo4j.kernel.impl.store.id.IdRange | From | To | |
| Extract And Move Method public iterator() : IdRangeIterator extracted from public shouldNotUseForbiddenMinusOneIdFromIdBatches() : void in class org.neo4j.kernel.ha.id.HaIdGeneratorFactoryTest & moved to class org.neo4j.kernel.impl.store.id.IdRange | From | To | |
| Extract And Move Method public iterator() : IdRangeIterator extracted from private storeLocally(allocation IdAllocation) : long in class org.neo4j.causalclustering.core.state.machines.id.ReplicatedIdGenerator & moved to class org.neo4j.kernel.impl.store.id.IdRange | From | To | |
| Extract And Move Method public iterator() : IdRangeIterator extracted from public shouldUseDefragIdsFirst() : void in class org.neo4j.kernel.impl.store.id.IdRangeIteratorTest & moved to class org.neo4j.kernel.impl.store.id.IdRange | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter store : RecordStore<RelationshipGroupRecord> to idGenerator : IdSequence in method public RelationshipGroupGetter(idGenerator IdSequence) in class org.neo4j.kernel.impl.transaction.state.RelationshipGroupGetter | From | To |