7d3cc5833b6ed0a4ccf01c20489e9650b53ad988
Files Diff
- Added: 4
- Removed: 1
- Renamed: 0
- Modified: 94
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 11 | ||
| Rename Method protected channelRead0(ctx ChannelHandlerContext, msg FileHeader) : void renamed to protected doChannelRead0(ctx ChannelHandlerContext, msg FileHeader) : void in class org.neo4j.coreedge.catchup.storecopy.FileHeaderHandler | From | To | |
| Rename Method protected channelRead0(ctx ChannelHandlerContext, fileContent FileContent) : void renamed to protected doChannelRead0(ctx ChannelHandlerContext, fileContent FileContent) : void in class org.neo4j.coreedge.catchup.storecopy.FileContentHandler | From | To | |
| Rename Method protected channelRead0(ctx ChannelHandlerContext, msg CoreSnapshotRequest) : void renamed to protected doChannelRead0(ctx ChannelHandlerContext, msg CoreSnapshotRequest) : void in class org.neo4j.coreedge.core.state.snapshot.CoreSnapshotRequestHandler | From | To | |
| Rename Method protected channelRead0(ctx ChannelHandlerContext, msg GetStoreRequest) : void renamed to protected doChannelRead0(ctx ChannelHandlerContext, msg GetStoreRequest) : void in class org.neo4j.coreedge.catchup.storecopy.GetStoreRequestHandler | From | To | |
| Rename Method protected channelRead0(ctx ChannelHandlerContext, msg TxPullRequest) : void renamed to protected doChannelRead0(ctx ChannelHandlerContext, msg TxPullRequest) : void in class org.neo4j.coreedge.catchup.tx.TxPullRequestHandler | From | To | |
| Rename Method protected channelRead0(ctx ChannelHandlerContext, msg StoreCopyFinishedResponse) : void renamed to protected doChannelRead0(ctx ChannelHandlerContext, msg StoreCopyFinishedResponse) : void in class org.neo4j.coreedge.catchup.storecopy.StoreCopyFinishedResponseHandler | From | To | |
| Rename Method protected channelRead0(ctx ChannelHandlerContext, msg TxStreamFinishedResponse) : void renamed to protected doChannelRead0(ctx ChannelHandlerContext, msg TxStreamFinishedResponse) : void in class org.neo4j.coreedge.catchup.tx.TxStreamFinishedResponseHandler | From | To | |
| Rename Method protected channelRead0(ctx ChannelHandlerContext, msg GetStoreIdRequest) : void renamed to protected doChannelRead0(ctx ChannelHandlerContext, message GetStoreIdRequest) : void in class org.neo4j.coreedge.catchup.storecopy.GetStoreIdRequestHandler | From | To | |
| Rename Method protected channelRead0(ctx ChannelHandlerContext, msg TxPullResponse) : void renamed to protected doChannelRead0(ctx ChannelHandlerContext, msg TxPullResponse) : void in class org.neo4j.coreedge.catchup.tx.TxPullResponseHandler | From | To | |
| Rename Method protected channelRead0(ctx ChannelHandlerContext, msg GetStoreIdResponse) : void renamed to protected doChannelRead0(ctx ChannelHandlerContext, msg GetStoreIdResponse) : void in class org.neo4j.coreedge.catchup.storecopy.GetStoreIdResponseHandler | From | To | |
| Rename Method protected channelRead0(ctx ChannelHandlerContext, coreSnapshot CoreSnapshot) : void renamed to protected doChannelRead0(ctx ChannelHandlerContext, coreSnapshot CoreSnapshot) : void in class org.neo4j.coreedge.core.state.snapshot.CoreSnapshotResponseHandler | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method protected channelRead0(channelHandlerContext ChannelHandlerContext, storeIdAwareMessage RaftMessages.StoreIdAwareMessage) : void from class org.neo4j.coreedge.core.consensus.RaftServer.RaftMessageHandler to protected doChannelRead0(channelHandlerContext ChannelHandlerContext, storeIdAwareMessage RaftMessages.StoreIdAwareMessage) : void from class org.neo4j.coreedge.core.consensus.RaftMessageHandler | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type factory : Factory<? extends Message> to factory : Function<Byte,? extends Message> in method package SimpleRequestDecoder(factory Function<Byte,? extends Message>) in class org.neo4j.coreedge.catchup.SimpleRequestDecoder | From | To | |
| Inline Method | 1 | ||
| Inline Method private startNettyServer() : void inlined to public start() : void in class org.neo4j.coreedge.core.consensus.RaftServer | From | To | |
| Change Return Type | 1 | ||
| Change Return Type FollowerStates to FollowerStates<MemberId> in method private initialFollowerStates() : FollowerStates<MemberId> in class org.neo4j.coreedge.core.consensus.state.RaftStateTest | From | To | |
| Extract Superclass | 2 | ||
| Extract Superclass org.neo4j.coreedge.messaging.BaseMessage from classes [org.neo4j.coreedge.catchup.storecopy.FileContent, org.neo4j.coreedge.catchup.storecopy.FileHeader, org.neo4j.coreedge.catchup.storecopy.GetStoreIdRequest, org.neo4j.coreedge.catchup.storecopy.GetStoreIdResponse, org.neo4j.coreedge.catchup.storecopy.GetStoreRequest, org.neo4j.coreedge.catchup.storecopy.StoreCopyFinishedResponse, org.neo4j.coreedge.catchup.tx.TxPullRequest, org.neo4j.coreedge.catchup.tx.TxPullResponse, org.neo4j.coreedge.catchup.tx.TxStreamFinishedResponse, org.neo4j.coreedge.core.consensus.RaftMessages.BaseRaftMessage, org.neo4j.coreedge.core.state.snapshot.CoreSnapshot, org.neo4j.coreedge.core.state.snapshot.CoreSnapshotRequest] | From | To | |
| Extract Superclass org.neo4j.coreedge.VersionCheckerChannelInboundHandler from classes [org.neo4j.coreedge.core.consensus.RaftMessageHandler, org.neo4j.coreedge.catchup.storecopy.FileContentHandler, org.neo4j.coreedge.catchup.storecopy.FileHeaderHandler, org.neo4j.coreedge.catchup.storecopy.GetStoreIdRequestHandler, org.neo4j.coreedge.catchup.storecopy.GetStoreIdResponseHandler, org.neo4j.coreedge.catchup.storecopy.GetStoreRequestHandler, org.neo4j.coreedge.catchup.storecopy.StoreCopyFinishedResponseHandler, org.neo4j.coreedge.catchup.tx.TxPullRequestHandler, org.neo4j.coreedge.catchup.tx.TxPullResponseHandler, org.neo4j.coreedge.catchup.tx.TxStreamFinishedResponseHandler, org.neo4j.coreedge.core.state.snapshot.CoreSnapshotRequestHandler, org.neo4j.coreedge.core.state.snapshot.CoreSnapshotResponseHandler] | From | To | |
| Extract Variable | 3 | ||
| Extract Variable channel : NetworkReadableClosableChannelNetty4 in method protected decode(ctx ChannelHandlerContext, msg ByteBuf, out List<Object>) : void from class org.neo4j.coreedge.catchup.storecopy.GetStoreIdResponseDecoder | From | To | |
| Extract Variable lastCommittedTxBeforeStoreCopy : long in method protected decode(ctx ChannelHandlerContext, msg ByteBuf, out List<Object>) : void from class org.neo4j.coreedge.catchup.storecopy.StoreCopyFinishedResponseDecoder | From | To | |
| Extract Variable messageType : byte in method public channelRead(ctx ChannelHandlerContext, msg Object) : void from class org.neo4j.coreedge.catchup.ServerMessageTypeHandler | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type factory : Factory<? extends Message> to factory : Function<Byte,? extends Message> in class org.neo4j.coreedge.catchup.SimpleRequestDecoder | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter msg : GetStoreIdRequest to message : GetStoreIdRequest in method protected doChannelRead0(ctx ChannelHandlerContext, message GetStoreIdRequest) : void in class org.neo4j.coreedge.catchup.storecopy.GetStoreIdRequestHandler | From | To |