7fcb74693465f86567b812d7b8fe97cef96c8edd
Files Diff
- Added: 41
- Removed: 8
- Renamed: 0
- Modified: 38
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 5 | ||
| Change Parameter Type target : CountsAccessor to target : Updater in method public Initializer(target Updater) in class org.neo4j.kernel.impl.api.CountsAccessor.Initializer | From | To | |
| Change Parameter Type store : SortedKeyValueStore<CountsKey,CopyableDoubleLongRegister> to store : CountsVisitor.Visitable in method private allRecords(store CountsVisitor.Visitable) : Collection<Pair<? extends CountsKey,Long>> in class org.neo4j.kernel.impl.store.counts.CountsRotationTest | From | To | |
| Change Parameter Type store : CountsStore to store : CountsTracker in method private get(store CountsTracker, key CountsKey) : long in class org.neo4j.kernel.impl.store.counts.CountsComputerTest | From | To | |
| Change Parameter Type tracker : CountsTracker to tracker : Tracker in method public verify(tracker Tracker) : void in class org.neo4j.kernel.impl.store.CountsOracle | From | To | |
| Change Parameter Type countsAccessor : CountsAccessor to countsUpdater : CountsAccessor.Updater in method public CountsStoreApplier(countsUpdater CountsAccessor.Updater, nodeStore NodeStore) in class org.neo4j.kernel.impl.api.CountsStoreApplier | From | To | |
| Move Method | 2 | ||
| Move Method private pageCache() : PageCache from class org.neo4j.kernel.impl.store.counts.CountsTrackerTest to public pageCache() : PageCache from class org.neo4j.kernel.impl.store.kvstore.Resources | From | To | |
| Move Method public close() : void from class org.neo4j.kernel.impl.store.counts.ConcurrentCountsTrackerState to public close() : void from class org.neo4j.kernel.impl.api.CountsStoreApplier | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute private updateLock : ReadWriteLock from class org.neo4j.kernel.impl.store.counts.CountsTracker to private updateLock : ReadWriteLock from class org.neo4j.kernel.impl.store.kvstore.AbstractKeyValueStore | From | To | |
| Move Attribute | 3 | ||
| Move Attribute public DEFAULT_SECOND_VALUE : long from class org.neo4j.kernel.impl.store.counts.CountsRecordSerializer to private DEFAULT_SECOND_VALUE : long from class org.neo4j.kernel.impl.api.CountsRecordState | From | To | |
| Move Attribute public fs : EphemeralFileSystemRule from class org.neo4j.kernel.impl.store.counts.CountsTrackerTest to private fs : EphemeralFileSystemRule from class org.neo4j.kernel.impl.store.kvstore.Resources | From | To | |
| Move Attribute public DEFAULT_FIRST_VALUE : long from class org.neo4j.kernel.impl.store.counts.CountsRecordSerializer to private DEFAULT_FIRST_VALUE : long from class org.neo4j.kernel.impl.api.CountsRecordState | From | To | |
| Extract Class | 1 | ||
| Extract Class org.neo4j.kernel.impl.store.kvstore.Resources from class org.neo4j.kernel.impl.store.counts.CountsTrackerTest | From | To | |
| Rename Class | 1 | ||
| Rename Class org.neo4j.kernel.impl.store.counts.keys.IndexCountsKey renamed to org.neo4j.kernel.impl.store.counts.keys.IndexStatisticsKey | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type that : IndexCountsKey to that : IndexStatisticsKey in method public compareTo(other CountsKey) : int in class org.neo4j.kernel.impl.store.counts.keys.IndexStatisticsKey | From | To | |
| Change Variable Type tracker : CountsTracker to updater : CountsAccessor.Updater in method private resetIndexCounts(labelId int, pkId int) : void in class org.neo4j.kernel.impl.api.index.IndexStatisticsIT | From | To | |
| Change Variable Type records : Collection<Pair<CountsKey,Long>> to records : Collection<Pair<? extends CountsKey,Long>> in method private allRecords(store CountsVisitor.Visitable) : Collection<Pair<? extends CountsKey,Long>> in class org.neo4j.kernel.impl.store.counts.CountsRotationTest | From | To | |
| Extract Method | 6 | ||
| Extract Method private newTracker() : CountsTracker extracted from public shouldBeAbleToReadUpToDateValueWhileAnotherThreadIsPerformingRotation() : void in class org.neo4j.kernel.impl.store.counts.CountsTrackerTest | From | To | |
| Extract Method private newTracker() : CountsTracker extracted from public shouldStoreCounts() : void in class org.neo4j.kernel.impl.store.counts.CountsTrackerTest | From | To | |
| Extract Method private newTracker() : CountsTracker extracted from public shouldUpdateCountsOnExistingStore() : void in class org.neo4j.kernel.impl.store.counts.CountsTrackerTest | From | To | |
| Extract Method public instance() : EphemeralFileSystemAbstraction extracted from public get() : EphemeralFileSystemAbstraction in class org.neo4j.test.EphemeralFileSystemRule | From | To | |
| Inline Variable | 1 | ||
| Inline Variable countsTracker : CountsTracker in method public newNeoStore(allowCreateEmpty boolean) : NeoStore from class org.neo4j.kernel.impl.store.StoreFactory | From | To | |
| Rename Method | 5 | ||
| Rename Method public visitIndexCounts(labelId int, propertyKeyId int, updates long, size long) : void renamed to public visitIndexStatistics(labelId int, propertyKeyId int, updates long, size long) : void in class org.neo4j.kernel.impl.api.CountsRecordState.Verifier | From | To | |
| Rename Method public indexCountsKey(labelId int, propertyKeyId int) : IndexCountsKey renamed to public indexStatisticsKey(labelId int, propertyKeyId int) : IndexStatisticsKey in class org.neo4j.kernel.impl.store.counts.keys.CountsKeyFactory | From | To | |
| Rename Method public visitIndexCounts(labelId int, propertyKeyId int, updates long, size long) : void renamed to public visitIndexStatistics(labelId int, propertyKeyId int, updates long, size long) : void in class org.neo4j.kernel.impl.api.CountsAccessor.Initializer | From | To | |
| Rename Method public oracle() : CountsOracle renamed to private someData() : CountsOracle in class org.neo4j.kernel.impl.store.counts.CountsTrackerTest | From | To | |
| Rename Method public visitIndexCounts(labelId int, propertyKeyId int, updates long, size long) : void renamed to public visitIndexStatistics(labelId int, propertyKeyId int, updates long, size long) : void in class org.neo4j.kernel.impl.api.CountsVisitor | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method package storeFile() : File from class org.neo4j.kernel.impl.store.counts.CountsTracker to public currentFile() : File from class org.neo4j.kernel.impl.store.kvstore.AbstractKeyValueStore | From | To | |
| Rename Variable | 3 | ||
| Rename Variable newTxId : int to txId : int in method public shouldUpdateCountsOnExistingStore() : void in class org.neo4j.kernel.impl.store.counts.CountsTrackerTest | From | To | |
| Rename Variable storeFile : File to path : File in method public main(args String[]) : void in class org.neo4j.kernel.impl.store.counts.DumpCountsStore | From | To | |
| Rename Variable tracker : CountsTracker to updater : CountsAccessor.Updater in method private resetIndexCounts(labelId int, pkId int) : void in class org.neo4j.kernel.impl.api.index.IndexStatisticsIT | From | To | |
| Change Return Type | 2 | ||
| Change Return Type Collection<Pair<CountsKey,Long>> to Collection<Pair<? extends CountsKey,Long>> in method private allRecords(store CountsVisitor.Visitable) : Collection<Pair<? extends CountsKey,Long>> in class org.neo4j.kernel.impl.store.counts.CountsRotationTest | From | To | |
| Change Return Type IndexCountsKey to IndexStatisticsKey in method public indexStatisticsKey(labelId int, propertyKeyId int) : IndexStatisticsKey in class org.neo4j.kernel.impl.store.counts.keys.CountsKeyFactory | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.neo4j.kernel.impl.store.kvstore.AbstractKeyValueStore from classes [org.neo4j.kernel.impl.store.counts.CountsTracker] | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute countsAccessor : CountsAccessor to countsUpdater : CountsAccessor.Updater in class org.neo4j.kernel.impl.api.CountsStoreApplier | From | To | |
| Rename Attribute countsAccessor : CountsAccessor to updater : CountsAccessor.Updater in class org.neo4j.kernel.impl.api.CountsStoreApplierTest | From | To | |
| Rename Attribute ALPHA : String to LEFT : String in class org.neo4j.kernel.impl.store.counts.CountsTracker | From | To | |
| Rename Attribute BETA : String to RIGHT : String in class org.neo4j.kernel.impl.store.counts.CountsTracker | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.neo4j.kernel.impl.api.CountsAccessor.Updater from classes [org.neo4j.kernel.impl.api.CountsRecordState] | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type target : CountsAccessor to target : Updater in class org.neo4j.kernel.impl.api.CountsAccessor.Initializer | From | To | |
| Change Attribute Type counts : CountsTracker to counts : CountsAccessor in class org.neo4j.consistency.checking.GraphStoreFixture.TransactionDataBuilder | From | To | |
| Change Attribute Type countsAccessor : CountsAccessor to updater : CountsAccessor.Updater in class org.neo4j.kernel.impl.api.CountsStoreApplierTest | From | To | |
| Change Attribute Type countsAccessor : CountsAccessor to countsUpdater : CountsAccessor.Updater in class org.neo4j.kernel.impl.api.CountsStoreApplier | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public multiplex(visitors CountsVisitor...) : CountsVisitor extracted from public verify(tracker CountsTracker) : void in class org.neo4j.kernel.impl.store.CountsOracle & moved to class org.neo4j.kernel.impl.api.CountsVisitor.Adapter | From | To | |
| Rename Parameter | 5 | ||
| Rename Parameter total : long to delta : long in method public incrementIndexUpdates(labelId int, propertyKeyId int, delta long) : void in class org.neo4j.kernel.impl.api.CountsAccessor | From | To | |
| Rename Parameter lastCommittedTxId : long to txId : long in method public rotate(txId long) : void in class org.neo4j.kernel.impl.store.counts.CountsTracker | From | To | |
| Rename Parameter countsAccessor : CountsAccessor to countsUpdater : CountsAccessor.Updater in method public CountsStoreApplier(countsUpdater CountsAccessor.Updater, nodeStore NodeStore) in class org.neo4j.kernel.impl.api.CountsStoreApplier | From | To | |
| Rename Parameter pageCache : PageCache to pages : PageCache in method public CountsTracker(logger StringLogger, fs FileSystemAbstraction, pages PageCache, baseFile File) in class org.neo4j.kernel.impl.store.counts.CountsTracker | From | To | |
| Rename Parameter storeFileBase : File to baseFile : File in method public CountsTracker(logger StringLogger, fs FileSystemAbstraction, pages PageCache, baseFile File) in class org.neo4j.kernel.impl.store.counts.CountsTracker | From | To |