80c37e4a699946ec48c5b1a4a74d3566b50fb1c5
Files Diff
- Added: 7
- Removed: 5
- Renamed: 0
- Modified: 44
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private getBatchingNeoStores() : BatchingNeoStores from class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter to public instantiateNeoStores(fileSystem FileSystemAbstraction, storeDir File, externalPageCache PageCache, recordFormats RecordFormats, config Configuration, logService LogService, additionalInitialIds AdditionalInitialIds, dbConfig Config) : BatchingNeoStores from class org.neo4j.unsafe.impl.batchimport.ImportLogic | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type sortedTypes : Map.Entry<Object,MutableLong>[] to sortedTypes : Pair<Object,Long>[] in method public RelationshipTypeDistribution(sortedTypes Pair<Object,Long>[]) in class org.neo4j.unsafe.impl.batchimport.RelationshipTypeDistribution | From | To | |
| Move Method | 5 | ||
| Move Method private configWithRecordsPerPageBasedBatchSize(source Configuration, store RecordStore<?>) : Configuration from class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter to private configWithRecordsPerPageBasedBatchSize(source Configuration, store RecordStore<?>) : Configuration from class org.neo4j.unsafe.impl.batchimport.ImportLogic | From | To | |
| Move Method private executeStage(stage Stage) : void from class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter to private executeStage(stage Stage) : void from class org.neo4j.unsafe.impl.batchimport.ImportLogic | From | To | |
| Move Method private typeIdFilter(typesToLinkThisRound Collection<Object>, relationshipTypeRepository BatchingRelationshipTypeTokenRepository) : Predicate<RelationshipRecord> from class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter to private typeIdFilter(typesToLinkThisRound Collection<Object>, relationshipTypeRepository BatchingRelationshipTypeTokenRepository) : Predicate<RelationshipRecord> from class org.neo4j.unsafe.impl.batchimport.ImportLogic | From | To | |
| Move Method private totalMemoryUsageOf(users MemoryStatsVisitor.Visitable...) : long from class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter to private totalMemoryUsageOf(users MemoryStatsVisitor.Visitable...) : long from class org.neo4j.unsafe.impl.batchimport.ImportLogic | From | To | |
| Move Method public shouldSplitUpRelationshipTypesInBatches() : void from class org.neo4j.unsafe.impl.batchimport.cache.NodeRelationshipCacheTest to public shouldSplitUpRelationshipTypesInBatches() : void from class org.neo4j.unsafe.impl.batchimport.ImportLogicTest | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Iterator<Map.Entry<Object,MutableLong>> to Iterator<Pair<Object,Long>> in method public iterator() : Iterator<Pair<Object,Long>> in class org.neo4j.unsafe.impl.batchimport.RelationshipTypeDistribution | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private log : Log from class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter to private log : Log from class org.neo4j.unsafe.impl.batchimport.ImportLogic | From | To | |
| Extract Class | 1 | ||
| Extract Class org.neo4j.unsafe.impl.batchimport.ImportLogic from class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter | From | To | |
| Extract Attribute | 11 | ||
| Extract Attribute public NAME : String in class org.neo4j.unsafe.impl.batchimport.NodeFirstGroupStage | From | To | |
| Extract Attribute public NAME : String in class org.neo4j.unsafe.impl.batchimport.ScanAndCacheGroupsStage | From | To | |
| Extract Attribute public NAME : String in class org.neo4j.unsafe.impl.batchimport.CountGroupsStage | From | To | |
| Extract Attribute public NAME : String in class org.neo4j.unsafe.impl.batchimport.NodeStage | From | To | |
| Extract Attribute public NAME : String in class org.neo4j.unsafe.impl.batchimport.RelationshipCountsStage | From | To | |
| Extract Attribute public NAME : String in class org.neo4j.unsafe.impl.batchimport.WriteGroupsStage | From | To | |
| Extract Attribute public NAME : String in class org.neo4j.unsafe.impl.batchimport.RelationshipStage | From | To | |
| Extract Attribute public NAME : String in class org.neo4j.unsafe.impl.batchimport.IdMapperPreparationStage | From | To | |
| Extract Attribute public NAME : String in class org.neo4j.unsafe.impl.batchimport.NodeDegreeCountStage | From | To | |
| Extract Attribute public NAME : String in class org.neo4j.unsafe.impl.batchimport.NodeCountsStage | From | To | |
| Extract Attribute public NAME : String in class org.neo4j.unsafe.impl.batchimport.SparseNodeFirstRelationshipStage | From | To | |
| Move Class | 5 | ||
| Move Class org.neo4j.tooling.SimpleDataGenerator moved to org.neo4j.unsafe.impl.batchimport.input.SimpleDataGenerator | From | To | |
| Move Class org.neo4j.tooling.EntityDataGenerator moved to org.neo4j.unsafe.impl.batchimport.input.EntityDataGenerator | From | To | |
| Move Class org.neo4j.tooling.Distribution moved to org.neo4j.unsafe.impl.batchimport.input.Distribution | From | To | |
| Move Class org.neo4j.tooling.SimpleDataGeneratorBatch moved to org.neo4j.unsafe.impl.batchimport.input.SimpleDataGeneratorBatch | From | To | |
| Move Class org.neo4j.tooling.DataGeneratorInput moved to org.neo4j.unsafe.impl.batchimport.input.DataGeneratorInput | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type processed : Iterator<Entry<Object,MutableLong>> to processed : Iterator<Pair<Object,Long>> in method public shouldReturnRelationshipTypesInDescendingOrder() : void in class org.neo4j.unsafe.impl.batchimport.RelationshipTypeCheckerStepTest | From | To | |
| Change Variable Type type : Entry<Object,MutableLong> to type : Pair<Object,Long> in method private shouldReturnRelationshipTypeIdsInReverseOrderOfTokenCreation(typeIds boolean) : void in class org.neo4j.unsafe.impl.batchimport.RelationshipTypeCheckerStepTest | From | To | |
| Change Variable Type entry : Entry<Object,MutableLong> to entry : Pair<Object,Long> in method public shouldReturnRelationshipTypesInDescendingOrder() : void in class org.neo4j.unsafe.impl.batchimport.RelationshipTypeCheckerStepTest | From | To | |
| Extract Variable | 1 | ||
| Extract Variable thread : Thread in method public receive(ticket long, batch Void) : long from class org.neo4j.unsafe.impl.batchimport.staging.ProducerStep | From | To | |
| Extract Method | 1 | ||
| Extract Method public flush() : void extracted from public close() : void in class org.neo4j.unsafe.impl.batchimport.store.BatchingTokenRepository | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type sortedTypes : Map.Entry<Object,MutableLong>[] to sortedTypes : Pair<Object,Long>[] in class org.neo4j.unsafe.impl.batchimport.RelationshipTypeDistribution | From | To |