82672dd1f9a19c216bcaafa899cdd5a1100b9292
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 4 | ||
| Rename Variable newRoot : long to oldRootId : long in method public shouldRereadNewGenIfReadFailureCausedByCheckpointInInternal() : void in class org.neo4j.index.gbptree.SeekCursorTest | From | To | |
| Rename Variable newGenOfNewRoot : long to prevId : long in method private keyCount(nodeId long) : int in class org.neo4j.index.gbptree.SeekCursorTest | From | To | |
| Rename Variable pos : int to childPos : int in method private moveToCorrectLeaf(cursor PageCursor, key KEY, stableGeneration long, unstableGeneration long) : void in class org.neo4j.index.gbptree.InternalTreeLogic | From | To | |
| Rename Variable root : long to prevId : long in method private keyCount(nodeId long) : int in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Change Return Type | 3 | ||
| Change Return Type long to void in method private newRootFromSplit(split StructurePropagation<MutableLong>) : void in class org.neo4j.index.gbptree.SeekCursorTest | From | To | |
| Change Return Type long to void in method private newRootFromSplit(split StructurePropagation<MutableLong>) : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Change Return Type VALUE to boolean in method private removeFromLeaf(cursor PageCursor, structurePropagation StructurePropagation<KEY>, key KEY, into VALUE, stableGeneration long, unstableGeneration long) : boolean in class org.neo4j.index.gbptree.InternalTreeLogic | From | To | |
| Replace Variable With Attribute | 5 | ||
| Replace Variable With Attribute newRoot : long to rootId : long in method public shouldRereadSiblingIfReadFailureCausedByConcurrentCheckpoint() : void in class org.neo4j.index.gbptree.SeekCursorTest | From | To | |
| Replace Variable With Attribute newRoot : long to rootId : long in method public shouldFailChildPointerIfReadFailureNotCausedByCheckpoint() : void in class org.neo4j.index.gbptree.SeekCursorTest | From | To | |
| Replace Variable With Attribute newRoot : long to rootId : long in method public shouldRereadChildPointerIfReadFailureCausedByCheckpoint() : void in class org.neo4j.index.gbptree.SeekCursorTest | From | To | |
| Replace Variable With Attribute rootAllocations : int to numberOfRootSplits : int in method public shouldCreateNewVersionWhenInsertInStableInternal() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Replace Variable With Attribute newRoot : long to rootId : long in method public shouldFailNewGenIfReadFailureNotCausedByCheckpointInInternal() : void in class org.neo4j.index.gbptree.SeekCursorTest | From | To | |
| Inline Variable | 1 | ||
| Inline Variable keyCount : int in method package insert(cursor PageCursor, structurePropagation StructurePropagation<KEY>, key KEY, value VALUE, valueMerger ValueMerger<VALUE>, options IndexWriter.Options, stableGeneration long, unstableGeneration long) : void from class org.neo4j.index.gbptree.InternalTreeLogic | From | To | |
| Extract Method | 34 | ||
| Extract Method private initialize() : void extracted from public shouldCreateNewVersionWhenInsertInStableRootAsInternal() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustSplitWhenInsertingLastInFullLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustSplitWhenInsertingMiddleOfFullLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustOverwriteWithOverwriteMerger() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustUpdatePointersInSiblingsToSplit() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public shouldMergeValueInLeafBetweenTwoParentKeys() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustInsertAtFirstPositionInEmptyLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustRemoveFromLeftChild() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public shouldCreateNewVersionWhenRemoveInStableRootAsLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private keyCount(nodeId long) : int extracted from public shouldRereadNewGenIfReadFailureCausedByCheckpointInInternal() : void in class org.neo4j.index.gbptree.SeekCursorTest | From | To | |
| Extract Method private keyCount(nodeId long) : int extracted from public shouldCreateNewVersionWhenInsertInStableRootAsInternal() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public shouldOverwriteInheritedNewGenOnNewGen() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustRemoveLastInFullLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public shouldCreateNewVersionWhenInsertInStableInternal() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustSplitWhenInsertingFirstInFullLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public shouldMergeValueInLeafLeftOfParentKey() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustKeepExistingWithKeepExistingMerger() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public shouldCreateNewVersionWhenInsertInStableRootAsLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustSortCorrectlyOnInsertLastInLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustNotRemoveWhenKeyDoesNotExist() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustSortCorrectlyOnInsertInMiddleOfLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustProduceConsistentTreeWithRandomInserts() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public shouldMergeValueInRootLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustRemoveFirstInFullLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private moveToCorrectLeaf(cursor PageCursor, key KEY, stableGeneration long, unstableGeneration long) : void extracted from package insert(cursor PageCursor, structurePropagation StructurePropagation<KEY>, key KEY, value VALUE, valueMerger ValueMerger<VALUE>, options IndexWriter.Options, stableGeneration long, unstableGeneration long) : void in class org.neo4j.index.gbptree.InternalTreeLogic | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustRemoveFirstInEmptyLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustNotRemoveWhenKeyOnlyExistInInternal() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustRemoveInMiddleInFullLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustRemoveFromRightChildButNotFromInternalWithHitOnInternalSearch() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public shouldMergeValueInLeafAtParentKey() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public shouldCreateNewVersionWhenInsertInStableLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public modifierMustSortCorrectlyOnInsertFirstInLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private initialize() : void extracted from public shouldCreateNewVersionWhenRemoveInStableLeaf() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To | |
| Extract Method private updateRoot() : void extracted from public modifierMustProduceConsistentTreeWithRandomInserts() : void in class org.neo4j.index.gbptree.InternalTreeLogicTest | From | To |