85d4c6dbf1b7ecc99b8888a74c4d45c22ab9f873
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 19
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public shouldBatchNewEntriesAndHandleOtherMessagesSingularly() : void renamed to public shouldBatchNewEntriesAndHandleOtherMessagesFirst() : void in class org.neo4j.causalclustering.core.BatchingMessageHandlerTest | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type handler : LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage<?>> to handler : LifecycleMessageHandler<ReceivedInstantClusterIdAwareMessage<?>> in method package BatchingMessageHandler(handler LifecycleMessageHandler<ReceivedInstantClusterIdAwareMessage<?>>, inQueueConfig BoundedPriorityQueue.Config, batchConfig Config, jobFactory Function<Runnable,ContinuousJob>, logProvider LogProvider) in class org.neo4j.causalclustering.core.BatchingMessageHandler | From | To | |
| Change Parameter Type contents : List<ReplicatedContent> to contents : Collection<ReplicatedContent> in method package appendNewEntries(ctx ReadableRaftState, outcome Outcome, contents Collection<ReplicatedContent>) : void in class org.neo4j.causalclustering.core.consensus.roles.Appending | From | To | |
| Rename Variable | 3 | ||
| Rename Variable queueSize : int to inQueueConfig : BoundedPriorityQueue.Config in method private createBatchingHandler(config Config) : ComposableMessageHandler in class org.neo4j.causalclustering.core.RaftServerModule | From | To | |
| Rename Variable maxBatch : int to batchConfig : BatchingMessageHandler.Config in method private createBatchingHandler(config Config) : ComposableMessageHandler in class org.neo4j.causalclustering.core.RaftServerModule | From | To | |
| Rename Variable message : RaftMessages.ReceivedInstantClusterIdAwareMessage<?> to baseMessage : Optional<ReceivedInstantClusterIdAwareMessage<?>> in method public run() : void in class org.neo4j.causalclustering.core.BatchingMessageHandler | From | To | |
| Change Return Type | 4 | ||
| Change Return Type long to Optional<Long> in method public size() : Optional<Long> in class org.neo4j.causalclustering.core.replication.ReplicatedContent | From | To | |
| Change Return Type long to Optional<Long> in method public size() : Optional<Long> in class org.neo4j.causalclustering.core.replication.DistributedOperation | From | To | |
| Change Return Type long to Optional<Long> in method public size() : Optional<Long> in class org.neo4j.causalclustering.core.state.machines.dummy.DummyRequest | From | To | |
| Change Return Type long to Optional<Long> in method public size() : Optional<Long> in class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransaction | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [maxBatch : int, queueSize : int] to batchConfig : Config in method package BatchingMessageHandler(handler LifecycleMessageHandler<ReceivedInstantClusterIdAwareMessage<?>>, inQueueConfig BoundedPriorityQueue.Config, batchConfig Config, jobFactory Function<Runnable,ContinuousJob>, logProvider LogProvider) in class org.neo4j.causalclustering.core.BatchingMessageHandler | From | To | |
| Rename Attribute | 5 | ||
| Rename Attribute list : List<ReplicatedContent> to batch : List<ReplicatedContent> in class org.neo4j.causalclustering.core.consensus.RaftMessages.NewEntry.BatchRequest | From | To | |
| Rename Attribute batch : List<RaftMessages.ReceivedInstantClusterIdAwareMessage<?>> to entryBatch : List<RaftLogEntry> in class org.neo4j.causalclustering.core.BatchingMessageHandler | From | To | |
| Rename Attribute MAX_BATCH : int to BATCH_CONFIG : BatchingMessageHandler.Config in class org.neo4j.causalclustering.core.BatchingMessageHandlerTest | From | To | |
| Rename Attribute maxBatch : int to batchConfig : Config in class org.neo4j.causalclustering.core.BatchingMessageHandler | From | To | |
| Rename Attribute QUEUE_SIZE : int to IN_QUEUE_CONFIG : BoundedPriorityQueue.Config in class org.neo4j.causalclustering.core.BatchingMessageHandlerTest | From | To | |
| Change Variable Type | 7 | ||
| Change Variable Type queueSize : int to inQueueConfig : BoundedPriorityQueue.Config in method private createBatchingHandler(config Config) : ComposableMessageHandler in class org.neo4j.causalclustering.core.RaftServerModule | From | To | |
| Change Variable Type message : RaftMessages.ReceivedInstantClusterIdAwareMessage<?> to baseMessage : Optional<ReceivedInstantClusterIdAwareMessage<?>> in method public run() : void in class org.neo4j.causalclustering.core.BatchingMessageHandler | From | To | |
| Change Variable Type messageB : RaftMessages.NewEntry.Request to messageB : NewEntry.Request in method public shouldBatchRequests() : void in class org.neo4j.causalclustering.core.BatchingMessageHandlerTest | From | To | |
| Change Variable Type maxBatch : int to batchConfig : BatchingMessageHandler.Config in method private createBatchingHandler(config Config) : ComposableMessageHandler in class org.neo4j.causalclustering.core.RaftServerModule | From | To | |
| Change Variable Type messageA : RaftMessages.NewEntry.Request to messageA : NewEntry.Request in method public shouldBatchUsingReceivedInstantOfFirstReceivedMessage() : void in class org.neo4j.causalclustering.core.BatchingMessageHandlerTest | From | To | |
| Change Variable Type contents : List<ReplicatedContent> to contents : Collection<ReplicatedContent> in method public handle(req RaftMessages.NewEntry.BatchRequest) : Outcome in class org.neo4j.causalclustering.core.consensus.roles.Leader.Handler | From | To | |
| Change Variable Type messageA : RaftMessages.NewEntry.Request to messageA : NewEntry.Request in method public shouldBatchRequests() : void in class org.neo4j.causalclustering.core.BatchingMessageHandlerTest | From | To | |
| Extract Method | 1 | ||
| Extract Method private createBatchingHandler(config Config) : ComposableMessageHandler extracted from private createMessageHandlerChain(coreServerModule CoreServerModule) : LifecycleMessageHandler<ReceivedInstantClusterIdAwareMessage<?>> in class org.neo4j.causalclustering.core.RaftServerModule | From | To | |
| Change Attribute Type | 6 | ||
| Change Attribute Type batch : List<RaftMessages.ReceivedInstantClusterIdAwareMessage<?>> to entryBatch : List<RaftLogEntry> in class org.neo4j.causalclustering.core.BatchingMessageHandler | From | To | |
| Change Attribute Type downstreamHandler : LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage<?>> to downstreamHandler : LifecycleMessageHandler<ReceivedInstantClusterIdAwareMessage<?>> in class org.neo4j.causalclustering.core.BatchingMessageHandlerTest | From | To | |
| Change Attribute Type maxBatch : int to batchConfig : Config in class org.neo4j.causalclustering.core.BatchingMessageHandler | From | To | |
| Change Attribute Type MAX_BATCH : int to BATCH_CONFIG : BatchingMessageHandler.Config in class org.neo4j.causalclustering.core.BatchingMessageHandlerTest | From | To | |
| Change Attribute Type QUEUE_SIZE : int to IN_QUEUE_CONFIG : BoundedPriorityQueue.Config in class org.neo4j.causalclustering.core.BatchingMessageHandlerTest | From | To | |
| Change Attribute Type handler : LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage<?>> to handler : LifecycleMessageHandler<ReceivedInstantClusterIdAwareMessage<?>> in class org.neo4j.causalclustering.core.BatchingMessageHandler | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter jobSchedulerFactory : Function<Runnable,ContinuousJob> to jobFactory : Function<Runnable,ContinuousJob> in method package BatchingMessageHandler(handler LifecycleMessageHandler<ReceivedInstantClusterIdAwareMessage<?>>, inQueueConfig BoundedPriorityQueue.Config, batchConfig Config, jobFactory Function<Runnable,ContinuousJob>, logProvider LogProvider) in class org.neo4j.causalclustering.core.BatchingMessageHandler | From | To |