neo4j 8828c4548a8c4764cbffad439876fdb2fb9253e6

8828c4548a8c4764cbffad439876fdb2fb9253e6

Files Diff

Added: 1
Removed: 0
Renamed: 0
Modified: 23

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	2
Rename Method public shouldImportMultipleInputGroups() : void renamed to public shouldImportSplitInputFiles() : void in class org.neo4j.tooling.ImportToolTest	From	To
Rename Method public shouldImportMultipleInputGroupsWithAddedLabelsAndDefaultRelationshipType() : void renamed to public shouldImportMultipleInputsWithAddedLabelsAndDefaultRelationshipType() : void in class org.neo4j.tooling.ImportToolTest	From	To
Change Parameter Type	6
Change Parameter Type nodeIds : List<String> to data : Iterator<Triplet<String,String,String>> in method private writeRelationshipData(writer PrintStream, config Configuration, data Iterator<Triplet<String,String,String>>, linePredicate PrimitiveIntPredicate, specifyType boolean) : void in class org.neo4j.tooling.ImportToolTest	From	To
Change Parameter Type inGroup : PrimitiveIntPredicate to group : Group in method public get(inputId Object, group Group) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.IdMappers.ActualIdMapper	From	To
Change Parameter Type endNodeGroups : PrimitiveIntPredicate to endNodeGroups : Group in method public InputRelationship(id long, properties Object[], firstPropertyId Long, startNodeGroups Group, startNode Object, endNodeGroups Group, endNode Object, type String, typeId Integer) in class org.neo4j.unsafe.impl.batchimport.input.InputRelationship	From	To
Change Parameter Type inGroup : PrimitiveIntPredicate to group : Group in method public get(inputId Object, group Group) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.IdMapper	From	To
Change Parameter Type inGroup : PrimitiveIntPredicate to group : Group in method public get(inputId Object, group Group) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper	From	To
Change Parameter Type startNodeGroups : PrimitiveIntPredicate to startNodeGroups : Group in method public InputRelationship(id long, properties Object[], firstPropertyId Long, startNodeGroups Group, startNode Object, endNodeGroups Group, endNode Object, type String, typeId Integer) in class org.neo4j.unsafe.impl.batchimport.input.InputRelationship	From	To
Rename Variable	8
Rename Variable group1 : Group to secondGroup : Group in method public shouldPreventCollisionGetFromManyGroups() : void in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapperTest	From	To
Rename Variable firstGroupType : String to firstType : String in method public shouldImportMultipleInputsWithAddedLabelsAndDefaultRelationshipType() : void in class org.neo4j.tooling.ImportToolTest	From	To
Rename Variable group0 : Group to firstGroup : Group in method public shouldBeAbleToHaveDuplicateInputIdButInDifferentGroups() : void in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapperTest	From	To
Rename Variable group1 : Group to secondGroup : Group in method public shouldBeAbleToHaveDuplicateInputIdButInDifferentGroups() : void in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapperTest	From	To
Rename Variable firstGroupLabels : String[] to firstLabels : String[] in method public shouldImportMultipleInputsWithAddedLabelsAndDefaultRelationshipType() : void in class org.neo4j.tooling.ImportToolTest	From	To
Rename Variable secondGroupLabels : String[] to secondLabels : String[] in method public shouldImportMultipleInputsWithAddedLabelsAndDefaultRelationshipType() : void in class org.neo4j.tooling.ImportToolTest	From	To
Rename Variable group0 : Group to firstGroup : Group in method public shouldPreventCollisionGetFromManyGroups() : void in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapperTest	From	To
Rename Variable secondGroupType : String to secondType : String in method public shouldImportMultipleInputsWithAddedLabelsAndDefaultRelationshipType() : void in class org.neo4j.tooling.ImportToolTest	From	To
Rename Attribute	3
Rename Attribute currentGroup : ResourceIterator<ENTITY> to currentInput : ResourceIterator<ENTITY> in class org.neo4j.unsafe.impl.batchimport.input.csv.InputGroupsDeserializer	From	To
Rename Attribute endNodeGroups : PrimitiveIntPredicate to endNodeGroup : Group in class org.neo4j.unsafe.impl.batchimport.input.InputRelationship	From	To
Rename Attribute startNodeGroups : PrimitiveIntPredicate to startNodeGroup : Group in class org.neo4j.unsafe.impl.batchimport.input.InputRelationship	From	To
Extract Variable	2
Extract Variable relationshipData : Iterable<DataFactory<InputRelationship>> in method private input(nodesFiles Collection<Option<File[]>>, relationshipsFiles Collection<Option<File[]>>, inputFilesExtractor Function2<Args,String,Collection<Option<File[]>>>, idType IdType, configuration Configuration) : Input from class org.neo4j.tooling.ImportTool	From	To
Extract Variable nodeData : Iterable<DataFactory<InputNode>> in method private input(nodesFiles Collection<Option<File[]>>, relationshipsFiles Collection<Option<File[]>>, inputFilesExtractor Function2<Args,String,Collection<Option<File[]>>>, idType IdType, configuration Configuration) : Input from class org.neo4j.tooling.ImportTool	From	To
Inline Variable	1
Inline Variable decorator : Function<ENTITY,ENTITY> in method protected createNestedIterator(dataFactory DataFactory<ENTITY>) : ResourceIterator<ENTITY> from class org.neo4j.unsafe.impl.batchimport.input.csv.InputGroupsDeserializer	From	To
Change Attribute Type	2
Change Attribute Type endNodeGroups : PrimitiveIntPredicate to endNodeGroup : Group in class org.neo4j.unsafe.impl.batchimport.input.InputRelationship	From	To
Change Attribute Type startNodeGroups : PrimitiveIntPredicate to startNodeGroup : Group in class org.neo4j.unsafe.impl.batchimport.input.InputRelationship	From	To
Extract Method	9
Extract Method private relationshipData(includeHeader boolean, config Configuration, data Iterator<Triplet<String,String,String>>, linePredicate PrimitiveIntPredicate, specifyType boolean) : File extracted from private relationshipData(includeHeader boolean, config Configuration, nodeIds List<String>, linePredicate PrimitiveIntPredicate, specifyType boolean) : File in class org.neo4j.tooling.ImportToolTest	From	To
Extract Method private assertRelationship(relationship InputRelationship, id long, startNodeGroup Group, startNode Object, endNodeGroup Group, endNode Object, type String, properties Object[]) : void extracted from private assertRelationship(relationship InputRelationship, id long, startNode Object, endNode Object, type String, properties Object[]) : void in class org.neo4j.unsafe.impl.batchimport.input.csv.CsvInputTest	From	To
Extract Method private relationshipHeader(config Configuration, startIdGroup String, endIdGroup String) : File extracted from private relationshipHeader(config Configuration) : File in class org.neo4j.tooling.ImportToolTest	From	To
Extract Method private entry(name String, type Type, groupName String, extractor Extractor<?>) : Header.Entry extracted from private entry(name String, type Type, extractor Extractor<?>) : Header.Entry in class org.neo4j.unsafe.impl.batchimport.input.csv.DataFactoriesTest	From	To
Extract Method private nodeHeader(config Configuration, idGroup String) : File extracted from private nodeHeader(config Configuration) : File in class org.neo4j.tooling.ImportToolTest	From	To
Extract Method private entry(name String, type Type, groupName String, extractor Extractor<?>) : Header.Entry extracted from private entry(name String, type Type, extractor Extractor<?>) : Header.Entry in class org.neo4j.unsafe.impl.batchimport.input.csv.CsvInputTest	From	To
Extract Method private input(nodesFiles Collection<Option<File[]>>, relationshipsFiles Collection<Option<File[]>>, inputFilesExtractor Function2<Args,String,Collection<Option<File[]>>>, idType IdType, configuration Configuration) : Input extracted from public main(incomingArguments String[]) : void in class org.neo4j.tooling.ImportTool	From	To
Extract Method private nodeIds(count int) : List<String> extracted from private nodeIds() : List<String> in class org.neo4j.tooling.ImportToolTest	From	To
Extract Method private assertNode(node InputNode, group Group, id Object, properties Object[], labels Set<String>) : void extracted from private assertNode(node InputNode, id Object, properties Object[], labels Set<String>) : void in class org.neo4j.unsafe.impl.batchimport.input.csv.CsvInputTest	From	To
Rename Parameter	6
Rename Parameter nodeIds : List<String> to data : Iterator<Triplet<String,String,String>> in method private writeRelationshipData(writer PrintStream, config Configuration, data Iterator<Triplet<String,String,String>>, linePredicate PrimitiveIntPredicate, specifyType boolean) : void in class org.neo4j.tooling.ImportToolTest	From	To
Rename Parameter inGroup : PrimitiveIntPredicate to group : Group in method public get(inputId Object, group Group) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.IdMappers.ActualIdMapper	From	To
Rename Parameter group : Option<File[]> to input : Option<File[]> in method protected underlyingObjectToObject(input Option<File[]>) : DataFactory<InputNode> in class org.neo4j.tooling.ImportTool.nodeData	From	To
Rename Parameter files : Collection<Option<File[]>> to nodesFiles : Collection<Option<File[]>> in method private nodeData(nodesFiles Collection<Option<File[]>>) : Iterable<DataFactory<InputNode>> in class org.neo4j.tooling.ImportTool	From	To
Rename Parameter inGroup : PrimitiveIntPredicate to group : Group in method public get(inputId Object, group Group) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper	From	To
Rename Parameter inGroup : PrimitiveIntPredicate to group : Group in method public get(inputId Object, group Group) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.IdMapper	From	To

8828c4548a8c4764cbffad439876fdb2fb9253e6

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: