neo4j 8e12b78d674c8f7893ec8432009cc8bad2ce753d

8e12b78d674c8f7893ec8432009cc8bad2ce753d

Files Diff

Added: 5
Removed: 1
Renamed: 0
Modified: 12

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	11
Move And Rename Method public shouldNotMoveToRealElectionWithoutQuorum() : void from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to public shouldNotMoveToRealElectionWithoutPreVoteQuorum() : void from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Move And Rename Method public shouldNotSendPreVoteRequestsIfReceiveHeartbeatFromLeader() : void from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to public shouldMoveToRealElectionWithPreVoteQuorumOf5() : void from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Move And Rename Method public shouldMoveToRealElectionWithQuorumOf5() : void from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to public shouldMoveToRealElectionWithPreVoteQuorumOf5() : void from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Move And Rename Method public shouldProceedToRealElectionIfReceiveQuorumOfPositiveResponses() : void from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to public shouldProceedToRealElectionIfReceiveQuorumOfPositivePreVoteResponses() : void from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Move And Rename Method private initialState() : RaftState from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to private preElectionSupported() : RaftState from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Move And Rename Method public shouldNotSendRealVoteRequestsIfReceiveNegativeResponses() : void from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to public shouldNotSendRealVoteRequestsIfReceiveNegativePreVoteResponses() : void from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Move And Rename Method public shouldNotCountVotesFromSameMemberTwice() : void from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to public shouldNotCountPreVotesVotesFromSameMemberTwice() : void from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Move And Rename Method public shouldIgnorePositiveResponsesFromOlderTerm() : void from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to public shouldIgnorePreVotePositiveResponsesFromOlderTerm() : void from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Move And Rename Method public shouldSendRealVoteRequestsIfReceivePositiveResponses() : void from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to public shouldSendRealVoteRequestsIfReceivePositivePreVoteResponses() : void from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Move And Rename Method public shouldNotProceedToRealElectionIfReceiveNegativeResponses() : void from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to public shouldNotProceedToRealElectionIfReceiveNegativePreVoteResponses() : void from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Move And Rename Method public shouldIgnorePositiveResponsesIfNotInPreVotingStage() : void from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to public shouldIgnorePositivePreVoteResponsesIfNotInPreVotingStage() : void from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Change Parameter Type	1
Change Parameter Type votedFor : Optional<MemberId> to committedToVotingForAnother : boolean in method public shouldVoteFor(candidate MemberId, contextTerm long, requestTerm long, contextLastLogTerm long, requestLastLogTerm long, contextLastAppended long, requestLastLogIndex long, committedToVotingForAnother boolean, log Log) : boolean in class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Move Method	4
Move Method public shouldSendPreVoteRequestsOnElectionTimeout() : void from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to public shouldSendPreVoteRequestsOnElectionTimeout() : void from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Move Method public shouldResetPreVotesWhenMovingBackToFollower() : void from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to public shouldResetPreVotesWhenMovingBackToFollower() : void from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Move Method public shouldResetPreVoteIfReceiveHeartbeatFromLeader() : void from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to public shouldResetPreVoteIfReceiveHeartbeatFromLeader() : void from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Move Method public shouldSetPreElectionOnElectionTimeout() : void from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to public shouldSetPreElectionOnElectionTimeout() : void from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Pull Up Attribute	8
Pull Up Attribute private lastLogIndex : long from class org.neo4j.causalclustering.core.consensus.vote.VoteRequestBuilder to private lastLogIndex : long from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Pull Up Attribute package voteGranted : boolean from class org.neo4j.causalclustering.core.consensus.vote.VoteResponseBuilder to private voteGranted : boolean from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteResponseBuilder	From	To
Pull Up Attribute private term : long from class org.neo4j.causalclustering.core.consensus.vote.VoteResponseBuilder to private term : long from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteResponseBuilder	From	To
Pull Up Attribute private from : MemberId from class org.neo4j.causalclustering.core.consensus.vote.VoteRequestBuilder to private from : MemberId from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Pull Up Attribute private from : MemberId from class org.neo4j.causalclustering.core.consensus.vote.VoteResponseBuilder to private from : MemberId from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteResponseBuilder	From	To
Pull Up Attribute private lastLogTerm : long from class org.neo4j.causalclustering.core.consensus.vote.VoteRequestBuilder to private lastLogTerm : long from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Pull Up Attribute private term : long from class org.neo4j.causalclustering.core.consensus.vote.VoteRequestBuilder to private term : long from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Pull Up Attribute private candidate : MemberId from class org.neo4j.causalclustering.core.consensus.vote.VoteRequestBuilder to private candidate : MemberId from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Move Attribute	1
Move Attribute private member4 : MemberId from class org.neo4j.causalclustering.core.consensus.roles.PreVotingInitiatorTest to private member4 : MemberId from class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Extract Class	2
Extract Class org.neo4j.causalclustering.core.consensus.vote.AnyVoteResponseBuilder from class org.neo4j.causalclustering.core.consensus.vote.VoteRequestBuilder	From	To
Extract Class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder from class org.neo4j.causalclustering.core.consensus.vote.VoteResponseBuilder	From	To
Split Parameter	2
Split Parameter voteRequest : RaftMessages.Vote.Request to [state : ReadableRaftState, outcome : Outcome] in method package handleVoteRequest(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.Vote.Request, log Log) : void in class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Split Parameter outcome : Outcome to [state : ReadableRaftState, voteRequest : RaftMessages.Vote.Request] in method package handleVoteRequest(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.Vote.Request, log Log) : void in class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Extract Variable	7
Extract Variable requestLastLogIndex : long in method private shouldVoteFor(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.AnyVote.Request, committedToVotingForAnother boolean, log Log) : boolean from class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Extract Variable requestLastLogTerm : long in method private shouldVoteFor(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.AnyVote.Request, committedToVotingForAnother boolean, log Log) : boolean from class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Extract Variable contextTerm : long in method private shouldVoteFor(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.AnyVote.Request, committedToVotingForAnother boolean, log Log) : boolean from class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Extract Variable contextLastLogTerm : long in method private shouldVoteFor(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.AnyVote.Request, committedToVotingForAnother boolean, log Log) : boolean from class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Extract Variable requestTerm : long in method private shouldVoteFor(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.AnyVote.Request, committedToVotingForAnother boolean, log Log) : boolean from class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Extract Variable contextLastAppended : long in method private shouldVoteFor(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.AnyVote.Request, committedToVotingForAnother boolean, log Log) : boolean from class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Extract Variable candidate : MemberId in method private shouldVoteFor(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.AnyVote.Request, committedToVotingForAnother boolean, log Log) : boolean from class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Change Variable Type	1
Change Variable Type willVoteForCandidate : boolean to willVoteFor : ThrowingBooleanSupplier<IOException> in method private respondToPreVoteRequest(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.PreVote.Request, willVoteFor ThrowingBooleanSupplier<IOException>) : void in class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Extract Method	2
Extract Method private respondToPreVoteRequest(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.PreVote.Request, willVoteFor ThrowingBooleanSupplier<IOException>) : void extracted from package handlePreVoteRequest(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.PreVote.Request, log Log) : void in class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Extract Method private shouldVoteFor(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.AnyVote.Request, committedToVotingForAnother boolean, log Log) : boolean extracted from package handleVoteRequest(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.Vote.Request, log Log) : void in class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Rename Method	6
Rename Method public shouldUseTermFromRequestIfHigherThanOwn() : void renamed to public shouldUseTermFromPreVoteRequestIfHigherThanOwn() : void in class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Rename Method public shouldRespondNegativelyIfWouldNotVoteForCandidate() : void renamed to public shouldRespondNegativelyToPreVoteRequestsIfWouldNotVoteForCandidate() : void in class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Rename Method public shouldRespondPositivelyIfWouldVoteForCandidate() : void renamed to public shouldRespondPositivelyToPreVoteRequestsIfWouldVoteForCandidate() : void in class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Rename Method public shouldRespondPositivelyEvenIfAlreadyVotedInRealElection() : void renamed to public shouldRespondPositivelyToPreVoteRequestsEvenIfAlreadyVotedInRealElection() : void in class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Rename Method public shouldRespondNegativelyIfNotInPreVoteMyself() : void renamed to public shouldRespondNegativelyToPreVoteRequestsIfNotInPreVoteMyself() : void in class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Rename Method public shouldRespondPositivelyToMultipleMembersIfWouldVoteForAny() : void renamed to public shouldRespondPositivelyToPreVoteRequestsToMultipleMembersIfWouldVoteForAny() : void in class org.neo4j.causalclustering.core.consensus.roles.FollowerTest	From	To
Pull Up Method	7
Pull Up Method public term(term long) : VoteRequestBuilder from class org.neo4j.causalclustering.core.consensus.vote.VoteRequestBuilder to public term(term long) : AnyVoteRequestBuilder<T> from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Pull Up Method public candidate(candidate MemberId) : VoteRequestBuilder from class org.neo4j.causalclustering.core.consensus.vote.VoteRequestBuilder to public candidate(candidate MemberId) : AnyVoteRequestBuilder<T> from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Pull Up Method public lastLogTerm(lastLogTerm long) : VoteRequestBuilder from class org.neo4j.causalclustering.core.consensus.vote.VoteRequestBuilder to public lastLogTerm(lastLogTerm long) : AnyVoteRequestBuilder<T> from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Pull Up Method public lastLogIndex(lastLogIndex long) : VoteRequestBuilder from class org.neo4j.causalclustering.core.consensus.vote.VoteRequestBuilder to public lastLogIndex(lastLogIndex long) : AnyVoteRequestBuilder<T> from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Pull Up Method public term(term long) : VoteResponseBuilder from class org.neo4j.causalclustering.core.consensus.vote.VoteResponseBuilder to public term(term long) : AnyVoteResponseBuilder<T> from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteResponseBuilder	From	To
Pull Up Method public from(from MemberId) : VoteRequestBuilder from class org.neo4j.causalclustering.core.consensus.vote.VoteRequestBuilder to public from(from MemberId) : AnyVoteRequestBuilder<T> from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Pull Up Method public from(from MemberId) : VoteResponseBuilder from class org.neo4j.causalclustering.core.consensus.vote.VoteResponseBuilder to public from(from MemberId) : AnyVoteResponseBuilder<T> from class org.neo4j.causalclustering.core.consensus.vote.AnyVoteResponseBuilder	From	To
Change Return Type	7
Change Return Type VoteResponseBuilder to AnyVoteResponseBuilder<T> in method public from(from MemberId) : AnyVoteResponseBuilder<T> in class org.neo4j.causalclustering.core.consensus.vote.AnyVoteResponseBuilder	From	To
Change Return Type VoteResponseBuilder to AnyVoteResponseBuilder<T> in method public term(term long) : AnyVoteResponseBuilder<T> in class org.neo4j.causalclustering.core.consensus.vote.AnyVoteResponseBuilder	From	To
Change Return Type VoteRequestBuilder to AnyVoteRequestBuilder<T> in method public lastLogIndex(lastLogIndex long) : AnyVoteRequestBuilder<T> in class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Change Return Type VoteRequestBuilder to AnyVoteRequestBuilder<T> in method public candidate(candidate MemberId) : AnyVoteRequestBuilder<T> in class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Change Return Type VoteRequestBuilder to AnyVoteRequestBuilder<T> in method public term(term long) : AnyVoteRequestBuilder<T> in class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Change Return Type VoteRequestBuilder to AnyVoteRequestBuilder<T> in method public lastLogTerm(lastLogTerm long) : AnyVoteRequestBuilder<T> in class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Change Return Type VoteRequestBuilder to AnyVoteRequestBuilder<T> in method public from(from MemberId) : AnyVoteRequestBuilder<T> in class org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder	From	To
Parameterize Variable	1
Parameterize Variable willVoteForCandidate : boolean to willVoteFor : ThrowingBooleanSupplier<IOException> in method private respondToPreVoteRequest(state ReadableRaftState, outcome Outcome, voteRequest RaftMessages.PreVote.Request, willVoteFor ThrowingBooleanSupplier<IOException>) : void in class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Extract Superclass	2
Extract Superclass org.neo4j.causalclustering.core.consensus.vote.AnyVoteRequestBuilder from classes [org.neo4j.causalclustering.core.consensus.vote.VoteRequestBuilder]	From	To
Extract Superclass org.neo4j.causalclustering.core.consensus.vote.AnyVoteResponseBuilder from classes [org.neo4j.causalclustering.core.consensus.vote.VoteResponseBuilder]	From	To
Rename Parameter	3
Rename Parameter request : RaftMessages.PreVote.Request to req : RaftMessages.PreVote.Request in method public handle(req RaftMessages.PreVote.Request) : Outcome in class org.neo4j.causalclustering.core.consensus.roles.Candidate.Handler	From	To
Rename Parameter votedFor : Optional<MemberId> to committedToVotingForAnother : boolean in method public shouldVoteFor(candidate MemberId, contextTerm long, requestTerm long, contextLastLogTerm long, requestLastLogTerm long, contextLastAppended long, requestLastLogIndex long, committedToVotingForAnother boolean, log Log) : boolean in class org.neo4j.causalclustering.core.consensus.roles.Voting	From	To
Rename Parameter request : RaftMessages.PreVote.Request to req : RaftMessages.PreVote.Request in method public handle(req RaftMessages.PreVote.Request) : Outcome in class org.neo4j.causalclustering.core.consensus.roles.Leader.Handler	From	To

8e12b78d674c8f7893ec8432009cc8bad2ce753d

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: