neo4j 9251c0dced85e34dba1f09d12870d2bd2eafd210

9251c0dced85e34dba1f09d12870d2bd2eafd210

Files Diff

Added: 3
Removed: 1
Renamed: 0
Modified: 94

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	7
Change Parameter Type db : GraphDatabaseAPI to databaseManager : DatabaseManager in method public BoltStateMachineFactoryImpl(databaseManager DatabaseManager, usageData UsageData, availabilityGuard AvailabilityGuard, authentication Authentication, clock Clock, config Config, logging LogService) in class org.neo4j.bolt.runtime.BoltStateMachineFactoryImpl	From	To
Change Parameter Type graphAPI : GraphDatabaseAPI to dataSourceManager : DataSourceManager in method private createKernelData(fileSystem FileSystemAbstraction, pageCache PageCache, storeDir File, config Config, dataSourceManager DataSourceManager, life LifeSupport) : KernelData in class org.neo4j.causalclustering.core.EnterpriseCoreEditionModule	From	To
Change Parameter Type db : GraphDatabaseAPI to dataSourceManager : DataSourceManager in method public HighlyAvailableKernelData(dataSourceManager DataSourceManager, memberInfo ClusterMembers, databaseInfo ClusterDatabaseInfoProvider, fileSystem FileSystemAbstraction, pageCache PageCache, storeDir File, config Config) in class org.neo4j.kernel.ha.management.HighlyAvailableKernelData	From	To
Change Parameter Type graphDb : GraphDatabaseAPI to dataSourceManager : DataSourceManager in method private createKernelData(config Config, dataSourceManager DataSourceManager, members ClusterMembers, fs FileSystemAbstraction, pageCache PageCache, storeDir File, lastUpdateTime LastUpdateTime, txIdGetter LastTxIdGetter, life LifeSupport) : KernelData in class org.neo4j.kernel.ha.factory.HighlyAvailableEditionModule	From	To
Change Parameter Type databaseAPI : GraphDatabaseAPI to dataSourceManager : DataSourceManager in method public KernelData(fs FileSystemAbstraction, pageCache PageCache, storeDir File, configuration Config, dataSourceManager DataSourceManager) in class org.neo4j.kernel.internal.KernelData	From	To
Change Parameter Type db : GraphDatabaseAPI to databaseManager : DatabaseManager in method public BoltServer(databaseManager DatabaseManager, fs FileSystemAbstraction, jobScheduler JobScheduler, availabilityGuard AvailabilityGuard, connectorPortRegister ConnectorPortRegister, connectionTracker NetworkConnectionTracker, usageData UsageData, config Config, clock Clock, monitors Monitors, logService LogService, dependencyResolver DependencyResolver) in class org.neo4j.bolt.BoltServer	From	To
Change Parameter Type db : GraphDatabaseAPI to databaseManager : DatabaseManager in method private newBoltFactory(databaseManager DatabaseManager) : BoltStateMachineFactoryImpl in class org.neo4j.bolt.v1.runtime.BoltStateMachineFactoryImplTest	From	To
Rename Variable	2
Rename Variable exception : RuntimeException to startException : RuntimeException in method package shouldThrowAppropriateExceptionIfStartFails() : void in class org.neo4j.graphdb.facade.GraphDatabaseFacadeFactoryTest	From	To
Rename Variable exception : RuntimeException to initException : RuntimeException in method package shouldThrowAppropriateExceptionIfBothStartAndShutdownFail() : void in class org.neo4j.graphdb.facade.GraphDatabaseFacadeFactoryTest	From	To
Change Return Type	1
Change Return Type GraphDatabaseAPI to DatabaseManager in method private newDbMock() : DatabaseManager in class org.neo4j.bolt.v1.runtime.BoltStateMachineFactoryImplTest	From	To
Move Attribute	1
Move Attribute public graphDatabaseFacade : GraphDatabaseFacade from class org.neo4j.graphdb.factory.module.PlatformModule to private graphDatabaseFacade : GraphDatabaseFacade from class org.neo4j.dmbs.database.DefaultDatabaseManager	From	To
Parameterize Variable	1
Parameterize Variable proxySPI : EmbeddedProxySPI to facade : GraphDatabaseFacade in method private setupProcedures(platform PlatformModule, editionModule EditionModule, facade GraphDatabaseFacade) : Procedures in class org.neo4j.graphdb.facade.GraphDatabaseFacadeFactory	From	To
Rename Attribute	4
Rename Attribute graphDatabaseAPI : GraphDatabaseAPI to dataSourceManager : DataSourceManager in class org.neo4j.kernel.internal.KernelData	From	To
Rename Attribute dir : TestDirectory to testDirectory : TestDirectory in class org.neo4j.graphdb.facade.GraphDatabaseFacadeFactoryTest	From	To
Rename Attribute db : GraphDatabaseAPI to databaseManager : DatabaseManager in class org.neo4j.bolt.BoltServer	From	To
Rename Attribute db : GraphDatabaseAPI to databaseManager : DatabaseManager in class org.neo4j.bolt.runtime.BoltStateMachineFactoryImpl	From	To
Extract Variable	2
Extract Variable databaseName : String in method public makeSureBackupCanBePerformed() : void from class org.neo4j.ha.BackupHaIT	From	To
Extract Variable databaseName : String in method public makeSureBackupCanBePerformedFromAnyInstance() : void from class org.neo4j.ha.BackupHaIT	From	To
Change Variable Type	2
Change Variable Type proxySPI : EmbeddedProxySPI to facade : GraphDatabaseFacade in method private setupProcedures(platform PlatformModule, editionModule EditionModule, facade GraphDatabaseFacade) : Procedures in class org.neo4j.graphdb.facade.GraphDatabaseFacadeFactory	From	To
Change Variable Type db : GraphDatabaseAPI to db : GraphDatabaseFacade in method private newDbMock() : DatabaseManager in class org.neo4j.bolt.v1.runtime.BoltStateMachineFactoryImplTest	From	To
Inline Variable	1
Inline Variable graphDatabaseFacade : GraphDatabaseFacade in method public EnterpriseReadReplicaEditionModule(platformModule PlatformModule, discoveryServiceFactory DiscoveryServiceFactory, myself MemberId) from class org.neo4j.causalclustering.readreplica.EnterpriseReadReplicaEditionModule	From	To
Change Attribute Type	4
Change Attribute Type db : GraphDatabaseAPI to databaseManager : DatabaseManager in class org.neo4j.bolt.runtime.BoltStateMachineFactoryImpl	From	To
Change Attribute Type runningMachines : LinkedList<BoltStateMachine> to runningMachines : List<BoltStateMachine> in class org.neo4j.bolt.v3.runtime.integration.SessionExtension	From	To
Change Attribute Type graphDatabaseAPI : GraphDatabaseAPI to dataSourceManager : DataSourceManager in class org.neo4j.kernel.internal.KernelData	From	To
Change Attribute Type db : GraphDatabaseAPI to databaseManager : DatabaseManager in class org.neo4j.bolt.BoltServer	From	To
Rename Parameter	8
Rename Parameter db : GraphDatabaseAPI to dataSourceManager : DataSourceManager in method public HighlyAvailableKernelData(dataSourceManager DataSourceManager, memberInfo ClusterMembers, databaseInfo ClusterDatabaseInfoProvider, fileSystem FileSystemAbstraction, pageCache PageCache, storeDir File, config Config) in class org.neo4j.kernel.ha.management.HighlyAvailableKernelData	From	To
Rename Parameter databaseAPI : GraphDatabaseAPI to dataSourceManager : DataSourceManager in method public KernelData(fs FileSystemAbstraction, pageCache PageCache, storeDir File, configuration Config, dataSourceManager DataSourceManager) in class org.neo4j.kernel.internal.KernelData	From	To
Rename Parameter graphDb : GraphDatabaseAPI to dataSourceManager : DataSourceManager in method private createKernelData(config Config, dataSourceManager DataSourceManager, members ClusterMembers, fs FileSystemAbstraction, pageCache PageCache, storeDir File, lastUpdateTime LastUpdateTime, txIdGetter LastTxIdGetter, life LifeSupport) : KernelData in class org.neo4j.kernel.ha.factory.HighlyAvailableEditionModule	From	To
Rename Parameter name : String to databaseName : String in method private backupArguments(from String, backupDir File, databaseName String) : String[] in class org.neo4j.ha.BackupHaIT	From	To
Rename Parameter db : GraphDatabaseAPI to databaseManager : DatabaseManager in method public BoltServer(databaseManager DatabaseManager, fs FileSystemAbstraction, jobScheduler JobScheduler, availabilityGuard AvailabilityGuard, connectorPortRegister ConnectorPortRegister, connectionTracker NetworkConnectionTracker, usageData UsageData, config Config, clock Clock, monitors Monitors, logService LogService, dependencyResolver DependencyResolver) in class org.neo4j.bolt.BoltServer	From	To
Rename Parameter db : GraphDatabaseAPI to databaseManager : DatabaseManager in method private newBoltFactory(databaseManager DatabaseManager) : BoltStateMachineFactoryImpl in class org.neo4j.bolt.v1.runtime.BoltStateMachineFactoryImplTest	From	To
Rename Parameter graphAPI : GraphDatabaseAPI to dataSourceManager : DataSourceManager in method private createKernelData(fileSystem FileSystemAbstraction, pageCache PageCache, storeDir File, config Config, dataSourceManager DataSourceManager, life LifeSupport) : KernelData in class org.neo4j.causalclustering.core.EnterpriseCoreEditionModule	From	To
Rename Parameter db : GraphDatabaseAPI to databaseManager : DatabaseManager in method public BoltStateMachineFactoryImpl(databaseManager DatabaseManager, usageData UsageData, availabilityGuard AvailabilityGuard, authentication Authentication, clock Clock, config Config, logging LogService) in class org.neo4j.bolt.runtime.BoltStateMachineFactoryImpl	From	To

9251c0dced85e34dba1f09d12870d2bd2eafd210

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: