neo4j 99c86bc03b770a8b90b6a5e2953a9bf47cd1c240

99c86bc03b770a8b90b6a5e2953a9bf47cd1c240

Files Diff

Added: 5
Removed: 6
Renamed: 0
Modified: 102

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	2
Rename Method private moveMigratedFilesToWorkingDirectory(participantsNeedingMigration Iterable<StoreMigrationParticipant>, migrationDirectory File, workingDirectory File) : void renamed to private moveMigratedFilesToStoreDirectory(participants Iterable<StoreMigrationParticipant>, migrationDirectory File, storeDirectory File, versionToMigrateFrom String) : void in class org.neo4j.kernel.impl.storemigration.StoreUpgrader	From	To
Rename Method public shouldBeAbleToResumeMigration() : void renamed to public shouldBeAbleToResumeMigrationOnMoving() : void in class org.neo4j.kernel.impl.storemigration.StoreMigratorTest	From	To
Rename Variable	1
Rename Variable actualVersion : String to storeVersion : String in method public hasVersion(neostoreFile File, expectedVersion String) : Result in class org.neo4j.kernel.impl.storemigration.StoreVersionCheck	From	To
Change Return Type	1
Change Return Type void to boolean in method package trailer(writer KeyValueWriter, zeroValue boolean) : boolean in class org.neo4j.kernel.impl.store.kvstore.KeyValueWriter.State	From	To
Move Attribute	9
Move Attribute public fs : EphemeralFileSystemRule from class org.neo4j.kernel.impl.store.StoreVersionTrailerUtilTest to public fs : EphemeralFileSystemRule from class org.neo4j.kernel.impl.storemigration.StoreVersionCheckTest	From	To
Move Attribute private fs : FileSystemAbstraction from class org.neo4j.kernel.impl.storemigration.legacystore.v21.Legacy21Store to private fs : FileSystemAbstraction from class org.neo4j.kernel.impl.storemigration.legacystore.LegacyStoreVersionCheck	From	To
Move Attribute private idGeneratorFactory : IdGeneratorFactory from class org.neo4j.kernel.impl.store.TestDynamicStore to private idGeneratorFactory : IdGeneratorFactory from class org.neo4j.kernel.impl.store.CommonAbstractStoreTest	From	To
Move Attribute private fs : FileSystemAbstraction from class org.neo4j.kernel.impl.storemigration.legacystore.v21.Legacy21Store to private fs : FileSystemAbstraction from class upgrade.StoreUpgraderInterruptionTestIT	From	To
Move Attribute public fs : EphemeralFileSystemRule from class org.neo4j.kernel.impl.store.StoreVersionTest to public fs : EphemeralFileSystemRule from class org.neo4j.kernel.impl.storemigration.StoreVersionCheckTest	From	To
Move Attribute private pageCache : PageCache from class org.neo4j.kernel.impl.storemigration.SchemaIndexMigrator to private pageCache : PageCache from class org.neo4j.kernel.impl.store.CommonAbstractStoreTest	From	To
Move Attribute private fs : FileSystemAbstraction from class org.neo4j.kernel.impl.storemigration.legacystore.v22.Legacy22Store to private fs : FileSystemAbstraction from class upgrade.StoreUpgraderInterruptionTestIT	From	To
Move Attribute private fs : FileSystemAbstraction from class org.neo4j.kernel.impl.storemigration.legacystore.v22.Legacy22Store to private fs : FileSystemAbstraction from class org.neo4j.kernel.impl.storemigration.legacystore.LegacyStoreVersionCheck	From	To
Move Attribute private pageCache : PageCache from class org.neo4j.kernel.impl.store.TestDynamicStore to private pageCache : PageCache from class org.neo4j.kernel.impl.store.CommonAbstractStoreTest	From	To
Rename Attribute	1
Rename Attribute fileSystem : FileSystemAbstraction to fs : FileSystemAbstraction in class upgrade.StoreUpgraderInterruptionTestIT	From	To
Extract Variable	5
Extract Variable nodeLabelStore : DynamicArrayStore in method public getNodeStore() : NodeStore from class org.neo4j.kernel.impl.store.NeoStores	From	To
Extract Variable storeFactory : StoreFactory in method public upgradedNeoStoreShouldHaveNewUpgradeTimeAndUpgradeId() : void from class upgrade.StoreUpgraderTest	From	To
Extract Variable result : StoreVersionCheck.Result in method public shouldReportShortFileDoesNotHaveSpecifiedVersion() : void from class org.neo4j.kernel.impl.storemigration.StoreVersionCheckTest	From	To
Extract Variable record : long in method public checkVersion() : void from class org.neo4j.kernel.impl.store.MetaDataStore	From	To
Extract Variable logProvider : NullLogProvider in method private openStore(storeDir File, config Config, pageCache PageCache) : StoreFactory from class org.neo4j.kernel.impl.util.rawstorereader.RsdrMain	From	To
Extract Method	1
Extract Method private doWrite(key BigEndianByteArrayBuffer, value BigEndianByteArrayBuffer, expectedNextState State) : void extracted from public writeHeader(key BigEndianByteArrayBuffer, value BigEndianByteArrayBuffer) : boolean in class org.neo4j.kernel.impl.store.kvstore.KeyValueWriter	From	To
Rename Parameter	6
Rename Parameter storeFile : File to neostoreFile : File in method public hasVersion(neostoreFile File, expectedVersion String) : Result in class org.neo4j.kernel.impl.storemigration.StoreVersionCheck	From	To
Rename Parameter participantsNeedingMigration : Iterable<StoreMigrationParticipant> to participants : Iterable<StoreMigrationParticipant> in method private moveMigratedFilesToStoreDirectory(participants Iterable<StoreMigrationParticipant>, migrationDirectory File, storeDirectory File, versionToMigrateFrom String) : void in class org.neo4j.kernel.impl.storemigration.StoreUpgrader	From	To
Rename Parameter blockSizeFromConfiguration : int to blockSize : int in method public DynamicArrayStore(fileName File, configuration Config, idType IdType, idGeneratorFactory IdGeneratorFactory, pageCache PageCache, logProvider LogProvider, blockSize int) in class org.neo4j.kernel.impl.store.DynamicArrayStore	From	To
Rename Parameter blockSizeFromConfiguration : int to blockSize : int in method public DynamicStringStore(fileName File, configuration Config, idType IdType, idGeneratorFactory IdGeneratorFactory, pageCache PageCache, logProvider LogProvider, blockSize int) in class org.neo4j.kernel.impl.store.DynamicStringStore	From	To
Rename Parameter workingDirectory : File to storeDirectory : File in method private moveMigratedFilesToStoreDirectory(participants Iterable<StoreMigrationParticipant>, migrationDirectory File, storeDirectory File, versionToMigrateFrom String) : void in class org.neo4j.kernel.impl.storemigration.StoreUpgrader	From	To
Rename Parameter fs : FileSystemAbstraction to fileSystem : FileSystemAbstraction in method public StoreFactory(fileSystem FileSystemAbstraction, storeDir File, pageCache PageCache, logProvider LogProvider) in class org.neo4j.kernel.impl.store.StoreFactory	From	To

99c86bc03b770a8b90b6a5e2953a9bf47cd1c240

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: