9b0c8d9dab3c60246db38024b63cac42cceba496
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public shouldCloseSessionOnChannelClose() : void renamed to public shouldCloseProtocolOnChannelInactive() : void in class org.neo4j.bolt.v1.transport.socket.SocketTransportHandlerTest | From | To | |
| Rename Method public logsAndClosesConnectionOnUnexpectedExceptions() : void renamed to public logsAndClosesProtocolOnUnexpectedExceptions() : void in class org.neo4j.bolt.v1.transport.socket.SocketTransportHandlerTest | From | To | |
| Rename Variable | 6 | ||
| Rename Variable boltConnectionManagerFactory : BoltFactory to boltFactory : BoltFactory in method public newInstance(context KernelContext, dependencies Dependencies) : Lifecycle in class org.neo4j.bolt.BoltKernelExtension | From | To | |
| Rename Variable ch : Channel to channel : Channel in method private channelHandlerContextMock() : ChannelHandlerContext in class org.neo4j.bolt.v1.transport.socket.SocketTransportHandlerTest | From | To | |
| Rename Variable ctx : ChannelHandlerContext to context : ChannelHandlerContext in method private channelHandlerContextMock() : ChannelHandlerContext in class org.neo4j.bolt.v1.transport.socket.SocketTransportHandlerTest | From | To | |
| Rename Variable threadedSessions : ThreadedWorkerFactory to threadedWorkerFactory : WorkerFactory in method protected createWorkerFactory(boltFactory BoltFactory, scheduler JobScheduler, dependencies Dependencies, logService LogService) : WorkerFactory in class org.neo4j.bolt.BoltKernelExtension | From | To | |
| Change Return Type | 1 | ||
| Change Return Type SocketTransportHandler.ProtocolChooser to ProtocolChooser in method private protocolChooser(machine BoltStateMachine) : ProtocolChooser in class org.neo4j.bolt.v1.transport.socket.SocketTransportHandlerTest | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable boltConnectionManagerFactory : BoltFactory to boltFactory : BoltFactory in method protected createWorkerFactory(boltFactory BoltFactory, scheduler JobScheduler, dependencies Dependencies, logService LogService) : WorkerFactory in class org.neo4j.bolt.BoltKernelExtension | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type threadedSessions : ThreadedWorkerFactory to threadedWorkerFactory : WorkerFactory in method protected createWorkerFactory(boltFactory BoltFactory, scheduler JobScheduler, dependencies Dependencies, logService LogService) : WorkerFactory in class org.neo4j.bolt.BoltKernelExtension | From | To | |
| Extract Method | 4 | ||
| Extract Method private channelHandlerContextMock() : ChannelHandlerContext extracted from public shouldCloseSessionOnChannelClose() : void in class org.neo4j.bolt.v1.transport.socket.SocketTransportHandlerTest | From | To | |
| Extract Method private channelHandlerContextMock() : ChannelHandlerContext extracted from public logsAndClosesConnectionOnUnexpectedExceptions() : void in class org.neo4j.bolt.v1.transport.socket.SocketTransportHandlerTest | From | To | |
| Extract Method protected createWorkerFactory(boltFactory BoltFactory, scheduler JobScheduler, dependencies Dependencies, logService LogService) : WorkerFactory extracted from public newInstance(context KernelContext, dependencies Dependencies) : Lifecycle in class org.neo4j.bolt.BoltKernelExtension | From | To | |
| Extract Method private newSocketTransportHandler(protocolChooser ProtocolChooser) : SocketTransportHandler extracted from public shouldCloseSessionOnChannelClose() : void in class org.neo4j.bolt.v1.transport.socket.SocketTransportHandlerTest | From | To |