9d2e4659459370b07ea3527514980f718b2db93b
Files Diff
- Added: 4
- Removed: 2
- Renamed: 0
- Modified: 48
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private padIdMapperMemoryEstimate(calculateMemoryUsage long) : long renamed to private defensivelyPadMemoryEstimate(bytes long) : long in class org.neo4j.unsafe.impl.batchimport.staging.HumanUnderstandableExecutionMonitor | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method public sources(sources RawIterator<Reader,IOException>) : CharReadable moved from class org.neo4j.csv.reader.Readables to class org.neo4j.csv.reader.MultiReadableTest & inlined to public shouldTrackAbsolutePosition() : void | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type actual : RawIterator<Reader,IOException> to readers : RawIterator<CharReadable,IOException> in method public MultiReadable(readers RawIterator<CharReadable,IOException>) in class org.neo4j.csv.reader.MultiReadable | From | To | |
| Change Parameter Type stores : NeoStores to stores : BatchingNeoStores in method private initializeMisc(stores BatchingNeoStores) : void in class org.neo4j.unsafe.impl.batchimport.staging.HumanUnderstandableExecutionMonitor | From | To | |
| Rename Variable | 1 | ||
| Rename Variable idSize : int to trackerSize : int in method public calculateMemoryUsage(numberOfNodes long) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
| Change Return Type | 4 | ||
| Change Return Type RawIterator<Reader,IOException> to RawIterator<CharReadable,IOException> in method private readerIteratorFromStrings(data String[][], lineEnding Character) : RawIterator<CharReadable,IOException> in class org.neo4j.csv.reader.MultiReadableTest | From | To | |
| Change Return Type CharReadable to RawIterator<CharReadable,IOException> in method public stream() : RawIterator<CharReadable,IOException> in class org.neo4j.unsafe.impl.batchimport.input.csv.Data | From | To | |
| Change Return Type Reader to CharReadable in method public apply(file File) : CharReadable in class org.neo4j.csv.reader.Readables.FromFile | From | To | |
| Change Return Type int to void in method private printDots(from int, target int) : void in class org.neo4j.unsafe.impl.batchimport.staging.HumanUnderstandableExecutionMonitor | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private position : long from class org.neo4j.csv.reader.MultiReadable to private position : long from class org.neo4j.csv.reader.WrappedCharReadable | From | To | |
| Move Attribute private dependencies : Dependencies from class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter to private dependencies : Dependencies from class org.neo4j.unsafe.impl.batchimport.ImportLogic | From | To | |
| Move Class | 2 | ||
| Move Class org.neo4j.unsafe.impl.batchimport.store.BatchingIdSequenceTest moved to org.neo4j.kernel.impl.store.id.BatchingIdSequenceTest | From | To | |
| Move Class org.neo4j.unsafe.impl.batchimport.store.BatchingIdSequence moved to org.neo4j.kernel.impl.store.id.BatchingIdSequence | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type opener : IOFunction<File,Reader> to opener : IOFunction<File,CharReadable> in method public files(charset Charset, files File...) : CharReadable in class org.neo4j.csv.reader.Readables | From | To | |
| Change Variable Type readers : RawIterator<Reader,IOException> to readers : RawIterator<CharReadable,IOException> in method public shouldReadFromMultipleReaders() : void in class org.neo4j.csv.reader.MultiReadableTest | From | To | |
| Change Variable Type readers : RawIterator<Reader,IOException> to readers : RawIterator<CharReadable,IOException> in method public shouldTrackAbsolutePosition() : void in class org.neo4j.csv.reader.MultiReadableTest | From | To | |
| Change Variable Type readers : RawIterator<Reader,IOException> to readers : RawIterator<CharReadable,IOException> in method public shouldHandleSourcesEndingWithNewLine() : void in class org.neo4j.csv.reader.MultiReadableTest | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type current : Reader to current : CharReadable in class org.neo4j.csv.reader.MultiReadable | From | To | |
| Change Attribute Type actual : RawIterator<Reader,IOException> to actual : RawIterator<CharReadable,IOException> in class org.neo4j.csv.reader.MultiReadable | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public wrap(data String) : CharReadable extracted from private seeker(data String) : CharSeeker in class org.neo4j.unsafe.impl.batchimport.input.csv.DataFactoriesTest & moved to class org.neo4j.csv.reader.Readables | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter current : int to from : int in method private printDots(from int, target int) : void in class org.neo4j.unsafe.impl.batchimport.staging.HumanUnderstandableExecutionMonitor | From | To | |
| Rename Parameter calculateMemoryUsage : long to bytes : long in method private defensivelyPadMemoryEstimate(bytes long) : long in class org.neo4j.unsafe.impl.batchimport.staging.HumanUnderstandableExecutionMonitor | From | To | |
| Rename Parameter actual : RawIterator<Reader,IOException> to readers : RawIterator<CharReadable,IOException> in method public MultiReadable(readers RawIterator<CharReadable,IOException>) in class org.neo4j.csv.reader.MultiReadable | From | To |