9f07dd536ca6502f09b6a71215ca7e081dbe8049
Files Diff
- Added: 3
- Removed: 2
- Renamed: 0
- Modified: 12
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method private importRelationships(nodeRelationshipCache NodeRelationshipCache, storeUpdateMonitor CountingStoreUpdateMonitor, neoStore BatchingNeoStores, writeMonitor IoMonitor, idMapper IdMapper, relationships InputIterable<InputRelationship>, typeDistribution RelationshipTypeDistribution, freeMemoryForDenseNodeCache long) : void renamed to private linkRelationships(nodeRelationshipCache NodeRelationshipCache, neoStore BatchingNeoStores, typeDistribution RelationshipTypeDistribution, freeMemoryForDenseNodeCache long) : void in class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter | From | To | |
Pull Up Method | 2 | ||
Pull Up Method protected forkedProcess(id int, processors int, batch RelationshipRecord[]) : void from class org.neo4j.unsafe.impl.batchimport.RelationshipLinkbackStep to protected forkedProcess(id int, processors int, batch RelationshipRecord[]) : void from class org.neo4j.unsafe.impl.batchimport.RelationshipLinkStep | From | To | |
Pull Up Method public process(record RelationshipRecord, id int, processors int) : boolean from class org.neo4j.unsafe.impl.batchimport.RelationshipLinkbackStep to public process(record RelationshipRecord, id int, processors int) : boolean from class org.neo4j.unsafe.impl.batchimport.RelationshipLinkStep | From | To | |
Change Parameter Type | 1 | ||
Change Parameter Type relationships : InputIterator<InputRelationship> to relationships : InputIterable<InputRelationship> in method public RelationshipStage(config Configuration, writeMonitor IoMonitor, relationships InputIterable<InputRelationship>, idMapper IdMapper, badCollector Collector, inputCache InputCache, cache NodeRelationshipCache, neoStore BatchingNeoStores, storeUpdateMonitor EntityStoreUpdaterStep.Monitor) in class org.neo4j.unsafe.impl.batchimport.RelationshipStage | From | To | |
Move Method | 1 | ||
Move Method public getDistribution() : RelationshipTypeDistribution from class org.neo4j.unsafe.impl.batchimport.CalculateDenseNodesStage to public getDistribution() : RelationshipTypeDistribution from class org.neo4j.unsafe.impl.batchimport.RelationshipStage | From | To | |
Rename Variable | 4 | ||
Rename Variable typesToImportThisRound : Collection<Object> to typesToLinkThisRound : Collection<Object> in method private linkRelationships(nodeRelationshipCache NodeRelationshipCache, neoStore BatchingNeoStores, typeDistribution RelationshipTypeDistribution, freeMemoryForDenseNodeCache long) : void in class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter | From | To | |
Rename Variable calculateDenseNodesStage : CalculateDenseNodesStage to unlinkedRelationshipStage : RelationshipStage in method public doImport(input Input) : void in class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter | From | To | |
Rename Variable nextRelationshipId : long to readFilter : Predicate<RelationshipRecord> in method private linkRelationships(nodeRelationshipCache NodeRelationshipCache, neoStore BatchingNeoStores, typeDistribution RelationshipTypeDistribution, freeMemoryForDenseNodeCache long) : void in class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter | From | To | |
Rename Variable relationshipStage : RelationshipStage to linkForwardStage : RelationshipLinkforwardStage in method private linkRelationships(nodeRelationshipCache NodeRelationshipCache, neoStore BatchingNeoStores, typeDistribution RelationshipTypeDistribution, freeMemoryForDenseNodeCache long) : void in class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter | From | To | |
Pull Up Attribute | 2 | ||
Pull Up Attribute private nodeTypes : int from class org.neo4j.unsafe.impl.batchimport.RelationshipLinkbackStep to private nodeTypes : int from class org.neo4j.unsafe.impl.batchimport.RelationshipLinkStep | From | To | |
Pull Up Attribute private cache : NodeRelationshipCache from class org.neo4j.unsafe.impl.batchimport.RelationshipLinkbackStep to protected cache : NodeRelationshipCache from class org.neo4j.unsafe.impl.batchimport.RelationshipLinkStep | From | To | |
Move Attribute | 1 | ||
Move Attribute private typer : RelationshipTypeCheckerStep from class org.neo4j.unsafe.impl.batchimport.CalculateDenseNodesStage to private typer : RelationshipTypeCheckerStep from class org.neo4j.unsafe.impl.batchimport.RelationshipStage | From | To | |
Extract Superclass | 1 | ||
Extract Superclass org.neo4j.unsafe.impl.batchimport.RelationshipLinkStep from classes [org.neo4j.unsafe.impl.batchimport.RelationshipLinkbackStep] | From | To | |
Rename Attribute | 1 | ||
Rename Attribute idAssigner : AssignRelationshipIdBatchStep to typer : RelationshipTypeCheckerStep in class org.neo4j.unsafe.impl.batchimport.RelationshipStage | From | To | |
Change Variable Type | 3 | ||
Change Variable Type calculateDenseNodesStage : CalculateDenseNodesStage to unlinkedRelationshipStage : RelationshipStage in method public doImport(input Input) : void in class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter | From | To | |
Change Variable Type nextRelationshipId : long to readFilter : Predicate<RelationshipRecord> in method private linkRelationships(nodeRelationshipCache NodeRelationshipCache, neoStore BatchingNeoStores, typeDistribution RelationshipTypeDistribution, freeMemoryForDenseNodeCache long) : void in class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter | From | To | |
Change Variable Type relationshipStage : RelationshipStage to linkForwardStage : RelationshipLinkforwardStage in method private linkRelationships(nodeRelationshipCache NodeRelationshipCache, neoStore BatchingNeoStores, typeDistribution RelationshipTypeDistribution, freeMemoryForDenseNodeCache long) : void in class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter | From | To | |
Extract Method | 1 | ||
Extract Method private shouldChange(isDense boolean, record RelationshipRecord) : boolean extracted from public process(record RelationshipRecord, id int, processors int) : boolean in class org.neo4j.unsafe.impl.batchimport.RelationshipLinkStep | From | To | |
Change Attribute Type | 1 | ||
Change Attribute Type idAssigner : AssignRelationshipIdBatchStep to typer : RelationshipTypeCheckerStep in class org.neo4j.unsafe.impl.batchimport.RelationshipStage | From | To |