a188039cbcc1a3569f7426ff3bc763a1906e90d0
Files Diff
- Added: 8
- Removed: 3
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Extract Subclass | 2 | ||
| Extract Subclass org.neo4j.causalclustering.core.ClusterBindingHandler from class org.neo4j.causalclustering.core.state.RaftMessageHandler | From | To | |
| Extract Subclass org.neo4j.causalclustering.core.state.RaftMessageApplier from class org.neo4j.causalclustering.core.state.RaftMessageHandler | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type handler : MessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> to handler : LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> in method package BatchingMessageHandler(handler LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage>, queueSize int, maxBatch int, jobSchedulerFactory Function<Runnable,ContinuousJob>, logProvider LogProvider) in class org.neo4j.causalclustering.core.BatchingMessageHandler | From | To | |
| Change Parameter Type raftMessageHandler : Inbound.MessageHandler<RaftMessages.ClusterIdAwareMessage> to raftMessageHandler : LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> in method public RaftMessageMonitoringHandler(raftMessageHandler LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage>, clock Clock, monitors Monitors) in class org.neo4j.causalclustering.core.consensus.RaftMessageMonitoringHandler | From | To | |
| Change Parameter Type delegateHandler : Inbound.MessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> to delegateHandler : LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> in method public LeaderAvailabilityHandler(delegateHandler LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage>, leaderAvailabilityTimers LeaderAvailabilityTimers, term LongSupplier) in class org.neo4j.causalclustering.core.consensus.LeaderAvailabilityHandler | From | To | |
| Change Parameter Type raftMessageHandler : RaftMessageHandler to raftMessageHandler : LifecycleMessageHandler<?> in method public CoreLife(raftMachine RaftMachine, localDatabase LocalDatabase, clusterBinder ClusterBinder, commandApplicationProcess CommandApplicationProcess, coreStateMachines CoreStateMachines, raftMessageHandler LifecycleMessageHandler<?>, snapshotService CoreSnapshotService) in class org.neo4j.causalclustering.core.state.CoreLife | From | To | |
| Move Method | 4 | ||
| Move Method public shouldDelegateMessages() : void from class org.neo4j.causalclustering.core.consensus.LeaderAvailabilityHandlerTest to public shouldDelegateMessages() : void from class org.neo4j.causalclustering.core.ClusterBindingHandlerTest | From | To | |
| Move Method public shouldDropMessagesIfHasBeenStopped() : void from class org.neo4j.causalclustering.core.consensus.LeaderAvailabilityHandlerTest to public shouldDropMessagesIfHasBeenStopped() : void from class org.neo4j.causalclustering.core.ClusterBindingHandlerTest | From | To | |
| Move Method public shouldDropMessagesIfForDifferentClusterId() : void from class org.neo4j.causalclustering.core.consensus.LeaderAvailabilityHandlerTest to public shouldDropMessagesIfForDifferentClusterId() : void from class org.neo4j.causalclustering.core.ClusterBindingHandlerTest | From | To | |
| Move Method public shouldDropMessagesIfHasNotBeenStarted() : void from class org.neo4j.causalclustering.core.consensus.LeaderAvailabilityHandlerTest to public shouldDropMessagesIfHasNotBeenStarted() : void from class org.neo4j.causalclustering.core.ClusterBindingHandlerTest | From | To | |
| Push Down Attribute | 6 | ||
| Push Down Attribute private applicationProcess : CommandApplicationProcess from class org.neo4j.causalclustering.core.state.RaftMessageHandler to private applicationProcess : CommandApplicationProcess from class org.neo4j.causalclustering.core.state.RaftMessageApplier | From | To | |
| Push Down Attribute private localDatabase : LocalDatabase from class org.neo4j.causalclustering.core.state.RaftMessageHandler to private localDatabase : LocalDatabase from class org.neo4j.causalclustering.core.state.RaftMessageApplier | From | To | |
| Push Down Attribute private log : Log from class org.neo4j.causalclustering.core.state.RaftMessageHandler to private log : Log from class org.neo4j.causalclustering.core.ClusterBindingHandler | From | To | |
| Push Down Attribute private downloadService : CoreStateDownloaderService from class org.neo4j.causalclustering.core.state.RaftMessageHandler to private downloadService : CoreStateDownloaderService from class org.neo4j.causalclustering.core.state.RaftMessageApplier | From | To | |
| Push Down Attribute private raftMachine : RaftMachine from class org.neo4j.causalclustering.core.state.RaftMessageHandler to private raftMachine : RaftMachine from class org.neo4j.causalclustering.core.state.RaftMessageApplier | From | To | |
| Push Down Attribute private boundClusterId : ClusterId from class org.neo4j.causalclustering.core.state.RaftMessageHandler to private boundClusterId : ClusterId from class org.neo4j.causalclustering.core.ClusterBindingHandler | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private boundClusterId : ClusterId from class org.neo4j.causalclustering.core.consensus.LeaderAvailabilityHandler to private boundClusterId : ClusterId from class org.neo4j.causalclustering.core.ClusterBindingHandler | From | To | |
| Move Attribute private log : Log from class org.neo4j.causalclustering.core.consensus.LeaderAvailabilityHandler to private log : Log from class org.neo4j.causalclustering.core.ClusterBindingHandler | From | To | |
| Move Attribute private localDatabase : LocalDatabase from class org.neo4j.causalclustering.core.state.RaftMessageHandler to private localDatabase : LocalDatabase from class org.neo4j.causalclustering.core.server.CoreServerModule | From | To | |
| Move Attribute private downloadService : CoreStateDownloaderService from class org.neo4j.causalclustering.core.state.RaftMessageHandler to private downloadService : CoreStateDownloaderService from class org.neo4j.causalclustering.core.server.CoreServerModule | From | To | |
| Extract Class | 1 | ||
| Extract Class org.neo4j.causalclustering.core.ClusterBindingHandlerTest from class org.neo4j.causalclustering.core.consensus.LeaderAvailabilityHandlerTest | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.neo4j.causalclustering.core.state.RaftMessageHandler moved and renamed to org.neo4j.causalclustering.messaging.LifecycleMessageHandler | From | To | |
| Move Class | 2 | ||
| Move Class org.neo4j.causalclustering.core.server.BatchingMessageHandler moved to org.neo4j.causalclustering.core.BatchingMessageHandler | From | To | |
| Move Class org.neo4j.causalclustering.core.server.BatchingMessageHandlerTest moved to org.neo4j.causalclustering.core.BatchingMessageHandlerTest | From | To | |
| Inline Variable | 1 | ||
| Inline Variable config : Config in method public CoreServerModule(identityModule IdentityModule, platformModule PlatformModule, consensusModule ConsensusModule, coreStateMachinesModule CoreStateMachinesModule, replicationModule ReplicationModule, clusterStateDirectory File, clusteringModule ClusteringModule, localDatabase LocalDatabase, messageLogger MessageLogger<MemberId>, dbHealthSupplier Supplier<DatabaseHealth>, sslPolicy SslPolicy) from class org.neo4j.causalclustering.core.server.CoreServerModule | From | To | |
| Extract Method | 1 | ||
| Extract Method private createMembershipWaiterLifecycle() : MembershipWaiterLifecycle extracted from public CoreServerModule(identityModule IdentityModule, platformModule PlatformModule, consensusModule ConsensusModule, coreStateMachinesModule CoreStateMachinesModule, replicationModule ReplicationModule, clusterStateDirectory File, clusteringModule ClusteringModule, localDatabase LocalDatabase, messageLogger MessageLogger<MemberId>, dbHealthSupplier Supplier<DatabaseHealth>, sslPolicy SslPolicy) in class org.neo4j.causalclustering.core.server.CoreServerModule | From | To | |
| Push Down Method | 3 | ||
| Push Down Method package stop() : void from class org.neo4j.causalclustering.core.state.RaftMessageHandler to public stop() : void from class org.neo4j.causalclustering.core.ClusterBindingHandler | From | To | |
| Push Down Method package start(clusterId ClusterId) : void from class org.neo4j.causalclustering.core.state.RaftMessageHandler to public start(clusterId ClusterId) : void from class org.neo4j.causalclustering.core.ClusterBindingHandler | From | To | |
| Push Down Method private notifyCommitted(commitIndex long) : void from class org.neo4j.causalclustering.core.state.RaftMessageHandler to private notifyCommitted(commitIndex long) : void from class org.neo4j.causalclustering.core.state.RaftMessageApplier | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.neo4j.causalclustering.messaging.LifecycleMessageHandler from classes [org.neo4j.causalclustering.core.BatchingMessageHandler, org.neo4j.causalclustering.core.consensus.LeaderAvailabilityHandler] | From | To | |
| Change Attribute Type | 7 | ||
| Change Attribute Type delegateHandler : Inbound.MessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> to delegateHandler : LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> in class org.neo4j.causalclustering.core.consensus.LeaderAvailabilityHandler | From | To | |
| Change Attribute Type raftMessageHandler : Inbound.MessageHandler<RaftMessages.ClusterIdAwareMessage> to raftMessageHandler : LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> in class org.neo4j.causalclustering.core.consensus.RaftMessageMonitoringHandler | From | To | |
| Change Attribute Type downstreamHandler : MessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> to downstreamHandler : LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> in class org.neo4j.causalclustering.core.BatchingMessageHandlerTest | From | To | |
| Change Attribute Type raftMessageHandler : RaftMessageHandler to raftMessageHandler : LifecycleMessageHandler<?> in class org.neo4j.causalclustering.core.state.CoreLife | From | To | |
| Change Attribute Type delegate : Inbound.MessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> to delegate : LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> in class org.neo4j.causalclustering.core.consensus.LeaderAvailabilityHandlerTest | From | To | |
| Change Attribute Type downstream : Inbound.MessageHandler<RaftMessages.ClusterIdAwareMessage> to downstream : LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> in class org.neo4j.causalclustering.core.consensus.RaftMessageMonitoringHandlerTest | From | To | |
| Change Attribute Type handler : MessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> to handler : LifecycleMessageHandler<RaftMessages.ReceivedInstantClusterIdAwareMessage> in class org.neo4j.causalclustering.core.BatchingMessageHandler | From | To |