a56eb15e7b59f2fdb838d9e783f283ccb87dae6c
Files Diff
- Added: 2
- Removed: 2
- Renamed: 0
- Modified: 28
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 4 | ||
Rename Method public badRelationshipsCollector(out OutputStream) : Collector<InputRelationship> renamed to public badCollector(out OutputStream) : Collector in class org.neo4j.unsafe.impl.batchimport.input.csv.CsvInput | From | To | |
Rename Method public badRelationshipsCollector(out OutputStream) : Collector<InputRelationship> renamed to public badCollector(out OutputStream) : Collector in class org.neo4j.tooling.CsvDataGeneratorInput | From | To | |
Rename Method public badRelationshipsCollector(out OutputStream) : Collector<InputRelationship> renamed to public badCollector(out OutputStream) : Collector in class org.neo4j.unsafe.impl.batchimport.input.Input | From | To | |
Rename Method public badRelationships(tolerance int) : Function<OutputStream,Collector<InputRelationship>> renamed to public badCollector(tolerance int, collect int) : Function<OutputStream,Collector> in class org.neo4j.unsafe.impl.batchimport.input.Collectors | From | To | |
Move And Inline Method | 1 | ||
Move And Inline Method public accept(value int) : boolean moved from class org.neo4j.unsafe.impl.batchimport.input.Group.Adapter to class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper & inlined to private findFromCollisions(fromIndex long, toIndex long, groupId int, inputId Object) : long | From | To | |
Change Parameter Type | 6 | ||
Change Parameter Type inGroup : PrimitiveIntPredicate to groupId : int in method private binarySearch(inputId Object, groupId int) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
Change Parameter Type inGroup : PrimitiveIntPredicate to groupId : int in method private binarySearch(x long, inputId Object, low long, high long, groupId int) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
Change Parameter Type badRelationships : Collector<InputRelationship> to badCollector : Collector in method public CalculateDenseNodePrepareStep(control StageControl, config Configuration, badCollector Collector) in class org.neo4j.unsafe.impl.batchimport.CalculateDenseNodePrepareStep | From | To | |
Change Parameter Type badRelationshipsCollector : Collector<InputRelationship> to badCollector : Collector in method public CalculateDenseNodesStage(relationships InputIterable<InputRelationship>, cache NodeRelationshipCache, idMapper IdMapper, badCollector Collector, inputCache InputCache) in class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter.CalculateDenseNodesStage | From | To | |
Change Parameter Type inGroup : PrimitiveIntPredicate to groupId : int in method private findFromCollisions(index long, inputId Object, groupId int) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
Change Parameter Type collectorFactory : Function<OutputStream,Collector<InputRelationship>> to collectorFactory : Function<OutputStream,Collector> in method public CsvInput(nodeDataFactory Iterable<DataFactory<InputNode>>, nodeHeaderFactory Header.Factory, relationshipDataFactory Iterable<DataFactory<InputRelationship>>, relationshipHeaderFactory Header.Factory, idType IdType, config Configuration, collectorFactory Function<OutputStream,Collector>) in class org.neo4j.unsafe.impl.batchimport.input.csv.CsvInput | From | To | |
Rename Variable | 4 | ||
Rename Variable hasBadRelationships : boolean to hasBadEntries : boolean in method public doImport(input Input) : void in class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter | From | To | |
Rename Variable badRelationships : File to badFile : File in method public main(incomingArguments String[], defaultSettingsSuitableForTests boolean) : void in class org.neo4j.tooling.ImportTool | From | To | |
Rename Variable found : long to lowestFound : long in method private findFromCollisions(fromIndex long, toIndex long, groupId int, inputId Object) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
Rename Variable badRelationships : Collector<InputRelationship> to badCollector : Collector in method public doImport(input Input) : void in class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter | From | To | |
Change Return Type | 4 | ||
Change Return Type Collector<InputRelationship> to Collector in method public badCollector(out OutputStream) : Collector in class org.neo4j.tooling.CsvDataGeneratorInput | From | To | |
Change Return Type Collector<InputRelationship> to Collector in method public badCollector(out OutputStream) : Collector in class org.neo4j.unsafe.impl.batchimport.input.csv.CsvInput | From | To | |
Change Return Type Collector<InputRelationship> to Collector in method public badCollector(out OutputStream) : Collector in class org.neo4j.unsafe.impl.batchimport.input.Input | From | To | |
Change Return Type Function<OutputStream,Collector<InputRelationship>> to Function<OutputStream,Collector> in method public badCollector(tolerance int, collect int) : Function<OutputStream,Collector> in class org.neo4j.unsafe.impl.batchimport.input.Collectors | From | To | |
Rename Class | 1 | ||
Rename Class org.neo4j.unsafe.impl.batchimport.input.BadRelationshipsCollector renamed to org.neo4j.unsafe.impl.batchimport.input.BadCollector | From | To | |
Rename Attribute | 1 | ||
Rename Attribute badRelationships : Collector<InputRelationship> to badCollector : Collector in class org.neo4j.unsafe.impl.batchimport.CalculateDenseNodePrepareStep | From | To | |
Change Variable Type | 1 | ||
Change Variable Type badRelationships : Collector<InputRelationship> to badCollector : Collector in method public doImport(input Input) : void in class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter | From | To | |
Change Attribute Type | 2 | ||
Change Attribute Type badRelationships : Collector<InputRelationship> to badCollector : Collector in class org.neo4j.unsafe.impl.batchimport.CalculateDenseNodePrepareStep | From | To | |
Change Attribute Type collectorFactory : Function<OutputStream,Collector<InputRelationship>> to collectorFactory : Function<OutputStream,Collector> in class org.neo4j.unsafe.impl.batchimport.input.csv.CsvInput | From | To | |
Rename Parameter | 5 | ||
Rename Parameter inGroup : PrimitiveIntPredicate to groupId : int in method private binarySearch(x long, inputId Object, low long, high long, groupId int) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
Rename Parameter badRelationships : Collector<InputRelationship> to badCollector : Collector in method public CalculateDenseNodePrepareStep(control StageControl, config Configuration, badCollector Collector) in class org.neo4j.unsafe.impl.batchimport.CalculateDenseNodePrepareStep | From | To | |
Rename Parameter inGroup : PrimitiveIntPredicate to groupId : int in method private binarySearch(inputId Object, groupId int) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
Rename Parameter inGroup : PrimitiveIntPredicate to groupId : int in method private findFromCollisions(index long, inputId Object, groupId int) : long in class org.neo4j.unsafe.impl.batchimport.cache.idmapping.string.EncodingIdMapper | From | To | |
Rename Parameter badRelationshipsCollector : Collector<InputRelationship> to badCollector : Collector in method public CalculateDenseNodesStage(relationships InputIterable<InputRelationship>, cache NodeRelationshipCache, idMapper IdMapper, badCollector Collector, inputCache InputCache) in class org.neo4j.unsafe.impl.batchimport.ParallelBatchImporter.CalculateDenseNodesStage | From | To |