afc996ecb5ce77c03927ff9fc375027354cf2208
Files Diff
- Added: 3
- Removed: 4
- Renamed: 0
- Modified: 36
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type marshal : ChunkedEncoder to marshal : ChunkedInput<ByteBuf> in method private encode(buffer ByteBuf, marshal ChunkedInput<ByteBuf>) : void in class org.neo4j.causalclustering.messaging.marshalling.v2.RaftMessageEncoderDecoderTest | From | To | |
| Change Parameter Type byteBufAwareMarshal : ChunkedEncoder to byteBufAwareMarshal : ChunkedInput<ByteBuf> in method private ChunkedReplicatedContent(contentType byte, byteBufAwareMarshal ChunkedInput<ByteBuf>) in class org.neo4j.causalclustering.messaging.marshalling.ChunkedReplicatedContent | From | To | |
| Change Parameter Type serializer : CoreReplicatedContentMarshal to replicatedContentCodec : Codec<ReplicatedContent> in method public RaftMessageContentEncoder(replicatedContentCodec Codec<ReplicatedContent>) in class org.neo4j.causalclustering.messaging.marshalling.v2.encoding.RaftMessageContentEncoder | From | To | |
| Move Method | 4 | ||
| Move Method public marshal(replicatedContent ReplicatedContent, channel WritableChannel) : void from class org.neo4j.causalclustering.messaging.marshalling.CoreReplicatedContentMarshal to public marshal(replicatedContent ReplicatedContent, channel WritableChannel) : void from class org.neo4j.causalclustering.messaging.marshalling.CoreReplicatedContentMarshal.ReplicatedContentMarshaller | From | To | |
| Move Method public marshal(channel WritableChannel) : void from class org.neo4j.causalclustering.messaging.marshalling.ByteArrayChunkedEncoder to public marshal(writableChannel WritableChannel, replicatedTransaction ByteArrayReplicatedTransaction) : void from class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransactionSerializer | From | To | |
| Move Method protected unmarshal0(channel ReadableChannel) : ReplicatedContent from class org.neo4j.causalclustering.messaging.marshalling.CoreReplicatedContentMarshal to protected unmarshal0(channel ReadableChannel) : ReplicatedContent from class org.neo4j.causalclustering.messaging.marshalling.CoreReplicatedContentMarshal.ReplicatedContentMarshaller | From | To | |
| Move Method public marshal(channel WritableChannel) : void from class org.neo4j.causalclustering.core.state.machines.tx.TransactionRepresentationReplicatedTransaction.TxRepresentationMarshal to public marshal(writableChannel WritableChannel, replicatedTransaction TransactionRepresentationReplicatedTransaction) : void from class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransactionSerializer | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private serializer : CoreReplicatedContentMarshal from class org.neo4j.causalclustering.messaging.marshalling.v2.encoding.RaftMessageContentEncoder to private serializer : CoreReplicatedContentMarshal from class org.neo4j.causalclustering.messaging.marshalling.CoreReplicatedContentMarshal.ReplicatedContentCodec | From | To | |
| Move Attribute private serializer : CoreReplicatedContentMarshal from class org.neo4j.causalclustering.messaging.marshalling.v2.encoding.RaftMessageContentEncoder to private serializer : CoreReplicatedContentMarshal from class org.neo4j.causalclustering.messaging.marshalling.CoreReplicatedContentMarshal.ReplicatedContentMarshaller | From | To | |
| Extract Class | 1 | ||
| Extract Class org.neo4j.causalclustering.messaging.marshalling.CoreReplicatedContentMarshal.ReplicatedContentMarshaller from class org.neo4j.causalclustering.messaging.marshalling.CoreReplicatedContentMarshal | From | To | |
| Move Class | 1 | ||
| Move Class org.neo4j.causalclustering.core.state.machines.tx.TransactionRepresentationReplicatedTransaction.TxRepresentationMarshal.TransactionRepresentationWriter moved to org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransactionFactory.TransactionRepresentationWriter | From | To | |
| Extract Method | 1 | ||
| Extract Method public close() : void extracted from public encodeChunk(allocator ByteBufAllocator) : ByteBuf in class org.neo4j.causalclustering.core.state.machines.tx.TransactionRepresentationReplicatedTransaction.TxRepresentationMarshal | From | To | |
| Rename Method | 9 | ||
| Rename Method private unmarshalContent(contentType byte, channel ReadableChannel) : ContentBuilder<ReplicatedContent> renamed to private unmarshal(contentType byte, channel ReadableChannel) : ContentBuilder<ReplicatedContent> in class org.neo4j.causalclustering.messaging.marshalling.CoreReplicatedContentMarshal | From | To | |
| Rename Method public encodeChunk(allocator ByteBufAllocator) : ByteBuf renamed to public readChunk(allocator ByteBufAllocator) : ByteBuf in class org.neo4j.causalclustering.messaging.marshalling.ChunkedReplicatedContentTest.ThreeChunks | From | To | |
| Rename Method public encodeChunk(allocator ByteBufAllocator) : ByteBuf renamed to public readChunk(allocator ByteBufAllocator) : ByteBuf in class org.neo4j.causalclustering.messaging.marshalling.ByteArrayChunkedEncoder | From | To | |
| Rename Method public unmarshalContent(contentType byte, buffer ByteBuf) : ContentBuilder<ReplicatedContent> renamed to private unmarshal(contentType byte, buffer ByteBuf) : ContentBuilder<ReplicatedContent> in class org.neo4j.causalclustering.messaging.marshalling.CoreReplicatedContentMarshal | From | To | |
| Rename Method public marshal() : ChunkedEncoder renamed to public encode() : ChunkedInput<ByteBuf> in class org.neo4j.causalclustering.core.state.machines.tx.TransactionRepresentationReplicatedTransaction | From | To | |
| Rename Method public marshal() : ChunkedEncoder renamed to public encode() : ChunkedInput<ByteBuf> in class org.neo4j.causalclustering.core.state.machines.tx.ByteArrayReplicatedTransaction | From | To | |
| Rename Method public encodeChunk(allocator ByteBufAllocator) : ByteBuf renamed to public readChunk(allocator ByteBufAllocator) : ByteBuf in class org.neo4j.causalclustering.core.state.machines.tx.TransactionRepresentationReplicatedTransaction.TxRepresentationMarshal | From | To | |
| Rename Method public decode(byteBuf ByteBuf) : ReplicatedTransaction renamed to public unmarshal(byteBuf ByteBuf) : ReplicatedTransaction in class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransactionSerializer | From | To | |
| Rename Method public marshal() : ChunkedEncoder renamed to public encode() : ChunkedInput<ByteBuf> in class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransaction | From | To | |
| Rename Variable | 2 | ||
| Rename Variable capacity : int to metaDataCapacity : int in method public readChunk(allocator ByteBufAllocator) : ByteBuf in class org.neo4j.causalclustering.messaging.marshalling.ChunkedReplicatedContent | From | To | |
| Rename Variable metaData : ByteBuf to metaDataBuffer : ByteBuf in method public readChunk(allocator ByteBufAllocator) : ByteBuf in class org.neo4j.causalclustering.messaging.marshalling.ChunkedReplicatedContent | From | To | |
| Inline Method | 1 | ||
| Inline Method private writeMetadata(isFirstChunk boolean, isLastChunk boolean, allocator ByteBufAllocator) : ByteBuf inlined to public readChunk(allocator ByteBufAllocator) : ByteBuf in class org.neo4j.causalclustering.messaging.marshalling.ChunkedReplicatedContent | From | To | |
| Change Return Type | 3 | ||
| Change Return Type ChunkedEncoder to ChunkedInput<ByteBuf> in method public encode() : ChunkedInput<ByteBuf> in class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransaction | From | To | |
| Change Return Type ChunkedEncoder to ChunkedInput<ByteBuf> in method public encode() : ChunkedInput<ByteBuf> in class org.neo4j.causalclustering.core.state.machines.tx.TransactionRepresentationReplicatedTransaction | From | To | |
| Change Return Type ChunkedEncoder to ChunkedInput<ByteBuf> in method public encode() : ChunkedInput<ByteBuf> in class org.neo4j.causalclustering.core.state.machines.tx.ByteArrayReplicatedTransaction | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute serializer : CoreReplicatedContentMarshal to codec : Codec<ReplicatedContent> in class org.neo4j.causalclustering.messaging.marshalling.v2.encoding.RaftMessageContentEncoder | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type serializer : CoreReplicatedContentMarshal to codec : Codec<ReplicatedContent> in class org.neo4j.causalclustering.messaging.marshalling.v2.encoding.RaftMessageContentEncoder | From | To | |
| Change Attribute Type txWriter : TxRepresentationMarshal.TransactionRepresentationWriter to txWriter : ReplicatedTransactionFactory.TransactionRepresentationWriter in class org.neo4j.causalclustering.core.state.machines.tx.TransactionRepresentationReplicatedTransaction.TxRepresentationMarshal | From | To | |
| Change Attribute Type byteBufAwareMarshal : ChunkedEncoder to byteBufAwareMarshal : ChunkedInput<ByteBuf> in class org.neo4j.causalclustering.messaging.marshalling.ChunkedReplicatedContent | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method package chunked(contentType byte, chunkedInput ChunkedInput<ByteBuf>) : ChunkedInput<ByteBuf> extracted from public shouldProvideExpectedMetaData() : void in class org.neo4j.causalclustering.messaging.marshalling.ChunkedReplicatedContentTest & moved to class org.neo4j.causalclustering.messaging.marshalling.ChunkedReplicatedContent | From | To | |
| Extract And Move Method package writeInitialMetaData(firstChunk WritableChannel, tx TransactionRepresentationReplicatedTransaction) : void extracted from public encodeChunk(allocator ByteBufAllocator) : ByteBuf in class org.neo4j.causalclustering.core.state.machines.tx.TransactionRepresentationReplicatedTransaction.TxRepresentationMarshal & moved to class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransactionSerializer | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter channel : WritableChannel to writableChannel : WritableChannel in method public marshal(writableChannel WritableChannel, replicatedTransaction TransactionRepresentationReplicatedTransaction) : void in class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransactionSerializer | From | To | |
| Rename Parameter channel : WritableChannel to writableChannel : WritableChannel in method public marshal(writableChannel WritableChannel, replicatedTransaction ByteArrayReplicatedTransaction) : void in class org.neo4j.causalclustering.core.state.machines.tx.ReplicatedTransactionSerializer | From | To | |
| Rename Parameter serializer : CoreReplicatedContentMarshal to replicatedContentCodec : Codec<ReplicatedContent> in method public RaftMessageContentEncoder(replicatedContentCodec Codec<ReplicatedContent>) in class org.neo4j.causalclustering.messaging.marshalling.v2.encoding.RaftMessageContentEncoder | From | To |