b83cb5283d57a16aa872ab37e8dea2e26d504b11
Files Diff
- Added: 8
- Removed: 2
- Renamed: 0
- Modified: 45
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Inline Method | 4 | ||
| Move And Inline Method public init(cursor LabelCursor) : TxLabelCursor moved from class org.neo4j.kernel.impl.api.cursor.TxLabelCursor to class org.neo4j.kernel.impl.api.StateHandlingStatementOperations & inlined to public nodeCursorGetAll(statement KernelStatement) : NodeCursor | From | To | |
| Move And Inline Method public init(cursor LabelCursor) : TxLabelCursor moved from class org.neo4j.kernel.impl.api.cursor.TxLabelCursor to class org.neo4j.kernel.impl.api.StateHandlingStatementOperations & inlined to public relationshipCursorGetAll(statement KernelStatement) : RelationshipCursor | From | To | |
| Move And Inline Method public init(cursor PropertyCursor) : TxPropertyCursor moved from class org.neo4j.kernel.impl.api.cursor.TxPropertyCursor to class org.neo4j.kernel.impl.api.OperationsFacade & inlined to public relationshipCursorGetAll() : RelationshipCursor | From | To | |
| Move And Inline Method public init(cursor LabelCursor) : TxLabelCursor moved from class org.neo4j.kernel.impl.api.cursor.TxLabelCursor to class org.neo4j.kernel.impl.api.OperationsFacade & inlined to public relationshipCursorGetAll() : RelationshipCursor | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type instanceCache : InstanceCache<TxPropertyCursor> to instanceCache : Consumer<TxPropertyCursor> in method public TxPropertyCursor(instanceCache Consumer<TxPropertyCursor>) in class org.neo4j.kernel.impl.api.cursor.TxPropertyCursor | From | To | |
| Change Parameter Type instanceCache : InstanceCache<TxLabelCursor> to instanceCache : Consumer<TxLabelCursor> in method public TxLabelCursor(instanceCache Consumer<TxLabelCursor>) in class org.neo4j.kernel.impl.api.cursor.TxLabelCursor | From | To | |
| Move Attribute | 5 | ||
| Move Attribute private propertyCursor : InstanceCache<TxPropertyCursor> from class org.neo4j.kernel.impl.api.KernelStatement to private propertyCursor : InstanceCache<TxPropertyCursor> from class org.neo4j.kernel.impl.api.state.TxState | From | To | |
| Move Attribute private GET_KEY_INDEX_ID : ToIntFunction<PropertyCursor> from class org.neo4j.kernel.impl.api.store.DiskLayer to public GET_KEY_INDEX_ID : ToIntFunction<PropertyCursor> from class org.neo4j.kernel.api.cursor.PropertyCursor | From | To | |
| Move Attribute private GET_LABEL : ToIntFunction<LabelCursor> from class org.neo4j.kernel.impl.api.store.DiskLayer to public GET_LABEL : ToIntFunction<LabelCursor> from class org.neo4j.kernel.api.cursor.LabelCursor | From | To | |
| Move Attribute private GET_PROPERTY : Function<PropertyCursor,DefinedProperty> from class org.neo4j.kernel.impl.api.store.DiskLayer to public GET_PROPERTY : Function<PropertyCursor,DefinedProperty> from class org.neo4j.kernel.api.cursor.PropertyCursor | From | To | |
| Move Attribute private labelCursor : InstanceCache<TxLabelCursor> from class org.neo4j.kernel.impl.api.KernelStatement to private labelCursor : InstanceCache<TxLabelCursor> from class org.neo4j.kernel.impl.api.state.TxState | From | To | |
| Extract Class | 1 | ||
| Extract Class org.neo4j.kernel.impl.api.cursor.TxAbstractRelationshipCursor from class org.neo4j.kernel.impl.api.cursor.TxPropertyCursor | From | To | |
| Move Class | 1 | ||
| Move Class org.neo4j.kernel.impl.api.store.DiskLayer.CursorRelationshipIterator moved to org.neo4j.kernel.impl.api.store.CursorRelationshipIterator | From | To | |
| Extract Variable | 1 | ||
| Extract Variable store : StoreReadLayer in method public relDeletionShouldThrowExceptionWhenRelWasAlreadyDeletedInSameTx() : void from class org.neo4j.kernel.impl.api.state.StateHandlingStatementOperationsTest | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type txState : TransactionState to storeStatement : StoreStatement in method public relDeletionShouldThrowExceptionWhenRelWasAlreadyDeletedInSameTx() : void in class org.neo4j.kernel.impl.api.state.StateHandlingStatementOperationsTest | From | To | |
| Change Variable Type txState : TransactionState to storeStatement : StoreStatement in method public nodeDeletionShouldThrowExceptionWhenNodeWasAlreadyDeletedInSameTx() : void in class org.neo4j.kernel.impl.api.state.StateHandlingStatementOperationsTest | From | To | |
| Extract Method | 7 | ||
| Extract Method public nodeCursor(statement KernelStatement, nodeId long) : NodeCursor extracted from public nodeGetAllProperties(state KernelStatement, nodeId long) : Iterator<DefinedProperty> in class org.neo4j.kernel.impl.api.StateHandlingStatementOperations | From | To | |
| Extract Method public relationshipCursor(statement KernelStatement, relationshipId long) : RelationshipCursor extracted from public relationshipExists(state KernelStatement, relId long) : boolean in class org.neo4j.kernel.impl.api.StateHandlingStatementOperations | From | To | |
| Extract Method public nodeCursor(statement KernelStatement, nodeId long) : NodeCursor extracted from public nodeGetProperty(state KernelStatement, nodeId long, propertyKeyId int) : Property in class org.neo4j.kernel.impl.api.StateHandlingStatementOperations | From | To | |
| Extract Method public relationshipCursor(statement KernelStatement, relationshipId long) : RelationshipCursor extracted from public relationshipGetAllProperties(state KernelStatement, relationshipId long) : Iterator<DefinedProperty> in class org.neo4j.kernel.impl.api.StateHandlingStatementOperations | From | To | |
| Extract Method public nodeCursor(statement KernelStatement, nodeId long) : NodeCursor extracted from public nodeHasLabel(state KernelStatement, nodeId long, labelId int) : boolean in class org.neo4j.kernel.impl.api.StateHandlingStatementOperations | From | To | |
| Extract Method public nodeCursor(statement KernelStatement, nodeId long) : NodeCursor extracted from public nodeExists(state KernelStatement, nodeId long) : boolean in class org.neo4j.kernel.impl.api.StateHandlingStatementOperations | From | To | |
| Extract Method public relationshipCursor(statement KernelStatement, relationshipId long) : RelationshipCursor extracted from public relationshipGetProperty(state KernelStatement, relationshipId long, propertyKeyId int) : Property in class org.neo4j.kernel.impl.api.StateHandlingStatementOperations | From | To | |
| Rename Method | 2 | ||
| Rename Method public acquire() : T renamed to public get() : T in class org.neo4j.kernel.impl.util.InstanceCache | From | To | |
| Rename Method public release(instance T) : void renamed to public accept(instance T) : void in class org.neo4j.kernel.impl.util.InstanceCache | From | To | |
| Rename Variable | 2 | ||
| Rename Variable txState : TransactionState to storeStatement : StoreStatement in method public relDeletionShouldThrowExceptionWhenRelWasAlreadyDeletedInSameTx() : void in class org.neo4j.kernel.impl.api.state.StateHandlingStatementOperationsTest | From | To | |
| Rename Variable txState : TransactionState to storeStatement : StoreStatement in method public nodeDeletionShouldThrowExceptionWhenNodeWasAlreadyDeletedInSameTx() : void in class org.neo4j.kernel.impl.api.state.StateHandlingStatementOperationsTest | From | To | |
| Change Return Type | 5 | ||
| Change Return Type StoreSingleNodeCursor to NodeCursor in method public acquireSingleNodeCursor(nodeId long) : NodeCursor in class org.neo4j.kernel.impl.api.store.StoreStatement | From | To | |
| Change Return Type void to StoreNodeRelationshipCursor in method public init(isDense boolean, firstRelId long, fromNodeId long, direction Direction, relTypes int...) : StoreNodeRelationshipCursor in class org.neo4j.kernel.impl.api.store.StoreNodeRelationshipCursor | From | To | |
| Change Return Type void to StorePropertyCursor in method public init(firstPropertyId long) : StorePropertyCursor in class org.neo4j.kernel.impl.api.store.StorePropertyCursor | From | To | |
| Change Return Type StoreSingleRelationshipCursor to RelationshipCursor in method public acquireSingleRelationshipCursor(relId long) : RelationshipCursor in class org.neo4j.kernel.impl.api.store.StoreStatement | From | To | |
| Change Return Type void to StoreLabelCursor in method public init(labels long[]) : StoreLabelCursor in class org.neo4j.kernel.impl.api.store.StoreLabelCursor | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type instanceCache : InstanceCache<TxPropertyCursor> to instanceCache : Consumer<TxPropertyCursor> in class org.neo4j.kernel.impl.api.cursor.TxPropertyCursor | From | To | |
| Change Attribute Type instanceCache : InstanceCache<TxLabelCursor> to instanceCache : Consumer<TxLabelCursor> in class org.neo4j.kernel.impl.api.cursor.TxLabelCursor | From | To | |
| Rename Parameter | 15 | ||
| Rename Parameter state : KernelStatement to statement : KernelStatement in method public nodeCursorGetAll(statement KernelStatement) : NodeCursor in class org.neo4j.kernel.impl.api.GuardingStatementOperations | From | To | |
| Rename Parameter state : KernelStatement to statement : KernelStatement in method public relationshipCursorGetAll(statement KernelStatement) : RelationshipCursor in class org.neo4j.kernel.impl.api.GuardingStatementOperations | From | To | |
| Rename Parameter state : KernelStatement to statement : KernelStatement in method public relationshipCursor(statement KernelStatement, relationshipId long) : RelationshipCursor in class org.neo4j.kernel.impl.api.StateHandlingStatementOperations | From | To | |
| Rename Parameter state : KernelStatement to statement : KernelStatement in method public nodeCursorGetAll(statement KernelStatement) : NodeCursor in class org.neo4j.kernel.impl.api.ConstraintEnforcingEntityOperations | From | To | |
| Rename Parameter state : KernelStatement to statement : KernelStatement in method public relationshipCursorGetAll(statement KernelStatement) : RelationshipCursor in class org.neo4j.kernel.impl.api.ConstraintEnforcingEntityOperations | From | To | |
| Rename Parameter state : KernelStatement to statement : KernelStatement in method public nodeCursor(statement KernelStatement, nodeId long) : NodeCursor in class org.neo4j.kernel.impl.api.StateHandlingStatementOperations | From | To | |
| Rename Parameter state : KernelStatement to statement : KernelStatement in method public relationshipCursorGetAll(statement KernelStatement) : RelationshipCursor in class org.neo4j.kernel.impl.api.StateHandlingStatementOperations | From | To | |
| Rename Parameter state : KernelStatement to statement : KernelStatement in method public nodeCursorGetAll(statement KernelStatement) : NodeCursor in class org.neo4j.kernel.impl.api.StateHandlingStatementOperations | From | To | |
| Rename Parameter state : KernelStatement to statement : KernelStatement in method public relationshipCursorGetAll(statement KernelStatement) : RelationshipCursor in class org.neo4j.kernel.impl.api.operations.EntityReadOperations | From | To | |
| Rename Parameter state : KernelStatement to statement : KernelStatement in method public nodeCursorGetAll(statement KernelStatement) : NodeCursor in class org.neo4j.kernel.impl.api.operations.EntityReadOperations | From | To |