b94dd444951910fe4076b6cdddc28a8dfb6bdfe7
Files Diff
- Added: 12
- Removed: 4
- Renamed: 0
- Modified: 40
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public totalEntriesStored() : int from class org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState to protected storedEntryCount() : int from class org.neo4j.kernel.impl.store.kvstore.ActiveState | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass org.neo4j.kernel.impl.store.kvstore.ActiveState from class org.neo4j.kernel.impl.store.kvstore.KeyValueStoreState | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type store : KeyValueStoreFile to store : ReadableState<Key> in method private ConcurrentMapState(prototype Prototype<Key>, store ReadableState<Key>, file File) in class org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState | From | To | |
| Move Method | 3 | ||
| Move Method public abstract dataProvider() : DataProvider from class org.neo4j.kernel.impl.store.kvstore.KeyValueStoreState to protected abstract dataProvider() : DataProvider from class org.neo4j.kernel.impl.store.kvstore.ReadableState | From | To | |
| Move Method public toString() : String from class org.neo4j.kernel.impl.store.kvstore.SortedKeyValueStore to public toString() : String from class org.neo4j.kernel.impl.store.counts.FileVersion | From | To | |
| Move Method public toString() : String from class org.neo4j.kernel.impl.store.kvstore.SortedKeyValueStoreHeader to public toString() : String from class org.neo4j.kernel.impl.store.counts.FileVersion | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private keys : KeyFormat<Key> from class org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState to private keys : KeyFormat<Key> from class org.neo4j.kernel.impl.store.kvstore.DeadState | From | To | |
| Move Attribute private rotation : RotationStrategy from class org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState to private rotation : RotationStrategy from class org.neo4j.kernel.impl.store.kvstore.DeadState.NeedsCreation | From | To | |
| Extract Class | 1 | ||
| Extract Class org.neo4j.kernel.impl.store.kvstore.ReadableState from class org.neo4j.kernel.impl.store.kvstore.KeyValueStoreState | From | To | |
| Rename Class | 1 | ||
| Rename Class org.neo4j.kernel.impl.store.kvstore.KeyValueStoreState renamed to org.neo4j.kernel.impl.store.kvstore.ProgressiveState | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [keys : KeyFormat<Key>, store : KeyValueStoreFile] to prototype : Prototype<Key> in method private ConcurrentMapState(prototype Prototype<Key>, store ReadableState<Key>, file File) in class org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type state : KeyValueStoreState<Key> to state : ProgressiveState<Key> in method protected visitAll(visitor Visitor) : void in class org.neo4j.kernel.impl.store.kvstore.AbstractKeyValueStore | From | To | |
| Extract Variable | 1 | ||
| Extract Variable counts : CountsAccessor in method public execute(stores DirectStoreAccess, logger StringLogger) : ConsistencySummaryStatistics from class org.neo4j.consistency.checking.full.FullCheck | From | To | |
| Extract Method | 2 | ||
| Extract Method public initialize(countsUpdater CountsAccessor.Updater) : void extracted from public rebuildCounts() : void in class org.neo4j.kernel.impl.store.CountsComputer | From | To | |
| Extract Method private dataProvider(store ReadableState<Key>, changes ConcurrentMap<Key,byte[]>) : DataProvider extracted from public dataProvider() : DataProvider in class org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState | From | To | |
| Rename Method | 4 | ||
| Rename Method public apply(key Key, update ValueUpdate, reset boolean) : void renamed to package applyUpdate(store ReadableState<Key>, changes ConcurrentMap<Key,byte[]>, key Key, update ValueUpdate, reset boolean) : void in class org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState | From | To | |
| Rename Method public visit(key ReadableBuffer, value ReadableBuffer) : boolean renamed to protected value(value ReadableBuffer) : void in class org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState.PreviousValue | From | To | |
| Rename Method protected ensureSameThread() : void renamed to protected ensureOpenOnSameThread() : void in class org.neo4j.kernel.impl.store.kvstore.EntryUpdater | From | To | |
| Rename Method public rebuildCounts() : void renamed to public recomputeCounts(stores NeoStore) : void in class org.neo4j.kernel.impl.store.CountsComputer | From | To | |
| Push Down Method | 2 | ||
| Push Down Method public abstract headers() : Headers from class org.neo4j.kernel.impl.store.kvstore.KeyValueStoreState to protected headers() : Headers from class org.neo4j.kernel.impl.store.kvstore.ActiveState | From | To | |
| Push Down Method public abstract hasChanges() : boolean from class org.neo4j.kernel.impl.store.kvstore.KeyValueStoreState to protected abstract hasChanges() : boolean from class org.neo4j.kernel.impl.store.kvstore.ActiveState | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method public headers() : Headers from class org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState to protected headers() : Headers from class org.neo4j.kernel.impl.store.kvstore.ActiveState | From | To | |
| Rename Variable | 1 | ||
| Rename Variable txId : int to secondTx : int in method public shouldUpdateCountsOnExistingStore() : void in class org.neo4j.kernel.impl.store.counts.CountsTrackerTest | From | To | |
| Change Return Type | 4 | ||
| Change Return Type boolean to void in method protected value(value ReadableBuffer) : void in class org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState.PreviousValue | From | To | |
| Change Return Type KeyValueStoreState<Key> to void in method protected close() : void in class org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState | From | To | |
| Change Return Type EntryUpdater<Key> to Optional<EntryUpdater<Key>> in method protected updater(version long) : Optional<EntryUpdater<Key>> in class org.neo4j.kernel.impl.store.kvstore.AbstractKeyValueStore | From | To | |
| Change Return Type CountsAccessor.Updater to Optional<CountsAccessor.Updater> in method public apply(txId long) : Optional<CountsAccessor.Updater> in class org.neo4j.kernel.impl.store.counts.CountsTracker | From | To | |
| Extract Superclass | 2 | ||
| Extract Superclass org.neo4j.kernel.impl.store.kvstore.ActiveState from classes [org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState] | From | To | |
| Extract Superclass org.neo4j.kernel.impl.store.kvstore.ValueSink from classes [org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState.PreviousValue] | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute countsTracker : CountsTracker to lastCommittedTransactionId : long in class org.neo4j.kernel.impl.store.CountsComputer | From | To | |
| Rename Attribute rotation : RotationStrategy to previousVersion : long in class org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState | From | To | |
| Rename Attribute initialTransactionId : long to previouslyCommittedTxId : long in class org.neo4j.kernel.impl.transaction.DeadSimpleTransactionIdStore | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type state : KeyValueStoreState<Key> to state : ProgressiveState<Key> in class org.neo4j.kernel.impl.store.kvstore.AbstractKeyValueStore | From | To | |
| Change Attribute Type rotation : RotationStrategy to previousVersion : long in class org.neo4j.kernel.impl.store.kvstore.ConcurrentMapState | From | To | |
| Change Attribute Type countsTracker : CountsTracker to lastCommittedTransactionId : long in class org.neo4j.kernel.impl.store.CountsComputer | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method protected prepareRotation(version long) : PreparedRotation extracted from public rotate(txId long) : long in class org.neo4j.kernel.impl.store.counts.CountsTracker & moved to class org.neo4j.kernel.impl.store.kvstore.AbstractKeyValueStore | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter lookup : Reader<Value> to reader : Reader<Value> in method protected lookup(key Key, reader Reader<Value>) : Value in class org.neo4j.kernel.impl.store.kvstore.AbstractKeyValueStore | From | To | |
| Rename Parameter txId : long to version : long in method protected updater(version long) : Optional<EntryUpdater<Key>> in class org.neo4j.kernel.impl.store.kvstore.AbstractKeyValueStore | From | To | |
| Rename Parameter initialTransactionId : long to previouslyCommittedTxId : long in method public DeadSimpleTransactionIdStore(previouslyCommittedTxId long, checksum long) in class org.neo4j.kernel.impl.transaction.DeadSimpleTransactionIdStore | From | To |