bd944012568f49c0f7a029697b7dfe541216a4d9
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 23
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public replicaMembers() : Map<MemberId,ReadReplicaInfo> renamed to public members() : Map<MemberId,ReadReplicaInfo> in class org.neo4j.causalclustering.discovery.ReadReplicaTopology | From | To | |
| Rename Variable | 5 | ||
| Rename Variable renewableTimeoutService : ControlledRenewableTimeoutService to jobScheduler : OnDemandJobScheduler in method public shouldRegisterReadReplicaInTopology() : void in class org.neo4j.causalclustering.discovery.HazelcastClientTest | From | To | |
| Rename Variable t : Throwable to e : Throwable in method private disconnectFromCore() : void in class org.neo4j.causalclustering.discovery.HazelcastClient | From | To | |
| Rename Variable jobHandle : JobScheduler.JobHandle to logJob : JobScheduler.JobHandle in method private createHazelcastInstance() : HazelcastInstance in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService | From | To | |
| Rename Variable renewableTimeoutService : ControlledRenewableTimeoutService to jobScheduler : OnDemandJobScheduler in method public shouldRemoveReadReplicasOnGracefulShutdown() : void in class org.neo4j.causalclustering.discovery.HazelcastClientTest | From | To | |
| Rename Variable renewableTimeoutService : ControlledRenewableTimeoutService to jobScheduler : OnDemandJobScheduler in method public shouldSwallowNPEFromHazelcast() : void in class org.neo4j.causalclustering.discovery.HazelcastClientTest | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Set<MemberId> to Map<MemberId,CoreServerInfo> in method public members() : Map<MemberId,CoreServerInfo> in class org.neo4j.causalclustering.discovery.CoreTopology | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [connector : HazelcastConnector, renewableTimeoutService : RenewableTimeoutService] to config : Config in method package HazelcastClient(connector HazelcastConnector, scheduler JobScheduler, logProvider LogProvider, config Config, myself MemberId) in class org.neo4j.causalclustering.discovery.HazelcastClient | From | To | |
| Rename Attribute | 6 | ||
| Rename Attribute hazelcastInstance : HazelcastInstance to hzInstance : RobustHazelcastWrapper in class org.neo4j.causalclustering.discovery.HazelcastClient | From | To | |
| Rename Attribute renewableTimeoutService : RenewableTimeoutService to refreshPeriod : long in class org.neo4j.causalclustering.discovery.HazelcastClient | From | To | |
| Rename Attribute jobHandle : JobScheduler.JobHandle to refreshJob : JobScheduler.JobHandle in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService | From | To | |
| Rename Attribute connector : HazelcastConnector to timeToLive : long in class org.neo4j.causalclustering.discovery.HazelcastClient | From | To | |
| Rename Attribute latestReadReplicaTopology : ReadReplicaTopology to readReplicaTopology : ReadReplicaTopology in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService | From | To | |
| Rename Attribute latestCoreTopology : CoreTopology to coreTopology : CoreTopology in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type renewableTimeoutService : ControlledRenewableTimeoutService to jobScheduler : OnDemandJobScheduler in method public shouldRemoveReadReplicasOnGracefulShutdown() : void in class org.neo4j.causalclustering.discovery.HazelcastClientTest | From | To | |
| Change Variable Type renewableTimeoutService : ControlledRenewableTimeoutService to jobScheduler : OnDemandJobScheduler in method public shouldSwallowNPEFromHazelcast() : void in class org.neo4j.causalclustering.discovery.HazelcastClientTest | From | To | |
| Change Variable Type renewableTimeoutService : ControlledRenewableTimeoutService to jobScheduler : OnDemandJobScheduler in method public shouldRegisterReadReplicaInTopology() : void in class org.neo4j.causalclustering.discovery.HazelcastClientTest | From | To | |
| Extract Variable | 3 | ||
| Extract Variable jobScheduler : OnDemandJobScheduler in method public shouldNotReconnectWhileHazelcastRemainsAvailable() : void from class org.neo4j.causalclustering.discovery.HazelcastClientTest | From | To | |
| Extract Variable jobScheduler : OnDemandJobScheduler in method public shouldReturnTopologyUsingHazelcastMembers() : void from class org.neo4j.causalclustering.discovery.HazelcastClientTest | From | To | |
| Extract Variable jobScheduler : OnDemandJobScheduler in method public shouldReturnEmptyTopologyIfUnableToConnectToHazelcast() : void from class org.neo4j.causalclustering.discovery.HazelcastClientTest | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type renewableTimeoutService : RenewableTimeoutService to refreshPeriod : long in class org.neo4j.causalclustering.discovery.HazelcastClient | From | To | |
| Change Attribute Type connector : HazelcastConnector to timeToLive : long in class org.neo4j.causalclustering.discovery.HazelcastClient | From | To | |
| Change Attribute Type hazelcastInstance : HazelcastInstance to hzInstance : RobustHazelcastWrapper in class org.neo4j.causalclustering.discovery.HazelcastClient | From | To | |
| Change Attribute Type scheduler : JobScheduler to scheduler : RobustJobSchedulerWrapper in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService | From | To | |
| Extract Method | 1 | ||
| Extract Method private disconnectFromCore() : void extracted from public stop() : void in class org.neo4j.causalclustering.discovery.HazelcastClient | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method private refreshTopology() : void extracted from public memberAdded(membershipEvent MembershipEvent) : void in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService.OurMembershipListener & moved to class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService | From | To | |
| Extract And Move Method private refreshTopology() : void extracted from public memberRemoved(membershipEvent MembershipEvent) : void in class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService.OurMembershipListener & moved to class org.neo4j.causalclustering.discovery.HazelcastCoreTopologyService | From | To |