neo4j c42d5a5d3321a6ba0ff44f0604aa7bdbf8c5e767

c42d5a5d3321a6ba0ff44f0604aa7bdbf8c5e767

Files Diff

Added: 19
Removed: 0
Renamed: 0
Modified: 32

Link to commit

Dependency Action
Added
	org.apache.geronimo.specs:geronimo-jta_1.1_spec:1.1.1
	geronimo-spec:geronimo-spec-j2ee:1.4-rc4

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method private getReadLockOnMaster(resourceType ResourceType, resourceId long) : boolean renamed to private acquireSharedOnMaster(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Change Parameter Type	19
Change Parameter Type resourceId : long to resourceIds : long... in method public acquireExclusive(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.transaction.state.RelationshipCreatorTest.Tracker	From	To
Change Parameter Type resourceId : long to resourceIds : long... in method private acquireSharedOnMaster(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Change Parameter Type resourceId : long to resourceIds : long... in method public acquireExclusive(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.enterprise.lock.forseti.ForsetiClient	From	To
Change Parameter Type locks : Locks.Client to statementLocks : StatementLocks in method public initialize(lastCommittedTx long, lastTimeStamp long, statementLocks StatementLocks, type Type, accessMode AccessMode) : KernelTransactionImplementation in class org.neo4j.kernel.impl.api.KernelTransactionImplementation	From	To
Change Parameter Type resourceId : long to resourceIds : long... in method private acquireExclusiveOnMaster(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Change Parameter Type resourceId : long to resourceIds : long... in method public acquireShared(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.enterprise.lock.forseti.ForsetiClient	From	To
Change Parameter Type lockManager : Locks to statementLocksFactory : StatementLocksFactory in method public NeoStoreDataSource(storeDir File, config Config, idGeneratorFactory IdGeneratorFactory, eligibleForReuse IdReuseEligibility, idTypeConfigurationProvider IdTypeConfigurationProvider, logService LogService, scheduler JobScheduler, tokenNameLookup TokenNameLookup, dependencyResolver DependencyResolver, propertyKeyTokens PropertyKeyTokenHolder, labelTokens LabelTokenHolder, relationshipTypeTokens RelationshipTypeTokenHolder, statementLocksFactory StatementLocksFactory, schemaWriteGuard SchemaWriteGuard, transactionEventHandlers TransactionEventHandlers, indexingServiceMonitor IndexingService.Monitor, fs FileSystemAbstraction, transactionMonitor TransactionMonitor, databaseHealth DatabaseHealth, physicalLogMonitor PhysicalLogFile.Monitor, transactionHeaderInformationFactory TransactionHeaderInformationFactory, startupStatistics StartupStatisticsProvider, guard Guard, commitProcessFactory CommitProcessFactory, autoIndexing AutoIndexing, pageCache PageCache, constraintSemantics ConstraintSemantics, monitors Monitors, tracers Tracers, procedures Procedures, ioLimiter IOLimiter) in class org.neo4j.kernel.NeoStoreDataSource	From	To
Change Parameter Type resourceId : long to resourceIds : long... in method public acquireShared(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Change Parameter Type resourceId : long to resourceIds : long[] in method private onlyFirstTimeLocks(lockMap Map<Long,AtomicInteger>, resourceIds long[]) : long[] in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Change Parameter Type resourceId : long to resourceIds : long... in method public acquireExclusive(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Change Parameter Type resourceId : long to resourceIds : long... in method public acquireExclusive(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.locking.community.CommunityLockClient	From	To
Change Parameter Type locks : Locks to statementLocksFactory : StatementLocksFactory in method public KernelTransactions(statementLocksFactory StatementLocksFactory, constraintIndexCreator ConstraintIndexCreator, statementOperations StatementOperationParts, schemaWriteGuard SchemaWriteGuard, txHeaderFactory TransactionHeaderInformationFactory, transactionCommitProcess TransactionCommitProcess, indexConfigStore IndexConfigStore, legacyIndexProviderLookup LegacyIndexProviderLookup, hooks TransactionHooks, transactionMonitor TransactionMonitor, dataSourceLife LifeSupport, tracers Tracers, storageEngine StorageEngine, procedures Procedures, transactionIdStore TransactionIdStore, config Config, clock Clock) in class org.neo4j.kernel.impl.api.KernelTransactions	From	To
Change Parameter Type resourceId : long to resourceIds : long... in method public acquireExclusive(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.locking.Locks.Client	From	To
Change Parameter Type locks : Locks to statementLocksFactory : StatementLocksFactory in method package TestKernelTransactions(statementLocksFactory StatementLocksFactory, constraintIndexCreator ConstraintIndexCreator, statementOperations StatementOperationParts, schemaWriteGuard SchemaWriteGuard, txHeaderFactory TransactionHeaderInformationFactory, transactionCommitProcess TransactionCommitProcess, indexConfigStore IndexConfigStore, legacyIndexProviderLookup LegacyIndexProviderLookup, hooks TransactionHooks, transactionMonitor TransactionMonitor, dataSourceLife LifeSupport, tracers Tracers, storageEngine StorageEngine, procedures Procedures, transactionIdStore TransactionIdStore, config Config, clock Clock) in class org.neo4j.kernel.impl.api.KernelTransactionsTest.TestKernelTransactions	From	To
Change Parameter Type locks : Locks.Client to statementLocks : StatementLocks in method package initialize(statementLocks StatementLocks) : void in class org.neo4j.kernel.impl.api.KernelStatement	From	To
Change Parameter Type resourceId : long to resourceIds : long... in method public acquireShared(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.locking.community.CommunityLockClient	From	To
Change Parameter Type resourceId : long to resourceIds : long... in method public acquireExclusive(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.storageengine.api.lock.ResourceLocker	From	To
Change Parameter Type resourceId : long to resourceIds : long... in method public acquireShared(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.locking.Locks.Client	From	To
Rename Variable	2
Rename Variable locks : Locks to statementLocksFactory : StatementLocksFactory in method private newKernelTransactions(locks Locks, storageEngine StorageEngine, commitProcess TransactionCommitProcess, testKernelTransactions boolean) : KernelTransactions in class org.neo4j.kernel.impl.api.KernelTransactionsTest	From	To
Rename Variable lockHolder : Locks.Client to locks : Locks.Client in method public mockedState(txState TransactionState) : KernelStatement in class org.neo4j.kernel.impl.api.StatementOperationsTestHelper	From	To
Change Return Type	4
Change Return Type boolean to void in method private acquireSharedOnMaster(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Change Return Type Locks.Client to StatementLocks in method public locks() : StatementLocks in class org.neo4j.kernel.impl.api.KernelStatement	From	To
Change Return Type boolean to void in method private receiveLockResponse(response Response<LockResult>) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Change Return Type boolean to void in method private acquireExclusiveOnMaster(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Move Attribute	2
Move Attribute private locks : Locks from class org.neo4j.kernel.NeoStoreDataSource to private locks : Locks from class org.neo4j.kernel.impl.locking.DeferringStatementLocksFactory	From	To
Move Attribute private locks : Locks from class org.neo4j.kernel.NeoStoreDataSource to private locks : Locks from class org.neo4j.kernel.impl.locking.SimpleStatementLocksFactory	From	To
Rename Attribute	3
Rename Attribute locks : Locks to statementLocksFactory : StatementLocksFactory in class org.neo4j.kernel.impl.api.KernelTransactions	From	To
Rename Attribute locks : Locks.Client to statementLocks : StatementLocks in class org.neo4j.kernel.impl.api.KernelStatement	From	To
Rename Attribute locks : Locks to statementLocksFactory : StatementLocksFactory in class org.neo4j.kernel.NeoStoreDataSource	From	To
Change Variable Type	1
Change Variable Type locks : Locks to statementLocksFactory : StatementLocksFactory in method private newKernelTransactions(locks Locks, storageEngine StorageEngine, commitProcess TransactionCommitProcess, testKernelTransactions boolean) : KernelTransactions in class org.neo4j.kernel.impl.api.KernelTransactionsTest	From	To
Extract Method	32
Extract Method private acquireExclusiveSchemaLock(state KernelStatement) : void extracted from public constraintDrop(state KernelStatement, constraint RelationshipPropertyConstraint) : void in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public uniqueIndexesGetAll(state KernelStatement) : Iterator<IndexDescriptor> in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public indexGetState(state KernelStatement, descriptor IndexDescriptor) : InternalIndexState in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public relationshipCreate(state KernelStatement, relationshipTypeId int, startNodeId long, endNodeId long) : long in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public indexGetCommittedId(state KernelStatement, index IndexDescriptor, filter Predicate<SchemaRule.Kind>) : long in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public schemaStateGetOrCreate(state KernelStatement, key K, creator Function<K,V>) : V in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public schemaStateFlush(state KernelStatement) : void in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public indexesGetForLabel(state KernelStatement, labelId int) : Iterator<IndexDescriptor> in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private onlyFirstTimeLocks(lockMap Map<Long,AtomicInteger>, resourceIds long[]) : long[] extracted from public acquireShared(resourceType ResourceType, resourceId long) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public indexUniqueValuesPercentage(state KernelStatement, descriptor IndexDescriptor) : double in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public indexGetForLabelAndPropertyKey(state KernelStatement, labelId int, propertyKey int) : IndexDescriptor in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireExclusiveSchemaLock(state KernelStatement) : void extracted from public uniquePropertyConstraintCreate(state KernelStatement, labelId int, propertyKeyId int) : UniquenessConstraint in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public indexesGetAll(state KernelStatement) : Iterator<IndexDescriptor> in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public indexGetPopulationProgress(state KernelStatement, descriptor IndexDescriptor) : PopulationProgress in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireExclusiveSchemaLock(state KernelStatement) : void extracted from public constraintDrop(state KernelStatement, constraint NodePropertyConstraint) : void in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireExclusiveSchemaLock(state KernelStatement) : void extracted from public indexCreate(state KernelStatement, labelId int, propertyKey int) : IndexDescriptor in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private onlyFirstTimeLocks(lockMap Map<Long,AtomicInteger>, resourceIds long[]) : long[] extracted from public acquireExclusive(resourceType ResourceType, resourceId long) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Extract Method private acquireExclusiveSchemaLock(state KernelStatement) : void extracted from public indexDrop(state KernelStatement, descriptor IndexDescriptor) : void in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public indexGetOwningUniquenessConstraintId(state KernelStatement, index IndexDescriptor) : Long in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public constraintsGetAll(state KernelStatement) : Iterator<PropertyConstraint> in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public constraintsGetForRelationshipTypeAndPropertyKey(state KernelStatement, relTypeId int, propertyKeyId int) : Iterator<RelationshipPropertyConstraint> in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireExclusiveSchemaLock(state KernelStatement) : void extracted from public relationshipPropertyExistenceConstraintCreate(state KernelStatement, relTypeId int, propertyKeyId int) : RelationshipPropertyExistenceConstraint in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public constraintsGetForRelationshipType(state KernelStatement, typeId int) : Iterator<RelationshipPropertyConstraint> in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireExclusiveSchemaLock(state KernelStatement) : void extracted from public uniqueIndexDrop(state KernelStatement, descriptor IndexDescriptor) : void in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public nodeAddLabel(state KernelStatement, nodeId long, labelId int) : boolean in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireExclusiveSchemaLock(state KernelStatement) : void extracted from public nodePropertyExistenceConstraintCreate(state KernelStatement, labelId int, propertyKeyId int) : NodePropertyExistenceConstraint in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public constraintsGetForLabel(state KernelStatement, labelId int) : Iterator<NodePropertyConstraint> in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public constraintsGetForLabelAndPropertyKey(state KernelStatement, labelId int, propertyKeyId int) : Iterator<NodePropertyConstraint> in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public nodeSetProperty(state KernelStatement, nodeId long, property DefinedProperty) : Property in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public indexSize(state KernelStatement, descriptor IndexDescriptor) : long in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public uniqueIndexesGetForLabel(state KernelStatement, labelId int) : Iterator<IndexDescriptor> in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Extract Method private acquireSharedSchemaLock(state KernelStatement) : void extracted from public schemaStateContains(state KernelStatement, key K) : boolean in class org.neo4j.kernel.impl.api.LockingStatementOperations	From	To
Change Attribute Type	3
Change Attribute Type locks : Locks to statementLocksFactory : StatementLocksFactory in class org.neo4j.kernel.NeoStoreDataSource	From	To
Change Attribute Type locks : Locks to statementLocksFactory : StatementLocksFactory in class org.neo4j.kernel.impl.api.KernelTransactions	From	To
Change Attribute Type locks : Locks.Client to statementLocks : StatementLocks in class org.neo4j.kernel.impl.api.KernelStatement	From	To
Rename Parameter	19
Rename Parameter resourceId : long to resourceIds : long... in method public acquireExclusive(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.locking.Locks.Client	From	To
Rename Parameter locks : Locks to statementLocksFactory : StatementLocksFactory in method public KernelTransactions(statementLocksFactory StatementLocksFactory, constraintIndexCreator ConstraintIndexCreator, statementOperations StatementOperationParts, schemaWriteGuard SchemaWriteGuard, txHeaderFactory TransactionHeaderInformationFactory, transactionCommitProcess TransactionCommitProcess, indexConfigStore IndexConfigStore, legacyIndexProviderLookup LegacyIndexProviderLookup, hooks TransactionHooks, transactionMonitor TransactionMonitor, dataSourceLife LifeSupport, tracers Tracers, storageEngine StorageEngine, procedures Procedures, transactionIdStore TransactionIdStore, config Config, clock Clock) in class org.neo4j.kernel.impl.api.KernelTransactions	From	To
Rename Parameter locks : Locks.Client to statementLocks : StatementLocks in method package initialize(statementLocks StatementLocks) : void in class org.neo4j.kernel.impl.api.KernelStatement	From	To
Rename Parameter resourceId : long to resourceIds : long... in method public acquireExclusive(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.enterprise.lock.forseti.ForsetiClient	From	To
Rename Parameter locks : Locks to statementLocksFactory : StatementLocksFactory in method package TestKernelTransactions(statementLocksFactory StatementLocksFactory, constraintIndexCreator ConstraintIndexCreator, statementOperations StatementOperationParts, schemaWriteGuard SchemaWriteGuard, txHeaderFactory TransactionHeaderInformationFactory, transactionCommitProcess TransactionCommitProcess, indexConfigStore IndexConfigStore, legacyIndexProviderLookup LegacyIndexProviderLookup, hooks TransactionHooks, transactionMonitor TransactionMonitor, dataSourceLife LifeSupport, tracers Tracers, storageEngine StorageEngine, procedures Procedures, transactionIdStore TransactionIdStore, config Config, clock Clock) in class org.neo4j.kernel.impl.api.KernelTransactionsTest.TestKernelTransactions	From	To
Rename Parameter resourceId : long to resourceIds : long... in method public acquireShared(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.locking.community.CommunityLockClient	From	To
Rename Parameter resourceId : long to resourceIds : long... in method public acquireExclusive(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Rename Parameter resourceId : long to resourceIds : long... in method public acquireExclusive(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.locking.community.CommunityLockClient	From	To
Rename Parameter locks : Locks.Client to statementLocks : StatementLocks in method public initialize(lastCommittedTx long, lastTimeStamp long, statementLocks StatementLocks, type Type, accessMode AccessMode) : KernelTransactionImplementation in class org.neo4j.kernel.impl.api.KernelTransactionImplementation	From	To
Rename Parameter resourceId : long to resourceIds : long... in method private acquireExclusiveOnMaster(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Rename Parameter lockManager : Locks to statementLocksFactory : StatementLocksFactory in method public NeoStoreDataSource(storeDir File, config Config, idGeneratorFactory IdGeneratorFactory, eligibleForReuse IdReuseEligibility, idTypeConfigurationProvider IdTypeConfigurationProvider, logService LogService, scheduler JobScheduler, tokenNameLookup TokenNameLookup, dependencyResolver DependencyResolver, propertyKeyTokens PropertyKeyTokenHolder, labelTokens LabelTokenHolder, relationshipTypeTokens RelationshipTypeTokenHolder, statementLocksFactory StatementLocksFactory, schemaWriteGuard SchemaWriteGuard, transactionEventHandlers TransactionEventHandlers, indexingServiceMonitor IndexingService.Monitor, fs FileSystemAbstraction, transactionMonitor TransactionMonitor, databaseHealth DatabaseHealth, physicalLogMonitor PhysicalLogFile.Monitor, transactionHeaderInformationFactory TransactionHeaderInformationFactory, startupStatistics StartupStatisticsProvider, guard Guard, commitProcessFactory CommitProcessFactory, autoIndexing AutoIndexing, pageCache PageCache, constraintSemantics ConstraintSemantics, monitors Monitors, tracers Tracers, procedures Procedures, ioLimiter IOLimiter) in class org.neo4j.kernel.NeoStoreDataSource	From	To
Rename Parameter resourceId : long to resourceIds : long... in method public acquireShared(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.enterprise.lock.forseti.ForsetiClient	From	To
Rename Parameter resourceId : long to resourceIds : long[] in method private onlyFirstTimeLocks(lockMap Map<Long,AtomicInteger>, resourceIds long[]) : long[] in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Rename Parameter resourceId : long to resourceIds : long... in method public acquireShared(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To
Rename Parameter resourceId : long to resourceIds : long... in method public acquireShared(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.locking.Locks.Client	From	To
Rename Parameter resourceId : long to resourceIds : long... in method public acquireExclusive(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.storageengine.api.lock.ResourceLocker	From	To
Rename Parameter resourceId : long to resourceIds : long... in method public acquireExclusive(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.impl.transaction.state.RelationshipCreatorTest.Tracker	From	To
Rename Parameter resourceId : long to resourceIds : long... in method private acquireSharedOnMaster(resourceType ResourceType, resourceIds long...) : void in class org.neo4j.kernel.ha.lock.SlaveLocksClient	From	To

c42d5a5d3321a6ba0ff44f0604aa7bdbf8c5e767

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: