d333c9fa543134459dec3fef97a2106b75278e0f
Files Diff
- Added: 11
- Removed: 4
- Renamed: 0
- Modified: 28
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Class | 2 | ||
| Rename Class org.neo4j.coreedge.raft.log.inmemory.ConcurrentStressIT renamed to org.neo4j.coreedge.raft.log.inmemory.InMemoryConcurrentStressIT | From | To | |
| Rename Class org.neo4j.coreedge.raft.log.segmented.ConcurrentStressIT renamed to org.neo4j.coreedge.raft.log.segmented.SegmentedConcurrentStressIT | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type reader : ReadAheadChannel<StoreChannel> to reader : Reader in method package getReader(logIndex long) : IOCursor<EntryRecord> in class org.neo4j.coreedge.raft.log.segmented.SegmentFile | From | To | |
| Change Variable Type limitOptional : Optional<Long> to optionalFile : Optional<SegmentFile> in method private nextSegment() : boolean in class org.neo4j.coreedge.raft.log.segmented.EntryCursor | From | To | |
| Extract Variable | 3 | ||
| Extract Variable indexToKeep : long in method public indexToKeepTest() : void from class org.neo4j.coreedge.raft.log.segmented.SizeBasedLogPruningStrategyTest | From | To | |
| Extract Variable file : SegmentFile in method private nextSegment() : boolean from class org.neo4j.coreedge.raft.log.segmented.EntryCursor | From | To | |
| Extract Variable oldReader : IOCursor<EntryRecord> in method private nextSegment() : boolean from class org.neo4j.coreedge.raft.log.segmented.EntryCursor | From | To | |
| Inline Variable | 1 | ||
| Inline Variable hasSegment : boolean in method private nextSegment() : boolean from class org.neo4j.coreedge.raft.log.segmented.EntryCursor | From | To | |
| Rename Method | 1 | ||
| Rename Method public shouldThrowExceptionIfReadingAnEntryThatDoesNotExist() : void renamed to public shouldThrowExceptionWhenReadingAnEntryWhichHasBeenPruned() : void in class org.neo4j.coreedge.raft.log.RaftLogContractTest | From | To | |
| Pull Up Method | 4 | ||
| Pull Up Method private testSegmentFiles(size int) : ArrayList<SegmentFile> from class org.neo4j.coreedge.raft.log.segmented.EntryBasedLogPruningStrategyTest to package createSegmentFiles(size int) : ArrayList<SegmentFile> from class org.neo4j.coreedge.raft.log.segmented.PruningStrategyTest | From | To | |
| Pull Up Method private testSegmentFiles(size int) : ListIterator<SegmentFile> from class org.neo4j.coreedge.raft.log.segmented.SizeBasedLogPruningStrategyTest to package createSegmentFiles(size int) : ArrayList<SegmentFile> from class org.neo4j.coreedge.raft.log.segmented.PruningStrategyTest | From | To | |
| Pull Up Method private testSegmentHeader(value long) : SegmentHeader from class org.neo4j.coreedge.raft.log.segmented.EntryBasedLogPruningStrategyTest to private testSegmentHeader(value long) : SegmentHeader from class org.neo4j.coreedge.raft.log.segmented.PruningStrategyTest | From | To | |
| Pull Up Method private testSegmentHeader(value long) : SegmentHeader from class org.neo4j.coreedge.raft.log.segmented.SizeBasedLogPruningStrategyTest to private testSegmentHeader(value long) : SegmentHeader from class org.neo4j.coreedge.raft.log.segmented.PruningStrategyTest | From | To | |
| Inline Method | 2 | ||
| Inline Method private collectSegmentsForDisposal(pruneIndex long, forDisposal Collection<SegmentFile>) : SegmentFile inlined to public prune(pruneIndex long) : SegmentFile in class org.neo4j.coreedge.raft.log.segmented.Segments | From | To | |
| Rename Variable | 4 | ||
| Rename Variable oldestNotDisposed : SegmentFile to notDisposed : SegmentFile in method public prune(pruneIndex long) : SegmentFile in class org.neo4j.coreedge.raft.log.segmented.Segments | From | To | |
| Rename Variable entryCacheSize : int to readerPoolSize : int in method protected createRaftLog() : RaftLog in class org.neo4j.coreedge.raft.log.segmented.SegmentedRaftLogVerificationIT | From | To | |
| Rename Variable limitOptional : Optional<Long> to optionalFile : Optional<SegmentFile> in method private nextSegment() : boolean in class org.neo4j.coreedge.raft.log.segmented.EntryCursor | From | To | |
| Rename Variable raftLogEntry : RaftLogEntry to entry : RaftLogEntry in method public readEntryTerm(logIndex long) : long in class org.neo4j.coreedge.raft.log.segmented.SegmentedRaftLog | From | To | |
| Change Return Type | 2 | ||
| Change Return Type ListIterator<SegmentFile> to ArrayList<SegmentFile> in method package createSegmentFiles(size int) : ArrayList<SegmentFile> in class org.neo4j.coreedge.raft.log.segmented.PruningStrategyTest | From | To | |
| Change Return Type void to boolean in method public delete() : boolean in class org.neo4j.coreedge.raft.log.segmented.SegmentFile | From | To | |
| Replace Variable With Attribute | 3 | ||
| Replace Variable With Attribute newReader : IOCursor<EntryRecord> to reader : IOCursor<EntryRecord> in method private nextSegment() : boolean in class org.neo4j.coreedge.raft.log.segmented.EntryCursor | From | To | |
| Replace Variable With Attribute segmentFile : SegmentFile to file : SegmentFile in method public getIndexToKeep(segments Segments) : long in class org.neo4j.coreedge.raft.log.segmented.SizeBasedLogPruningStrategy | From | To | |
| Replace Variable With Attribute spy : SegmentFile to fileA : SegmentFile in method public shouldNotSwallowExceptionOnClose() : void in class org.neo4j.coreedge.raft.log.segmented.SegmentsTest | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.neo4j.coreedge.raft.log.segmented.PruningStrategyTest from classes [org.neo4j.coreedge.raft.log.segmented.EntryBasedLogPruningStrategyTest, org.neo4j.coreedge.raft.log.segmented.SizeBasedLogPruningStrategyTest] | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute reader : ReadAheadChannel<StoreChannel> to bufferedReader : ReadAheadChannel<StoreChannel> in class org.neo4j.coreedge.raft.log.segmented.EntryRecordCursor | From | To | |
| Rename Attribute segmentedRaftLogPruner : SegmentedRaftLogPruner to pruner : SegmentedRaftLogPruner in class org.neo4j.coreedge.raft.log.segmented.SegmentedRaftLog | From | To | |
| Rename Attribute segmentFiles : List<SegmentFile> to allSegments : List<SegmentFile> in class org.neo4j.coreedge.raft.log.segmented.Segments | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type readerPool : StoreChannelPool to readerPool : ReaderPool in class org.neo4j.coreedge.raft.log.segmented.SegmentFile | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method package visit(visitor Visitor<SegmentFile,RuntimeException>) : void extracted from private dump(filenameOrDirectory String, out PrintStream) : int in class org.neo4j.coreedge.raft.log.segmented.DumpSegmentedRaftLog & moved to class org.neo4j.coreedge.raft.log.segmented.Segments | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter reader : ReadAheadChannel<StoreChannel> to bufferedReader : ReadAheadChannel<StoreChannel> in method package EntryRecordCursor(bufferedReader ReadAheadChannel<StoreChannel>, contentMarshal ChannelMarshal<ReplicatedContent>, startIndex long) in class org.neo4j.coreedge.raft.log.segmented.EntryRecordCursor | From | To | |
| Rename Parameter segmentFiles : List<SegmentFile> to allSegments : List<SegmentFile> in method package Segments(fileSystem FileSystemAbstraction, fileNames FileNames, readerPool ReaderPool, allSegments List<SegmentFile>, contentMarshal ChannelMarshal<ReplicatedContent>, logProvider LogProvider, currentVersion long) in class org.neo4j.coreedge.raft.log.segmented.Segments | From | To | |
| Rename Parameter pruningStrategyConfig : String to pruningConfig : String in method public SegmentedRaftLog(fileSystem FileSystemAbstraction, directory File, rotateAtSize long, contentMarshal ChannelMarshal<ReplicatedContent>, logProvider LogProvider, pruningConfig String, readerPoolSize int, clock Clock) in class org.neo4j.coreedge.raft.log.segmented.SegmentedRaftLog | From | To |