neo4j d8dbe0ca37c1391b6df23b4860866e2a2accaa28

d8dbe0ca37c1391b6df23b4860866e2a2accaa28

Files Diff

Added: 1
Removed: 2
Renamed: 0
Modified: 27

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	2
Rename Method public shouldSerializeAndDeserializeUsingByteBuffer() : void renamed to public shouldSerializeAndDeserialize() : void in class org.neo4j.coreedge.raft.membership.CoreMemberMarshalTest	From	To
Rename Method public shouldMarshalAndUnmarshalFromByteBuf() : void renamed to public shouldMarshalAndUnmarshalFromChannel() : void in class org.neo4j.coreedge.server.AdvertisedSocketAddressMarshallingTest	From	To
Move And Inline Method	4
Move And Inline Method public unmarshal(buffer ByteBuf) : CoreMember moved from class org.neo4j.coreedge.server.CoreMember.CoreMemberMarshal to class org.neo4j.coreedge.raft.net.codecs.RaftMessageDecoder & inlined to protected decode(ctx ChannelHandlerContext, buffer ByteBuf, list List<Object>) : void	From	To
Move And Inline Method public marshal(member CoreMember, buffer ByteBuf) : void moved from class org.neo4j.coreedge.server.CoreMember.CoreMemberMarshal to class org.neo4j.coreedge.raft.net.codecs.RaftMessageEncoder & inlined to protected encode(ctx ChannelHandlerContext, message RaftMessages.RaftMessage<CoreMember>, list List<Object>) : void	From	To
Move And Inline Method public unmarshal(buffer ByteBuffer) : CoreMember moved from class org.neo4j.coreedge.server.CoreMember.CoreMemberMarshal to class org.neo4j.coreedge.raft.net.codecs.RaftMessageDecoder & inlined to protected decode(ctx ChannelHandlerContext, buffer ByteBuf, list List<Object>) : void	From	To
Move And Inline Method public marshal(member CoreMember, buffer ByteBuffer) : void moved from class org.neo4j.coreedge.server.CoreMember.CoreMemberMarshal to class org.neo4j.coreedge.raft.net.codecs.RaftMessageEncoder & inlined to protected encode(ctx ChannelHandlerContext, message RaftMessages.RaftMessage<CoreMember>, list List<Object>) : void	From	To
Change Parameter Type	9
Change Parameter Type marshal : ByteBufMarshal<ReplicatedContent> to marshal : ChannelMarshal<ReplicatedContent> in method public RaftServer(marshal ChannelMarshal<ReplicatedContent>, listenAddress ListenSocketAddress, logProvider LogProvider) in class org.neo4j.coreedge.raft.RaftServer	From	To
Change Parameter Type buffer : ByteBuf to buffer : WritableChannel in method private writeMember(member CoreMember, buffer WritableChannel) : void in class org.neo4j.coreedge.raft.net.codecs.RaftMessageEncoder	From	To
Change Parameter Type marshal : ByteBufMarshal<ReplicatedContent> to marshal : ChannelMarshal<ReplicatedContent> in method public RaftMessageEncoder(marshal ChannelMarshal<ReplicatedContent>) in class org.neo4j.coreedge.raft.net.codecs.RaftMessageEncoder	From	To
Change Parameter Type marshal : ByteBufMarshal<ReplicatedContent> to marshal : ChannelMarshal<ReplicatedContent> in method public RaftChannelInitializer(marshal ChannelMarshal<ReplicatedContent>) in class org.neo4j.coreedge.raft.net.RaftChannelInitializer	From	To
Change Parameter Type source : ByteBuf to source : ReadableChannel in method public unmarshal(source ReadableChannel) : CoreSnapshot in class org.neo4j.coreedge.raft.state.CoreSnapshot.Marshal	From	To
Change Parameter Type marshal : ByteBufMarshal<ReplicatedContent> to marshal : ChannelMarshal<ReplicatedContent> in method public NaiveDurableRaftLog(fileSystem FileSystemAbstraction, directory File, marshal ChannelMarshal<ReplicatedContent>, logProvider LogProvider) in class org.neo4j.coreedge.raft.log.naive.NaiveDurableRaftLog	From	To
Change Parameter Type marshal : ByteBufMarshal<ReplicatedContent> to marshal : ChannelMarshal<ReplicatedContent> in method public RaftMessageDecoder(marshal ChannelMarshal<ReplicatedContent>) in class org.neo4j.coreedge.raft.net.codecs.RaftMessageDecoder	From	To
Change Parameter Type buffer : ByteBuf to buffer : WritableChannel in method public marshal(coreSnapshot CoreSnapshot, buffer WritableChannel) : void in class org.neo4j.coreedge.raft.state.CoreSnapshot.Marshal	From	To
Change Parameter Type buffer : ByteBuf to buffer : ReadableChannel in method private retrieveMember(buffer ReadableChannel) : CoreMember in class org.neo4j.coreedge.raft.net.codecs.RaftMessageDecoder	From	To
Inline Method	1
Inline Method private dealWithPossibleNullAddress(coreAddress AdvertisedSocketAddress, raftAddress AdvertisedSocketAddress) : CoreMember inlined to public unmarshal(source ReadableChannel) : CoreMember in class org.neo4j.coreedge.server.CoreMember.CoreMemberMarshal	From	To
Rename Variable	1
Rename Variable buffer : ByteBuf to channel : ReadableChannel in method protected decode(ctx ChannelHandlerContext, buffer ByteBuf, list List<Object>) : void in class org.neo4j.coreedge.raft.net.codecs.RaftMessageDecoder	From	To
Rename Class	1
Rename Class org.neo4j.coreedge.raft.replication.CoreReplicatedContentByteBufferMarshalTest renamed to org.neo4j.coreedge.raft.replication.CoreReplicatedContentMarshalTest	From	To
Parameterize Variable	3
Parameterize Variable message : ReplicatedContent to replicatedTx : ReplicatedContent in method private assertMarshalingEquality(buffer ByteBuf, replicatedTx ReplicatedContent) : void in class org.neo4j.coreedge.raft.replication.CoreReplicatedContentMarshalTest	From	To
Change Variable Type	7
Change Variable Type marshal : AdvertisedSocketAddress.AdvertisedSocketAddressByteBufferMarshal to marshal : AdvertisedSocketAddress.AdvertisedSocketAddressChannelMarshal in method private writeMember(member CoreMember, buffer WritableChannel) : void in class org.neo4j.coreedge.raft.net.codecs.RaftMessageEncoder	From	To
Change Variable Type buffer : ByteBuf to channel : ReadableChannel in method protected decode(ctx ChannelHandlerContext, buffer ByteBuf, list List<Object>) : void in class org.neo4j.coreedge.raft.net.codecs.RaftMessageDecoder	From	To
Change Variable Type logChannel : NetworkReadableClosableByteBuf to logChannel : NetworkReadableClosableChannelNetty4 in method protected decode(ctx ChannelHandlerContext, msg ByteBuf, out List<Object>) : void in class org.neo4j.coreedge.catchup.tx.edge.TxPullResponseDecoder	From	To
Change Variable Type transactionCursor : PhysicalTransactionCursor<NetworkReadableClosableByteBuf> to transactionCursor : PhysicalTransactionCursor<NetworkReadableClosableChannelNetty4> in method protected decode(ctx ChannelHandlerContext, msg ByteBuf, out List<Object>) : void in class org.neo4j.coreedge.catchup.tx.edge.TxPullResponseDecoder	From	To
Change Variable Type marshal : AdvertisedSocketAddress.AdvertisedSocketAddressByteBufferMarshal to marshal : AdvertisedSocketAddress.AdvertisedSocketAddressChannelMarshal in method private retrieveMember(buffer ReadableChannel) : CoreMember in class org.neo4j.coreedge.raft.net.codecs.RaftMessageDecoder	From	To
Change Variable Type marshal : AdvertisedSocketAddress.AdvertisedSocketAddressByteBufferMarshal to marshal : AdvertisedSocketAddress.AdvertisedSocketAddressChannelMarshal in method public shouldMarshalAndUnmarshalFromChannel() : void in class org.neo4j.coreedge.server.AdvertisedSocketAddressMarshallingTest	From	To
Change Variable Type reader : LogEntryReader<NetworkReadableClosableByteBuf> to reader : LogEntryReader<NetworkReadableClosableChannelNetty4> in method protected decode(ctx ChannelHandlerContext, msg ByteBuf, out List<Object>) : void in class org.neo4j.coreedge.catchup.tx.edge.TxPullResponseDecoder	From	To
Extract Variable	1
Extract Variable channel : NetworkFlushableByteBuf in method protected encode(ctx ChannelHandlerContext, response TxPullResponse, out List<Object>) : void from class org.neo4j.coreedge.catchup.tx.core.TxPullResponseEncoder	From	To
Extract Method	5
Extract Method private assertMarshalingEquality(buffer ByteBuf, replicatedTx ReplicatedContent) : void extracted from public shouldMarshalMemberSet() : void in class org.neo4j.coreedge.raft.replication.CoreReplicatedContentMarshalTest	From	To
Extract Method private assertMarshalingEquality(buffer ByteBuf, replicatedTx ReplicatedContent) : void extracted from public shouldMarshalTransactionReferenceWithMissingHeader() : void in class org.neo4j.coreedge.raft.replication.CoreReplicatedContentMarshalTest	From	To
Extract Method private assertMarshalingEquality(buffer ByteBuf, replicatedTx ReplicatedContent) : void extracted from public shouldMarshalTransactionReference() : void in class org.neo4j.coreedge.raft.replication.CoreReplicatedContentMarshalTest	From	To
Extract Method private assertMarshalingEquality(buffer ByteBuf, replicatedTx ReplicatedContent) : void extracted from public shouldMarshalTokenRequest() : void in class org.neo4j.coreedge.raft.replication.CoreReplicatedContentMarshalTest	From	To
Extract Method private assertMarshalingEquality(buffer ByteBuf, replicatedTx ReplicatedContent) : void extracted from public shouldMarshalIdRangeRequest() : void in class org.neo4j.coreedge.raft.replication.CoreReplicatedContentMarshalTest	From	To
Change Attribute Type	8
Change Attribute Type marshal : ByteBufMarshal<ReplicatedContent> to marshal : ChannelMarshal<ReplicatedContent> in class org.neo4j.coreedge.raft.net.codecs.RaftMessageDecoder	From	To
Change Attribute Type marshal : ByteBufMarshal<ReplicatedContent> to marshal : ChannelMarshal<ReplicatedContent> in class org.neo4j.coreedge.raft.net.codecs.RaftMessageEncodingDecodingTest	From	To
Change Attribute Type marshal : ByteBufMarshal<ReplicatedContent> to marshal : ChannelMarshal<ReplicatedContent> in class org.neo4j.coreedge.raft.net.RaftChannelInitializer	From	To
Change Attribute Type serializer : ByteBufMarshal<ReplicatedContent> to serializer : ChannelMarshal<ReplicatedContent> in class org.neo4j.coreedge.raft.net.RaftMessageProcessingTest	From	To
Change Attribute Type marshal : ByteBufMarshal<ReplicatedContent> to marshal : ChannelMarshal<ReplicatedContent> in class org.neo4j.coreedge.raft.net.codecs.RaftMessageEncoder	From	To
Change Attribute Type marshal : ByteBufMarshal<ReplicatedContent> to marshal : ChannelMarshal<ReplicatedContent> in class org.neo4j.coreedge.raft.log.naive.NaiveDurableRaftLog	From	To
Change Attribute Type marshal : ByteBufMarshal<ReplicatedContent> to marshal : ChannelMarshal<ReplicatedContent> in class org.neo4j.coreedge.raft.RaftServer	From	To
Change Attribute Type marshal : ByteBufMarshal<ReplicatedContent> to marshal : ChannelMarshal<ReplicatedContent> in class org.neo4j.coreedge.raft.replication.CoreReplicatedContentMarshalTest	From	To

d8dbe0ca37c1391b6df23b4860866e2a2accaa28

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: