d8f990c7c2806dc2787081bfcfaeeed200868f27
Files Diff
- Added: 10
- Removed: 1
- Renamed: 0
- Modified: 37
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Extract Subclass | 1 | ||
| Extract Subclass org.neo4j.kernel.impl.api.index.OnlineIndexUpdatesValidator from class org.neo4j.kernel.impl.api.index.IndexUpdatesValidator | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type indexUpdatesValidator : IndexUpdatesValidator to indexingService : IndexingService in method private buildRecovery(fileSystemAbstraction FileSystemAbstraction, cacheAccess CacheAccessBackDoor, indexingService IndexingService, labelScanStore LabelScanStore, neoStore NeoStore, recoveryVisitorMonitor RecoveryVisitor.Monitor, recoveryMonitor Recovery.Monitor, logFiles PhysicalLogFiles, logRotationControl LogRotationControl, startupStatistics StartupStatisticsProvider, legacyIndexApplierLookup LegacyIndexApplierLookup) : void in class org.neo4j.kernel.NeoStoreDataSource | From | To | |
| Change Parameter Type mode : TransactionApplicationMode to indexUpdatesValidator : IndexUpdatesValidator in method private commitProcess(indexing IndexingService, indexUpdatesValidator IndexUpdatesValidator) : TransactionRepresentationCommitProcess in class org.neo4j.kernel.impl.transaction.state.NeoStoreTransactionTest | From | To | |
| Push Down Attribute | 4 | ||
| Push Down Attribute private propertyStore : PropertyStore from class org.neo4j.kernel.impl.api.index.IndexUpdatesValidator to private propertyStore : PropertyStore from class org.neo4j.kernel.impl.api.index.OnlineIndexUpdatesValidator | From | To | |
| Push Down Attribute private propertyLoader : PropertyLoader from class org.neo4j.kernel.impl.api.index.IndexUpdatesValidator to private propertyLoader : PropertyLoader from class org.neo4j.kernel.impl.api.index.OnlineIndexUpdatesValidator | From | To | |
| Push Down Attribute private indexing : IndexingService from class org.neo4j.kernel.impl.api.index.IndexUpdatesValidator to private indexing : IndexingService from class org.neo4j.kernel.impl.api.index.OnlineIndexUpdatesValidator | From | To | |
| Push Down Attribute private nodeStore : NodeStore from class org.neo4j.kernel.impl.api.index.IndexUpdatesValidator to private nodeStore : NodeStore from class org.neo4j.kernel.impl.api.index.OnlineIndexUpdatesValidator | From | To | |
| Rename Class | 1 | ||
| Rename Class org.neo4j.kernel.impl.api.index.IndexUpdatesValidatorTest renamed to org.neo4j.kernel.impl.api.index.OnlineIndexUpdatesValidatorTest | From | To | |
| Move Class | 1 | ||
| Move Class org.neo4j.kernel.impl.api.index.IndexUpdatesValidator.NodePropertyCommandsExtractor moved to org.neo4j.kernel.impl.api.index.NodePropertyCommandsExtractor | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type indexUpdatesValidator : IndexUpdatesValidator to neoStoreProvider : NeoStoreProvider in method private addMockedNeoStore(dependencyResolver DependencyResolver) : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest | From | To | |
| Change Variable Type storeApplier : TransactionRepresentationStoreApplier to storeApplier : BatchingTransactionRepresentationStoreApplier in method public shouldNotApplyTransactionIfIndexUpdatesValidationFails() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest | From | To | |
| Change Variable Type txApplier : TransactionRepresentationStoreApplier to txApplier : BatchingTransactionRepresentationStoreApplier in method public clientShouldReadAndApplyTransactionLogsOnNewLockSessionRequest() : void in class org.neo4j.ha.upgrade.MasterClientTest | From | To | |
| Extract Variable | 1 | ||
| Extract Variable neoStore : NeoStore in method private addMockedNeoStore(dependencyResolver DependencyResolver) : void from class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest | From | To | |
| Extract Method | 2 | ||
| Extract Method private addMockedNeoStore(dependencyResolver DependencyResolver) : void extracted from public shouldNotApplyTransactionIfIndexUpdatesValidationFails() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest | From | To | |
| Extract Method private addMockedNeoStore(dependencyResolver DependencyResolver) : void extracted from public shouldNotMarkTransactionsAsCommittedIfAppenderClosed() : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest | From | To | |
| Rename Method | 1 | ||
| Rename Method package noCommandsExtracted() : boolean renamed to public containsAnyNodeOrPropertyUpdate() : boolean in class org.neo4j.kernel.impl.api.index.NodePropertyCommandsExtractor | From | To | |
| Push Down Method | 2 | ||
| Push Down Method public validate(transaction TransactionRepresentation, mode TransactionApplicationMode) : ValidatedIndexUpdates from class org.neo4j.kernel.impl.api.index.IndexUpdatesValidator to public validate(transaction TransactionRepresentation) : ValidatedIndexUpdates from class org.neo4j.kernel.impl.api.index.OnlineIndexUpdatesValidator | From | To | |
| Push Down Method public IndexUpdatesValidator(neoStore NeoStore, propertyLoader PropertyLoader, indexing IndexingService) from class org.neo4j.kernel.impl.api.index.IndexUpdatesValidator to public OnlineIndexUpdatesValidator(neoStore NeoStore, propertyLoader PropertyLoader, indexing IndexingService, updateMode IndexUpdateMode) from class org.neo4j.kernel.impl.api.index.OnlineIndexUpdatesValidator | From | To | |
| Rename Variable | 1 | ||
| Rename Variable indexUpdatesValidator : IndexUpdatesValidator to neoStoreProvider : NeoStoreProvider in method private addMockedNeoStore(dependencyResolver DependencyResolver) : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to IndexUpdatesValidator in method private setUpIndexUpdatesValidatorMocking(dependencyResolverMock DependencyResolver) : IndexUpdatesValidator in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest | From | To | |
| Parameterize Variable | 2 | ||
| Parameterize Variable resolver : DependencyResolver to dependencyResolver : DependencyResolver in method private addMockedNeoStore(dependencyResolver DependencyResolver) : void in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpackerTest | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute recoveredUpdates : Set<NodePropertyUpdate> to batchedUpdates : Set<NodePropertyUpdate> in class org.neo4j.kernel.impl.api.index.IndexRecoveryIT.GatheringIndexWriter | From | To | |
| Rename Attribute inRecovery : boolean to isBatched : boolean in class org.neo4j.kernel.api.impl.index.LuceneIndexAccessor.LuceneIndexUpdater | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type storeApplier : TransactionRepresentationStoreApplier to storeApplier : BatchingTransactionRepresentationStoreApplier in class org.neo4j.com.storecopy.TransactionCommittingResponseUnpacker | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter inRecovery : boolean to inBatched : boolean in method private LuceneIndexUpdater(inBatched boolean) in class org.neo4j.kernel.api.impl.index.LuceneIndexAccessor.LuceneIndexUpdater | From | To | |
| Rename Parameter mode : TransactionApplicationMode to indexUpdatesValidator : IndexUpdatesValidator in method private commitProcess(indexing IndexingService, indexUpdatesValidator IndexUpdatesValidator) : TransactionRepresentationCommitProcess in class org.neo4j.kernel.impl.transaction.state.NeoStoreTransactionTest | From | To | |
| Rename Parameter indexUpdatesValidator : IndexUpdatesValidator to indexingService : IndexingService in method private buildRecovery(fileSystemAbstraction FileSystemAbstraction, cacheAccess CacheAccessBackDoor, indexingService IndexingService, labelScanStore LabelScanStore, neoStore NeoStore, recoveryVisitorMonitor RecoveryVisitor.Monitor, recoveryMonitor Recovery.Monitor, logFiles PhysicalLogFiles, logRotationControl LogRotationControl, startupStatistics StartupStatisticsProvider, legacyIndexApplierLookup LegacyIndexApplierLookup) : void in class org.neo4j.kernel.NeoStoreDataSource | From | To |