dc1dffe5afaace46147fd4ee1c1f152419359efb
Files Diff
- Added: 5
- Removed: 6
- Renamed: 0
- Modified: 35
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 4 | ||
Rename Method public shouldSendHeartBeatsAfterBecomingLeader() : void renamed to public shouldAppendNewLeaderBarrierAfterBecomingLeader() : void in class org.neo4j.coreedge.raft.RaftInstanceTest | From | To | |
Rename Method public shouldNotUpdateCommitIndexIfConsumerFails() : void renamed to public shouldUpdateCommitIndexEvenIfConsumerFails() : void in class org.neo4j.coreedge.raft.log.RaftLogAdversarialTest | From | To | |
Rename Method public shouldFailFutureForTransactionCommittedUnderWrongLockManager() : void renamed to public shouldFailFutureForTransactionCommittedUnderOldLeader() : void in class org.neo4j.coreedge.raft.replication.tx.ReplicatedTransactionStateMachineTest | From | To | |
Rename Method public shouldRejectTransactionCommittedUnderOldAssignmentOfLockManager() : void renamed to public shouldRejectTransactionCommittedUnderOldLeader() : void in class org.neo4j.coreedge.raft.replication.tx.ReplicatedTransactionStateMachineTest | From | To | |
Move Method | 1 | ||
Move Method public read(channel NetworkReadableLogChannelNetty4) : TransactionRepresentation from class org.neo4j.coreedge.raft.replication.tx.ReplicatedTransactionFactory.TransactionDeserializer to public read(channel NetworkReadableLogChannelNetty4, extraHeader byte[]) : TransactionRepresentation from class org.neo4j.coreedge.raft.replication.tx.ReplicatedTransactionFactory | From | To | |
Rename Variable | 3 | ||
Rename Variable i : int to index : int in method public replay() : void in class org.neo4j.coreedge.raft.log.NaiveDurableRaftLog | From | To | |
Rename Variable deleteStoreOnStartUp : DeleteStoreOnStartUp to recoverTransactionLogState : RecoverTransactionLogState in method public raftTimeOutServiceTriggersMessagesSentToAnotherServer() : void in class org.neo4j.coreedge.CoreServerStartupProcessTest | From | To | |
Rename Variable i : int to index : int in method public replay() : void in class org.neo4j.coreedge.raft.log.InMemoryRaftLog | From | To | |
Rename Attribute | 3 | ||
Rename Attribute SERVICE_ASSIGNMENT_TYPE : byte to NEW_LEADER_BARRIER_TYPE : byte in class org.neo4j.coreedge.raft.net.CoreReplicatedContentMarshal | From | To | |
Rename Attribute lastTxIdForPreviousAssignment : long to lastTxIdForPreviousLeaderReign : long in class org.neo4j.coreedge.raft.replication.tx.ReplicatedTransactionStateMachine | From | To | |
Rename Attribute localCommitProcess : TransactionCommitProcess to commitProcess : TransactionCommitProcess in class org.neo4j.coreedge.raft.replication.tx.ReplicatedTransactionStateMachine | From | To | |
Change Variable Type | 1 | ||
Change Variable Type deleteStoreOnStartUp : DeleteStoreOnStartUp to recoverTransactionLogState : RecoverTransactionLogState in method public raftTimeOutServiceTriggersMessagesSentToAnotherServer() : void in class org.neo4j.coreedge.CoreServerStartupProcessTest | From | To | |
Extract Variable | 4 | ||
Extract Variable localCommit : long in method private caughtUpWithLeader() : boolean from class org.neo4j.coreedge.raft.membership.MembershipWaiter.Evaluator | From | To | |
Extract Variable relationshipTypeTokenHolder : ReplicatedRelationshipTypeTokenHolder in method public EnterpriseCoreEditionModule(platformModule PlatformModule, discoveryServiceFactory DiscoveryServiceFactory) from class org.neo4j.coreedge.server.core.EnterpriseCoreEditionModule | From | To | |
Extract Variable labelTokenHolder : ReplicatedLabelTokenHolder in method public EnterpriseCoreEditionModule(platformModule PlatformModule, discoveryServiceFactory DiscoveryServiceFactory) from class org.neo4j.coreedge.server.core.EnterpriseCoreEditionModule | From | To | |
Extract Variable propertyKeyTokenHolder : ReplicatedPropertyKeyTokenHolder in method public EnterpriseCoreEditionModule(platformModule PlatformModule, discoveryServiceFactory DiscoveryServiceFactory) from class org.neo4j.coreedge.server.core.EnterpriseCoreEditionModule | From | To | |
Extract Method | 1 | ||
Extract Method package appendNewEntry(ctx ReadableRaftState<MEMBER>, outcome Outcome<MEMBER>, content ReplicatedContent) : void extracted from public handle(message RaftMessages.Message<MEMBER>, ctx ReadableRaftState<MEMBER>, log Log) : Outcome<MEMBER> in class org.neo4j.coreedge.raft.roles.Leader | From | To | |
Rename Parameter | 1 | ||
Rename Parameter localCommitProcess : TransactionCommitProcess to commitProcess : TransactionCommitProcess in method public ReplicatedTransactionStateMachine(commitProcess TransactionCommitProcess, myGlobalSession GlobalSession, dependencies Dependencies) in class org.neo4j.coreedge.raft.replication.tx.ReplicatedTransactionStateMachine | From | To |