dd27c4acac18b432bc206507d6572190a1501c9f
Files Diff
- Added: 8
- Removed: 3
- Renamed: 0
- Modified: 14
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 1 | ||
| Merge Attribute [backupFlowFactory : BackupFlowFactory, backupFlow : BackupFlow] to backupStrategyCoordinatorFactory : BackupStrategyCoordinatorFactory in class org.neo4j.backup.OnlineBackupCommandTest | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type backupFlowFactory : BackupFlowFactory to backupStrategyCoordinatorFactory : BackupStrategyCoordinatorFactory in method package OnlineBackupCommand(outsideWorld OutsideWorld, onlineBackupContextLoader OnlineBackupContextLoader, backupSupportingClassesFactory AbstractBackupSupportingClassesFactory, backupStrategyCoordinatorFactory BackupStrategyCoordinatorFactory) in class org.neo4j.backup.OnlineBackupCommand | From | To | |
| Move Method | 2 | ||
| Move Method private traverseGenerateMoveActions(dir File, basePath File) : Stream<FileMoveAction> from class org.neo4j.com.storecopy.StoreCopyClient to package traverseGenerateMoveActions(dir File, basePath File) : Stream<FileMoveAction> from class org.neo4j.com.storecopy.FileMoveProvider | From | To | |
| Move Method private expandTraverseFiles(dir File, basePath File) : Stream<FileMoveAction> from class org.neo4j.com.storecopy.StoreCopyClient to private expandTraverseFiles(dir File, basePath File) : Stream<FileMoveAction> from class org.neo4j.com.storecopy.FileMoveProvider | From | To | |
| Extract Class | 1 | ||
| Extract Class org.neo4j.com.storecopy.FileMoveProvider from class org.neo4j.com.storecopy.StoreCopyClient | From | To | |
| Rename Class | 3 | ||
| Rename Class org.neo4j.backup.BackupFlowTest renamed to org.neo4j.backup.BackupStrategyCoordinatorTest | From | To | |
| Rename Class org.neo4j.backup.BackupFlow renamed to org.neo4j.backup.BackupStrategyCoordinator | From | To | |
| Rename Class org.neo4j.backup.BackupFlowFactory renamed to org.neo4j.backup.BackupStrategyCoordinatorFactory | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type backupFlow : BackupFlow to backupStrategyCoordinator : BackupStrategyCoordinator in method public execute(args String[]) : void in class org.neo4j.backup.OnlineBackupCommand | From | To | |
| Extract Variable | 3 | ||
| Extract Variable directoryExistsInCachedSystem : boolean in method public move(toDir File, copyOptions CopyOption...) : void from class org.neo4j.com.storecopy.FileMoveAction.copyViaPageCache | From | To | |
| Extract Variable previousBackupExists : boolean in method private performBackupWithoutLifecycle(onlineBackupContext OnlineBackupContext) : PotentiallyErroneousState<BackupStrategyOutcome> from class org.neo4j.backup.BackupStrategyWrapper | From | To | |
| Extract Variable master : boolean in method public getMaster() : HighlyAvailableGraphDatabase from class org.neo4j.kernel.impl.ha.ClusterManager.ManagedCluster | From | To | |
| Extract Method | 2 | ||
| Extract Method private moveFromTemporaryLocationToCorrect(storeFileMoveActions List<FileMoveAction>, tempStore File, moveAfterCopy MoveAfterCopy) : void extracted from public copyStore(requester StoreCopyRequester, cancellationRequest CancellationRequest, moveAfterCopy MoveAfterCopy) : void in class org.neo4j.com.storecopy.StoreCopyClient | From | To | |
| Extract Method private recoverDatabase(tempStore File) : void extracted from public copyStore(requester StoreCopyRequester, cancellationRequest CancellationRequest, moveAfterCopy MoveAfterCopy) : void in class org.neo4j.com.storecopy.StoreCopyClient | From | To | |
| Split Attribute | 1 | ||
| Split Attribute backupFlowFactory : BackupFlowFactory to [backupStrategyCoordinatorFactory : BackupStrategyCoordinatorFactory, backupStrategyCoordinator : BackupStrategyCoordinator] in class org.neo4j.backup.OnlineBackupCommandTest | From | To | |
| Rename Method | 1 | ||
| Rename Method package backupFlow(onlineBackupContext OnlineBackupContext, backupProtocolService BackupProtocolService, backupDelegator BackupDelegator, pageCache PageCache) : BackupFlow renamed to package backupStrategyCoordinator(onlineBackupContext OnlineBackupContext, backupProtocolService BackupProtocolService, backupDelegator BackupDelegator, pageCache PageCache) : BackupStrategyCoordinator in class org.neo4j.backup.BackupStrategyCoordinatorFactory | From | To | |
| Rename Variable | 1 | ||
| Rename Variable backupFlow : BackupFlow to backupStrategyCoordinator : BackupStrategyCoordinator in method public execute(args String[]) : void in class org.neo4j.backup.OnlineBackupCommand | From | To | |
| Change Return Type | 1 | ||
| Change Return Type BackupFlow to BackupStrategyCoordinator in method package backupStrategyCoordinator(onlineBackupContext OnlineBackupContext, backupProtocolService BackupProtocolService, backupDelegator BackupDelegator, pageCache PageCache) : BackupStrategyCoordinator in class org.neo4j.backup.BackupStrategyCoordinatorFactory | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute outsideWorld : OutsideWorld to fileMoveProvider : FileMoveProvider in class org.neo4j.backup.BackupCopyService | From | To | |
| Rename Attribute backupFlow : BackupFlow to backupStrategyCoordinator : BackupStrategyCoordinator in class org.neo4j.backup.OnlineBackupCommandTest | From | To | |
| Rename Attribute backupFlowFactory : BackupFlowFactory to backupStrategyCoordinatorFactory : BackupStrategyCoordinatorFactory in class org.neo4j.backup.OnlineBackupCommand | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type outsideWorld : OutsideWorld to fileMoveProvider : FileMoveProvider in class org.neo4j.backup.BackupCopyService | From | To | |
| Change Attribute Type backupFlowFactory : BackupFlowFactory to backupStrategyCoordinatorFactory : BackupStrategyCoordinatorFactory in class org.neo4j.backup.OnlineBackupCommand | From | To | |
| Change Attribute Type backupFlow : BackupFlow to backupStrategyCoordinator : BackupStrategyCoordinator in class org.neo4j.backup.OnlineBackupCommandTest | From | To | |
| Change Attribute Type subject : BackupFlow to subject : BackupStrategyCoordinator in class org.neo4j.backup.BackupStrategyCoordinatorTest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter timeout : long to timeoutMillis : long in method public isAvailable(timeoutMillis long) : boolean in class org.neo4j.kernel.impl.factory.GraphDatabaseFacade | From | To | |
| Rename Parameter backupFlowFactory : BackupFlowFactory to backupStrategyCoordinatorFactory : BackupStrategyCoordinatorFactory in method package OnlineBackupCommand(outsideWorld OutsideWorld, onlineBackupContextLoader OnlineBackupContextLoader, backupSupportingClassesFactory AbstractBackupSupportingClassesFactory, backupStrategyCoordinatorFactory BackupStrategyCoordinatorFactory) in class org.neo4j.backup.OnlineBackupCommand | From | To |