dfd2a227f0b5de623cc3a5c1df06a0d4e2901ac9
Files Diff
- Added: 9
- Removed: 11
- Renamed: 0
- Modified: 29
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 2 | ||
| Merge Attribute [schemaIndexProvider : SchemaIndexProvider, labelScanStoreProvider : LabelScanStoreProvider] to progressMonitor : MigrationProgressMonitor in class org.neo4j.kernel.impl.storemigration.participant.LegacyIndexMigratorTest | From | To | |
| Merge Attribute [schemaIndexProvider : SchemaIndexProvider, labelScanStoreProvider : LabelScanStoreProvider] to progressMonitor : MigrationProgressMonitor in class org.neo4j.kernel.impl.storemigration.participant.SchemaIndexMigratorTest | From | To | |
| Pull Up Method | 4 | ||
| Pull Up Method public rebuildCounts(storeDir File, versionToMigrateFrom String) : void from class org.neo4j.kernel.impl.storemigration.LegacyIndexMigrator to public rebuildCounts(storeDir File, versionToMigrateFrom String) : void from class org.neo4j.kernel.impl.storemigration.participant.BaseStoreMigrationParticipant | From | To | |
| Pull Up Method public cleanup(migrationDir File) : void from class org.neo4j.kernel.impl.storemigration.SchemaIndexMigrator to public cleanup(migrationDir File) : void from class org.neo4j.kernel.impl.storemigration.participant.BaseStoreMigrationParticipant | From | To | |
| Pull Up Method public rebuildCounts(storeDir File, versionToMigrateFrom String) : void from class org.neo4j.kernel.impl.storemigration.SchemaIndexMigrator to public rebuildCounts(storeDir File, versionToMigrateFrom String) : void from class org.neo4j.kernel.impl.storemigration.participant.BaseStoreMigrationParticipant | From | To | |
| Pull Up Method public cleanup(migrationDir File) : void from class org.neo4j.kernel.impl.storemigration.LegacyIndexMigrator to public cleanup(migrationDir File) : void from class org.neo4j.kernel.impl.storemigration.participant.BaseStoreMigrationParticipant | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type monitor : Monitor to config : Config in method private newUpgrader(upgradableDatabase UpgradableDatabase, pageCache PageCache, config Config) : StoreUpgrader in class upgrade.StoreUpgraderTest | From | To | |
| Change Parameter Type upgradeConfiguration : UpgradeConfiguration to upgradableDatabase : UpgradableDatabase in method public StoreUpgrader(upgradableDatabase UpgradableDatabase, progressMonitor MigrationProgressMonitor, config Config, fileSystem FileSystemAbstraction, logProvider LogProvider) in class org.neo4j.kernel.impl.storemigration.StoreUpgrader | From | To | |
| Inline Method | 1 | ||
| Inline Method private newUpgrader(upgradeConfig UpgradeConfiguration, pageCache PageCache) : StoreUpgrader inlined to public shouldContinueMovingFilesIfUpgradeCancelledWhileMoving() : void in class upgrade.StoreUpgraderTest | From | To | |
| Rename Variable | 1 | ||
| Rename Variable indexProvider : LegacyIndexProvider to legacyIndexProvider : LegacyIndexProvider in method public run(fs FileSystemAbstraction, storeDirectory File, config Config, userLogProvider LogProvider) : void in class org.neo4j.tools.migration.StoreMigration | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private schemaIndexProvider : SchemaIndexProvider from class org.neo4j.kernel.impl.storemigration.LegacyIndexMigratorTest to private schemaIndexProvider : SchemaIndexProvider from class org.neo4j.kernel.impl.storemigration.DatabaseMigrator | From | To | |
| Move Attribute private config : Config from class org.neo4j.kernel.impl.storemigration.ConfigMapUpgradeConfiguration to private config : Config from class org.neo4j.kernel.impl.storemigration.StoreUpgrader | From | To | |
| Move Attribute private labelScanStoreProvider : LabelScanStoreProvider from class org.neo4j.kernel.impl.storemigration.LegacyIndexMigratorTest to private labelScanStoreProvider : LabelScanStoreProvider from class org.neo4j.kernel.impl.storemigration.DatabaseMigrator | From | To | |
| Extract Class | 1 | ||
| Extract Class org.neo4j.kernel.impl.storemigration.DatabaseMigrator from class org.neo4j.kernel.impl.storemigration.LegacyIndexMigratorTest | From | To | |
| Move Class | 7 | ||
| Move Class org.neo4j.kernel.impl.storemigration.SchemaIndexMigratorTest moved to org.neo4j.kernel.impl.storemigration.participant.SchemaIndexMigratorTest | From | To | |
| Move Class org.neo4j.kernel.impl.storemigration.LegacyIndexMigrator moved to org.neo4j.kernel.impl.storemigration.participant.LegacyIndexMigrator | From | To | |
| Move Class org.neo4j.kernel.impl.storemigration.StoreMigratorTest moved to org.neo4j.kernel.impl.storemigration.participant.StoreMigratorTest | From | To | |
| Move Class org.neo4j.kernel.impl.storemigration.StoreSourceTraceability moved to org.neo4j.kernel.impl.storemigration.participant.StoreSourceTraceability | From | To | |
| Move Class org.neo4j.kernel.impl.storemigration.LegacyIndexMigratorTest moved to org.neo4j.kernel.impl.storemigration.participant.LegacyIndexMigratorTest | From | To | |
| Move Class org.neo4j.kernel.impl.storemigration.StoreMigrator moved to org.neo4j.kernel.impl.storemigration.participant.StoreMigrator | From | To | |
| Move Class org.neo4j.kernel.impl.storemigration.SchemaIndexMigrator moved to org.neo4j.kernel.impl.storemigration.participant.SchemaIndexMigrator | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.neo4j.kernel.impl.storemigration.participant.BaseStoreMigrationParticipant from classes [org.neo4j.kernel.impl.storemigration.participant.LegacyIndexMigrator, org.neo4j.kernel.impl.storemigration.participant.SchemaIndexMigrator, org.neo4j.kernel.impl.storemigration.participant.StoreMigrator] | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute monitor : Monitor to progressMonitor : MigrationProgressMonitor in class org.neo4j.kernel.impl.storemigration.StoreUpgrader | From | To | |
| Rename Attribute upgradeConfiguration : UpgradeConfiguration to upgradableDatabase : UpgradableDatabase in class org.neo4j.kernel.impl.storemigration.StoreUpgrader | From | To | |
| Rename Attribute progressMonitor : MigrationProgressMonitor to schemaIndexProvider : SchemaIndexProvider in class org.neo4j.kernel.impl.storemigration.participant.StoreMigrator | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type monitor : Monitor to progressMonitor : MigrationProgressMonitor in class org.neo4j.kernel.impl.storemigration.StoreUpgrader | From | To | |
| Change Attribute Type upgradeConfiguration : UpgradeConfiguration to upgradableDatabase : UpgradableDatabase in class org.neo4j.kernel.impl.storemigration.StoreUpgrader | From | To | |
| Change Attribute Type progressMonitor : MigrationProgressMonitor to schemaIndexProvider : SchemaIndexProvider in class org.neo4j.kernel.impl.storemigration.participant.StoreMigrator | From | To | |
| Extract Method | 10 | ||
| Extract Method private newUpgrader(upgradableDatabase UpgradableDatabase, pageCache PageCache) : StoreUpgrader extracted from public shouldRefuseToUpgradeIfAnyOfTheStoresWeNotShutDownCleanly() : void in class upgrade.StoreUpgraderTest | From | To | |
| Extract Method private newUpgrader(upgradableDatabase UpgradableDatabase, config Config, pageCache PageCache) : StoreUpgrader extracted from public shouldHaltUpgradeIfUpgradeConfigurationVetoesTheProcess() : void in class upgrade.StoreUpgraderTest | From | To | |
| Extract Method private newUpgrader(upgradableDatabase UpgradableDatabase, pageCache PageCache) : StoreUpgrader extracted from public shouldRefuseToUpgradeIfAllOfTheStoresWereNotShutDownCleanly() : void in class upgrade.StoreUpgraderTest | From | To | |
| Extract Method private newUpgrader(upgradableDatabase UpgradableDatabase, pageCache PageCache) : StoreUpgrader extracted from public shouldUpgradeAnOldFormatStore() : void in class upgrade.StoreUpgraderTest | From | To | |
| Extract Method private newUpgrader(upgradableDatabase UpgradableDatabase, config Config, pageCache PageCache) : StoreUpgrader extracted from public upgradedNeoStoreShouldHaveNewUpgradeTimeAndUpgradeId() : void in class upgrade.StoreUpgraderTest | From | To | |
| Extract Method private upgradeStore() : void extracted from public start() : void in class org.neo4j.kernel.NeoStoreDataSource | From | To | |
| Extract Method private newUpgrader(upgradableDatabase UpgradableDatabase, config Config, pageCache PageCache) : StoreUpgrader extracted from public upgradeShouldNotLeaveLeftoverAndMigrationDirs() : void in class upgrade.StoreUpgraderTest | From | To | |
| Extract Method private newUpgrader(upgradableDatabase UpgradableDatabase, pageCache PageCache) : StoreUpgrader extracted from public shouldLeaveAllFilesUntouchedIfWrongVersionNumberFound() : void in class upgrade.StoreUpgraderTest | From | To | |
| Extract Method private newUpgrader(upgradableDatabase UpgradableDatabase, pageCache PageCache) : StoreUpgrader extracted from public shouldContinueMovingFilesIfUpgradeCancelledWhileMoving() : void in class upgrade.StoreUpgraderTest | From | To | |
| Extract Method private newUpgrader(upgradableDatabase UpgradableDatabase, config Config, pageCache PageCache) : StoreUpgrader extracted from public shouldContinueMovingFilesIfUpgradeCancelledWhileMoving() : void in class upgrade.StoreUpgraderTest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter upgradeConfiguration : UpgradeConfiguration to upgradableDatabase : UpgradableDatabase in method public StoreUpgrader(upgradableDatabase UpgradableDatabase, progressMonitor MigrationProgressMonitor, config Config, fileSystem FileSystemAbstraction, logProvider LogProvider) in class org.neo4j.kernel.impl.storemigration.StoreUpgrader | From | To | |
| Rename Parameter monitor : Monitor to config : Config in method private newUpgrader(upgradableDatabase UpgradableDatabase, pageCache PageCache, config Config) : StoreUpgrader in class upgrade.StoreUpgraderTest | From | To |