neo4j e6da4057d98dc930037901f2d447522b5449719e

e6da4057d98dc930037901f2d447522b5449719e

Files Diff

Added: 8
Removed: 2
Renamed: 0
Modified: 21

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Extract Subclass	1
Extract Subclass org.neo4j.kernel.ha.SlaveUpdatePuller from class org.neo4j.kernel.ha.UpdatePuller	From	To
Push Down Attribute	8
Push Down Attribute private instanceId : InstanceId from class org.neo4j.kernel.ha.UpdatePuller to private instanceId : InstanceId from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Attribute private halted : boolean from class org.neo4j.kernel.ha.UpdatePuller to private halted : boolean from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Attribute private cappedLogger : CappedOperation<Pair<String,? extends Exception>> from class org.neo4j.kernel.ha.UpdatePuller to private cappedLogger : CappedOperation<Pair<String,? extends Exception>> from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Attribute public NEXT_TICKET : Condition from class org.neo4j.kernel.ha.UpdatePuller to package NEXT_TICKET : Condition from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Attribute private currentTicket : AtomicInteger from class org.neo4j.kernel.ha.UpdatePuller to private currentTicket : AtomicInteger from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Attribute private me : Thread from class org.neo4j.kernel.ha.UpdatePuller to private me : Thread from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Attribute private targetTicket : AtomicInteger from class org.neo4j.kernel.ha.UpdatePuller to private targetTicket : AtomicInteger from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Attribute private logger : StringLogger from class org.neo4j.kernel.ha.UpdatePuller to private logger : StringLogger from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Move Attribute	6
Move Attribute private lastUpdateTime : LastUpdateTime from class org.neo4j.kernel.ha.UpdatePuller to private lastUpdateTime : LastUpdateTime from class org.neo4j.kernel.ha.PullerFactory	From	To
Move Attribute private updatePuller : UpdatePuller from class org.neo4j.kernel.ha.UpdatePullerTest to private updatePuller : UpdatePuller from class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Move Attribute private master : Master from class org.neo4j.kernel.ha.UpdatePuller to private master : Master from class org.neo4j.kernel.ha.PullerFactory	From	To
Move Attribute private requestContextFactory : RequestContextFactory from class org.neo4j.kernel.ha.UpdatePuller to private requestContextFactory : RequestContextFactory from class org.neo4j.kernel.ha.PullerFactory	From	To
Move Attribute private invalidEpochHandler : InvalidEpochExceptionHandler from class org.neo4j.kernel.ha.UpdatePuller to private invalidEpochHandler : InvalidEpochExceptionHandler from class org.neo4j.kernel.ha.PullerFactory	From	To
Move Attribute private memberStateMachine : HighAvailabilityMemberStateMachine from class org.neo4j.kernel.ha.UpdatePuller to private memberStateMachine : HighAvailabilityMemberStateMachine from class org.neo4j.kernel.ha.PullerFactory	From	To
Extract Class	1
Extract Class org.neo4j.kernel.ha.PullerFactory from class org.neo4j.kernel.ha.UpdatePuller	From	To
Rename Class	1
Rename Class org.neo4j.kernel.ha.UpdatePullerClient renamed to org.neo4j.kernel.ha.UpdatePullerScheduler	From	To
Move Class	2
Move Class org.neo4j.kernel.ha.UpdatePullerTest.ErrorTrackingLogger moved to org.neo4j.kernel.ha.SlaveUpdatePullerTest.ErrorTrackingLogger	From	To
Move Class org.neo4j.kernel.ha.UpdatePullerTest.ErrorTrackingLogging moved to org.neo4j.kernel.ha.SlaveUpdatePullerTest.ErrorTrackingLogging	From	To
Change Variable Type	1
Change Variable Type client : UpdatePullerClient to updatePuller : UpdatePuller in method public sync(except HighlyAvailableGraphDatabase...) : void in class org.neo4j.test.ha.ClusterManager.ManagedCluster	From	To
Extract Variable	1
Extract Variable obligationFulfiller : TransactionObligationFulfiller in method private startHaCommunication(haCommunicationLife LifeSupport, neoDataSource NeoStoreDataSource, me URI, masterUri URI, storeId StoreId, cancellationRequest CancellationRequest) : URI from class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Extract Method	1
Extract Method private getLocalhostUri() : URI extracted from public shouldReturnNullIfWhenFailingToPullingUpdatesFromMaster() : void in class org.neo4j.kernel.ha.cluster.SwitchToSlaveTest	From	To
Push Down Method	9
Push Down Method public run() : void from class org.neo4j.kernel.ha.UpdatePuller to public run() : void from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Method public shutdown() : void from class org.neo4j.kernel.ha.UpdatePuller to public shutdown() : void from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Method private poke() : int from class org.neo4j.kernel.ha.UpdatePuller to private poke() : int from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Method public await(condition Condition, strictlyAssertActive boolean) : boolean from class org.neo4j.kernel.ha.UpdatePuller to private await(condition Condition, strictlyAssertActive boolean) : boolean from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Method public isActive() : boolean from class org.neo4j.kernel.ha.UpdatePuller to public isActive() : boolean from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Method private doPullUpdates() : void from class org.neo4j.kernel.ha.UpdatePuller to private doPullUpdates() : void from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Method public toString() : String from class org.neo4j.kernel.ha.UpdatePuller to public toString() : String from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Method public init() : void from class org.neo4j.kernel.ha.UpdatePuller to public init() : void from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Push Down Method private checkActive(strictlyAssertActive boolean) : boolean from class org.neo4j.kernel.ha.UpdatePuller to private checkActive(strictlyAssertActive boolean) : boolean from class org.neo4j.kernel.ha.SlaveUpdatePuller	From	To
Rename Variable	3
Rename Variable client : UpdatePullerClient to updatePuller : UpdatePuller in method public sync(except HighlyAvailableGraphDatabase...) : void in class org.neo4j.test.ha.ClusterManager.ManagedCluster	From	To
Rename Variable nioneoDataSource : NeoStoreDataSource to neoDataSource : NeoStoreDataSource in method public switchToSlave(haCommunicationLife LifeSupport, me URI, masterUri URI, cancellationRequest CancellationRequest) : URI in class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Rename Variable toTest : HighAvailabilityModeSwitcher to modeSwitcher : HighAvailabilityModeSwitcher in method public shouldRecognizeNewMasterIfNewMasterBecameAvailableDuringSwitch() : void in class org.neo4j.kernel.ha.cluster.HighAvailabilityModeSwitcherTest	From	To
Change Attribute Type	1
Change Attribute Type intervalJobHandle : JobHandle to intervalJobHandle : JobScheduler.JobHandle in class org.neo4j.kernel.ha.UpdatePullerScheduler	From	To
Rename Parameter	2
Rename Parameter nioneoDataSource : NeoStoreDataSource to neoDataSource : NeoStoreDataSource in method private executeConsistencyChecks(myId InstanceId, masterUri URI, neoDataSource NeoStoreDataSource, cancellationRequest CancellationRequest) : boolean in class org.neo4j.kernel.ha.cluster.SwitchToSlave	From	To
Rename Parameter updatePullingThread : UpdatePuller to updatePuller : UpdatePuller in method public UpdatePullerScheduler(updatePuller UpdatePuller, scheduler JobScheduler, logging Logging, pullIntervalMillis long) in class org.neo4j.kernel.ha.UpdatePullerScheduler	From	To

e6da4057d98dc930037901f2d447522b5449719e

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: