e6e6d9dfe3832e630a13d15441de709f6b5f4c84
Files Diff
- Added: 10
- Removed: 5
- Renamed: 0
- Modified: 36
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public create(samplingConfig IndexSamplingConfig, scheduler JobScheduler, providerMap SchemaIndexProviderMap, storeView IndexStoreView, tokenNameLookup TokenNameLookup, indexRules Iterable<IndexRule>, logProvider LogProvider, monitor Monitor, schemaStateChangeCallback Runnable) : IndexingService from class org.neo4j.kernel.impl.api.index.IndexingService to public createIndexingService(samplingConfig IndexSamplingConfig, scheduler JobScheduler, providerMap SchemaIndexProviderMap, storeView IndexStoreView, tokenNameLookup TokenNameLookup, indexRules Iterable<IndexRule>, logProvider LogProvider, monitor IndexingService.Monitor, schemaStateChangeCallback Runnable) : IndexingService from class org.neo4j.kernel.impl.api.index.IndexingServiceFactory | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type rule : IndexRule to rules : IndexRule... in method public createIndexes(rules IndexRule...) : void in class org.neo4j.kernel.impl.api.index.IndexingService | From | To | |
| Change Parameter Type proxySetup : IndexProxySetup to indexProxyCreator : IndexProxyCreator in method package IndexingService(indexProxyCreator IndexProxyCreator, providerMap SchemaIndexProviderMap, indexMapRef IndexMapReference, storeView IndexStoreView, indexRules Iterable<IndexRule>, samplingController IndexSamplingController, tokenNameLookup TokenNameLookup, scheduler JobScheduler, schemaStateChangeCallback Runnable, logProvider LogProvider, monitor Monitor) in class org.neo4j.kernel.impl.api.index.IndexingService | From | To | |
| Change Parameter Type monitor : Monitor to monitor : IndexingService.Monitor in method public createIndexingService(samplingConfig IndexSamplingConfig, scheduler JobScheduler, providerMap SchemaIndexProviderMap, storeView IndexStoreView, tokenNameLookup TokenNameLookup, indexRules Iterable<IndexRule>, logProvider LogProvider, monitor IndexingService.Monitor, schemaStateChangeCallback Runnable) : IndexingService in class org.neo4j.kernel.impl.api.index.IndexingServiceFactory | From | To | |
| Move Method | 1 | ||
| Move Method private populateFromQueueIfAvailable(currentlyIndexedNodeId long) : void from class org.neo4j.kernel.impl.api.index.IndexPopulationJob to private populateFromQueueIfAvailable(currentlyIndexedNodeId long) : void from class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Move Attribute | 10 | ||
| Move Attribute private logProvider : LogProvider from class org.neo4j.kernel.impl.api.index.IndexPopulationJob to private logProvider : LogProvider from class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Move Attribute private scheduler : JobScheduler from class org.neo4j.kernel.impl.api.index.PopulatingIndexProxy to private scheduler : JobScheduler from class org.neo4j.kernel.impl.api.index.IndexingService | From | To | |
| Move Attribute private indexUserDescription : String from class org.neo4j.kernel.impl.api.index.IndexPopulationJob to package indexUserDescription : String from class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.IndexPopulation | From | To | |
| Move Attribute private queue : Queue<NodePropertyUpdate> from class org.neo4j.kernel.impl.api.index.IndexPopulationJob to private queue : Queue<NodePropertyUpdate> from class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Move Attribute private indexCountsRemover : IndexCountsRemover from class org.neo4j.kernel.impl.api.index.IndexPopulationJob to package indexCountsRemover : IndexCountsRemover from class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.IndexPopulation | From | To | |
| Move Attribute private providerDescriptor : SchemaIndexProvider.Descriptor from class org.neo4j.kernel.impl.api.index.IndexPopulationJob to package providerDescriptor : SchemaIndexProvider.Descriptor from class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.IndexPopulation | From | To | |
| Move Attribute private flipper : FlippableIndexProxy from class org.neo4j.kernel.impl.api.index.IndexPopulationJob to package flipper : FlippableIndexProxy from class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.IndexPopulation | From | To | |
| Move Attribute private log : Log from class org.neo4j.kernel.impl.api.index.IndexPopulationJob to private log : Log from class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator | From | To | |
| Move Attribute private descriptor : IndexDescriptor from class org.neo4j.kernel.impl.api.index.IndexPopulationJob to package descriptor : IndexDescriptor from class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.IndexPopulation | From | To | |
| Move Attribute private config : IndexConfiguration from class org.neo4j.kernel.impl.api.index.IndexPopulationJob to package config : IndexConfiguration from class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.IndexPopulation | From | To | |
| Extract Class | 2 | ||
| Extract Class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator from class org.neo4j.kernel.impl.api.index.IndexPopulationJob | From | To | |
| Extract Class org.neo4j.kernel.impl.api.index.MultipleIndexPopulator.IndexPopulation from class org.neo4j.kernel.impl.api.index.IndexPopulationJob | From | To | |
| Rename Class | 1 | ||
| Rename Class org.neo4j.kernel.impl.api.index.IndexProxySetup renamed to org.neo4j.kernel.impl.api.index.IndexProxyCreator | From | To | |
| Move Class | 4 | ||
| Move Class org.neo4j.kernel.impl.api.index.UniquePropertyIndexUpdater moved to org.neo4j.kernel.impl.api.index.updater.UniquePropertyIndexUpdater | From | To | |
| Move Class org.neo4j.kernel.impl.api.index.DelegatingIndexUpdater moved to org.neo4j.kernel.impl.api.index.updater.DelegatingIndexUpdater | From | To | |
| Move Class org.neo4j.kernel.impl.api.index.UpdateCountingIndexUpdater moved to org.neo4j.kernel.impl.api.index.updater.UpdateCountingIndexUpdater | From | To | |
| Move Class org.neo4j.kernel.impl.api.index.SwallowingIndexUpdater moved to org.neo4j.kernel.impl.api.index.updater.SwallowingIndexUpdater | From | To | |
| Extract Variable | 1 | ||
| Extract Variable diff : int in method public selection(among T[], min int, max int, allowDuplicates boolean) : T[] from class org.neo4j.test.Randoms | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type visitor : Visitor<NodePropertyUpdate,RuntimeException> to visitor : Visitor<NodePropertyUpdate,IndexPopulationFailedKernelException> in method public answer(invocation InvocationOnMock) : StoreScan<IndexPopulationFailedKernelException> in class org.neo4j.kernel.impl.api.index.IndexingServiceTest.DataUpdates | From | To | |
| Change Variable Type result : RESULT to loaded : NodeRecord in method public run() : void in class org.neo4j.kernel.impl.transaction.state.NeoStoreIndexStoreView.NodeStoreScan | From | To | |
| Rename Method | 2 | ||
| Rename Method public createIndex(rule IndexRule) : void renamed to public createIndexes(rules IndexRule...) : void in class org.neo4j.kernel.impl.api.index.IndexingService | From | To | |
| Rename Method public samplingController() : IndexSamplingController renamed to public getSamplingController() : IndexSamplingController in class org.neo4j.kernel.impl.api.index.IndexingService | From | To | |
| Rename Variable | 1 | ||
| Rename Variable result : RESULT to loaded : NodeRecord in method public run() : void in class org.neo4j.kernel.impl.transaction.state.NeoStoreIndexStoreView.NodeStoreScan | From | To | |
| Change Return Type | 2 | ||
| Change Return Type StoreScan<RuntimeException> to StoreScan<IndexPopulationFailedKernelException> in method public answer(invocation InvocationOnMock) : StoreScan<IndexPopulationFailedKernelException> in class org.neo4j.kernel.impl.api.index.IndexingServiceTest.DataUpdates | From | To | |
| Change Return Type Visitor<NodePropertyUpdate,RuntimeException> to Visitor<NodePropertyUpdate,IndexPopulationFailedKernelException> in method private visitor(v Object) : Visitor<NodePropertyUpdate,IndexPopulationFailedKernelException> in class org.neo4j.kernel.impl.api.index.IndexingServiceTest.DataUpdates | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute proxySetup : IndexProxySetup to indexProxyCreator : IndexProxyCreator in class org.neo4j.kernel.impl.api.index.IndexingService | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type populator : IndexPopulator to populator : MultipleIndexPopulator in class org.neo4j.kernel.impl.api.index.IndexPopulationJob | From | To | |
| Change Attribute Type proxySetup : IndexProxySetup to indexProxyCreator : IndexProxyCreator in class org.neo4j.kernel.impl.api.index.IndexingService | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter rule : IndexRule to rules : IndexRule... in method public createIndexes(rules IndexRule...) : void in class org.neo4j.kernel.impl.api.index.IndexingService | From | To | |
| Rename Parameter proxySetup : IndexProxySetup to indexProxyCreator : IndexProxyCreator in method package IndexingService(indexProxyCreator IndexProxyCreator, providerMap SchemaIndexProviderMap, indexMapRef IndexMapReference, storeView IndexStoreView, indexRules Iterable<IndexRule>, samplingController IndexSamplingController, tokenNameLookup TokenNameLookup, scheduler JobScheduler, schemaStateChangeCallback Runnable, logProvider LogProvider, monitor Monitor) in class org.neo4j.kernel.impl.api.index.IndexingService | From | To |