neo4j e70eee953f02baaa35ca78da63fcf1dcd3115429

e70eee953f02baaa35ca78da63fcf1dcd3115429

Files Diff

Added: 16
Removed: 4
Renamed: 0
Modified: 56

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method public key() : String from class org.neo4j.bolt.v1.runtime.BoltStateMachineV1 to public id() : String from class org.neo4j.server.web.JettyHttpConnection	From	To
Move And Inline Method	6
Move And Inline Method public open(connector String, rawChannel Channel, messageLogger BoltMessageLogger) : BoltChannel moved from class org.neo4j.bolt.BoltChannel to class org.neo4j.bolt.v1.BoltProtocolV1Test & inlined to private newBoltChannel(rawChannel Channel) : BoltChannel	From	To
Move And Inline Method public open(connector String, rawChannel Channel, messageLogger BoltMessageLogger) : BoltChannel moved from class org.neo4j.bolt.BoltChannel to class org.neo4j.bolt.BoltChannelTest & inlined to package shouldCloseUnderlyingChannelWhenItIsOpen() : void	From	To
Move And Inline Method public getBoltConnectionTracker(dependencyResolver DependencyResolver) : BoltConnectionTracker moved from class org.neo4j.kernel.enterprise.builtinprocs.EnterpriseBuiltInDbmsProcedures to class org.neo4j.server.security.enterprise.auth.ProcedureInteractionTestBase & inlined to package countBoltConnectionsByUsername() : Map<String,Long>	From	To
Move And Inline Method public open(connector String, rawChannel Channel, messageLogger BoltMessageLogger) : BoltChannel moved from class org.neo4j.bolt.BoltChannel to class org.neo4j.bolt.BoltChannelTest & inlined to package shouldLogWhenClosed() : void	From	To
Move And Inline Method public open(connector String, rawChannel Channel, messageLogger BoltMessageLogger) : BoltChannel moved from class org.neo4j.bolt.BoltChannel to class org.neo4j.bolt.BoltChannelTest & inlined to package shouldNotCloseUnderlyingChannelWhenItIsClosed() : void	From	To
Move And Inline Method public open(connector String, rawChannel Channel, messageLogger BoltMessageLogger) : BoltChannel moved from class org.neo4j.bolt.BoltChannel to class org.neo4j.bolt.BoltChannelTest & inlined to package shouldLogWhenOpened() : void	From	To
Move And Rename Class	1
Move And Rename Class org.neo4j.kernel.api.bolt.BoltConnectionTracker moved and renamed to org.neo4j.kernel.api.net.NetworkConnectionTracker	From	To
Change Variable Type	2
Change Variable Type boltConnectionTracker : BoltConnectionTracker to connectionTracker : NetworkConnectionTracker in method package countBoltConnectionsByUsername() : Map<String,Long> in class org.neo4j.server.security.enterprise.auth.ProcedureInteractionTestBase	From	To
Change Variable Type ch : SocketChannel to ch : Channel in method private protocolOnAddress(address ListenSocketAddress) : NettyServer.ProtocolInitializer in class org.neo4j.bolt.v1.transport.NettyServerTest	From	To
Extract Method	2
Extract Method private isIPv6(hostname String) : boolean extracted from public isIPv6() : boolean in class org.neo4j.helpers.SocketAddress	From	To
Extract Method private getConnectionTracker() : NetworkConnectionTracker extracted from public listConnections() : Stream<ConnectionResult> in class org.neo4j.kernel.enterprise.builtinprocs.EnterpriseBuiltInDbmsProcedures	From	To
Rename Method	5
Rename Method protected createSessionTracker() : BoltConnectionTracker renamed to protected createConnectionTracker() : NetworkConnectionTracker in class org.neo4j.kernel.impl.enterprise.EnterpriseEditionModule	From	To
Rename Method protected createSessionTracker() : BoltConnectionTracker renamed to protected createConnectionTracker() : NetworkConnectionTracker in class org.neo4j.graphdb.factory.module.EditionModule	From	To
Rename Method protected createSessionTracker() : BoltConnectionTracker renamed to protected createConnectionTracker() : NetworkConnectionTracker in class org.neo4j.kernel.ha.factory.HighlyAvailableEditionModule	From	To
Rename Method protected createSessionTracker() : BoltConnectionTracker renamed to protected createConnectionTracker() : NetworkConnectionTracker in class org.neo4j.causalclustering.readreplica.EnterpriseReadReplicaEditionModule	From	To
Rename Method protected createSessionTracker() : BoltConnectionTracker renamed to protected createConnectionTracker() : NetworkConnectionTracker in class org.neo4j.causalclustering.core.EnterpriseCoreEditionModule	From	To
Inline Method	1
Inline Method private getBoltConnectionTracker() : BoltConnectionTracker inlined to protected terminateConnectionsForValidUser(username String) : void in class org.neo4j.server.security.enterprise.auth.AuthProceduresBase	From	To
Rename Variable	2
Rename Variable owner : String to username : String in method private processInitMessage(message InitMessage, context StateMachineContext) : BoltStateMachineState in class org.neo4j.bolt.v1.runtime.ConnectedState	From	To
Rename Variable boltConnectionTracker : BoltConnectionTracker to connectionTracker : NetworkConnectionTracker in method package countBoltConnectionsByUsername() : Map<String,Long> in class org.neo4j.server.security.enterprise.auth.ProcedureInteractionTestBase	From	To
Change Return Type	8
Change Return Type Stream<ConnectionResult> to Stream<ListConnectionResult> in method public listConnections() : Stream<ListConnectionResult> in class org.neo4j.kernel.enterprise.builtinprocs.EnterpriseBuiltInDbmsProcedures	From	To
Change Return Type BoltConnectionTracker to NetworkConnectionTracker in method protected createConnectionTracker() : NetworkConnectionTracker in class org.neo4j.causalclustering.core.EnterpriseCoreEditionModule	From	To
Change Return Type BoltConnectionTracker to NetworkConnectionTracker in method protected createConnectionTracker() : NetworkConnectionTracker in class org.neo4j.graphdb.factory.module.EditionModule	From	To
Change Return Type BoltConnectionTracker to NetworkConnectionTracker in method protected createConnectionTracker() : NetworkConnectionTracker in class org.neo4j.causalclustering.readreplica.EnterpriseReadReplicaEditionModule	From	To
Change Return Type ChannelInitializer<io.netty.channel.socket.SocketChannel> to ChannelInitializer<Channel> in method public channelInitializer() : ChannelInitializer<Channel> in class org.neo4j.bolt.transport.NettyServer.ProtocolInitializer	From	To
Change Return Type BoltConnectionTracker to NetworkConnectionTracker in method protected createConnectionTracker() : NetworkConnectionTracker in class org.neo4j.kernel.impl.enterprise.EnterpriseEditionModule	From	To
Change Return Type ChannelInitializer<SocketChannel> to ChannelInitializer<Channel> in method public channelInitializer() : ChannelInitializer<Channel> in class org.neo4j.bolt.transport.SocketTransport	From	To
Change Return Type BoltConnectionTracker to NetworkConnectionTracker in method protected createConnectionTracker() : NetworkConnectionTracker in class org.neo4j.kernel.ha.factory.HighlyAvailableEditionModule	From	To
Rename Attribute	2
Rename Attribute boltLogging : BoltMessageLogging to boltChannel : BoltChannel in class org.neo4j.bolt.transport.TransportSelectionHandler	From	To
Rename Attribute NOOP : BoltConnectionTracker to NO_OP : NetworkConnectionTracker in class org.neo4j.kernel.api.net.NetworkConnectionTracker	From	To
Extract Interface	1
Extract Interface org.neo4j.kernel.api.net.TrackedNetworkConnection from classes [org.neo4j.bolt.BoltChannel]	From	To
Change Attribute Type	2
Change Attribute Type NOOP : BoltConnectionTracker to NO_OP : NetworkConnectionTracker in class org.neo4j.kernel.api.net.NetworkConnectionTracker	From	To
Change Attribute Type boltLogging : BoltMessageLogging to boltChannel : BoltChannel in class org.neo4j.bolt.transport.TransportSelectionHandler	From	To
Rename Parameter	1
Rename Parameter owner : String to username : String in method private newStatementProcessor(username String, userAgent String, authResult AuthenticationResult, context StateMachineContext) : StatementProcessor in class org.neo4j.bolt.v1.runtime.ConnectedState	From	To

e70eee953f02baaa35ca78da63fcf1dcd3115429

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: