e76da5f794a8baf103716f7fb80f5810f0c0511b
Files Diff
- Added: 2
- Removed: 3
- Renamed: 0
- Modified: 30
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 10 | ||
| Rename Method public deserialize(buffer ByteBuf) : String renamed to public unmarshal(buffer ByteBuf) : String in class org.neo4j.coreedge.raft.replication.StringMarshal | From | To | |
| Rename Method protected abstract getLogIndex(file File) : long renamed to protected abstract getOrdinalOfLastRecord(file File) : long in class org.neo4j.coreedge.raft.state.StateRecoveryManager | From | To | |
| Rename Method public serialize(buffer ByteBuffer, string String) : void renamed to public marshal(buffer ByteBuffer, string String) : void in class org.neo4j.coreedge.raft.replication.StringMarshal | From | To | |
| Rename Method public votedFor(votedFor MEMBER) : void renamed to public InMemoryVoteState(votedFor MEMBER, term long) in class org.neo4j.coreedge.raft.state.vote.InMemoryVoteState | From | To | |
| Rename Method public serialize(buffer ByteBuf, string String) : void renamed to public marshal(buffer ByteBuf, string String) : void in class org.neo4j.coreedge.raft.replication.StringMarshal | From | To | |
| Rename Method public shouldPanicIfCannotPersistToDisk() : void renamed to public shouldPanicAndThrowExceptionIfCannotPersistToDisk() : void in class org.neo4j.coreedge.raft.state.id_allocation.OnDiskIdAllocationStateTest | From | To | |
| Rename Method protected getLogIndex(file File) : long renamed to protected getOrdinalOfLastRecord(file File) : long in class org.neo4j.coreedge.raft.state.membership.RaftMembershipStateRecoveryManager | From | To | |
| Rename Method protected getLogIndex(file File) : long renamed to protected getOrdinalOfLastRecord(file File) : long in class org.neo4j.coreedge.raft.state.id_allocation.IdAllocationStateRecoveryManager | From | To | |
| Rename Method public deserialize(buffer ByteBuffer) : String renamed to public unmarshal(buffer ByteBuffer) : String in class org.neo4j.coreedge.raft.replication.StringMarshal | From | To | |
| Rename Method protected getLogIndex(storeFile File) : long renamed to protected getOrdinalOfLastRecord(storeFile File) : long in class org.neo4j.coreedge.raft.replication.id.StateRecoveryManagerTest.TestOnlyStateRecoveryManager | From | To | |
| Move Method | 1 | ||
| Move Method private readLastEntryFrom(fileSystemAbstraction FileSystemAbstraction, file File) : InMemoryVoteState<CoreMember> from class org.neo4j.coreedge.raft.state.vote.OnDiskVoteState to public readLastEntryFrom(fileSystemAbstraction FileSystemAbstraction, file File) : InMemoryVoteState<MEMBER> from class org.neo4j.coreedge.raft.state.vote.VoteStateRecoveryManager | From | To | |
| Rename Variable | 3 | ||
| Rename Variable decoder : AdvertisedSocketAddressDecoder to marshal : AdvertisedSocketAddress.AdvertisedSocketAddressMarshal in method private retrieveMember(buffer ByteBuf) : CoreMember in class org.neo4j.coreedge.raft.net.codecs.RaftMessageDecoder | From | To | |
| Rename Variable serializer : CoreMemberMarshal to marshal : CoreMemberMarshal in method public shouldSerializeAndDeserializeUsingByteBuffer() : void in class org.neo4j.coreedge.raft.membership.CoreMemberMarshalTest | From | To | |
| Rename Variable encoder : AdvertisedSocketAddressEncoder to marshal : AdvertisedSocketAddress.AdvertisedSocketAddressMarshal in method private writeMember(member CoreMember, buffer ByteBuf) : void in class org.neo4j.coreedge.raft.net.codecs.RaftMessageEncoder | From | To | |
| Move Source Folder | 1 | ||
| Move Source Folder enterprise/core-edge/src/main to enterprise/core-edge/src/test | From | To | |
| Change Return Type | 1 | ||
| Change Return Type InMemoryVoteState<CoreMember> to InMemoryVoteState<MEMBER> in method public readLastEntryFrom(fileSystemAbstraction FileSystemAbstraction, file File) : InMemoryVoteState<MEMBER> in class org.neo4j.coreedge.raft.state.vote.VoteStateRecoveryManager | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute NUMBER_OF_VOTES_PER_WRITE : int to NUMBER_OF_BYTES_PER_VOTE : int in class org.neo4j.coreedge.raft.state.vote.InMemoryVoteState.InMemoryVoteStateStateMarshal | From | To | |
| Extract Variable | 1 | ||
| Extract Variable mock : Supplier in method private createVoteStore(fileSystem FileSystemAbstraction) : VoteState<CoreMember> from class org.neo4j.coreedge.raft.state.VoteStateAdversarialTest | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type encoder : AdvertisedSocketAddressEncoder to marshal : AdvertisedSocketAddress.AdvertisedSocketAddressMarshal in method private writeMember(member CoreMember, buffer ByteBuf) : void in class org.neo4j.coreedge.raft.net.codecs.RaftMessageEncoder | From | To | |
| Change Variable Type lastRead : InMemoryRaftMembershipState to lastRead : InMemoryRaftMembershipState<MEMBER> in method public readLastEntryFrom(file File) : InMemoryRaftMembershipState<MEMBER> in class org.neo4j.coreedge.raft.state.membership.RaftMembershipStateRecoveryManager | From | To | |
| Change Variable Type decoder : AdvertisedSocketAddressDecoder to marshal : AdvertisedSocketAddress.AdvertisedSocketAddressMarshal in method private retrieveMember(buffer ByteBuf) : CoreMember in class org.neo4j.coreedge.raft.net.codecs.RaftMessageDecoder | From | To | |
| Extract Method | 2 | ||
| Extract Method private dealWithPossibleNullAddress(coreAddress AdvertisedSocketAddress, raftAddress AdvertisedSocketAddress) : CoreMember extracted from public unmarshal(buffer ByteBuffer) : CoreMember in class org.neo4j.coreedge.raft.membership.CoreMemberMarshal | From | To | |
| Extract Method private dealWithPossibleNullAddress(coreAddress AdvertisedSocketAddress, raftAddress AdvertisedSocketAddress) : CoreMember extracted from public unmarshal(buffer ByteBuf) : CoreMember in class org.neo4j.coreedge.raft.membership.CoreMemberMarshal | From | To |