neo4j f33a23381f6a780da6bfeeea6b59446c928d1789

f33a23381f6a780da6bfeeea6b59446c928d1789

Files Diff

Added: 14
Removed: 4
Renamed: 0
Modified: 39

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Extract Subclass	1
Extract Subclass org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler	From	To
Change Parameter Type	4
Change Parameter Type labelIdFilter : IntPredicate to labelIds : int[] in method public StoreViewNodeStoreScan(nodeStore NodeStore, locks LockService, propertyStore PropertyStore, labelUpdateVisitor Visitor<NodeLabelUpdate,FAILURE>, propertyUpdatesVisitor Visitor<NodePropertyUpdates,FAILURE>, labelIds int[], propertyKeyIdFilter IntPredicate) in class org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan	From	To
Change Parameter Type labelIdFilter : IntPredicate to labelIds : int[] in method public visitNodes(labelIds int[], propertyKeyIdFilter IntPredicate, propertyUpdateVisitor Visitor<NodePropertyUpdates,FAILURE>, labelUpdateVisitor Visitor<NodeLabelUpdate,FAILURE>) : StoreScan<FAILURE> in class org.neo4j.kernel.impl.api.index.IndexStoreView	From	To
Change Parameter Type labelIdFilter : IntPredicate to labelIds : int[] in method public visitNodes(labelIds int[], propertyKeyIdFilter IntPredicate, propertyUpdatesVisitor Visitor<NodePropertyUpdates,FAILURE>, labelUpdateVisitor Visitor<NodeLabelUpdate,FAILURE>) : StoreScan<FAILURE> in class org.neo4j.kernel.impl.transaction.state.storeview.NeoStoreIndexStoreView	From	To
Change Parameter Type fullStoreStream : FullStoreChangeStream to storeViewSupplier : Supplier<IndexStoreView> in method public LuceneLabelScanStoreBuilder(storeDir File, storeViewSupplier Supplier<IndexStoreView>, fileSystem FileSystemAbstraction, config Config, operationalMode OperationalMode, logProvider LogProvider) in class org.neo4j.index.lucene.LuceneLabelScanStoreBuilder	From	To
Push Down Attribute	6
Push Down Attribute private values : MultiSet<String> from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to private values : MultiSet<String> from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Push Down Attribute private sampledSteps : int from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to private sampledSteps : int from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Push Down Attribute private sampleSizeLimit : int from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to private sampleSizeLimit : int from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Push Down Attribute private accumulatedSampledSize : long from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to private accumulatedSampledSize : long from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Push Down Attribute private sampleSize : long from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to private sampleSize : long from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Push Down Attribute private accumulatedUniqueValues : long from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to private accumulatedUniqueValues : long from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Rename Class	1
Rename Class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSamplerTest renamed to org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSamplerTest	From	To
Move Class	4
Move Class org.neo4j.kernel.impl.transaction.state.NeoStoreIndexStoreViewTest moved to org.neo4j.kernel.impl.transaction.state.storeview.NeoStoreIndexStoreViewTest	From	To
Move Class org.neo4j.kernel.impl.transaction.state.NeoStoreIndexStoreView moved to org.neo4j.kernel.impl.transaction.state.storeview.NeoStoreIndexStoreView	From	To
Move Class org.neo4j.kernel.impl.transaction.state.NeoStoreIndexStoreView.NodeStoreScan moved to org.neo4j.kernel.impl.transaction.state.storeview.NodeStoreScan	From	To
Move Class org.neo4j.kernel.impl.transaction.state.NeoStoreIndexStoreView.StoreViewNodeStoreScan moved to org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan	From	To
Change Variable Type	2
Change Variable Type scan : NeoStoreIndexStoreView.NodeStoreScan to scan : NodeStoreScan in method public shouldGiveBackCompletionPercentage() : void in class org.neo4j.kernel.impl.transaction.state.NodeStoreScanTest	From	To
Change Variable Type descriptor : IndexDescriptor to multipleIndexPopulator : MultipleIndexPopulator in method private addPopulator(indexPopulator IndexPopulator, id int, flippableIndexProxy FlippableIndexProxy, failedIndexProxyFactory FailedIndexProxyFactory) : void in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulatorTest	From	To
Extract Method	1
Extract Method private addPopulator(multipleIndexPopulator MultipleIndexPopulator, indexPopulator IndexPopulator, id int, flippableIndexProxy FlippableIndexProxy, failedIndexProxyFactory FailedIndexProxyFactory) : void extracted from private addPopulator(indexPopulator IndexPopulator, id int, flippableIndexProxy FlippableIndexProxy, failedIndexProxyFactory FailedIndexProxyFactory) : void in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulatorTest	From	To
Rename Method	1
Rename Method private assertStillOpenForBusiness() : void renamed to private assertOpen() : void in class org.neo4j.kernel.impl.api.index.FlippableIndexProxy	From	To
Push Down Method	9
Push Down Method public include(value String, increment long) : void from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to public include(value String, increment long) : void from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Push Down Method public include(value String) : void from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to public include(value String) : void from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Push Down Method public result() : IndexSample from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to public result() : IndexSample from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Push Down Method public exclude(value String) : void from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to public exclude(value String) : void from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Push Down Method public exclude(value String, decrement long) : void from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to public exclude(value String, decrement long) : void from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Push Down Method private nextStep() : void from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to private nextStep() : void from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Push Down Method private calculateInitialSetSize(sampleSizeLimit int) : int from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to private calculateInitialSetSize(sampleSizeLimit int) : int from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Push Down Method public result(numDocs int) : IndexSample from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to public result(numDocs int) : IndexSample from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Push Down Method public NonUniqueIndexSampler(sampleSizeLimit int) from class org.neo4j.kernel.impl.api.index.sampling.NonUniqueIndexSampler to public DefaultNonUniqueIndexSampler(sampleSizeLimit int) from class org.neo4j.kernel.impl.api.index.sampling.DefaultNonUniqueIndexSampler	From	To
Replace Variable With Attribute	1
Replace Variable With Attribute descriptor : IndexDescriptor to multipleIndexPopulator : MultipleIndexPopulator in method private addPopulator(indexPopulator IndexPopulator, id int, flippableIndexProxy FlippableIndexProxy, failedIndexProxyFactory FailedIndexProxyFactory) : void in class org.neo4j.kernel.impl.api.index.MultipleIndexPopulatorTest	From	To
Rename Attribute	2
Rename Attribute fullStoreStream : FullStoreChangeStream to storeViewSupplier : Supplier<IndexStoreView> in class org.neo4j.index.lucene.LuceneLabelScanStoreBuilder	From	To
Rename Attribute labelIdFilter : IntPredicate to labelIds : int[] in class org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan	From	To
Change Attribute Type	3
Change Attribute Type labelId : long to labelId : int in class org.neo4j.kernel.impl.transaction.state.storeview.NeoStoreIndexStoreViewTest	From	To
Change Attribute Type fullStoreStream : FullStoreChangeStream to storeViewSupplier : Supplier<IndexStoreView> in class org.neo4j.index.lucene.LuceneLabelScanStoreBuilder	From	To
Change Attribute Type labelIdFilter : IntPredicate to labelIds : int[] in class org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan	From	To
Rename Parameter	4
Rename Parameter labelIdFilter : IntPredicate to labelIds : int[] in method public StoreViewNodeStoreScan(nodeStore NodeStore, locks LockService, propertyStore PropertyStore, labelUpdateVisitor Visitor<NodeLabelUpdate,FAILURE>, propertyUpdatesVisitor Visitor<NodePropertyUpdates,FAILURE>, labelIds int[], propertyKeyIdFilter IntPredicate) in class org.neo4j.kernel.impl.transaction.state.storeview.StoreViewNodeStoreScan	From	To
Rename Parameter labelIdFilter : IntPredicate to labelIds : int[] in method public visitNodes(labelIds int[], propertyKeyIdFilter IntPredicate, propertyUpdateVisitor Visitor<NodePropertyUpdates,FAILURE>, labelUpdateVisitor Visitor<NodeLabelUpdate,FAILURE>) : StoreScan<FAILURE> in class org.neo4j.kernel.impl.api.index.IndexStoreView	From	To
Rename Parameter labelIdFilter : IntPredicate to labelIds : int[] in method public visitNodes(labelIds int[], propertyKeyIdFilter IntPredicate, propertyUpdatesVisitor Visitor<NodePropertyUpdates,FAILURE>, labelUpdateVisitor Visitor<NodeLabelUpdate,FAILURE>) : StoreScan<FAILURE> in class org.neo4j.kernel.impl.transaction.state.storeview.NeoStoreIndexStoreView	From	To
Rename Parameter fullStoreStream : FullStoreChangeStream to storeViewSupplier : Supplier<IndexStoreView> in method public LuceneLabelScanStoreBuilder(storeDir File, storeViewSupplier Supplier<IndexStoreView>, fileSystem FileSystemAbstraction, config Config, operationalMode OperationalMode, logProvider LogProvider) in class org.neo4j.index.lucene.LuceneLabelScanStoreBuilder	From	To

f33a23381f6a780da6bfeeea6b59446c928d1789

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: