neo4j f9d2b35496754357ac4607037436eb0bc6021b0d

f9d2b35496754357ac4607037436eb0bc6021b0d

Files Diff

Added: 5
Removed: 10
Renamed: 0
Modified: 21

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Inline Method	2
Move And Inline Method package returnRelationships(ops EntityReadOperations, state KernelStatement, nodeId long, skipFirst boolean, relIds RelationshipData...) : void moved from class org.neo4j.kernel.impl.api.TwoPhaseNodeForRelationshipLockingTest to class org.neo4j.kernel.impl.api.LockingStatementOperationsTest & inlined to public detachDeleteNodeWithoutRelationshipsExclusivelyLockNode() : void	From	To
Move And Inline Method package returnRelationships(ops EntityReadOperations, state KernelStatement, nodeId long, skipFirst boolean, relIds RelationshipData...) : void moved from class org.neo4j.kernel.impl.api.TwoPhaseNodeForRelationshipLockingTest to class org.neo4j.kernel.impl.api.LockingStatementOperationsTest & inlined to public detachDeleteNodeExclusivelyLockNodes() : void	From	To
Change Parameter Type	1
Change Parameter Type relTypeCursor : Cursor<RelationshipTypeItem> to relTypeCursor : Cursor<IntSupplier> in method public DegreeCursor(relTypeCursor Cursor<IntSupplier>) in class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor.DegreeCursor	From	To
Move Method	1
Move Method private deduplicate(types int[]) : int[] from class org.neo4j.kernel.impl.api.OperationsFacade to private deduplicate(types int[]) : int[] from class org.neo4j.kernel.api.cursor.NodeItemHelper	From	To
Pull Up Attribute	10
Pull Up Attribute private currentId : long from class org.neo4j.kernel.impl.api.store.AllRelationshipIterator to private currentId : long from class org.neo4j.kernel.impl.api.store.AllRecordIdIterator	From	To
Pull Up Attribute private id : long from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to protected id : long from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Attribute private relationshipStore : RelationshipStore from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to protected relationshipStore : RelationshipStore from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Attribute private nodeState : NodeState from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to protected nodeState : NodeState from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Attribute private nodeRecord : NodeRecord from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to protected nodeRecord : NodeRecord from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Attribute private lockService : LockService from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to private lockService : LockService from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Attribute private cursor : Cursor<NodeItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to protected cursor : Cursor<NodeItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Attribute private nodeIsAddedInThisTx : boolean from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to protected nodeIsAddedInThisTx : boolean from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Attribute private state : TransactionState from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to protected state : TransactionState from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Attribute private relationshipGroupStore : RecordStore<RelationshipGroupRecord> from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to protected relationshipGroupStore : RecordStore<RelationshipGroupRecord> from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Move And Rename Class	1
Move And Rename Class org.neo4j.kernel.impl.api.store.DegreeItemCursor moved and renamed to org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor.DegreeItemIterator	From	To
Move Class	2
Move Class org.neo4j.kernel.impl.api.store.DegreeItemDenseCursor moved to org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor.DegreeItemDenseCursor	From	To
Move Class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor.DegreeCursor moved to org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor.DegreeCursor	From	To
Change Variable Type	1
Change Variable Type relTypesCursor : Cursor<RelationshipTypeItem> to relTypesCursor : Cursor<IntSupplier> in method private relTypes(cursor StoreSingleNodeCursor) : Set<TestRelType> in class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursorTest	From	To
Extract Variable	2
Extract Variable cursor : Cursor<NodeItem> in method private nodeCursor(statement StorageStatement, nodeId long) : Cursor<NodeItem> from class org.neo4j.kernel.api.txstate.TransactionCountingStateVisitor	From	To
Extract Variable exists : boolean in method public next() : boolean from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor	From	To
Inline Variable	2
Inline Variable firstIn : long in method public next() : boolean from class org.neo4j.kernel.impl.api.store.DegreeItemDenseCursor	From	To
Inline Variable firstOut : long in method public next() : boolean from class org.neo4j.kernel.impl.api.store.DegreeItemDenseCursor	From	To
Pull Up Method	28
Pull Up Method public degree(direction Direction) : int from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to public degree(direction Direction) : int from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Method public id() : long from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to public id() : long from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Method public close() : void from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to public close() : void from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Method public get() : NodeItem from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to public get() : NodeItem from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Method public degrees() : Cursor<DegreeItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to public degrees() : Cursor<DegreeItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Method public relationships(direction Direction, relTypes int...) : Cursor<RelationshipItem> from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to public relationships(direction Direction, relTypes int...) : Cursor<RelationshipItem> from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Method public degree(direction Direction, relType int) : int from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to public degree(direction Direction, relType int) : int from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Method private directionOf(nodeId long, relationshipId long, startNode long, endNode long) : Direction from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to private directionOf(nodeId long, relationshipId long, startNode long, endNode long) : Direction from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Method public labels() : Cursor<LabelItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to public labels() : Cursor<LabelItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Method public id() : long from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to public id() : long from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Method private shortLivedReadLock() : Lock from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to private shortLivedReadLock() : Lock from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Method public label(labelId int) : Cursor<LabelItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to public label(labelId int) : Cursor<LabelItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Method public properties() : Cursor<PropertyItem> from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to public properties() : Cursor<PropertyItem> from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Method public relationships(direction Direction) : Cursor<RelationshipItem> from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to public relationships(direction Direction) : Cursor<RelationshipItem> from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Method public isDense() : boolean from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to public isDense() : boolean from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Method public degrees() : Cursor<DegreeItem> from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to public degrees() : Cursor<DegreeItem> from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Method public degree(direction Direction) : int from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to public degree(direction Direction) : int from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Method public label(labelId int) : Cursor<LabelItem> from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to public label(labelId int) : Cursor<LabelItem> from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Method public properties() : Cursor<PropertyItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to public properties() : Cursor<PropertyItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Method public isDense() : boolean from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to public isDense() : boolean from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Method public degree(direction Direction, relType int) : int from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to public degree(direction Direction, relType int) : int from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Method public property(propertyKeyId int) : Cursor<PropertyItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to public property(propertyKeyId int) : Cursor<PropertyItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Method public relationships(direction Direction) : Cursor<RelationshipItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to public relationships(direction Direction) : Cursor<RelationshipItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Method public relationships(direction Direction, relTypes int...) : Cursor<RelationshipItem> from class org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor to public relationships(direction Direction, relTypes int...) : Cursor<RelationshipItem> from class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor	From	To
Pull Up Method public labels() : Cursor<LabelItem> from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to public labels() : Cursor<LabelItem> from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Method public property(propertyKeyId int) : Cursor<PropertyItem> from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to public property(propertyKeyId int) : Cursor<PropertyItem> from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Pull Up Method protected doFetchNext(highId long) : boolean from class org.neo4j.kernel.impl.api.store.AllRelationshipIterator to protected doFetchNext(highId long) : boolean from class org.neo4j.kernel.impl.api.store.AllRecordIdIterator	From	To
Pull Up Method public get() : NodeItem from class org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor to public get() : NodeItem from class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor	From	To
Inline Method	3
Inline Method public mapForAll(function Function<T,E>, consumer Consumer<E>) : void inlined to public forAll(consumer Consumer<T>) : void in class org.neo4j.cursor.RawCursor	From	To
Inline Method private lockAllNodes(state KernelStatement) : void inlined to package lockAllNodesAndConsumeRelationships(nodeId long, state KernelStatement) : void in class org.neo4j.kernel.impl.api.TwoPhaseNodeForRelationshipLocking	From	To
Change Return Type	2
Change Return Type boolean to void in method private updateRelationshipsCountsFromDegrees(type int, label int, outgoing long, incoming long) : void in class org.neo4j.kernel.api.txstate.TransactionCountingStateVisitor	From	To
Change Return Type Cursor<RelationshipTypeItem> to Cursor<IntSupplier> in method public relationshipTypes() : Cursor<IntSupplier> in class org.neo4j.storageengine.api.NodeItem	From	To
Extract Superclass	3
Extract Superclass org.neo4j.kernel.impl.api.store.AllRecordIdIterator from classes [org.neo4j.kernel.impl.api.store.AllRelationshipIterator]	From	To
Extract Superclass org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor from classes [org.neo4j.kernel.impl.api.cursor.TxSingleNodeCursor]	From	To
Extract Superclass org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor from classes [org.neo4j.kernel.impl.api.store.StoreSingleNodeCursor]	From	To
Rename Attribute	1
Rename Attribute relationshipGroupRecord : RelationshipGroupRecord to group : RelationshipGroupRecord in class org.neo4j.kernel.impl.api.store.StoreAbstractNodeCursor.DegreeItemDenseCursor	From	To
Change Attribute Type	1
Change Attribute Type relTypeCursor : Cursor<RelationshipTypeItem> to relTypeCursor : Cursor<IntSupplier> in class org.neo4j.kernel.impl.api.cursor.TxAbstractNodeCursor.DegreeCursor	From	To

f9d2b35496754357ac4607037436eb0bc6021b0d

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: