neo4j fe464acb728077abc5e26e49e3504c7074eaeef0

fe464acb728077abc5e26e49e3504c7074eaeef0

Files Diff

Added: 1
Removed: 0
Renamed: 0
Modified: 11

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method public settingsFor(crs CoordinateReferenceSystem) : SpaceFillingCurveSettings from class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactory to public forCRS(crs CoordinateReferenceSystem) : SpaceFillingCurveSettings from class org.neo4j.kernel.impl.index.schema.config.ConfiguredSpaceFillingCurveSettingsCache	From	To
Move And Inline Method	1
Move And Inline Method private envelopeFromCRS(dimension int, geographic boolean, envelopeSettings EnvelopeSettings) : Envelope moved from class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactory to class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactory.EnvelopeSettings & inlined to package asEnvelope() : Envelope	From	To
Change Parameter Type	6
Change Parameter Type settingsFromIndexHeader : SettingsFromIndexHeader to settingsFromIndexHeader : SpaceFillingCurveSettings.SettingsFromIndexHeader in method public abstract readHeader(settingsFromIndexHeader SpaceFillingCurveSettings.SettingsFromIndexHeader, headerBytes ByteBuffer) : void in class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactory.SpatialIndexType	From	To
Change Parameter Type settings : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in method private createEmptyIndex(indexId long, schemaIndexDescriptor SchemaIndexDescriptor, configuredSettings ConfiguredSpaceFillingCurveSettingsCache) : void in class org.neo4j.kernel.impl.index.schema.SpatialIndexSettingsTest	From	To
Change Parameter Type settings : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in method private makeIndexFile(indexId long, configuredSettings ConfiguredSpaceFillingCurveSettingsCache) : SpatialIndexFiles.SpatialFile in class org.neo4j.kernel.impl.index.schema.SpatialIndexSettingsTest	From	To
Change Parameter Type settingsFactory : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in method package SpatialFile(crs CoordinateReferenceSystem, configuredSettings ConfiguredSpaceFillingCurveSettingsCache, indexDirectory File) in class org.neo4j.kernel.impl.index.schema.SpatialIndexFiles.SpatialFile	From	To
Change Parameter Type settings : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in method private createLayoutTestUtil(labelId int, configuredSettings ConfiguredSpaceFillingCurveSettingsCache) : SpatialLayoutTestUtil in class org.neo4j.kernel.impl.index.schema.SpatialIndexSettingsTest	From	To
Change Parameter Type settingsFactory : SpaceFillingCurveSettingsFactory to settingsCache : ConfiguredSpaceFillingCurveSettingsCache in method package SpatialIndexFiles(directoryStructure IndexDirectoryStructure, indexId long, fs FileSystemAbstraction, settingsCache ConfiguredSpaceFillingCurveSettingsCache) in class org.neo4j.kernel.impl.index.schema.SpatialIndexFiles	From	To
Move Method	3
Move Method private valOrDefault(val double, def double) : double from class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactory to private valOrDefault(val double, def double) : double from class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactory.EnvelopeSettings	From	To
Move Method public fromGBPTree(indexFile File, pageCache PageCache, onError Function<ByteBuffer,String>) : SpaceFillingCurveSettings from class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettings to public fromGBPTree(indexFile File, pageCache PageCache, onError Function<ByteBuffer,String>) : SpaceFillingCurveSettings from class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactory	From	To
Move Method package fromConfig(dimensions int, maxBits int, extents Envelope) : SpaceFillingCurveSettings from class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettings to package fromConfig(maxBits int, envelopeSettings EnvelopeSettings) : SpaceFillingCurveSettings from class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactory	From	To
Move Attribute	3
Move Attribute private settings : HashMap<CoordinateReferenceSystem,SpaceFillingCurveSettings> from class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactory to private settings : HashMap<CoordinateReferenceSystem,SpaceFillingCurveSettings> from class org.neo4j.kernel.impl.index.schema.config.ConfiguredSpaceFillingCurveSettingsCache	From	To
Move Attribute private maxBits : int from class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactory to private maxBits : int from class org.neo4j.kernel.impl.index.schema.config.ConfiguredSpaceFillingCurveSettingsCache	From	To
Move Attribute private SPATIAL_SETTING_PREFIX : String from class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactory to private SPATIAL_SETTING_PREFIX : String from class org.neo4j.kernel.impl.index.schema.config.ConfiguredSpaceFillingCurveSettingsCache	From	To
Extract Class	1
Extract Class org.neo4j.kernel.impl.index.schema.config.ConfiguredSpaceFillingCurveSettingsCache from class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactory	From	To
Move Class	1
Move Class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettings.SpatialIndexType moved to org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactory.SpatialIndexType	From	To
Change Variable Type	3
Change Variable Type factory : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in method private shouldGetSettingsFor(config Config, crs CoordinateReferenceSystem, dimensions int, maxBits int, envelope Envelope) : void in class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactoryTest	From	To
Change Variable Type indexType : SpatialIndexType to indexType : SpaceFillingCurveSettingsFactory.SpatialIndexType in method package headerReader(onError Function<ByteBuffer,String>) : Header.Reader in class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettings.SettingsFromIndexHeader	From	To
Change Variable Type settings3 : SpaceFillingCurveSettingsFactory to settings3 : ConfiguredSpaceFillingCurveSettingsCache in method public shouldNotLeakSpaceFillingCurveSettingsBetweenExistingAndNewIndexes() : void in class org.neo4j.kernel.impl.index.schema.SpatialIndexSettingsTest	From	To
Rename Variable	1
Rename Variable factory : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in method private shouldGetSettingsFor(config Config, crs CoordinateReferenceSystem, dimensions int, maxBits int, envelope Envelope) : void in class org.neo4j.kernel.impl.index.schema.config.SpaceFillingCurveSettingsFactoryTest	From	To
Change Return Type	1
Change Return Type SpaceFillingCurveSettingsFactory to ConfiguredSpaceFillingCurveSettingsCache in method private getConfiguredSpaceFillingCurveSettings(config Config) : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialIndexProvider	From	To
Replace Variable With Attribute	1
Replace Variable With Attribute indexId3 : long to indexId1 : long in method public shouldNotLeakSpaceFillingCurveSettingsBetweenExistingAndNewIndexes() : void in class org.neo4j.kernel.impl.index.schema.SpatialIndexSettingsTest	From	To
Rename Attribute	8
Rename Attribute settingsFactory : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialIndexProvider	From	To
Rename Attribute settings : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialIndexAccessorTest	From	To
Rename Attribute settings1 : SpaceFillingCurveSettingsFactory to configuredSettings1 : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialIndexSettingsTest	From	To
Rename Attribute settingsFactory : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialIndexFiles	From	To
Rename Attribute settings : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialNonUniqueIndexPopulatorTest	From	To
Rename Attribute settings : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialIndexFiles.SpatialFile	From	To
Rename Attribute settings2 : SpaceFillingCurveSettingsFactory to configuredSettings2 : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialIndexSettingsTest	From	To
Rename Attribute settings : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialUniqueIndexPopulatorTest	From	To
Change Attribute Type	8
Change Attribute Type settingsFactory : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialIndexProvider	From	To
Change Attribute Type settings : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialIndexAccessorTest	From	To
Change Attribute Type settings1 : SpaceFillingCurveSettingsFactory to configuredSettings1 : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialIndexSettingsTest	From	To
Change Attribute Type settingsFactory : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialIndexFiles	From	To
Change Attribute Type settings : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialNonUniqueIndexPopulatorTest	From	To
Change Attribute Type settings : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialIndexFiles.SpatialFile	From	To
Change Attribute Type settings : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialUniqueIndexPopulatorTest	From	To
Change Attribute Type settings2 : SpaceFillingCurveSettingsFactory to configuredSettings2 : ConfiguredSpaceFillingCurveSettingsCache in class org.neo4j.kernel.impl.index.schema.SpatialIndexSettingsTest	From	To
Rename Parameter	5
Rename Parameter settingsFactory : SpaceFillingCurveSettingsFactory to settingsCache : ConfiguredSpaceFillingCurveSettingsCache in method package SpatialIndexFiles(directoryStructure IndexDirectoryStructure, indexId long, fs FileSystemAbstraction, settingsCache ConfiguredSpaceFillingCurveSettingsCache) in class org.neo4j.kernel.impl.index.schema.SpatialIndexFiles	From	To
Rename Parameter settings : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in method private makeIndexFile(indexId long, configuredSettings ConfiguredSpaceFillingCurveSettingsCache) : SpatialIndexFiles.SpatialFile in class org.neo4j.kernel.impl.index.schema.SpatialIndexSettingsTest	From	To
Rename Parameter settingsFactory : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in method package SpatialFile(crs CoordinateReferenceSystem, configuredSettings ConfiguredSpaceFillingCurveSettingsCache, indexDirectory File) in class org.neo4j.kernel.impl.index.schema.SpatialIndexFiles.SpatialFile	From	To
Rename Parameter settings : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in method private createLayoutTestUtil(labelId int, configuredSettings ConfiguredSpaceFillingCurveSettingsCache) : SpatialLayoutTestUtil in class org.neo4j.kernel.impl.index.schema.SpatialIndexSettingsTest	From	To
Rename Parameter settings : SpaceFillingCurveSettingsFactory to configuredSettings : ConfiguredSpaceFillingCurveSettingsCache in method private createEmptyIndex(indexId long, schemaIndexDescriptor SchemaIndexDescriptor, configuredSettings ConfiguredSpaceFillingCurveSettingsCache) : void in class org.neo4j.kernel.impl.index.schema.SpatialIndexSettingsTest	From	To

fe464acb728077abc5e26e49e3504c7074eaeef0

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: